Github user rob05c commented on the issue:
https://github.com/apache/incubator-trafficcontrol/pull/425
As far as the Wrapper comments go: a lot of @alficles objections are
difficult to get right, or impossible to implement, with the current Wrap
helpers
The Wrap helpers are are now more duplicate than reasonable. Go's type
system isn't powerful enough for these wrappers to work well, especially as the
handling complexity grows. They're increasingly difficult to write and read.
I've thought for a while now that they should be refactored, probably into
stock `http.HandlerFunc`s. Using `HandlerFunc` would have some duplicate logic,
but probably not much more than is already there, and would be far easier to
understand.
I'd rather wait to do that refactor in its own PR, than here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
