[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...
Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Perhaps we should leave the Java version in there, at least for the short term, but rename it to `traffic_monitor_legacy` (or `_java` or something that makes sense), and have *that* build modified to produce the RPM with a modified name. I agree that the golang version has been stable, but I'm not sure if everyone is ready to migrate. I also agree that this sort of change needs to be brought up on the list. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...
Github user rob05c commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 I think it's been long enough, we haven't seen any major issues with the Golang TM. What about renaming `/traffic_monitor_golang` to `/traffic_monitor`, deleting the old Java dir (which will still be in Git history, if anyone needs it), and making Golang the default build in `build_all.sh`? Should we ask on the mailing list if anyone objects to making the Golang TM the default in the next release? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 @rob05c what do you think about including `_go` in the golang Traffic Monitor RPM filename, presuming that the above still works? We could also do the inverse, and modify the Java version's RPM version instead. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-trafficcontrol issue #731: [TC-192] Differentiates between goTM an...
Github user elsloo commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/731 Hey @rguiliani, thanks for the PR. When the two Traffic Monitor RPMs are built, we will end up with an RPM with `_go` in its name, which will be included in the version. Do you know whether this resulting RPM can still be installed via `yum install traffic_monitor`? We must ensure that our installation and upgrade path is still valid, as we have existing installations using the non-`_go` named version of the RPM, and we need to be able to run `yum upgrade traffic_monitor` to get to the next version. Based on what I know of the spec file, I *think* this will work, but I would like confirmation. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
