[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/624


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

[mitchell852]

Github user mitchell852 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/624#discussion_r119386426
  
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -579,7 +573,7 @@ sub is_good_password {
return "Your password cannot be the same as your username.";
}
 
-   if ( ( $value ne '' ) && $value !~ qr/^.{8,100}$/ ) {
+   if ( ( $value ne '' ) && ( length($value) < 8 ) ) {
--- End diff --

thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/624#discussion_r119262039
  
--- Diff: traffic_ops/app/lib/API/User.pm ---
@@ -579,7 +573,7 @@ sub is_good_password {
return "Your password cannot be the same as your username.";
}
 
-   if ( ( $value ne '' ) && $value !~ qr/^.{8,100}$/ ) {
+   if ( ( $value ne '' ) && ( length($value) < 8 ) ) {
--- End diff --

first part is not necessary..   length('') is zero


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #624: [TC-359] - fixes bug where updat...

[mitchell852]

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/624

[TC-359] - fixes bug where updating a user always returned "email taken" or 
"use…

…rname taken". well of course it's taken...it's taken by the user that 
I'm trying to update...also, registration_sent is a timestamp, not a 
boolean..and also, regex is confusing...

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-359-fixes-user-update

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/624.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #624


commit 652bb007e6e9c81a9a968f73b8ee6f5a04f07426
Author: Jeremy Mitchell 
Date:   2017-05-30T21:00:39Z

fixes bug where updating a user always returned "email taken" or "username 
taken"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---