[GitHub] incubator-trafficcontrol pull request #766: [TC-461] DS steering tenancy che...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-trafficcontrol/pull/766


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #766: [TC-461] DS steering tenancy che...

[mitchell852]

Github user mitchell852 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/766#discussion_r131236009
  
--- Diff: traffic_ops/app/lib/API/DeliveryService/SteeringTarget.pm ---
@@ -29,6 +30,20 @@ sub index {
my $steering_id = $self->param('id');
my @data;
 
+   my $tenant_utils = Utils::Tenant->new($self);
+   my $tenants_data = $tenant_utils->create_tenants_data_from_db();
+   my $ds = $self->db->resultset('Deliveryservice')->find( { id => 
$steering_id } );
+   if ( defined($ds) ) {
+   #TO THE REVIEWER
--- End diff --

can you take out the "to the reviewer"s


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #766: [TC-461] DS steering tenancy che...

[nir-sopher]

GitHub user nir-sopher opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/766

[TC-461] DS steering tenancy checks

WIP
Waiting to merge with PR 765

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nir-sopher/incubator-trafficcontrol 
ds-tenancy-validation-steering

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/766.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #766


commit 8bd9c437d2b50cd6dbe09b8b23050b15b625f483
Author: nir-sopher 
Date:   2017-07-17T20:25:42Z

DS steering tenancy checks




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---