[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131972340
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

looking again -- that block isn't necessary -- the `last` will exit the 
nearest enclosing loop,  which is the `foreach ... $#parts)`



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131968755
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

Do we have a standard perl indentation tool?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131967719
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

then please reformat that section and indent appropriately.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[mtorluemke]

Github user mtorluemke commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131964778
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

potentially more clear if the braces for the new block are moved to 
separate lines (with indentation)...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[alficles]

Github user alficles commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131962210
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

It's perl. :/ Creates the mandatory block for the early exit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[dangogh]

Github user dangogh commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/785#discussion_r131959659
  
--- Diff: traffic_ops/bin/traffic_ops_ort.pl ---
@@ -1266,15 +1266,19 @@ sub check_plugins {
( my @parts ) = split( /\@plugin\=/, $liner );
foreach my $i ( 1..$#parts ) {
( my $plugin_name, my $plugin_config_file ) = 
split( /\@pparam\=/, $parts[$i] );
-   if (defined( $plugin_config_file ) ) {
+   if (defined( $plugin_config_file ) ) {{
--- End diff --

`{{` ???



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-trafficcontrol pull request #785: [TC-502] ORT now skips file chec...

[alficles]

GitHub user alficles opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/785

[TC-502] ORT now skips file checks for remap plugin arguments that start 
with '-'.

ORT parses the remap.config file to find dependent files to update.
Since parameters to plugins aren't easily distinguished from options
to those plugins, this distinguishes based on the first character.
It's not ideal, but it works well in practice.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alficles/incubator-trafficcontrol 
tc-502-ort-param-args

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/785.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #785


commit e47b02afa238a22411b7824bc79dcbae110cb718
Author: Chris Lemmons 
Date:   2017-08-08T15:44:08Z

[TC-502] ORT now skips file checks for remap plugin arguments that start 
with '-'.

ORT parses the remap.config file to find dependent files to update.
Since parameters to plugins aren't easily distinguished from options
to those plugins, this distinguishes based on the first character.
It's not ideal, but it works well in practice.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---