[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

2018-03-27 Thread GitBox
mitchell852 commented on issue #2030: Feature: UI elements to delete active 
invalidation rules & queue revalidations
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-376657842
 
 
   looks like #1867 takes care of the ability to delete invalidate content 
jobs...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

2018-03-22 Thread GitBox
mitchell852 commented on issue #2030: Feature: UI elements to delete active 
invalidation rules & queue revalidations
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-375366000
 
 
   I think this would require 2 things:
   
   1. A new API endpoint like POST /api/1.3/cdns/:id/queue_revalidate to queue 
revalidations (set reval_pending=1) for all servers for a given CDN
   
   I suppose this endpoint would be limited to the Operations or Admin role?
   
   Question: Is there any need to "unqueue revalidations". I'm thinking 
probably not.
   
   2. Create a DELETE /api/1.3/jobs/:id API endpoint
   
   This endpoint would probably require the Portal role and need to check 
tenancy to ensure that someone isn't trying to delete a job associated with a 
delivery service outside their tenancy.
   
   regex_revalidate.config file is built from the job table so deleting a job 
is how you clear things from regex_revalidate.config as far as I can tell.
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L1714
   
   Question: Should deleting a job automatically set reval_pending=1 for all 
servers of the CDN that the DS belongs to? The opposite is currently true - 
creating a job, sets reval_pending=1 for all servers of the CDN that the DS 
belongs to.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] mitchell852 commented on issue #2030: Feature: UI elements to delete active invalidation rules & queue revalidations

2018-03-22 Thread GitBox
mitchell852 commented on issue #2030: Feature: UI elements to delete active 
invalidation rules & queue revalidations
URL: 
https://github.com/apache/incubator-trafficcontrol/issues/2030#issuecomment-375366000
 
 
   I think this would require 2 things:
   
   1. A new API endpoint like POST /api/1.3/cdns/:id/queue_revalidate to queue 
revalidations (set reval_pending=1) for all servers for a given CDN
   
   I suppose this endpoint would be limited to the Operations or Admin role?
   
   Question: Is there any need to "unqueue revalidations". I'm thinking 
probably not.
   
   2. Create a DELETE /api/1.3/jobs/:id API endpoint
   
   This endpoint would probably require the Portal role and need to check 
tenancy to ensure that someone isn't trying to delete a job associated with a 
delivery service outside their tenancy.
   
   regex_revalidate.config file is built from the job table so deleting a job 
is how you clear things from regex_revalidate.config.
   
   
https://github.com/apache/incubator-trafficcontrol/blob/master/traffic_ops/app/lib/API/Configs/ApacheTrafficServer.pm#L1714
   
   Question: Should deleting a job automatically set reval_pending=1 for all 
servers of the CDN that the DS belongs to? The opposite is currently true - 
creating a job, sets reval_pending=1 for all servers of the CDN that the DS 
belongs to.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services