[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127809#comment-16127809 ] ASF GitHub Bot commented on TC-262: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 Refer to this link for build results (access rights to CI server needed): https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/27/ > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125647#comment-16125647 ] ASF GitHub Bot commented on TC-262: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 Can one of the admins verify this patch? > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115637#comment-16115637 ] ASF GitHub Bot commented on TC-262: --- Github user asfgit commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 Can one of the admins verify this patch? > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049390#comment-16049390 ] Ryan Durfey commented on TC-262: Thanks for the heads up. I am working to get some additional focus on commits. Ryan > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049370#comment-16049370 ] John Schmerge commented on TC-262: -- I would love someone to apply the pull request > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042938#comment-16042938 ] ASF GitHub Bot commented on TC-262: --- Github user jschmerge commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 I thought i had left a comment regarding this patch a few weeks back answering the question @limited posed... I'm going to focus on just the Drive_Letters and Drive_Hash_Id params, the RAM_* and SSD_* work the same way. The Drive_Hash_Id param takes a CSV string for *_all_* the drives, and the order is expected to match the order in the Drive_Letters CSV string. Provisions have been taken to allow for omitting a hash id for a drive, in that if: Drive_Letters = "a,b,c,d,e" and Drive_Hash_Id = ",,foo,,bar" You'll end up with a storage.config that contains: `/dev/sda volume=1 /dev/sdb volume=1 /dev/sdc volume=1 id=foo /dev/sdd volume=1 /dev/sde volume=1 id=bar` > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014996#comment-16014996 ] John Schmerge commented on TC-262: -- The single parameter is a comma-separated set of values that correspond 1:1 to the drive letter comma-separated list. If you were to have, for example drive_prefix=/dev/sd drive_letters=a,b,c,d,e drive_hash_id=,,disk3,,disk5 That would result in a storage.config file with the following content: /dev/sda volume=1 /dev/sdb volume=1 /dev/sdc volume=1 id=disk3 /dev/sdd volume=1 /dev/sde volume=1 id=disk5 > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001390#comment-16001390 ] ASF GitHub Bot commented on TC-262: --- Github user jschmerge commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 The parameter is actually rather nicely documented with examples in the ATS documentation: https://docs.trafficserver.apache.org/en/latest/admin-guide/files/storage.config.en.html#linux-example This patch just exposes the configuration item as a knob in traffic-ops. > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990196#comment-15990196 ] ASF GitHub Bot commented on TC-262: --- Github user oren-shemesh commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 Indeed, an entry in the documentation explaining the purpose and usage of these parameters would be in place. > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (TC-262) Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next release
[ https://issues.apache.org/jira/browse/TC-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990073#comment-15990073 ] ASF GitHub Bot commented on TC-262: --- Github user limited commented on the issue: https://github.com/apache/incubator-trafficcontrol/pull/497 What values would one typically set for the *_Hash_Id? Does it need to correspond to a property of the disks? > Merge https://github.com/apache/incubator-trafficcontrol/pull/497 into next > release > --- > > Key: TC-262 > URL: https://issues.apache.org/jira/browse/TC-262 > Project: Traffic Control > Issue Type: Improvement > Components: Traffic Ops >Reporter: John Schmerge >Priority: Minor > > This patch adds three new parameters to control/configure the seed > strings for the consistent hash used for cachekey->drive mapping in > ATS... This allows an arbitrary string to be assigned as the key for > drives instead of relying on the OS's device node name as the seed for > the hash. The three parameters added are: > Drive_Hash_Id > RAM_Drive_Hash_Id > SSD_Drive_Hash_Id > And they specify the id keys for spinning, ram, and ssd devices. > If this parameter is missing from the TO config for a server, the > generated file ommits any specification of the id parameter (preserving > the previous file generation behavior). > Also note that the csv id strings for these three new parameters should > order their entries to match the order of the Drive_Letters parameter. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
