[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129448#comment-16129448
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user mitchell852 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/818#discussion_r133571450
  
--- Diff: traffic_portal/app/src/common/modules/header/header.tpl.html ---
@@ -61,11 +61,11 @@
 
 
 
-
-
-
-
-
+
--- End diff --

yea, i did


> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0, 2.2.0
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0, 2.2.0
>
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129332#comment-16129332
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user dneuman64 commented on a diff in the pull request:


https://github.com/apache/incubator-trafficcontrol/pull/818#discussion_r133551958
  
--- Diff: traffic_portal/app/src/common/modules/header/header.tpl.html ---
@@ -61,11 +61,11 @@
 
 
 
-
-
-
-
-
+
--- End diff --

did you mean to leave this commented out?


> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0, 2.2.0
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0, 2.2.0
>
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129330#comment-16129330
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user dneuman64 commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  
@mitchell852 I will get this merged today


> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Affects Versions: 2.1.0, 2.2.0
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
> Fix For: 2.1.0, 2.2.0
>
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128879#comment-16128879
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/80/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16128875#comment-16128875
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/40/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127904#comment-16127904
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/78/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127890#comment-16127890
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/40/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127888#comment-16127888
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/38/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127798#comment-16127798
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/3/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127760#comment-16127760
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/75/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127754#comment-16127754
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/37/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127679#comment-16127679
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 
https://builds.apache.org/job/incubator-trafficcontrol-PR/74/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127675#comment-16127675
 ] 

ASF GitHub Bot commented on TC-515:
---

Github user asfgit commented on the issue:

https://github.com/apache/incubator-trafficcontrol/pull/818
  

Refer to this link for build results (access rights to CI server needed): 

https://builds.apache.org/job/incubator-trafficcontrol-traffic_ops-test-PR/36/



> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TC-515) Traffic Portal - Show human readable protocol on DS page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TC-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16127669#comment-16127669
 ] 

ASF GitHub Bot commented on TC-515:
---

GitHub user mitchell852 opened a pull request:

https://github.com/apache/incubator-trafficcontrol/pull/818

[TC-515] - TPv2 - adds human readable ds protocols to ds table



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mitchell852/incubator-trafficcontrol 
tc-515-ds-protocol-names

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-trafficcontrol/pull/818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #818


commit 2fbf009a5458c53b2a08b227ef1e1e049c80bf24
Author: Jeremy Mitchell 
Date:   2017-08-15T18:20:41Z

adds human readable ds protocols to ds table




> Traffic Portal - Show human readable protocol on DS page
> 
>
> Key: TC-515
> URL: https://issues.apache.org/jira/browse/TC-515
> Project: Traffic Control
>  Issue Type: Bug
>  Components: Traffic Portal
>Reporter: David Neuman
>Assignee: Jeremy Mitchell
>Priority: Minor
>
> In the TO UI, the delivery service protocol is converted from an int (0,1,2) 
> to a human readable string (http, https, http and https, etc).  The new TO 
> portal just shows the int but it should show the human readable string.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)