[jira] [Commented] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107585#comment-13107585
]
Leif Hedstrom commented on TS-837:
--
So I can assume that this patch fixes all cases where -fno-strict-aliaasing was
necessary? I clearly remember having to add that option to avoid seemingly
"random" crashes (but, it was a long time ago).
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
> Attachments: proxything.diff
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-960) Make "error documents" templatable to the administrator
[ https://issues.apache.org/jira/browse/TS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107584#comment-13107584 ] Leif Hedstrom commented on TS-960: -- I think that's what proxy.config.body_factory.enable_customizations is for, no ? The hardcoded stuff are "defaults", which you can override. Not sure why they are hardcoded, presumably for performance, but that seems like a small win honestly (but, not sure). > Make "error documents" templatable to the administrator > --- > > Key: TS-960 > URL: https://issues.apache.org/jira/browse/TS-960 > Project: Traffic Server > Issue Type: Improvement >Affects Versions: 3.1.1 >Reporter: Igor Galić > > I believe it would be enormously usable to the Administrator to have > templatable (editable) error documents (like httpd does) > That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put > it in a template > replace things title with @@TITLE@@ or similar -- maybe even WARN the user > that they have to occur in exactly that order to work, so as to make parsing > as simple as possible.? > In any case this template should be cached, and only read once upon startup. > We have a cache, after all, we should use it. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Galić updated TS-837:
--
Attachment: (was: proxything_1.diff)
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
> Attachments: proxything.diff
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Galić updated TS-837:
--
Comment: was deleted
(was: update, now should work with --enable-debug)
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
> Attachments: proxything.diff
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Galić updated TS-837:
--
Attachment: proxything_1.diff
update, now should work with --enable-debug
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
> Attachments: proxything.diff, proxything_1.diff
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Galić updated TS-837:
--
Attachment: proxything.diff
WTFPL.
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
> Attachments: proxything.diff
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107558#comment-13107558
]
Igor Galić commented on TS-837:
---
A nice person from ##workingset provided me with a patch:
00:26:37 < xv7> jMCg: http://jengelh.medozas.de/files/proxything.diff needs
review, but along the lines of that
> ATS fails to compile with gcc 4.6.1 with --enable-debug
> ---
>
> Key: TS-837
> URL: https://issues.apache.org/jira/browse/TS-837
> Project: Traffic Server
> Issue Type: Bug
>Affects Versions: 3.1.0, 3.0.0
> Environment: Linux, Debian, Amd64 + GCC 4.6.1
>Reporter: Igor Galić
> Fix For: 3.1.1
>
>
> {noformat}
> In file included from ../../proxy/ControlMatcher.h:104:0,
> from ../../proxy/ParentSelection.h:37,
> from P_Socks.h:30,
> from P_Net.h:106,
> from Connection.cc:34:
> ../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
> HTTPInfo::object_key_get()':
> ../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'int64_t
> HTTPInfo::object_size_get()':
> ../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> ../../proxy/hdrs/HTTP.h: In member function 'void
> HTTPInfo::object_size_set(int64_t)':
> ../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
> will break strict-aliasing rules [-Werror=strict-aliasing]
> cc1plus: all warnings being treated as errors
> *** [Connection.o] Error 1
> make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
> make: *** [all-recursive] Error 1
> {noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Created] (TS-960) Make "error documents" templatable to the administrator
Pretty sure we have this already. -- leif On Sep 17, 2011, at 8:53 PM, Igor Galić (JIRA) wrote: > Make "error documents" templatable to the administrator > --- > > Key: TS-960 > URL: https://issues.apache.org/jira/browse/TS-960 > Project: Traffic Server > Issue Type: Improvement >Affects Versions: 3.1.1 >Reporter: Igor Galić > > > I believe it would be enormously usable to the Administrator to have > templatable (editable) error documents (like httpd does) > > That means to remove the HTML code from proxy/http/HttpMessageBody.cc and put > it in a template > replace things title with @@TITLE@@ or similar -- maybe even WARN the user > that they have to occur in exactly that order to work, so as to make parsing > as simple as possible.? > > In any case this template should be cached, and only read once upon startup. > We have a cache, after all, we should use it. > > -- > This message is automatically generated by JIRA. > For more information on JIRA, see: http://www.atlassian.com/software/jira > >
