[jira] [Commented] (TS-837) ATS fails to compile with gcc 4.6.1 with --enable-debug
[
https://issues.apache.org/jira/browse/TS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107659#comment-13107659
]
Igor Galić commented on TS-837:
---
He created the patch removing -fno-strict-aliasing from configure.ac -- but
without --enable-debug -- and without other options I presume, so this will not
cover the entire code-base. It's a just start.
ATS fails to compile with gcc 4.6.1 with --enable-debug
---
Key: TS-837
URL: https://issues.apache.org/jira/browse/TS-837
Project: Traffic Server
Issue Type: Bug
Affects Versions: 3.1.0, 3.0.0
Environment: Linux, Debian, Amd64 + GCC 4.6.1
Reporter: Igor Galić
Fix For: 3.1.1
Attachments: proxything.diff
{noformat}
In file included from ../../proxy/ControlMatcher.h:104:0,
from ../../proxy/ParentSelection.h:37,
from P_Socks.h:30,
from P_Net.h:106,
from Connection.cc:34:
../../proxy/hdrs/HTTP.h: In member function 'INK_MD5
HTTPInfo::object_key_get()':
../../proxy/hdrs/HTTP.h:1375:24: error: dereferencing type-punned pointer
will break strict-aliasing rules [-Werror=strict-aliasing]
../../proxy/hdrs/HTTP.h: In member function 'int64_t
HTTPInfo::object_size_get()':
../../proxy/hdrs/HTTP.h:1405:24: error: dereferencing type-punned pointer
will break strict-aliasing rules [-Werror=strict-aliasing]
../../proxy/hdrs/HTTP.h: In member function 'void
HTTPInfo::object_size_set(int64_t)':
../../proxy/hdrs/HTTP.h:1422:51: error: dereferencing type-punned pointer
will break strict-aliasing rules [-Werror=strict-aliasing]
cc1plus: all warnings being treated as errors
*** [Connection.o] Error 1
make[2]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore/net'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/netsrc/trafficserver-3.0.0/iocore'
make: *** [all-recursive] Error 1
{noformat}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-947) AIO Race condition on non NT systems
[
https://issues.apache.org/jira/browse/TS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13107719#comment-13107719
]
mohan_zl commented on TS-947:
-
One question:
The variable sleep_wait in struct AIOThreadInfo is not used now, why not nuke
it away or use it for Jplevyak's patch, looks like:
timespec ten_msec_timespec = ink_based_hrtime_to_timespec(ink_get_hrtime() +
HRTIME_MSECONDS(thr_info-sleep_wait));
AIO Race condition on non NT systems
Key: TS-947
URL: https://issues.apache.org/jira/browse/TS-947
Project: Traffic Server
Issue Type: Bug
Components: Core
Environment: stock build with static libts, running on a 4 core server
Reporter: B Wyatt
Fix For: 3.1.1
Attachments: lock-safe-AIO.patch
Refer to code below. The timeslice starting when a consumer thread
determines that the temp_list is empty (A) and ending when it releases the
aio_mutex(C) is unsafe if the work queues are empty and it breaks loop
execution at B. During this timeslice (A-C) the consumer holds the aio_mutex
and as a result request producers enqueue items on the temporary atomic list
(D). As a consumer in this state will wait for a signal on aio_cond to
proceed before processing the temp_list again, any requests on the temp_list
are effectively stalled until a future request produces this signal or
manually processes the temp_list.
In the case of cache volume initialization, there is no future request and
the initialization sequence soft locks.
{code:title=iocore/aio/AIO.cc(annotated)}
void *
aio_thread_main(void *arg)
{
...
ink_mutex_acquire(my_aio_req-aio_mutex);
for (;;) {
do {
current_req = my_aio_req;
/* check if any pending requests on the atomic list */
A if (!INK_ATOMICLIST_EMPTY(my_aio_req-aio_temp_list))
aio_move(my_aio_req);
if (!(op = my_aio_req-aio_todo.pop()) !(op =
my_aio_req-http_aio_todo.pop()))
Bbreak;
...
service request
...
} while (1);
Cink_cond_wait(my_aio_req-aio_cond, my_aio_req-aio_mutex);
}
...
}
static void
aio_queue_req(AIOCallbackInternal *op, int fromAPI = 0)
{
...
if (!ink_mutex_try_acquire(req-aio_mutex)) {
Dink_atomiclist_push(req-aio_temp_list, op);
} else {
/* check if any pending requests on the atomic list */
if (!INK_ATOMICLIST_EMPTY(req-aio_temp_list))
aio_move(req);
/* now put the new request */
aio_insert(op, req);
ink_cond_signal(req-aio_cond);
ink_mutex_release(req-aio_mutex);
}
...
}
{code}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-961) Extend TS API to support TSNetAccept with inbound transparency
Extend TS API to support TSNetAccept with inbound transparency -- Key: TS-961 URL: https://issues.apache.org/jira/browse/TS-961 Project: Traffic Server Issue Type: Improvement Components: TS API Reporter: Yossi Gottlieb Priority: Minor Fix For: 3.1.1 This is required for protocol plugins to use this capability. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with inbound transparency
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yossi Gottlieb updated TS-961: -- Attachment: api_accept_transparent.diff Extend TS API to support TSNetAccept with inbound transparency -- Key: TS-961 URL: https://issues.apache.org/jira/browse/TS-961 Project: Traffic Server Issue Type: Improvement Components: TS API Reporter: Yossi Gottlieb Priority: Minor Fix For: 3.1.1 Attachments: api_accept_transparent.diff This is required for protocol plugins to use this capability. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with inbound transparency
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yossi Gottlieb updated TS-961: -- Attachment: api_transparency.diff Extend TS API to support TSNetAccept with inbound transparency -- Key: TS-961 URL: https://issues.apache.org/jira/browse/TS-961 Project: Traffic Server Issue Type: Improvement Components: TS API Reporter: Yossi Gottlieb Priority: Minor Fix For: 3.1.1 Attachments: api_transparency.diff This is required for protocol plugins to use this capability. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-961) Extend TS API to support TSNetAccept with inbound transparency
[ https://issues.apache.org/jira/browse/TS-961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yossi Gottlieb updated TS-961: -- Attachment: (was: api_accept_transparent.diff) Extend TS API to support TSNetAccept with inbound transparency -- Key: TS-961 URL: https://issues.apache.org/jira/browse/TS-961 Project: Traffic Server Issue Type: Improvement Components: TS API Reporter: Yossi Gottlieb Priority: Minor Fix For: 3.1.1 Attachments: api_transparency.diff This is required for protocol plugins to use this capability. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-962) typo of key name in logstats.cc
typo of key name in logstats.cc
---
Key: TS-962
URL: https://issues.apache.org/jira/browse/TS-962
Project: Traffic Server
Issue Type: Bug
Components: Stats
Affects Versions: 3.0.1
Reporter: Nick Berry
Priority: Minor
Attachments: logstats.cc-key_name_typo-patch
appears in trunk as well.
{code}
$ traffic_logstats -j
{ total: {
*snip*
error.conenct_failed : { req: 0, req_pct: 0.00, bytes: 0,
bytes_pct: 0.00 },
*snip*
},
}
{code}
error.connect_failed is misspelled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-962) typo of key name in logstats.cc
[
https://issues.apache.org/jira/browse/TS-962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Berry updated TS-962:
--
Attachment: logstats.cc-key_name_typo-patch
typo of key name in logstats.cc
---
Key: TS-962
URL: https://issues.apache.org/jira/browse/TS-962
Project: Traffic Server
Issue Type: Bug
Components: Stats
Affects Versions: 3.0.1
Reporter: Nick Berry
Priority: Minor
Attachments: logstats.cc-key_name_typo-patch
appears in trunk as well.
{code}
$ traffic_logstats -j
{ total: {
*snip*
error.conenct_failed : { req: 0, req_pct: 0.00, bytes: 0,
bytes_pct: 0.00 },
*snip*
},
}
{code}
error.connect_failed is misspelled.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
