[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API
[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168519#comment-13168519 ] Leif Hedstrom commented on TS-1045: --- Reading this, and the code, I'm starting to wonder if TSFetchPageRespGet() is a broken API ? I mean, the differences between it, and the new TSFetchHdrGet(), is simply getting the header from the response. Is there ever a case when we need all three of these APIs (TSFetchPageRespGet(), TSFetchRespGet() and TSFetchHdrGet() ) ? PATCH: add new TSFetchHdrGet API Key: TS-1045 URL: https://issues.apache.org/jira/browse/TS-1045 Project: Traffic Server Issue Type: Improvement Components: HTTP Reporter: James Peach Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.2 Attachments: 0007-Add-new-public-API-TSFetchHdrGet.patch TSFetchUrl does not provide any way to get the headers from the result. This patch adds a new API TSFetchHdrGet(), which is analogous to TSFetchRespGet() and returns the headers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1045) PATCH: add new TSFetchHdrGet API
[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168541#comment-13168541 ] Leif Hedstrom commented on TS-1045: --- I'm honestly not sure what the intention was here... There seems to be overlap for sure. I mean, if TSFetchPageRespGet() returns the full response, then why do we need TSFetchRespGet()? That's why I'm wondering that we either a) Keep only TSFetchPageRespGet(), and expose appropriate APIs to get stuff out of it. or b) Eliminate TSFetchPageRespGet(), and only keep TSFetchRespGet() and a new TSFetchHdrGet() Or is there ever a case where we'd need all three ? PATCH: add new TSFetchHdrGet API Key: TS-1045 URL: https://issues.apache.org/jira/browse/TS-1045 Project: Traffic Server Issue Type: Improvement Components: HTTP Reporter: James Peach Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.2 Attachments: 0007-Add-new-public-API-TSFetchHdrGet.patch TSFetchUrl does not provide any way to get the headers from the result. This patch adds a new API TSFetchHdrGet(), which is analogous to TSFetchRespGet() and returns the headers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1045) PATCH: add new TSFetchHdrGet API
[ https://issues.apache.org/jira/browse/TS-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-1045: -- Attachment: TS-1045-formatting.diff Suggested changes for formatting, and making the functions more like the other similar APIs. Maybe this won't be necessary at all, but jpeach will let us know what will be the right solution for these APIs. PATCH: add new TSFetchHdrGet API Key: TS-1045 URL: https://issues.apache.org/jira/browse/TS-1045 Project: Traffic Server Issue Type: Improvement Components: HTTP Reporter: James Peach Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.2 Attachments: 0007-Add-new-public-API-TSFetchHdrGet.patch, TS-1045-formatting.diff TSFetchUrl does not provide any way to get the headers from the result. This patch adds a new API TSFetchHdrGet(), which is analogous to TSFetchRespGet() and returns the headers. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-912) TSFetchURL - poor performance
[ https://issues.apache.org/jira/browse/TS-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13168707#comment-13168707 ] James Peach commented on TS-912: I believe that this happens when the whole response is delivered in a single event handler invocation. In this case, read_from_net() delivers the read event, but not not notice that it read to EOF and so does not deliver the EOS event. The plugin has to wait for a TCP timeout to get the EOS delivered. TSFetchURL - poor performance - Key: TS-912 URL: https://issues.apache.org/jira/browse/TS-912 Project: Traffic Server Issue Type: Bug Components: TS API Affects Versions: 3.0.0 Environment: Linux Reporter: Naveen Labels: api, perfomance, ts Fix For: 3.1.2 Running a Apache benchmark with a simple plugin that just does TSFetchURL gives a ~13ms response time. The Fetch was on a localhost. All the plugin does is just sends an hello world response to the client. http://pastebin.com/1uEvuZqk Removing the TSFetchURL from the picture gives a response time of 1ms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
