[jira] [Commented] (TS-1102) Cleanup obsolete debugging code

[Uri Shachar (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200803#comment-13200803
 ] 

Uri Shachar commented on TS-1102:
-

That could be the problem -- I used svn -- Isn't the svn repo synced/updated 
from the git repo?

 Cleanup obsolete debugging code
 ---

 Key: TS-1102
 URL: https://issues.apache.org/jira/browse/TS-1102
 Project: Traffic Server
  Issue Type: Bug
  Components: Core, Logging, Performance
Affects Versions: 3.0.2
 Environment: Any
Reporter: Uri Shachar
Assignee: Leif Hedstrom
Priority: Minor
 Fix For: 3.1.3

 Attachments: diags_cleanup.patch, remove_prefix_arg.patch, 
 remove_prefix_arg_v2.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc = 4.1 
 for all compilation environments, and it includes variadic argument macro 
 support with ##_VA_ARGS_ that deletes the final comma if no arguments are 
 provided.
 Removing the added layer should also improve performance when high volume 
 debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TS-1102) Cleanup obsolete debugging code

[Leif Hedstrom (Commented) (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13200813#comment-13200813
 ] 

Leif Hedstrom commented on TS-1102:
---

I think the old SVN repo is read-only since the migration happened. The git 
repo is at

http://git-wip-us.apache.org/repos/asf/trafficserver.git


(or https://  if you want a read-write repo, the http:// is read-only).

I'll look at the rejections in a bit, but if you have time, prepping one that 
patches against git trunk (master) would be great.

 Cleanup obsolete debugging code
 ---

 Key: TS-1102
 URL: https://issues.apache.org/jira/browse/TS-1102
 Project: Traffic Server
  Issue Type: Bug
  Components: Core, Logging, Performance
Affects Versions: 3.0.2
 Environment: Any
Reporter: Uri Shachar
Assignee: Leif Hedstrom
Priority: Minor
 Fix For: 3.1.3

 Attachments: diags_cleanup.patch, remove_prefix_arg.patch, 
 remove_prefix_arg_v2.patch

   Original Estimate: 24h
  Remaining Estimate: 24h

 The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc = 4.1 
 for all compilation environments, and it includes variadic argument macro 
 support with ##_VA_ARGS_ that deletes the final comma if no arguments are 
 provided.
 Removing the added layer should also improve performance when high volume 
 debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira