[jira] [Commented] (TS-1136) Expose Configuration API such that config files can be written (or scripted) in a glue-language such as Lua

2012-03-15 Thread Leif Hedstrom (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230241#comment-13230241
 ] 

Leif Hedstrom commented on TS-1136:
---

Well, the existing admin API (which I'm shockingly familiar with ...) only 
works on a running system. What we need is a system that can hook up a DSL 
config system at startup. I've been thinking a lot about this, what I've been 
meaning to do is to make a Lua system that generates records.config, 
remap.config, parent.config, cache.config etc. That would be step one towards 
profit I think. E.g. Lua code like
{code}

domain{
 name = { ogre.com, www.ogre.com},
 path = { /, function
local rec = rec
rec.url_remap.pristine_host_hdr = 0

{code}

or some such, I need to think some more about how this actually works in Lua 
:). But it's syntax of passing tables are function parameters without requiring 
() makes for neat DSL syntax I think.


This could easily include support for different plugins (regex_remap, 
header_filter, remap_conf etc.), and generate those plugin config files as well.

 Expose Configuration API such that config files can be written (or scripted) 
 in a glue-language such as Lua
 ---

 Key: TS-1136
 URL: https://issues.apache.org/jira/browse/TS-1136
 Project: Traffic Server
  Issue Type: New Feature
  Components: Configuration
Reporter: Igor Galić

 To unify and simplify our configuration it would be great to have them in a 
 script language.
 Lua is an ideal candidate as it is easy to embed and it would make for a 
 wonderful - and powerful DSL.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Igor Brezac (Created) (JIRA)
Implement HTTP method filtering in ip_allow.config
--

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.2, 3.1.3
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3


Implement HTTP method filtering in ip_allow.config (and deprecate 
proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Igor Brezac (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Brezac updated TS-1140:


Attachment: ts.patch

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Created] (TS-1141) Server intercerpt performance problems.

2012-03-15 Thread Leif Hedstrom (Created) (JIRA)
Server intercerpt performance problems.
---

 Key: TS-1141
 URL: https://issues.apache.org/jira/browse/TS-1141
 Project: Traffic Server
  Issue Type: Improvement
  Components: Core
Reporter: Leif Hedstrom
 Fix For: 3.3.0


It seems server intercept plugins are fairly expensive. A very simple one, 
serving a few bytes out of RAM, can only do in the order of 20K QPS, whereas 
the same server serving out of RAM cache do wo 175k QPS. I know there will be 
overhead in plugin APIs, but almost 10x seems quite high.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Commented

[ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230739#comment-13230739
 ] 

Igor Galić commented on TS-1140:


I don't like the smell of STL in this code, but it's been in before, so that's 
not Igor's beef.

line 107, while you're at it, please change the if()/else to have { braces  }
lines 129-138 are incomprehensible.. to me. Don't we have anywhere a foreach 
template? Alan...? ;)

what's happening in line 164 of that patch with the snprintf?
Looks like you're using tabs - our code uses spaces.

Two questions or.. wishes:
{code}
+src_ip=0.0.0.0-255.255.255.255action=ip_deny  
method=PUSH|PURGE|DELETE
{code}

Maybe I'm delusioned, but I thought we had a /network notation somewhere 
around. Maybe it's just wishful thinking because in httpd we do.

And finally: This is my remap config:
{code}
map / http://127.0.0.1:8000 @method=GET @method=POST @method=HEAD 
@method=OPTIONS @action=allow
{code}
I used this because quickfilters where broken. But now that they worked and you 
moved the code to IpAllow.cc -- which part of our code takes care of parsing ^ 
that?

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Alan M. Carroll (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll updated TS-1140:


Attachment: ts-1140.diff

Updated patch.

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Issue Comment Edited] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Alan M. Carroll (Issue Comment Edited) (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13230872#comment-13230872
 ] 

Alan M. Carroll edited comment on TS-1140 at 3/16/12 3:42 AM:
--

Updated patch. I think I got most of Igor's issues.

  was (Author: amc):
Updated patch.
  
 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Alan M. Carroll (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll updated TS-1140:


Attachment: (was: ts-1140.diff)

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Alan M. Carroll (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan M. Carroll updated TS-1140:


Attachment: ts-1140.diff

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Igor Brezac (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Brezac updated TS-1140:


Attachment: ts-1140-v2.diff

Fixed a few more issue based on Igor's comments.

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Igor Brezac (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Brezac updated TS-1140:


Attachment: ts-1140-v2.diff

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Updated] (TS-1140) Implement HTTP method filtering in ip_allow.config

2012-03-15 Thread Igor Brezac (Updated) (JIRA)

 [ 
https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Igor Brezac updated TS-1140:


Attachment: (was: ts-1140-v2.diff)

 Implement HTTP method filtering in ip_allow.config
 --

 Key: TS-1140
 URL: https://issues.apache.org/jira/browse/TS-1140
 Project: Traffic Server
  Issue Type: New Feature
  Components: HTTP
Affects Versions: 3.1.3, 3.1.2
Reporter: Igor Brezac
Priority: Critical
 Fix For: 3.1.3

 Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch


 Implement HTTP method filtering in ip_allow.config (and deprecate 
 proxy.config.http.quick_filter.mask)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira