[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249542#comment-13249542 ] Uri Shachar commented on TS-1079: - @James: Regarding bool/int: No other function in ts.h.in uses bool (TSHttpTxnPrivateSessionSet, TSHttpTxnClientKeepaliveSet, TSHttpTxnReqCacheableSet... all use ints) -- while C99 added bool types, I didn't want to create a new dependency. Leif's explanation is correct about the design -- the idea is to allow plugins to do something like: TSDebugSpecifc(TSHttpTxnDebugGet(txn), plugin_tag , Hello World from transaction %p, txn); Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1147) deprecate records.config SSL configuration
[ https://issues.apache.org/jira/browse/TS-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249565#comment-13249565 ] Igor Galić commented on TS-1147: doing a code reading now deprecate records.config SSL configuration -- Key: TS-1147 URL: https://issues.apache.org/jira/browse/TS-1147 Project: Traffic Server Issue Type: Improvement Components: SSL Reporter: James Peach Assignee: James Peach Priority: Minor Fix For: 3.1.5 Since ssl_multicert.config is a strict superset of the SSL certificate configuration in records.config, we should deprecate configuring SSL certificates in records.config and make ssl_multicert.config the One True Way. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249589#comment-13249589 ] James Peach commented on TS-1079: - WRT bool: yep you are correct. WRT: TSDebugSpecific(), I think I'd prefer the caller to test TSHttpTxnDebugGet(), but that's arguably a matter of taste. Could you post the specific API proposal (i.e. the ts.h diff and rationale) to the dev@ list so that it can get a wider review? That said, I think this is a useful change and would like to see this in for 3.2. Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249591#comment-13249591 ] James Peach commented on TS-1079: - Hmm, Leif convinced me that the caller can't do the test. Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[
https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249593#comment-13249593
]
Igor Galić commented on TS-1079:
Uri, we already use C99 style {{inttypes.h}} and {{stdint.h}}
{{proxy/api/ts/ts.h}} already has an {{#include stdint.h}}, so I don't think
it's a big issue to introduce {{stdbool.h}} as well..
Comments?
Add an API function to turn debugging on for specific transactions/sessions
---
Key: TS-1079
URL: https://issues.apache.org/jira/browse/TS-1079
Project: Traffic Server
Issue Type: Improvement
Components: Core, HTTP
Reporter: Uri Shachar
Assignee: Leif Hedstrom
Priority: Minor
Fix For: 3.1.4
Attachments: debug_specific.patch, debug_specific_2.patch,
debug_specific_3.patch, debug_specific_4.patch
Original Estimate: 72h
Remaining Estimate: 72h
When attempting to troubleshoot issues on a production ATS system, it
is often impossible/difficult to turn on any of the 'high-volume' debug tags
like http due to the performance impact.
This enhancement allows a plugin to set a debug flag for a specific txn/ssn,
and replaces some of the internal Debug calls with a new function that checks
if the flag is turned on, and outputs the debug line regardless of the tag if
it is (The diags enable/disable flag is still taken into account).
The API will also have TSDebugSpecific in order to allow plugins to use the
same functionality.
In addition, we might consider adding an internal config file (remap-like) to
allow turning this flag on without plugin intervention.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249594#comment-13249594 ] Leif Hedstrom commented on TS-1079: --- Igor: I would stay away from stdbool for now honestly. Plus, making one API use bool and everything else use int is poor interface design. I'm totally fine revisiting this for v4.0, and do another round of (large) API improvements and changes. Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
- Original Message - [ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249594#comment-13249594 ] Leif Hedstrom commented on TS-1079: --- Igor: I would stay away from stdbool for now honestly. Plus, making one API use bool and everything else use int is poor interface design. I'm totally fine revisiting this for v4.0, and do another round of (large) API improvements and changes. sounds familiar. Like... something I could've said.. On IRC. ;) Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira -- Igor Galić Tel: +43 (0) 664 886 22 883 Mail: i.ga...@brainsware.org URL: http://brainsware.org/ GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
[jira] [Commented] (TS-1079) Add an API function to turn debugging on for specific transactions/sessions
[ https://issues.apache.org/jira/browse/TS-1079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249595#comment-13249595 ] Igor Galić commented on TS-1079: sounds familiar. Like... something I could've said.. On IRC. ;) Add an API function to turn debugging on for specific transactions/sessions --- Key: TS-1079 URL: https://issues.apache.org/jira/browse/TS-1079 Project: Traffic Server Issue Type: Improvement Components: Core, HTTP Reporter: Uri Shachar Assignee: Leif Hedstrom Priority: Minor Fix For: 3.1.4 Attachments: debug_specific.patch, debug_specific_2.patch, debug_specific_3.patch, debug_specific_4.patch Original Estimate: 72h Remaining Estimate: 72h When attempting to troubleshoot issues on a production ATS system, it is often impossible/difficult to turn on any of the 'high-volume' debug tags like http due to the performance impact. This enhancement allows a plugin to set a debug flag for a specific txn/ssn, and replaces some of the internal Debug calls with a new function that checks if the flag is turned on, and outputs the debug line regardless of the tag if it is (The diags enable/disable flag is still taken into account). The API will also have TSDebugSpecific in order to allow plugins to use the same functionality. In addition, we might consider adding an internal config file (remap-like) to allow turning this flag on without plugin intervention. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1192) Remove gethostbyname usage in test code
Remove gethostbyname usage in test code --- Key: TS-1192 URL: https://issues.apache.org/jira/browse/TS-1192 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon NetTest-simple-proxy.cc and test_I_simple_proxy.cc directly use gethostbyname(). These will be changed to use getaddrinfo(). We're removing gethostbyname() and gethostbyaddr() in an effort to get traffic server building on more platforms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (TS-1193) Traffic Server building on OpenBSD
Traffic Server building on OpenBSD -- Key: TS-1193 URL: https://issues.apache.org/jira/browse/TS-1193 Project: Traffic Server Issue Type: Improvement Reporter: Brian Geffon Assignee: Brian Geffon This is a parent issue for the task of getting traffic server building on OpenBSD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1192) Remove gethostbyname usage in test code
[ https://issues.apache.org/jira/browse/TS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249618#comment-13249618 ] Brian Geffon commented on TS-1192: -- Both of those files aren't actually used anywhere...removing them from the code base. Remove gethostbyname usage in test code --- Key: TS-1192 URL: https://issues.apache.org/jira/browse/TS-1192 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon NetTest-simple-proxy.cc and test_I_simple_proxy.cc directly use gethostbyname(). These will be changed to use getaddrinfo(). We're removing gethostbyname() and gethostbyaddr() in an effort to get traffic server building on more platforms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1192) Remove gethostbyname usage in test code
[ https://issues.apache.org/jira/browse/TS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13249622#comment-13249622 ] Brian Geffon commented on TS-1192: -- committed in 0d5e5e182194c36f3b37dfac421ec3cd13038081 Remove gethostbyname usage in test code --- Key: TS-1192 URL: https://issues.apache.org/jira/browse/TS-1192 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon Fix For: 3.1.4 NetTest-simple-proxy.cc and test_I_simple_proxy.cc directly use gethostbyname(). These will be changed to use getaddrinfo(). We're removing gethostbyname() and gethostbyaddr() in an effort to get traffic server building on more platforms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (TS-1192) Remove gethostbyname usage in test code
[ https://issues.apache.org/jira/browse/TS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon reassigned TS-1192: Assignee: Brian Geffon Remove gethostbyname usage in test code --- Key: TS-1192 URL: https://issues.apache.org/jira/browse/TS-1192 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon Assignee: Brian Geffon Fix For: 3.1.4 NetTest-simple-proxy.cc and test_I_simple_proxy.cc directly use gethostbyname(). These will be changed to use getaddrinfo(). We're removing gethostbyname() and gethostbyaddr() in an effort to get traffic server building on more platforms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TS-1192) Remove gethostbyname usage in test code
[ https://issues.apache.org/jira/browse/TS-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon resolved TS-1192. -- Resolution: Fixed Fix Version/s: 3.1.4 Remove gethostbyname usage in test code --- Key: TS-1192 URL: https://issues.apache.org/jira/browse/TS-1192 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon Fix For: 3.1.4 NetTest-simple-proxy.cc and test_I_simple_proxy.cc directly use gethostbyname(). These will be changed to use getaddrinfo(). We're removing gethostbyname() and gethostbyaddr() in an effort to get traffic server building on more platforms. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1193) Traffic Server building on OpenBSD
[ https://issues.apache.org/jira/browse/TS-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Brian Geffon updated TS-1193: - Affects Version/s: 3.1.3 Traffic Server building on OpenBSD -- Key: TS-1193 URL: https://issues.apache.org/jira/browse/TS-1193 Project: Traffic Server Issue Type: Improvement Affects Versions: 3.1.3 Reporter: Brian Geffon Assignee: Brian Geffon This is a parent issue for the task of getting traffic server building on OpenBSD. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
