[jira] [Created] (TS-2493) API: introducing UDP API
Zhao Yongming created TS-2493: - Summary: API: introducing UDP API Key: TS-2493 URL: https://issues.apache.org/jira/browse/TS-2493 Project: Traffic Server Issue Type: Improvement Reporter: Zhao Yongming when doing UDP tasks in plugins, there is no UDP api available to use, we need to introduce those APIs task for [~xinyuziran] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2493) API: introducing UDP API
[ https://issues.apache.org/jira/browse/TS-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-2493: -- Component/s: TS API Affects Version/s: 4.1.2 Fix Version/s: 4.2.0 Assignee: Zhao Yongming Labels: UDP (was: ) API: introducing UDP API Key: TS-2493 URL: https://issues.apache.org/jira/browse/TS-2493 Project: Traffic Server Issue Type: Improvement Components: TS API Affects Versions: 4.1.2 Reporter: Zhao Yongming Assignee: Zhao Yongming Labels: UDP Fix For: 4.2.0 when doing UDP tasks in plugins, there is no UDP api available to use, we need to introduce those APIs task for [~xinyuziran] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (TS-2488) any of the space chars can follow the esi starting tags
[
https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870535#comment-13870535
]
Yu Qing edited comment on TS-2488 at 1/14/14 8:57 AM:
--
hi, Kit Chan, the old codes are confusion.
{code}
42 const EsiParser::EsiNodeInfo EsiParser::ESI_NODES[] = {
43 EsiNodeInfo(DocNode::TYPE_INCLUDE, include , 8, /, 2),
44 EsiNodeInfo(DocNode::TYPE_REMOVE, remove, 7, /esi:remove, 13),
45 EsiNodeInfo(DocNode::TYPE_COMMENT, comment , 7, /, 2),
46 EsiNodeInfo(DocNode::TYPE_VARS, vars, 5, /esi:vars, 11),
47 EsiNodeInfo(DocNode::TYPE_CHOOSE, choose, 7, /esi:choose, 13),
48 EsiNodeInfo(DocNode::TYPE_WHEN, when , 5, /esi:when, 11),
49 EsiNodeInfo(DocNode::TYPE_OTHERWISE, otherwise, 10,
/esi:otherwise, 16),
50 EsiNodeInfo(DocNode::TYPE_TRY, try, 4, /esi:try, 10),
51 EsiNodeInfo(DocNode::TYPE_ATTEMPT, attempt , 8, /esi:attempt, 14),
52 EsiNodeInfo(DocNode::TYPE_EXCEPT, except , 7, /esi:except, 13),
53 EsiNodeInfo(DocNode::TYPE_SPECIAL_INCLUDE, special-include , 15, /,
2),
54 EsiNodeInfo(DocNode::TYPE_UNKNOWN, , 0, , 0) // serves as end marker
55 };
56
{code}
the length of comment is 8, not 7! and the length of special-include is
16, not 15! I think this is a bug, so i fixed it in this patch.
according to the the syntax of ESI or XML, one of space chars(' ', '\t', '\r',
'\n'), '/' and '' must follow these starting tags. so the old codes make a
mistake.
any question?
was (Author: happy_fish100):
hi, Kit Chan, the old codes are confusion.
[code]
42 const EsiParser::EsiNodeInfo EsiParser::ESI_NODES[] = {
43 EsiNodeInfo(DocNode::TYPE_INCLUDE, include , 8, /, 2),
44 EsiNodeInfo(DocNode::TYPE_REMOVE, remove, 7, /esi:remove, 13),
45 EsiNodeInfo(DocNode::TYPE_COMMENT, comment , 7, /, 2),
46 EsiNodeInfo(DocNode::TYPE_VARS, vars, 5, /esi:vars, 11),
47 EsiNodeInfo(DocNode::TYPE_CHOOSE, choose, 7, /esi:choose, 13),
48 EsiNodeInfo(DocNode::TYPE_WHEN, when , 5, /esi:when, 11),
49 EsiNodeInfo(DocNode::TYPE_OTHERWISE, otherwise, 10,
/esi:otherwise, 16),
50 EsiNodeInfo(DocNode::TYPE_TRY, try, 4, /esi:try, 10),
51 EsiNodeInfo(DocNode::TYPE_ATTEMPT, attempt , 8, /esi:attempt, 14),
52 EsiNodeInfo(DocNode::TYPE_EXCEPT, except , 7, /esi:except, 13),
53 EsiNodeInfo(DocNode::TYPE_SPECIAL_INCLUDE, special-include , 15, /,
2),
54 EsiNodeInfo(DocNode::TYPE_UNKNOWN, , 0, , 0) // serves as end marker
55 };
56
[code]
the length of comment is 8, not 7! and the length of special-include is
16, not 15! I think this is a bug, so i fixed it in this patch.
according to the the syntax of ESI or XML, one of space chars(' ', '\t', '\r',
'\n'), '/' and '' must follow these starting tags. so the old codes make a
mistake.
any questiion?
any of the space chars can follow the esi starting tags
---
Key: TS-2488
URL: https://issues.apache.org/jira/browse/TS-2488
Project: Traffic Server
Issue Type: Improvement
Components: Plugins
Reporter: Yu Qing
Assignee: Kit Chan
Attachments:
0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt,
bugfix-for-TS-2488.patch
only the space char ' ' can follow the esi starting tags such as
esi:include, !--esi now, we should allow any space char after these
tags. the space chars include: ' ', '\t', '\r' and '\n'.
for example, following common usage:
!--esi
esi bala bala ...
--
because no space after the !--esi, the esi parser will keep these tags
which should be removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (TS-2488) any of the space chars can follow the esi starting tags
[
https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870535#comment-13870535
]
Yu Qing commented on TS-2488:
-
hi, Kit Chan, the old codes are confusion.
[code]
42 const EsiParser::EsiNodeInfo EsiParser::ESI_NODES[] = {
43 EsiNodeInfo(DocNode::TYPE_INCLUDE, include , 8, /, 2),
44 EsiNodeInfo(DocNode::TYPE_REMOVE, remove, 7, /esi:remove, 13),
45 EsiNodeInfo(DocNode::TYPE_COMMENT, comment , 7, /, 2),
46 EsiNodeInfo(DocNode::TYPE_VARS, vars, 5, /esi:vars, 11),
47 EsiNodeInfo(DocNode::TYPE_CHOOSE, choose, 7, /esi:choose, 13),
48 EsiNodeInfo(DocNode::TYPE_WHEN, when , 5, /esi:when, 11),
49 EsiNodeInfo(DocNode::TYPE_OTHERWISE, otherwise, 10,
/esi:otherwise, 16),
50 EsiNodeInfo(DocNode::TYPE_TRY, try, 4, /esi:try, 10),
51 EsiNodeInfo(DocNode::TYPE_ATTEMPT, attempt , 8, /esi:attempt, 14),
52 EsiNodeInfo(DocNode::TYPE_EXCEPT, except , 7, /esi:except, 13),
53 EsiNodeInfo(DocNode::TYPE_SPECIAL_INCLUDE, special-include , 15, /,
2),
54 EsiNodeInfo(DocNode::TYPE_UNKNOWN, , 0, , 0) // serves as end marker
55 };
56
[code]
the length of comment is 8, not 7! and the length of special-include is
16, not 15! I think this is a bug, so i fixed it in this patch.
according to the the syntax of ESI or XML, one of space chars(' ', '\t', '\r',
'\n'), '/' and '' must follow these starting tags. so the old codes make a
mistake.
any questiion?
any of the space chars can follow the esi starting tags
---
Key: TS-2488
URL: https://issues.apache.org/jira/browse/TS-2488
Project: Traffic Server
Issue Type: Improvement
Components: Plugins
Reporter: Yu Qing
Assignee: Kit Chan
Attachments:
0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt,
bugfix-for-TS-2488.patch
only the space char ' ' can follow the esi starting tags such as
esi:include, !--esi now, we should allow any space char after these
tags. the space chars include: ' ', '\t', '\r' and '\n'.
for example, following common usage:
!--esi
esi bala bala ...
--
because no space after the !--esi, the esi parser will keep these tags
which should be removed.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Updated] (TS-2449) I find INKUDPRecvFrom can not work .
[ https://issues.apache.org/jira/browse/TS-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinyuziran updated TS-2449: --- Attachment: main.patch iocore.patch All patch is here. I find INKUDPRecvFrom can not work . - Key: TS-2449 URL: https://issues.apache.org/jira/browse/TS-2449 Project: Traffic Server Issue Type: Bug Components: Core Reporter: xinyuziran Attachments: iocore.patch, main.patch, udp_patch.txt I find INKUDPBind can bind udp port, but INKUDPRecvFrom can't recive udp data. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2493) API: introducing UDP API
[ https://issues.apache.org/jira/browse/TS-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinyuziran updated TS-2493: --- Attachment: api.patch Udp api for plugin API: introducing UDP API Key: TS-2493 URL: https://issues.apache.org/jira/browse/TS-2493 Project: Traffic Server Issue Type: Improvement Components: TS API Affects Versions: 4.1.2 Reporter: Zhao Yongming Assignee: Zhao Yongming Labels: UDP Fix For: 4.2.0 Attachments: api.patch when doing UDP tasks in plugins, there is no UDP api available to use, we need to introduce those APIs task for [~xinyuziran] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Closed] (TS-2449) I find INKUDPRecvFrom can not work .
[ https://issues.apache.org/jira/browse/TS-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xinyuziran closed TS-2449. -- Resolution: Fixed Fix Version/s: 4.1.3 I find INKUDPRecvFrom can not work . - Key: TS-2449 URL: https://issues.apache.org/jira/browse/TS-2449 Project: Traffic Server Issue Type: Bug Components: Core Reporter: xinyuziran Fix For: 4.1.3 Attachments: iocore.patch, main.patch, udp_patch.txt I find INKUDPBind can bind udp port, but INKUDPRecvFrom can't recive udp data. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weijin reassigned TS-2494: -- Assignee: weijin ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Reporter: weijin Assignee: weijin Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Work started] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on TS-2494 started by weijin. ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Reporter: weijin Assignee: weijin Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weijin updated TS-2494: --- Attachment: TS-2494.diff ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Reporter: weijin Assignee: weijin Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870567#comment-13870567 ] weijin commented on TS-2494: traffic_line -s proxy.config.http.negative_revalidating_enabled -v 1 traffic_line -s proxy.config.http.negative_revalidating_lifetime -v 60 if the cached copy is stale and the os is down, the crash occurs. ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Reporter: weijin -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
weijin created TS-2494: -- Summary: ts crash if negative_revalidating_enabled when the os is down Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Reporter: weijin -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weijin updated TS-2494: --- Affects Version/s: 3.2.5 4.0.2 4.1.2 ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Affects Versions: 3.2.5, 4.0.2, 4.1.2 Reporter: weijin Assignee: weijin Priority: Critical Fix For: 4.2.0 Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weijin updated TS-2494: --- Fix Version/s: 4.2.0 ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Affects Versions: 3.2.5, 4.0.2, 4.1.2 Reporter: weijin Assignee: weijin Priority: Critical Fix For: 4.2.0 Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] weijin updated TS-2494: --- Priority: Critical (was: Major) ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Affects Versions: 3.2.5, 4.0.2, 4.1.2 Reporter: weijin Assignee: weijin Priority: Critical Fix For: 4.2.0 Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2494) ts crash if negative_revalidating_enabled when the os is down
[ https://issues.apache.org/jira/browse/TS-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870576#comment-13870576 ] weijin commented on TS-2494: traffic_line -s proxy.config.http.negative_caching_enabled -v 1 traffic_line -s proxy.config.http.negative_caching_lifetime -v 1 and the stale cached copy is not a 200 OK document but a 404 (not found) document. ts crash if negative_revalidating_enabled when the os is down - Key: TS-2494 URL: https://issues.apache.org/jira/browse/TS-2494 Project: Traffic Server Issue Type: Bug Affects Versions: 3.2.5, 4.0.2, 4.1.2 Reporter: weijin Assignee: weijin Priority: Critical Fix For: 4.2.0 Attachments: TS-2494.diff -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2490) traffic_cop kills TS process before it completes starting
[ https://issues.apache.org/jira/browse/TS-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870723#comment-13870723 ] Koushik Biswas commented on TS-2490: Guys what about adding a setting like config.watch_sleep_time to ATS? I agree that will not fix the problem described in TS-2058, as it will need to be in minutes, and that is impractical. However, while you decide on the best and most elegant fix to this start-up problem, config.watch_sleep_time would unblock people who just need traffic_cop to wait 10 - 20 seconds more before pulling the trigger. It is a 10 minute patch that will help someone out there. Please let me know your thoughts. traffic_cop kills TS process before it completes starting - Key: TS-2490 URL: https://issues.apache.org/jira/browse/TS-2490 Project: Traffic Server Issue Type: Bug Components: Cop, Core Reporter: David Carlin Several things can slow traffic_server startup - Long remap.config file - Long list of certs in ssl_multicert.config (see TS-2058) - Plugins that take too long to initialize You end up with a race condition where traffic_server never starts because traffic_cop kills it before it completes. There was a hack at Yahoo to address this - a YTS setting proxy.config.watch_sleep_time to change the heartbeat interval as a workaround. Doesn't seem like a practical solution for issues like TS-2058 where the heartbeat would need to be in minutes. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2449) I find INKUDPRecvFrom can not work .
[ https://issues.apache.org/jira/browse/TS-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-2449: -- Assignee: weijin I find INKUDPRecvFrom can not work . - Key: TS-2449 URL: https://issues.apache.org/jira/browse/TS-2449 Project: Traffic Server Issue Type: Bug Components: Core Reporter: xinyuziran Assignee: weijin Fix For: 4.1.3 Attachments: iocore.patch, main.patch, udp_patch.txt I find INKUDPBind can bind udp port, but INKUDPRecvFrom can't recive udp data. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2493) API: introducing UDP API
[ https://issues.apache.org/jira/browse/TS-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-2493: -- Assignee: weijin (was: Zhao Yongming) API: introducing UDP API Key: TS-2493 URL: https://issues.apache.org/jira/browse/TS-2493 Project: Traffic Server Issue Type: Improvement Components: TS API Affects Versions: 4.1.2 Reporter: Zhao Yongming Assignee: weijin Labels: UDP Fix For: 4.2.0 Attachments: api.patch when doing UDP tasks in plugins, there is no UDP api available to use, we need to introduce those APIs task for [~xinyuziran] -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2449) I find INKUDPRecvFrom can not work .
[ https://issues.apache.org/jira/browse/TS-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-2449: -- Affects Version/s: 4.1.2 I find INKUDPRecvFrom can not work . - Key: TS-2449 URL: https://issues.apache.org/jira/browse/TS-2449 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 4.1.2 Reporter: xinyuziran Assignee: weijin Fix For: 4.2.0 Attachments: iocore.patch, main.patch, udp_patch.txt I find INKUDPBind can bind udp port, but INKUDPRecvFrom can't recive udp data. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2449) I find INKUDPRecvFrom can not work .
[ https://issues.apache.org/jira/browse/TS-2449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhao Yongming updated TS-2449: -- Fix Version/s: (was: 4.1.3) I find INKUDPRecvFrom can not work . - Key: TS-2449 URL: https://issues.apache.org/jira/browse/TS-2449 Project: Traffic Server Issue Type: Bug Components: Core Affects Versions: 4.1.2 Reporter: xinyuziran Assignee: weijin Fix For: 4.2.0 Attachments: iocore.patch, main.patch, udp_patch.txt I find INKUDPBind can bind udp port, but INKUDPRecvFrom can't recive udp data. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (TS-2491) esi make test outputs All tests passed! but some test cases fail
[ https://issues.apache.org/jira/browse/TS-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kit Chan reassigned TS-2491: Assignee: Kit Chan esi make test outputs All tests passed! but some test cases fail -- Key: TS-2491 URL: https://issues.apache.org/jira/browse/TS-2491 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Attachments: 0001-TS-2491-esi-make-test-outputs-All-tests-passed-but-s.patch when some test cases fail in test/parser_test.cc, the last line is All tests passed!. we should show the error message when a test case fails, and break the batch tests. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2491) esi make test outputs All tests passed! but some test cases fail
[ https://issues.apache.org/jira/browse/TS-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-2491: -- Fix Version/s: 4.2.0 esi make test outputs All tests passed! but some test cases fail -- Key: TS-2491 URL: https://issues.apache.org/jira/browse/TS-2491 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2491-esi-make-test-outputs-All-tests-passed-but-s.patch when some test cases fail in test/parser_test.cc, the last line is All tests passed!. we should show the error message when a test case fails, and break the batch tests. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2488) any of the space chars can follow the esi starting tags
[ https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-2488: -- Fix Version/s: 4.2.0 any of the space chars can follow the esi starting tags --- Key: TS-2488 URL: https://issues.apache.org/jira/browse/TS-2488 Project: Traffic Server Issue Type: Improvement Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt, bugfix-for-TS-2488.patch only the space char ' ' can follow the esi starting tags such as esi:include, !--esi now, we should allow any space char after these tags. the space chars include: ' ', '\t', '\r' and '\n'. for example, following common usage: !--esi esi bala bala ... -- because no space after the !--esi, the esi parser will keep these tags which should be removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2488) any of the space chars can follow the esi starting tags
[ https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870852#comment-13870852 ] Leif Hedstrom commented on TS-2488: --- Thanks for all these patches! any of the space chars can follow the esi starting tags --- Key: TS-2488 URL: https://issues.apache.org/jira/browse/TS-2488 Project: Traffic Server Issue Type: Improvement Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt, bugfix-for-TS-2488.patch only the space char ' ' can follow the esi starting tags such as esi:include, !--esi now, we should allow any space char after these tags. the space chars include: ' ', '\t', '\r' and '\n'. for example, following common usage: !--esi esi bala bala ... -- because no space after the !--esi, the esi parser will keep these tags which should be removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-656) reimplement Connection Collapsing in a smooth way
[ https://issues.apache.org/jira/browse/TS-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870862#comment-13870862 ] Leif Hedstrom commented on TS-656: -- So, out of curiosity, how much work do you expect here? I wrote up a pretty significant amount of docs around how things works. We almost have connection collapsing already, in fact, it's probably *better* as it is today compared to Squid. See http://docs.trafficserver.apache.org/en/latest/admin/http-proxy-caching.en.html#reducing-origin-server-requests-avoiding-the-thundering-herd What's really missing here is probably something like a plugin, which controls our existing behavior based on requests / URL patterns. I would ask you not to implement a new system without discussing this on either the Wiki, mailing lists or bugs. :). reimplement Connection Collapsing in a smooth way - Key: TS-656 URL: https://issues.apache.org/jira/browse/TS-656 Project: Traffic Server Issue Type: Improvement Components: HTTP Affects Versions: 2.1.6 Environment: per discussed in IRC, we'd like to clean the current CC codes from trunk. Reporter: Zhao Yongming Assignee: weijin Fix For: 6.0.0 we should figure out how to implement the Connection Collapsing that not so ugly. target for V3.1 or so. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Closed] (TS-2488) any of the space chars can follow the esi starting tags
[ https://issues.apache.org/jira/browse/TS-2488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kit Chan closed TS-2488. any of the space chars can follow the esi starting tags --- Key: TS-2488 URL: https://issues.apache.org/jira/browse/TS-2488 Project: Traffic Server Issue Type: Improvement Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2488-any-space-char-can-follow-the-esi-starting-t.patch, 2488.txt, bugfix-for-TS-2488.patch only the space char ' ' can follow the esi starting tags such as esi:include, !--esi now, we should allow any space char after these tags. the space chars include: ' ', '\t', '\r' and '\n'. for example, following common usage: !--esi esi bala bala ... -- because no space after the !--esi, the esi parser will keep these tags which should be removed. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2491) esi make test outputs All tests passed! but some test cases fail
[ https://issues.apache.org/jira/browse/TS-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13870959#comment-13870959 ] Kit Chan commented on TS-2491: -- Sorry about the author name/email mistake. I accidentally use a wrong terminal window on my machine. Really sorry about that. esi make test outputs All tests passed! but some test cases fail -- Key: TS-2491 URL: https://issues.apache.org/jira/browse/TS-2491 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2491-esi-make-test-outputs-All-tests-passed-but-s.patch when some test cases fail in test/parser_test.cc, the last line is All tests passed!. we should show the error message when a test case fails, and break the batch tests. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2495) reduce the size of HttpVCTableEntry
[ https://issues.apache.org/jira/browse/TS-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-2495: Priority: Minor (was: Major) Fix Version/s: 4.2.0 Assignee: James Peach reduce the size of HttpVCTableEntry --- Key: TS-2495 URL: https://issues.apache.org/jira/browse/TS-2495 Project: Traffic Server Issue Type: Improvement Components: Performance Reporter: James Peach Assignee: James Peach Priority: Minor Fix For: 4.2.0 The ordering of fields in HttpVCTableEntry makes it take more space than necessary. We should minimize the waste. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Created] (TS-2495) reduce the size of HttpVCTableEntry
James Peach created TS-2495: --- Summary: reduce the size of HttpVCTableEntry Key: TS-2495 URL: https://issues.apache.org/jira/browse/TS-2495 Project: Traffic Server Issue Type: Improvement Components: Performance Reporter: James Peach The ordering of fields in HttpVCTableEntry makes it take more space than necessary. We should minimize the waste. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (TS-2495) reduce the size of HttpVCTableEntry
[ https://issues.apache.org/jira/browse/TS-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach resolved TS-2495. - Resolution: Fixed reduce the size of HttpVCTableEntry --- Key: TS-2495 URL: https://issues.apache.org/jira/browse/TS-2495 Project: Traffic Server Issue Type: Improvement Components: Performance Reporter: James Peach Assignee: James Peach Priority: Minor Fix For: 4.2.0 The ordering of fields in HttpVCTableEntry makes it take more space than necessary. We should minimize the waste. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2490) traffic_cop kills TS process before it completes starting
[ https://issues.apache.org/jira/browse/TS-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871353#comment-13871353 ] Bryan Call commented on TS-2490: Normally this happens on startup and we really shouldn't have a longer interval between for heathchecks on a running system. I recommend having a configurable startup heathcheck interval and after it has a successful healthcheck it starts to use the standard 10 second interval. traffic_cop kills TS process before it completes starting - Key: TS-2490 URL: https://issues.apache.org/jira/browse/TS-2490 Project: Traffic Server Issue Type: Bug Components: Cop, Core Reporter: David Carlin Several things can slow traffic_server startup - Long remap.config file - Long list of certs in ssl_multicert.config (see TS-2058) - Plugins that take too long to initialize You end up with a race condition where traffic_server never starts because traffic_cop kills it before it completes. There was a hack at Yahoo to address this - a YTS setting proxy.config.watch_sleep_time to change the heartbeat interval as a workaround. Doesn't seem like a practical solution for issues like TS-2058 where the heartbeat would need to be in minutes. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2490) traffic_cop kills TS process before it completes starting
[ https://issues.apache.org/jira/browse/TS-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871368#comment-13871368 ] Leif Hedstrom commented on TS-2490: --- What if we don't allow traffic_cop to kill anything until it has reached a good state? So, something like fail (no restart) fail (no restart) fail (no restart) success success ... fail (no restart) fail (restart) (remember, it takes two failures in a row to restart). This also avoids an annoying step where ATS goes into a loop of constant restarts because it can't startup properly. traffic_cop kills TS process before it completes starting - Key: TS-2490 URL: https://issues.apache.org/jira/browse/TS-2490 Project: Traffic Server Issue Type: Bug Components: Cop, Core Reporter: David Carlin Several things can slow traffic_server startup - Long remap.config file - Long list of certs in ssl_multicert.config (see TS-2058) - Plugins that take too long to initialize You end up with a race condition where traffic_server never starts because traffic_cop kills it before it completes. There was a hack at Yahoo to address this - a YTS setting proxy.config.watch_sleep_time to change the heartbeat interval as a workaround. Doesn't seem like a practical solution for issues like TS-2058 where the heartbeat would need to be in minutes. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2490) traffic_cop kills TS process before it completes starting
[
https://issues.apache.org/jira/browse/TS-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871370#comment-13871370
]
James Peach commented on TS-2490:
-
I don't have any objection to making the {{traffic_cop}} timeouts tunable. The
patch in TS-2058 is what I would prefer (set up the heartbeat earlier).
traffic_cop kills TS process before it completes starting
-
Key: TS-2490
URL: https://issues.apache.org/jira/browse/TS-2490
Project: Traffic Server
Issue Type: Bug
Components: Cop, Core
Reporter: David Carlin
Several things can slow traffic_server startup
- Long remap.config file
- Long list of certs in ssl_multicert.config (see TS-2058)
- Plugins that take too long to initialize
You end up with a race condition where traffic_server never starts because
traffic_cop kills it before it completes.
There was a hack at Yahoo to address this - a YTS setting
proxy.config.watch_sleep_time to change the heartbeat interval as a
workaround. Doesn't seem like a practical solution for issues like TS-2058
where the heartbeat would need to be in minutes.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (TS-2491) esi make test outputs All tests passed! but some test cases fail
[ https://issues.apache.org/jira/browse/TS-2491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871481#comment-13871481 ] Yu Qing commented on TS-2491: - take easy, hehe :) esi make test outputs All tests passed! but some test cases fail -- Key: TS-2491 URL: https://issues.apache.org/jira/browse/TS-2491 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Yu Qing Assignee: Kit Chan Fix For: 4.2.0 Attachments: 0001-TS-2491-esi-make-test-outputs-All-tests-passed-but-s.patch when some test cases fail in test/parser_test.cc, the last line is All tests passed!. we should show the error message when a test case fails, and break the batch tests. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2287) Create a Wiki page to document the design
[ https://issues.apache.org/jira/browse/TS-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871630#comment-13871630 ] Leif Hedstrom commented on TS-2287: --- Done: https://cwiki.apache.org/confluence/display/TS/Lua+Configurations Create a Wiki page to document the design - Key: TS-2287 URL: https://issues.apache.org/jira/browse/TS-2287 Project: Traffic Server Issue Type: Sub-task Reporter: Phil Sorber Assignee: Leif Hedstrom Fix For: Docs We need something a little more formal than the summit notes. It should go in the wiki. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Comment Edited] (TS-2287) Create a Wiki page to document the design
[ https://issues.apache.org/jira/browse/TS-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871630#comment-13871630 ] Leif Hedstrom edited comment on TS-2287 at 1/15/14 4:33 AM: Started: https://cwiki.apache.org/confluence/display/TS/Lua+Configurations was (Author: zwoop): Done: https://cwiki.apache.org/confluence/display/TS/Lua+Configurations Create a Wiki page to document the design - Key: TS-2287 URL: https://issues.apache.org/jira/browse/TS-2287 Project: Traffic Server Issue Type: Sub-task Reporter: Phil Sorber Assignee: Leif Hedstrom Fix For: Docs We need something a little more formal than the summit notes. It should go in the wiki. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (TS-2287) Create a Wiki page to document the design
[ https://issues.apache.org/jira/browse/TS-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reassigned TS-2287: - Assignee: Leif Hedstrom Create a Wiki page to document the design - Key: TS-2287 URL: https://issues.apache.org/jira/browse/TS-2287 Project: Traffic Server Issue Type: Sub-task Reporter: Phil Sorber Assignee: Leif Hedstrom Fix For: Docs We need something a little more formal than the summit notes. It should go in the wiki. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2287) Create a Wiki page to document the design
[ https://issues.apache.org/jira/browse/TS-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-2287: -- Fix Version/s: (was: 5.0.0) Docs Create a Wiki page to document the design - Key: TS-2287 URL: https://issues.apache.org/jira/browse/TS-2287 Project: Traffic Server Issue Type: Sub-task Reporter: Phil Sorber Assignee: Leif Hedstrom Fix For: Docs We need something a little more formal than the summit notes. It should go in the wiki. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Resolved] (TS-2287) Create a Wiki page to document the design
[ https://issues.apache.org/jira/browse/TS-2287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom resolved TS-2287. --- Resolution: Fixed I'm going to resolve this for now, I don't think we need a bug open for a wiki page now that it's created and just need continuous iterative modifications. Create a Wiki page to document the design - Key: TS-2287 URL: https://issues.apache.org/jira/browse/TS-2287 Project: Traffic Server Issue Type: Sub-task Reporter: Phil Sorber Assignee: Leif Hedstrom Fix For: Docs We need something a little more formal than the summit notes. It should go in the wiki. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Updated] (TS-2281) Augment config system to use LUA
[ https://issues.apache.org/jira/browse/TS-2281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-2281: -- Fix Version/s: (was: 6.0.0) 5.0.0 Augment config system to use LUA Key: TS-2281 URL: https://issues.apache.org/jira/browse/TS-2281 Project: Traffic Server Issue Type: Improvement Components: Configuration Reporter: Phil Sorber Assignee: Phil Sorber Fix For: 5.0.0 This is the main ticket for an upgrade of the config system to support LUA as discussed at the Fall 2013 Summit at Yahoo!. Notes from Summit: https://docs.google.com/document/d/1Gf3tfad1CbUEtd4n79MzgN4hRq-eu1hMh8FPW49NBe8/edit# -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Assigned] (TS-2289) Only support AIO_MODE_THREAD and AIO_MODE_NATIVE
[ https://issues.apache.org/jira/browse/TS-2289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom reassigned TS-2289: - Assignee: Leif Hedstrom Only support AIO_MODE_THREAD and AIO_MODE_NATIVE Key: TS-2289 URL: https://issues.apache.org/jira/browse/TS-2289 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.0.0 As discussed, we'd like to simplify this code, and only keep our own AIO and the linux native AIO implementations. That would leave AIO_MODE_THREAD and AIO_MODE_NATIVE. Also, I think it's pretty unfortunate that AIO_MODE_NATIVE has to escape encapsulation and have custom code in e.g. Cache.cc. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (TS-2437) Add an API to expose SSL_CTX for applications
[
https://issues.apache.org/jira/browse/TS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871652#comment-13871652
]
James Peach commented on TS-2437:
-
I think that the right way to do this might be using the lifecycle hooks API.
If you use an observer pattern, you can decouple the API from the code in
iocore. The lifecycle hooks would also let you handle the case where
certificates are reloaded, it's re-entrant and safe for multiple plugins, and
does not require the additional copy of the {{SSL_CTX}} pointers. Take a look
at {{TSLifecycleHookAdd}} and see what you think.
Add an API to expose SSL_CTX for applications
-
Key: TS-2437
URL: https://issues.apache.org/jira/browse/TS-2437
Project: Traffic Server
Issue Type: Task
Components: SSL, TS API
Reporter: Wei Sun
Assignee: James Peach
Fix For: 4.2.0
Attachments: TS-2437-2.diff, TS-2437.diff
It'll be good to add an API to expose all the SSL_CTXs, so that plugins can
manipulate their specific ssl settings / call back, etc.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
[jira] [Commented] (TS-2437) Add an API to expose SSL_CTX for applications
[ https://issues.apache.org/jira/browse/TS-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13871778#comment-13871778 ] Wei Sun commented on TS-2437: - Thanks for the reply. Per my understanding, the SSL contexts are initialized before loading plugins (TSPluginInit). It might not work If I invoke a lifecycle hook (e.g. TS_LIFECYCLE_SSL_CTX_INITIALIZED_HOOK) when creating SSL ctx, since the TSLifecycleHookAdd is delayed in TSPluginInit. Then I still need to store the created ssl_ctx in somewhere, and iterate them at a later time. Please correct me if I misunderstand your comment. Add an API to expose SSL_CTX for applications - Key: TS-2437 URL: https://issues.apache.org/jira/browse/TS-2437 Project: Traffic Server Issue Type: Task Components: SSL, TS API Reporter: Wei Sun Assignee: James Peach Fix For: 4.2.0 Attachments: TS-2437-2.diff, TS-2437.diff It'll be good to add an API to expose all the SSL_CTXs, so that plugins can manipulate their specific ssl settings / call back, etc. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
