[jira] [Commented] (TS-2480) Choose the address related SSL_CTX for session ticket callback
[ https://issues.apache.org/jira/browse/TS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308547#comment-14308547 ] ASF subversion and git services commented on TS-2480: - Commit 5fe69772aa7e5e841349f3426a997930b44c0ff5 in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5fe6977 ] TS-2480: Fix to work in the case where there are no ticket key files but tickets have not been disabled. Also fix RHEL 5 compile error. Choose the address related SSL_CTX for session ticket callback -- Key: TS-2480 URL: https://issues.apache.org/jira/browse/TS-2480 Project: Traffic Server Issue Type: Improvement Components: SSL Reporter: Wei Sun Assignee: Susan Hinrichs Labels: review Fix For: 5.3.0 Attachments: TS-2480.diff When the dest_ip in ssl_multicert.config is not '*', the default SSL_CTX retrieved from the request when presenting session ticket or session id is not associated with any app data (certs, settings, etc), ats delays the association in SNI handling. So in the callback of SSL_CTX_set_tlsext_ticket_key_cb or SSL_CTX_sess_set_get_cb, it won't get the expected SSL_CTX, and session ticket handling will be degraded to the default behavior. I have a requirement of retrieving SSL_CTX during these two callback functions, probably I could workaround it by SSLCertificateConfig::acquire()-findInfoInHash(ip) in every callback and get the expected SSL_CTX. I'm wondering is it feasible to do it once in make_ssl_connection()? Is there any design consideration for being this (delay to overwrite the SSL_CTX in SNI handling)? I have a small patch if it is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3287) Coverity fixes for v5.3.0 by zwoop
[ https://issues.apache.org/jira/browse/TS-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307414#comment-14307414 ] ASF subversion and git services commented on TS-3287: - Commit 01121ce827e246496f74e0ce4ed8770b67cb524d in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=01121ce ] TS-3287: Test for equality with zero on fd as well Coverity CID #1021842 Coverity fixes for v5.3.0 by zwoop -- Key: TS-3287 URL: https://issues.apache.org/jira/browse/TS-3287 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.3.0 This is my JIRA for Coverity commits for v5.3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2941) ATS not closing TLS connection properly
[ https://issues.apache.org/jira/browse/TS-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307437#comment-14307437 ] Susan Hinrichs commented on TS-2941: I got some insight from reading the SSL_shutdown man page https://www.openssl.org/docs/ssl/SSL_shutdown.html. If you enable quiet_shutdown, the SSL_shutdown will always return with success. Otherwise, you may need to call SSL_shutdown multiple times (much as you do with SSL_accept) to get the close_notify handshake through. Based on that, I'm assuming the original motivation for using quiet_shutdown was programming expediency. I'll move on assuming that and try to update our use of SSL_shutdown to operate without the quiet_shutdown. ATS not closing TLS connection properly --- Key: TS-2941 URL: https://issues.apache.org/jira/browse/TS-2941 Project: Traffic Server Issue Type: Bug Components: SSL Reporter: Alexey Ivanov Assignee: Susan Hinrichs Fix For: sometime We are seeing lots of RSTs on our edge boxes from HTTPS-enabled clients: {code} 20:31:42.861752 IP client-ip.56898 www.linkedin.com.https: Flags [S], seq 2989744105, win 65535, options [mss 1460,nop,wscale 4,nop,nop,TS val 1060727394 ecr 0,sackOK,eol], length 0 20:31:42.861760 IP www.linkedin.com.https client-ip.56898: Flags [S.], seq 441157858, ack 2989744106, win 14480, options [mss 1460,sackOK,TS val 579955489 ecr 1060727394,nop,wscale 7], length 0 20:31:43.005735 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack 1, win 8235, options [nop,nop,TS val 1060727553 ecr 579955489], length 0 20:31:43.012094 IP client-ip.56898 www.linkedin.com.https: Flags [P.], seq 1:216, ack 1, win 8235, options [nop,nop,TS val 1060727555 ecr 579955489], length 215 20:31:43.012115 IP www.linkedin.com.https client-ip.56898: Flags [.], ack 216, win 122, options [nop,nop,TS val 579955639 ecr 1060727555], length 0 20:31:43.012400 IP www.linkedin.com.https client-ip.56898: Flags [P.], seq 1:186, ack 216, win 122, options [nop,nop,TS val 579955640 ecr 1060727555], length 185 20:31:43.157903 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack 186, win 8223, options [nop,nop,TS val 1060727703 ecr 579955640], length 0 20:31:43.157919 IP client-ip.56898 www.linkedin.com.https: Flags [P.], seq 216:222, ack 186, win 8223, options [nop,nop,TS val 1060727704 ecr 579955640], length 6 20:31:43.163988 IP client-ip.56898 www.linkedin.com.https: Flags [P.], seq 222:307, ack 186, win 8223, options [nop,nop,TS val 1060727704 ecr 579955640], length 85 20:31:43.164096 IP www.linkedin.com.https client-ip.56898: Flags [.], ack 307, win 122, options [nop,nop,TS val 579955791 ecr 1060727704], length 0 20:31:43.164650 IP client-ip.56898 www.linkedin.com.https: Flags [.], seq 307:1755, ack 186, win 8223, options [nop,nop,TS val 1060727705 ecr 579955640], length 1448 20:31:43.164668 IP client-ip.56898 www.linkedin.com.https: Flags [P.], seq 1755:2472, ack 186, win 8223, options [nop,nop,TS val 1060727705 ecr 579955640], length 717 20:31:43.164677 IP www.linkedin.com.https client-ip.56898: Flags [.], ack 2472, win 167, options [nop,nop,TS val 579955792 ecr 1060727705], length 0 20:31:43.504019 IP www.linkedin.com.https client-ip.56898: Flags [P.], seq 186:1167, ack 2472, win 167, options [nop,nop,TS val 579956131 ecr 1060727705], length 981 20:31:43.504043 IP www.linkedin.com.https client-ip.56898: Flags [P.], seq 1167:1764, ack 2472, win 167, options [nop,nop,TS val 579956131 ecr 1060727705], length 597 20:31:43.504101 IP www.linkedin.com.https client-ip.56898: Flags [.], seq 1764:3212, ack 2472, win 167, options [nop,nop,TS val 579956131 ecr 1060727705], length 1448 20:31:43.504118 IP www.linkedin.com.https client-ip.56898: Flags [.], seq 3212:4660, ack 2472, win 167, options [nop,nop,TS val 579956131 ecr 1060727705], length 1448 20:31:43.504150 IP www.linkedin.com.https client-ip.56898: Flags [.], seq 4660:6108, ack 2472, win 167, options [nop,nop,TS val 579956132 ecr 1060727705], length 1448 20:31:43.743945 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack 1167, win 8162, options [nop,nop,TS val 1060728286 ecr 579956131], length 0 20:31:43.743966 IP www.linkedin.com.https client-ip.56898: Flags [P.], seq 6108:6126, ack 2472, win 167, options [nop,nop,TS val 579956371 ecr 1060728286], length 18 20:31:43.743987 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack 4660, win 7944, options [nop,nop,TS val 1060728286 ecr 579956131], length 0 20:31:43.743994 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack 6108, win 8192, options [nop,nop,TS val 1060728286 ecr 579956132], length 0 20:31:43.895889 IP client-ip.56898 www.linkedin.com.https: Flags [.], ack
[jira] [Commented] (TS-2480) Choose the address related SSL_CTX for session ticket callback
[ https://issues.apache.org/jira/browse/TS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308040#comment-14308040 ] ASF subversion and git services commented on TS-2480: - Commit 96ae19b6690aeec5ed77a5c92330750141c99d65 in trafficserver's branch refs/heads/master from shinrich [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=96ae19b ] TS-2480: Fix leak in the ticket key improvements. Choose the address related SSL_CTX for session ticket callback -- Key: TS-2480 URL: https://issues.apache.org/jira/browse/TS-2480 Project: Traffic Server Issue Type: Improvement Components: SSL Reporter: Wei Sun Assignee: Susan Hinrichs Labels: review Fix For: 5.3.0 Attachments: TS-2480.diff When the dest_ip in ssl_multicert.config is not '*', the default SSL_CTX retrieved from the request when presenting session ticket or session id is not associated with any app data (certs, settings, etc), ats delays the association in SNI handling. So in the callback of SSL_CTX_set_tlsext_ticket_key_cb or SSL_CTX_sess_set_get_cb, it won't get the expected SSL_CTX, and session ticket handling will be degraded to the default behavior. I have a requirement of retrieving SSL_CTX during these two callback functions, probably I could workaround it by SSLCertificateConfig::acquire()-findInfoInHash(ip) in every callback and get the expected SSL_CTX. I'm wondering is it feasible to do it once in make_ssl_connection()? Is there any design consideration for being this (delay to overwrite the SSL_CTX in SNI handling)? I have a small patch if it is needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3287) Coverity fixes for v5.3.0 by zwoop
[ https://issues.apache.org/jira/browse/TS-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307380#comment-14307380 ] ASF subversion and git services commented on TS-3287: - Commit 63d25f9adc9cf2a21f5fdad1600c3b1b8e6127c4 in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=63d25f9 ] TS-3287: Close socket to prevent resource leak Coverity CID #1021829 Coverity fixes for v5.3.0 by zwoop -- Key: TS-3287 URL: https://issues.apache.org/jira/browse/TS-3287 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.3.0 This is my JIRA for Coverity commits for v5.3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3287) Coverity fixes for v5.3.0 by zwoop
[ https://issues.apache.org/jira/browse/TS-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307333#comment-14307333 ] ASF subversion and git services commented on TS-3287: - Commit 7ac50d860015e1cce1e7b3d19d4eb07d42a583d8 in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7ac50d8 ] TS-3287: Close socket to prevent resource leak Coverity CID #1022129 Coverity fixes for v5.3.0 by zwoop -- Key: TS-3287 URL: https://issues.apache.org/jira/browse/TS-3287 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.3.0 This is my JIRA for Coverity commits for v5.3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3287) Coverity fixes for v5.3.0 by zwoop
[ https://issues.apache.org/jira/browse/TS-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307334#comment-14307334 ] ASF subversion and git services commented on TS-3287: - Commit d19a88b0df8baeb01e9215b73c658c20fdd72f2e in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d19a88b ] TS-3287: Close socket to prevent resource leak Coverity CID #1022130 Coverity fixes for v5.3.0 by zwoop -- Key: TS-3287 URL: https://issues.apache.org/jira/browse/TS-3287 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.3.0 This is my JIRA for Coverity commits for v5.3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3287) Coverity fixes for v5.3.0 by zwoop
[ https://issues.apache.org/jira/browse/TS-3287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14308241#comment-14308241 ] ASF subversion and git services commented on TS-3287: - Commit e938aa4c15700d654e026e44a0d6aad9117849a6 in trafficserver's branch refs/heads/master from [~psudaemon] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e938aa4 ] TS-3287: Use dup2() instead of close()/fnctl() to avoid race condition. Check return value of dup2() for errors. Coverity CID #114 Coverity fixes for v5.3.0 by zwoop -- Key: TS-3287 URL: https://issues.apache.org/jira/browse/TS-3287 Project: Traffic Server Issue Type: Bug Components: Core Reporter: Leif Hedstrom Assignee: Leif Hedstrom Fix For: 5.3.0 This is my JIRA for Coverity commits for v5.3.0. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Build failed in Jenkins: tsqa-master #106
See https://ci.trafficserver.apache.org/job/tsqa-master/106/changes Changes: [mlibbey] fix whitespace issue [mlibbey] add missing character to make link [mlibbey] Fix broken internal link [briang] Adding TsConfigSyntax.c (bison generated) to .gitignore -- [...truncated 13165 lines...] 10 568 2848.100 45801169/4580116 1836 1836 1836 75889552 25.90 10 568 2845.600 45525047/4552504 1832 1832 1832 75870538 26.90 10 567 2838.500 44998155/4499815 1830 1830 1830 74850551 27.90 10 568 2843.600 44435848/4443584 1822 1822 1823 73520528 28.90 10 575 2880.700 44370589/4437058 1845 1845 1845 73154347 29.90 10 569 2849.400 43658933/4365893 1822 1822 1822 72014804 30.90 10 568 2845.500 43373812/4337381 1817 1817 1817 72214569 31.90 MSG: reloading logging configuration 10 572 2863.800 43011701/4301170 1824 1824 1824 71368713 32.90 10 572 2861.000 42923695/4292369 1825 1825 1824 71146967 33.90 10 577 2888.400 42374702/4237470 1847 1847 1847 69965991 34.90 10 579 2897.700 42750392/4275039 1859 1859 1858 70985854 35.90 10 576 2883.800 43422360/4342236 1852 1852 1852 72247446 36.90 10 573 2870.800 43829343/4382934 1844 1844 1844 73336812 37.90 10 575 2880.900 43655030/4365503 1846 1846 1847 73373884 38.90 10 581 2909.300 44247009/4424700 1871 1871 1871 73653685 39.90 con new ops 1B lat bytes/per svrs new ops total time err 10 568 2843.600 42069204/4206920 1830 1830 1830 69667869 40.90 10 571 2857.300 43494741/4349474 1837 1837 1837 72027813 41.90 10 558 2797.000 42421621/4242162 1799 1799 1799 70122589 42.90 10 551 2757.200 42893938/4289393 1780 1780 1780 71029946 43.90 10 558 2793.800 42994742/4299474 1798 1798 1798 71015242 44.90 10 559 2803.600 43877052/4387705 1804 1804 1804 72712077 45.90 10 555 2779.100 43236614/4323661 1786 1786 1787 71575039 46.90 10 562 2815.500 43352459/4335245 1814 1814 1814 72165480 47.90 10 552 2765.200 42686072/4268607 1785 1785 1785 70556207 48.90 10 567 2839.100 43639048/4363904 1827 1827 1827 71567383 49.90 10 566 2834.700 43119565/4311956 1823 1823 1823 70524963 50.90 10 578 2894.800 43313212/4331321 1861 1861 1861 71013033 51.90 10 572 2858.800 42104105/4210410 1835 1835 1835 69105980 52.90 10 587 2936.900 42534222/4253422 1882 1882 1882 70139496 53.90 10 577 2887.300 41193703/4119370 1857 1857 1858 68210055 54.90 10 573 2870.200 42769653/4276965 1851 1851 1851 71309417 55.90 10 574 2875.000 43399196/4339919 1862 1862 1863 72325353 56.90 10 585 2930.800 43205080/4320508 1892 1892 1893 71615243 57.90 10 575 2879.800 42694383/4269438 1857 1857 1857 70555331 58.90 10 574 2873.100 42844722/4284472 1851 1851 1851 70771509 59.90 con new ops 1B lat bytes/per svrs new ops total time err 10 572 2864.300 42907046/4290704 1843 1843 1843 70346075 60.90 10 458 2291.400 34325636/3432563 1474 1474 1474 56276860 60.90 MSG: checking for crashes ... MSG: reloading logging configuration ./functions: line 177: 8001 Terminated ( tsexec traffic_cop --stdout $log ) ./functions: line 185: 8261 Terminated reload MSG: shutting down ... Success: test-log-refcounting test-multicert-loading test-multicert-loading test-privilege-elevation test-multicert-loading test-privilege-elevation -- Starting test: test-server-intercept MSG: bootstrapped Traffic Server into /tmp/test-server-intercept.28504 PREFIX: /tmp/test-server-intercept.28504 BINDIR: /opt/jenkins/tsqa-master/bin SYSCONFDIR: /tmp/test-server-intercept.28504/etc/trafficserver LIBDIR: /tmp/test-server-intercept.28504/lib LOGDIR: /tmp/test-server-intercept.28504/var/log/trafficserver RUNTIMEDIR: /tmp/test-server-intercept.28504/var/trafficserver PLUGINDIR: /opt/jenkins/tsqa-master/libexec/trafficserver INCLUDEDIR: /tmp/test-server-intercept.28504/include SNAPSHOTDIR: /tmp/test-server-intercept.28504/etc/trafficserver/snapshots records.config: /tmp/test-server-intercept.28504/etc/trafficserver/records.config remap.config: /tmp/test-server-intercept.28504/etc/trafficserver/remap.config plugin.config:
Build failed in Jenkins: tsqa-master #103
See https://ci.trafficserver.apache.org/job/tsqa-master/103/changes Changes: [Phil Sorber] TS-3287: Close socket to prevent resource leak [Phil Sorber] TS-3287: Close socket to prevent resource leak -- [...truncated 13165 lines...] 10 592 2964.400 44121415/4412141 1897 1897 1896 72959539 25.90 10 591 2961.900 44876557/4487655 1898 1898 1899 74639603 26.90 10 591 2960.100 44948034/4494803 1905 1905 1906 74307486 27.90 10 596 2982.700 44565908/4456590 1916 1916 1917 73815766 28.90 MSG: reloading logging configuration 10 597 2986.900 43774596/4377459 1910 1910 1910 72505003 29.90 10 597 2987.000 44047831/4404783 1910 1910 1911 73588169 30.90 10 594 2974.000 44473942/4447394 1908 1908 1908 74342516 31.90 10 582 2914.600 44183721/4418372 1863 1863 1862 73644170 32.90 10 574 2874.700 44311042/4431104 1839 1839 1839 73691837 33.90 10 582 2917.500 45016569/4501656 1872 1872 1873 75197282 34.90 10 580 2906.400 44277162/4427716 1867 1867 1867 73901215 35.90 10 586 2932.100 44961188/4496118 1887 1887 1887 74858969 36.90 10 580 2902.500 45085055/4508505 1859 1859 1859 74766242 37.90 10 591 2961.800 44715998/4471599 1894 1894 1894 74511665 38.90 10 590 2955.800 45176749/4517674 1893 1893 1893 75971307 39.90 con new ops 1B lat bytes/per svrs new ops total time err 10 591 2960.700 45997803/4599780 1898 1898 1898 76927258 40.90 10 593 2968.900 45284016/4528401 1909 1909 1909 7612 41.90 10 590 2956.000 45213269/4521326 1899 1899 1899 75790487 42.90 10 587 2940.000 44098676/4409867 1892 1892 1892 73688325 43.90 10 577 2887.200 43950345/4395034 1852 1852 1852 73119229 44.90 10 579 2898.100 44205174/4420517 1866 1866 1867 73523596 45.90 10 587 2939.300 45112602/4511260 1892 1892 1892 74982594 46.90 10 595 2981.000 44581758/4458175 1909 1909 1909 74351353 47.90 10 592 2964.600 44736953/4473695 1891 1891 1891 73841329 48.90 10 592 2965.900 44462942/4446294 1887 1887 1887 73140439 49.90 10 600 3006.100 45185484/4518548 1920 1920 1920 74042095 50.90 10 597 2987.900 46271722/4627172 1910 1910 1909 75498192 51.90 10 600 3005.500 46881007/4688100 1918 1918 1919 76267153 52.90 10 591 2956.600 45946410/4594641 1888 1888 1888 75039874 53.90 10 591 2957.100 44833358/4483335 1896 1896 1896 73766053 54.90 10 587 2941.100 44913220/4491322 1870 1870 1870 73003077 55.90 10 590 2951.700 44302549/4430254 1879 1879 1879 72445135 56.90 10 591 2960.900 44564816/4456481 1883 1883 1883 73368725 57.90 10 587 2935.700 44920008/4492000 1870 1870 1870 74349100 58.90 MSG: reloading logging configuration 10 589 2949.400 44210455/4421045 1886 1886 1886 73127559 59.90 con new ops 1B lat bytes/per svrs new ops total time err 10 589 2947.900 43135104/4313510 1885 1885 1885 71234277 60.90 10 471 2358.300 34508083/3450808 1508 1508 1508 56987421 60.90 MSG: checking for crashes ... ./functions: line 177: 21364 Terminated ( tsexec traffic_cop --stdout $log ) ./functions: line 177: 21630 Terminated reload MSG: shutting down ... Success: test-log-refcounting test-multicert-loading test-multicert-loading test-privilege-elevation test-multicert-loading test-privilege-elevation -- Starting test: test-server-intercept MSG: bootstrapped Traffic Server into /tmp/test-server-intercept.18908 PREFIX: /tmp/test-server-intercept.18908 BINDIR: /opt/jenkins/tsqa-master/bin SYSCONFDIR: /tmp/test-server-intercept.18908/etc/trafficserver LIBDIR: /tmp/test-server-intercept.18908/lib LOGDIR: /tmp/test-server-intercept.18908/var/log/trafficserver RUNTIMEDIR: /tmp/test-server-intercept.18908/var/trafficserver PLUGINDIR: /opt/jenkins/tsqa-master/libexec/trafficserver INCLUDEDIR: /tmp/test-server-intercept.18908/include SNAPSHOTDIR: /tmp/test-server-intercept.18908/etc/trafficserver/snapshots records.config: /tmp/test-server-intercept.18908/etc/trafficserver/records.config remap.config: /tmp/test-server-intercept.18908/etc/trafficserver/remap.config plugin.config: /tmp/test-server-intercept.18908/etc/trafficserver/plugin.config ssl_multicert.config:
Build failed in Jenkins: tsqa-master #104
See https://ci.trafficserver.apache.org/job/tsqa-master/104/changes Changes: [Phil Sorber] TS-3287: Close socket to prevent resource leak -- [...truncated 13173 lines...] 10 698 3492.400 52505617/5250561 2241 2241 2241 86043231 32.90 10 700 3503.700 52720812/5272081 2243 2243 2243 86942868 33.90 10 695 3482.000 54246862/5424686 2228 2228 2228 89499291 34.90 10 697 3486.000 53138854/5313885 2233 2233 2233 87565367 35.90 10 695 3480.800 52885313/5288531 2233 2233 2233 87329023 36.90 10 697 3486.800 52172864/5217286 2238 2238 2238 86214424 37.90 10 697 3489.300 52018081/5201808 2239 2239 2240 85849277 38.90 10 690 3452.000 53330656/5333065 2229 2229 2229 88427387 39.90 con new ops 1B lat bytes/per svrs new ops total time err 10 695 3479.600 53148742/5314874 2260 2260 2261 88302049 40.90 10 694 3477.300 52950155/5295015 2254 2254 2254 87618170 41.90 10 701 3511.200 52388102/5238810 2270 2270 2270 86538724 42.90 10 699 3500.400 52194543/5219454 2261 2261 2261 86511862 43.90 10 700 3505.700 53289419/5328941 2263 2263 2263 89026374 44.90 10 709 3549.200 53692707/5369270 2291 2291 2291 89509976 45.90 10 702 3513.900 52998851/5299885 2262 2262 2262 87877031 46.90 10 704 3526.900 52128189/5212818 2271 2271 2271 86874095 47.90 10 699 3498.600 52965148/5296514 2247 2247 2247 87635994 48.90 10 704 3520.600 53979532/5397953 2264 2264 2264 89798990 49.90 10 702 3510.900 54182565/5418256 2255 2255 2255 89635418 50.90 10 699 3496.900 53807093/5380709 2253 2253 2253 89359397 51.90 10 694 3474.900 52981582/5298158 2242 2242 2242 88080262 52.90 10 695 3476.400 52398952/5239895 2239 2239 2239 86650111 53.90 10 702 3517.900 51965224/5196522 2265 2265 2265 85970333 54.90 10 708 3545.900 51894951/5189495 2286 2286 2286 85823411 55.90 10 698 3492.700 51840816/5184081 2247 2247 2246 85089733 56.90 MSG: reloading logging configuration 10 698 3493.000 52357289/5235728 2253 2253 2252 85890349 57.90 10 698 3492.800 50958449/5095844 2246 2246 2245 83527793 58.90 10 697 3489.800 51344077/5134407 2239 2239 2240 84157634 59.90 con new ops 1B lat bytes/per svrs new ops total time err 10 699 3499.300 51825363/5182536 2247 2247 2247 84765530 60.90 10 559 2799.400 41460290/4146029 1797 1797 1797 67812424 60.90 MSG: checking for crashes ... ./functions: line 177: 17949 Terminated ( tsexec traffic_cop --stdout $log ) ./functions: line 185: 18221 Terminated reload MSG: shutting down ... Success: test-log-refcounting test-multicert-loading test-multicert-loading test-privilege-elevation test-multicert-loading test-privilege-elevation -- Starting test: test-server-intercept MSG: bootstrapped Traffic Server into /tmp/test-server-intercept.30617 PREFIX: /tmp/test-server-intercept.30617 BINDIR: /opt/jenkins/tsqa-master/bin SYSCONFDIR: /tmp/test-server-intercept.30617/etc/trafficserver LIBDIR: /tmp/test-server-intercept.30617/lib LOGDIR: /tmp/test-server-intercept.30617/var/log/trafficserver RUNTIMEDIR: /tmp/test-server-intercept.30617/var/trafficserver PLUGINDIR: /opt/jenkins/tsqa-master/libexec/trafficserver INCLUDEDIR: /tmp/test-server-intercept.30617/include SNAPSHOTDIR: /tmp/test-server-intercept.30617/etc/trafficserver/snapshots records.config: /tmp/test-server-intercept.30617/etc/trafficserver/records.config remap.config: /tmp/test-server-intercept.30617/etc/trafficserver/remap.config plugin.config: /tmp/test-server-intercept.30617/etc/trafficserver/plugin.config ssl_multicert.config: /tmp/test-server-intercept.30617/etc/trafficserver/ssl_multicert.config storage.config: /tmp/test-server-intercept.30617/etc/trafficserver/storage.config hosting.config: /tmp/test-server-intercept.30617/etc/trafficserver/hosting.config volume.config: /tmp/test-server-intercept.30617/etc/trafficserver/volume.config ip_allow.config: /tmp/test-server-intercept.30617/etc/trafficserver/ip_allow.config MSG: cop is alive MSG: manager is alive MSG: server is alive MSG: waiting 1s gethostbyname(jtest.trafficserver.apache.org): Unknown host con new ops 1B lat bytes/per svrs new ops total time err 10 77 381.8005096687/509668 336 336 33694963470.7 0 10 185 920.200
Build failed in Jenkins: tsqa-master #109
See https://ci.trafficserver.apache.org/job/tsqa-master/109/changes Changes: [Leif Hedstrom] Fix some indentation and typos. -- [...truncated 13148 lines...] 10 583 2918.000 46479945/4647994 1873 1873 1873 75868696 12.90 10 592 2964.400 47247283/4724728 1900 1900 1900 77138577 13.90 10 598 2994.100 46791761/4679176 1934 1934 1933 76523473 14.90 10 608 3045.700 46442931/4644293 1965 1965 1965 75718807 15.90 10 608 3042.800 47427362/4742736 1954 1954 1954 76976186 16.90 10 612 3066.800 47509621/4750962 1977 1977 1977 77420754 17.90 10 614 3072.800 47694024/4769402 1978 1978 1978 77041779 18.90 10 615 3081.700 48162420/4816242 1978 1978 1979 78299476 19.90 con new ops 1B lat bytes/per svrs new ops total time err 10 610 3054.900 48530348/4853034 1950 1950 1950 78349236 20.90 10 617 3089.000 47846149/4784614 1963 1963 1963 77607283 21.90 10 617 3087.400 48395769/4839576 1973 1973 1973 78274775 22.90 10 624 3122.700 47928094/4792809 2002 2002 2001 78126314 23.90 10 627 3141.000 47854236/4785423 2016 2016 2015 78138421 24.90 10 629 3151.600 47942935/4794293 2018 2018 2018 78258031 25.90 10 629 3147.400 48021689/4802168 2021 2021 2021 78720526 26.90 10 632 3166.000 48953957/4895395 2039 2039 2040 81235624 27.90 MSG: reloading logging configuration 10 634 3173.000 49193267/4919326 2041 2041 2041 81786574 28.90 10 630 3155.400 49416406/4941640 2039 2039 2038 81807329 29.90 10 631 3154.300 49252373/4925237 2027 2027 2028 81123833 30.90 10 632 3162.600 48292907/4829290 2029 2029 2029 79944123 31.90 10 628 3143.700 47766857/4776685 2022 2022 2022 79146723 32.90 10 623 3119.200 47625183/4762518 2003 2003 2003 78367982 33.90 10 620 3105.100 48493257/4849325 1989 1989 1988 79914577 34.90 10 617 3088.100 48928918/4892891 1983 1983 1983 80465397 35.90 10 621 3107.500 48743214/4874321 2004 2004 2004 8982 36.90 10 620 3102.800 47679150/4767915 1998 1998 1998 78413666 37.90 10 618 3096.600 47753269/4775326 1990 1990 1990 78805567 38.90 10 618 3094.900 47690536/4769053 1993 1993 1993 79433889 39.90 con new ops 1B lat bytes/per svrs new ops total time err 10 616 3084.900 46772275/4677227 1985 1985 1985 77708047 40.90 10 619 3097.900 46019069/4601906 1985 1985 1985 76244429 41.90 10 624 3125.800 46681592/4668159 2008 2008 2008 77467286 42.90 10 626 3133.000 47723439/4772343 2009 2009 2009 78961475 43.90 10 627 3140.400 48275970/4827597 2006 2006 2006 79936838 44.90 10 631 3159.500 48500333/4850033 2028 2028 2028 80525024 45.90 10 639 3200.800 48587258/4858725 2052 2052 2052 80958420 46.90 10 642 3211.900 48785227/4878522 2059 2059 2059 81248453 47.90 10 639 3202.700 48372469/4837246 2046 2046 2047 80375512 48.90 10 642 3215.700 48631838/4863183 2056 2056 2056 80735062 49.90 10 636 3182.400 49154762/4915476 2018 2018 2018 80778696 50.90 10 636 3180.300 49401003/4940100 2022 2022 2022 80883993 51.90 10 635 3177.500 48935212/4893521 2025 2025 2025 80808175 52.90 10 633 3168.200 48509787/4850978 2023 2023 2023 80249610 53.90 10 633 3167.700 48794167/4879416 2028 2028 2027 80905443 54.90 10 634 3177.800 48487937/4848793 2041 2041 2041 80693372 55.90 10 635 3179.400 47711313/4771131 2029 2029 2029 79380840 56.90 10 635 3179.900 48136310/4813631 2031 2031 2031 79755203 57.90 MSG: reloading logging configuration 10 639 3197.400 47680500/4768050 2057 2057 2057 78979635 58.90 10 641 3207.700 48019563/4801956 2066 2066 2066 80044399 59.90 con new ops 1B lat bytes/per svrs new ops total time err 10 640 3203.700 47947592/4794759 2066 2066 2067 80154912 60.90 10 512 2563.000 38358074/3835807 1653 1653 1653 64123929 60.90 MSG: checking for crashes ... ./functions: line 177: 11743 Terminated ( tsexec traffic_cop --stdout
[jira] [Updated] (TS-3368) remove traffic_line
[ https://issues.apache.org/jira/browse/TS-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-3368: Fix Version/s: 6.0.0 For version 6.0 due to compatibility. remove traffic_line --- Key: TS-3368 URL: https://issues.apache.org/jira/browse/TS-3368 Project: Traffic Server Issue Type: Bug Components: Configuration, Console, Management API Reporter: James Peach Fix For: 6.0.0 Provided {{traffic_ctl}} is stable, documented and a complete superset of {{traffic_line}}, we should remove {{traffic_line}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-3367) add a new command line management tool
[ https://issues.apache.org/jira/browse/TS-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach reassigned TS-3367: --- Assignee: James Peach I have an initial version of {{traffic_ctl}} ready that is equivalent to {{traffic_line}} add a new command line management tool -- Key: TS-3367 URL: https://issues.apache.org/jira/browse/TS-3367 Project: Traffic Server Issue Type: New Feature Components: Configuration, Console, Management API Reporter: James Peach Assignee: James Peach There's a lot of potential in the management API that can't be exposed in {{traffic_line}} due to it's poor command-line interface. Replace this with a new tool, {{traffic_ctl}}, which uses a subcommand-oriented interface to expose more features in a more regular way. For example: {code} [vagrant@localhost ~]$ sudo /opt/ats/bin/traffic_ctl Usage: traffic_ctl [OPTIONS] CMD [ARGS ...] Subcommands: alarm Manipulate alarms cluster Stop, restart and examine the cluster config Manipulate configuration records metric Manipulate performance metrics server Stop, restart and examine the server storage Manipulate cache storage Options: switch__type__default___description --debug onfalse Enable debugging output -h, --help Print usage information -V, --version Print version string {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-3367) add a new command line management tool
James Peach created TS-3367: --- Summary: add a new command line management tool Key: TS-3367 URL: https://issues.apache.org/jira/browse/TS-3367 Project: Traffic Server Issue Type: New Feature Components: Configuration, Console, Management API Reporter: James Peach There's a lot of potential in the management API that can't be exposed in {{traffic_line}} due to it's poor command-line interface. Replace this with a new tool, {{traffic_ctl}}, which uses a subcommand-oriented interface to expose more features in a more regular way. For example: {code} [vagrant@localhost ~]$ sudo /opt/ats/bin/traffic_ctl Usage: traffic_ctl [OPTIONS] CMD [ARGS ...] Subcommands: alarm Manipulate alarms cluster Stop, restart and examine the cluster config Manipulate configuration records metric Manipulate performance metrics server Stop, restart and examine the server storage Manipulate cache storage Options: switch__type__default___description --debug onfalse Enable debugging output -h, --help Print usage information -V, --version Print version string {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-3367) add a new command line management tool
[ https://issues.apache.org/jira/browse/TS-3367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Peach updated TS-3367: Fix Version/s: 5.3.0 add a new command line management tool -- Key: TS-3367 URL: https://issues.apache.org/jira/browse/TS-3367 Project: Traffic Server Issue Type: New Feature Components: Configuration, Console, Management API Reporter: James Peach Assignee: James Peach Fix For: 5.3.0 There's a lot of potential in the management API that can't be exposed in {{traffic_line}} due to it's poor command-line interface. Replace this with a new tool, {{traffic_ctl}}, which uses a subcommand-oriented interface to expose more features in a more regular way. For example: {code} [vagrant@localhost ~]$ sudo /opt/ats/bin/traffic_ctl Usage: traffic_ctl [OPTIONS] CMD [ARGS ...] Subcommands: alarm Manipulate alarms cluster Stop, restart and examine the cluster config Manipulate configuration records metric Manipulate performance metrics server Stop, restart and examine the server storage Manipulate cache storage Options: switch__type__default___description --debug onfalse Enable debugging output -h, --help Print usage information -V, --version Print version string {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-3368) remove traffic_line
James Peach created TS-3368: --- Summary: remove traffic_line Key: TS-3368 URL: https://issues.apache.org/jira/browse/TS-3368 Project: Traffic Server Issue Type: Bug Components: Configuration, Console, Management API Reporter: James Peach Provided {{traffic_ctl}} is stable, documented and a complete superset of {{traffic_line}}, we should remove {{traffic_line}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3364) Add configuration to control traffic_server's reaction to fatal errors during (re)loading the config files.
[ https://issues.apache.org/jira/browse/TS-3364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14307929#comment-14307929 ] Leif Hedstrom commented on TS-3364: --- Ya, pushing to prod, and let it fail, seems like a bad idea. Thinking about it, rather than traffic_line/_ctrl, it'll probably be a lot easier to add this verification process to traffic_server. E.g. {code} traffic_server -Cverify {code} And let it load all configs, and then shutdown and exit with either 0 for success, or a status code indicating what went wrong. Add configuration to control traffic_server's reaction to fatal errors during (re)loading the config files. Key: TS-3364 URL: https://issues.apache.org/jira/browse/TS-3364 Project: Traffic Server Issue Type: Improvement Components: Configuration Affects Versions: 5.3.0 Reporter: Sudheer Vinukonda Currently, traffic_server fails to initialize when it encounters fatal errors in loading the config files during start up. During dynamic reloading of config files (e.g. via traffic_line), traffic_server rejects new config and falls back to existing/old config (however, if there was a traffic_server crash/restart subsequently, that can again result into failing to initialize). This jira proposes to make the behavior of traffic_server when it encounters such fatal errors configurable via a new setting {{proxy.config.ignore_fatal_errors}} with the below options: {code} 0 : All errors are fatal, do not load/reload 1 : Ignore a bad config line, continue with the rest 2 : Ignore a bad config line, stop parsing the file further .. {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)