[jira] [Commented] (TS-3950) PluginVC receives events after it's already closed.

2016-12-12 Thread estar yaoyang (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743958#comment-15743958
 ] 

estar yaoyang commented on TS-3950:
---

Thank you, Leif.
The latest official version did not appear similar problems. My problem may 
because of using 'memory reclaim' or 'spdy'. 

> PluginVC receives events after it's already closed.
> ---
>
> Key: TS-3950
> URL: https://issues.apache.org/jira/browse/TS-3950
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Plugins
>Reporter: Sudheer Vinukonda
>Assignee: Sudheer Vinukonda
> Fix For: sometime
>
>
> This is a follow up to TS-3949. It looks like PluginVC receives events (read, 
> write, timeout etc) even after it's already closed. It currently ignores 
> those events by checking the *closed* state. However, this looks to be 
> inherently incorrect, since, accessing the data inside an already closed 
> pluginVC is fraught with bugs (e.g. it could have been reallocated etc).
> Opening this jira to track the problem and see if it can be fixed better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (TS-4636) traffic.out is open too many times

2016-12-12 Thread Daniel Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743482#comment-15743482
 ] 

Daniel Xu edited comment on TS-4636 at 12/12/16 11:22 PM:
--

Update: did more digging. If you run the {{traffic_server}} binary alone, there 
are 4 copies of {{traffic.out}} open. It looks like these are all open for good 
reason. 1 fd is for the stdout BaseLogFile; 1 fd is for the stderr BaseLogFile; 
1 fd is for the duplicated STDERR_FILENO; 1 fd is for the duplicated 
STDOUT_FILENO. Although this could maybe be improved, I don't see any great 
reason to spend time doing it.

However, when you run the {{trafficserver}} script, {{traffic_server}} has 6 
files open. Still need to dig more. Will continue Wednesday. My hunch right now 
is the initial non-records Diags object is using dup2 on 
{{STD{ERR,OUT}_FILENO}}.


was (Author: danobi):
Update: did more digging. If you run the {{traffic_server}} binary alone, there 
are 4 copies of {{traffic.out}} open. It looks like these are all open for good 
reason. 1 fd is for the stdout BaseLogFile; 1 fd is for the stderr BaseLogFile; 
1 fd is for the duplicated STDERR_FILENO; 1 fd is for the duplicated 
STDOUT_FILENO. Although this could maybe be improved, I don't see any great 
reason to spend time doing it.

However, when you run the {{trafficserver}} script, {{traffic_server}} has 6 
files open. Still need to dig more. Will continue Wednesday. My hunch right now 
is the initial non-records Diags object is using dup2 on STD{ERR,OUT}_FILENO.

> traffic.out is open too many times
> --
>
> Key: TS-4636
> URL: https://issues.apache.org/jira/browse/TS-4636
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Logging
>Reporter: James Peach
>Assignee: Daniel Xu
> Fix For: sometime
>
>
> Looks like something is wrong with {{traffic.out}}. I am expecting that this 
> shold only be open twice (for stdout and stderr).
> {noformat}
> traffic_s 12272 nmadmin0w   CHR1,3  0t0 1051 
> /dev/null
> traffic_s 12272 nmadmin1w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin2w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin3r   DIR  202,1 40962 /
> traffic_s 12272 nmadmin4u   REG  202,1 3839   524557 
> /n/log/trafficserver/manager.log
> traffic_s 12272 nmadmin5u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin6u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin7u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin8u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin9u  IPv4   19233316  0t0  TCP *:80 
> (LISTEN)
> traffic_s 12272 nmadmin   10u  IPv4   19233317  0t0  TCP 
> *:443 (LISTEN)
> traffic_s 12272 nmadmin   11u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   12u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   13u  unix 0x8801e2aaf080  0t0 19233322 
> socket
> traffic_s 12272 nmadmin   14u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   15u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   16u  unix 0x8800d9e63c00  0t0 19233956 
> socket
> {noformat}
> {noformat}
> [root@qa1 ~]# lsof -P -p $(pidof traffic_server) | grep traffic.out
> [ET_NET 2317 nobody1u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody2u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody5u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody7u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   17u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   21u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (TS-4636) traffic.out is open too many times

2016-12-12 Thread Daniel Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743482#comment-15743482
 ] 

Daniel Xu edited comment on TS-4636 at 12/12/16 11:19 PM:
--

Update: did more digging. If you run the {{traffic_server}} binary alone, there 
are 4 copies of {{traffic.out}} open. It looks like these are all open for good 
reason. 1 fd is for the stdout BaseLogFile; 1 fd is for the stderr BaseLogFile; 
1 fd is for the duplicated STDERR_FILENO; 1 fd is for the duplicated 
STDOUT_FILENO. Although this could maybe be improved, I don't see any great 
reason to spend time doing it.

However, when you run the {{trafficserver}} script, {{traffic_server}} has 6 
files open. Still need to dig more. Will continue Wednesday. My hunch right now 
is the initial non-records Diags object is using dup2 on STD{ERR,OUT}_FILENO.


was (Author: danobi):
Update: did more digging. If you run the {{traffic_server}} binary alone, there 
are 4 copies of {{traffic.out}} open. It looks like these are all open for good 
reason. 1 fd is for the stdout BaseLogFile; 1 fd is for the stderr BaseLogFile; 
1 fd is for the duplicated STDERR_FILENO; 1 fd is for the duplicated 
STDOUT_FILENO. Although this could maybe be improved, I don't see any great 
reason to spend time doing it.

However, when you run the {{trafficserver}} script, {{traffic_server}} has 6 
files open. Still need to dig more. Will continue Wednesday. My hunch right now 
is the initial non-records using Diags object is using dup2 on 
STD{ERR,OUT}_FILENO.

> traffic.out is open too many times
> --
>
> Key: TS-4636
> URL: https://issues.apache.org/jira/browse/TS-4636
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Logging
>Reporter: James Peach
>Assignee: Daniel Xu
> Fix For: sometime
>
>
> Looks like something is wrong with {{traffic.out}}. I am expecting that this 
> shold only be open twice (for stdout and stderr).
> {noformat}
> traffic_s 12272 nmadmin0w   CHR1,3  0t0 1051 
> /dev/null
> traffic_s 12272 nmadmin1w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin2w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin3r   DIR  202,1 40962 /
> traffic_s 12272 nmadmin4u   REG  202,1 3839   524557 
> /n/log/trafficserver/manager.log
> traffic_s 12272 nmadmin5u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin6u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin7u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin8u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin9u  IPv4   19233316  0t0  TCP *:80 
> (LISTEN)
> traffic_s 12272 nmadmin   10u  IPv4   19233317  0t0  TCP 
> *:443 (LISTEN)
> traffic_s 12272 nmadmin   11u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   12u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   13u  unix 0x8801e2aaf080  0t0 19233322 
> socket
> traffic_s 12272 nmadmin   14u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   15u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   16u  unix 0x8800d9e63c00  0t0 19233956 
> socket
> {noformat}
> {noformat}
> [root@qa1 ~]# lsof -P -p $(pidof traffic_server) | grep traffic.out
> [ET_NET 2317 nobody1u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody2u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody5u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody7u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   17u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   21u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4636) traffic.out is open too many times

2016-12-12 Thread Daniel Xu (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-4636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15743482#comment-15743482
 ] 

Daniel Xu commented on TS-4636:
---

Update: did more digging. If you run the {{traffic_server}} binary alone, there 
are 4 copies of {{traffic.out}} open. It looks like these are all open for good 
reason. 1 fd is for the stdout BaseLogFile; 1 fd is for the stderr BaseLogFile; 
1 fd is for the duplicated STDERR_FILENO; 1 fd is for the duplicated 
STDOUT_FILENO. Although this could maybe be improved, I don't see any great 
reason to spend time doing it.

However, when you run the {{trafficserver}} script, {{traffic_server}} has 6 
files open. Still need to dig more. Will continue Wednesday. My hunch right now 
is the initial non-records using Diags object is using dup2 on 
STD{ERR,OUT}_FILENO.

> traffic.out is open too many times
> --
>
> Key: TS-4636
> URL: https://issues.apache.org/jira/browse/TS-4636
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Logging
>Reporter: James Peach
>Assignee: Daniel Xu
> Fix For: sometime
>
>
> Looks like something is wrong with {{traffic.out}}. I am expecting that this 
> shold only be open twice (for stdout and stderr).
> {noformat}
> traffic_s 12272 nmadmin0w   CHR1,3  0t0 1051 
> /dev/null
> traffic_s 12272 nmadmin1w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin2w   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin3r   DIR  202,1 40962 /
> traffic_s 12272 nmadmin4u   REG  202,1 3839   524557 
> /n/log/trafficserver/manager.log
> traffic_s 12272 nmadmin5u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin6u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin7u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin8u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin9u  IPv4   19233316  0t0  TCP *:80 
> (LISTEN)
> traffic_s 12272 nmadmin   10u  IPv4   19233317  0t0  TCP 
> *:443 (LISTEN)
> traffic_s 12272 nmadmin   11u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   12u  0,90 6384 
> anon_inode
> traffic_s 12272 nmadmin   13u  unix 0x8801e2aaf080  0t0 19233322 
> socket
> traffic_s 12272 nmadmin   14u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   15u   REG  202,172377   524555 
> /n/log/trafficserver/traffic.out
> traffic_s 12272 nmadmin   16u  unix 0x8800d9e63c00  0t0 19233956 
> socket
> {noformat}
> {noformat}
> [root@qa1 ~]# lsof -P -p $(pidof traffic_server) | grep traffic.out
> [ET_NET 2317 nobody1u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody2u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody5u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody7u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   17u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> [ET_NET 2317 nobody   21u  REG  202,1542101711082 
> /opt/ats/var/log/trafficserver/traffic.out
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33429=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33429
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 21:44
Start Date: 12/Dec/16 21:44
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1154/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 33429)
Time Spent: 1.5h  (was: 1h 20m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1154/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33428=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33428
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 21:40
Start Date: 12/Dec/16 21:40
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1259/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 33428)
Time Spent: 1h 20m  (was: 1h 10m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1259/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
@PSUdaemon - I've updated the docs per your request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1225: Create a tool to list files changed since ...

2016-12-12 Thread danobi 
Github user danobi closed the pull request at:

https://github.com/apache/trafficserver/pull/1225


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1225: Create a tool to list files changed since a tag

2016-12-12 Thread danobi 
Github user danobi commented on the issue:

https://github.com/apache/trafficserver/pull/1225
  
Forget about this for now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33421=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33421
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:30
Start Date: 12/Dec/16 20:30
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1258/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 33421)
Time Spent: 0.5h  (was: 20m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33424=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33424
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:34
Start Date: 12/Dec/16 20:34
Worklog Time Spent: 10m 
  Work Description: Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
@jpeach Cisco is looking at using it in their deployments and possibly Cox.


Issue Time Tracking
---

Worklog Id: (was: 33424)
Time Spent: 1h  (was: 50m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread jrushford 
Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
@jpeach Cisco is looking at using it in their deployments and possibly Cox.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33423=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33423
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:34
Start Date: 12/Dec/16 20:34
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1153/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 33423)
Time Spent: 50m  (was: 40m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1153/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33422=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33422
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:33
Start Date: 12/Dec/16 20:33
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
@jpeach, that doesn't sound like a bad idea, but I don't think it should be 
a requirement to get this in. The Comcast implementation is entirely open 
source as well, so this isn't a plugin that only Comcast can use.

https://github.com/Comcast/money


Issue Time Tracking
---

Worklog Id: (was: 33422)
Time Spent: 40m  (was: 0.5h)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread PSUdaemon 
Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
@jpeach, that doesn't sound like a bad idea, but I don't think it should be 
a requirement to get this in. The Comcast implementation is entirely open 
source as well, so this isn't a plugin that only Comcast can use.

https://github.com/Comcast/money


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread atsci 
Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1258/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33419=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33419
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:26
Start Date: 12/Dec/16 20:26
Worklog Time Spent: 10m 
  Work Description: Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Is anyone outside of Comcast using this? Can a configurable plugin 
supporting [OpenTracing](http://opentracing.io) be generalized to also support 
Comcast?


Issue Time Tracking
---

Worklog Id: (was: 33419)
Time Spent: 20m  (was: 10m)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread jpeach 
Github user jpeach commented on the issue:

https://github.com/apache/trafficserver/pull/1258
  
Is anyone outside of Comcast using this? Can a configurable plugin 
supporting [OpenTracing](http://opentracing.io) be generalized to also support 
Comcast?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5089) Add money_trace plugin

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?focusedWorklogId=33418=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33418
 ]

ASF GitHub Bot logged work on TS-5089:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 20:17
Start Date: 12/Dec/16 20:17
Worklog Time Spent: 10m 
  Work Description: GitHub user jrushford opened a pull request:

https://github.com/apache/trafficserver/pull/1258

TS-5089: Add money_trace plugin.

This is an experimental remap plugin that is now open sourced that allows 
traffic server caches to participate in a distributed tracing system that 
utilizes the Comcast Money library.  The Comcast Money library, 
https://github.com/Comcast/money/wiki, has its roots in Google Dapper and 
Twitter's zipkin.  

Hopefully this plugin may prove useful for others in the community.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver TS-5089

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1258


commit e96ed1f7ec166b49be5adda763fe08e0b6936ee2
Author: John J. Rushford 
Date:   2016-12-12T19:10:15Z

TS-5089: Add money_trace plugin.




Issue Time Tracking
---

Worklog Id: (was: 33418)
Time Spent: 10m
Remaining Estimate: 0h

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1258: TS-5089: Add money_trace plugin.

2016-12-12 Thread jrushford 
GitHub user jrushford opened a pull request:

https://github.com/apache/trafficserver/pull/1258

TS-5089: Add money_trace plugin.

This is an experimental remap plugin that is now open sourced that allows 
traffic server caches to participate in a distributed tracing system that 
utilizes the Comcast Money library.  The Comcast Money library, 
https://github.com/Comcast/money/wiki, has its roots in Google Dapper and 
Twitter's zipkin.  

Hopefully this plugin may prove useful for others in the community.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver TS-5089

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1258.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1258


commit e96ed1f7ec166b49be5adda763fe08e0b6936ee2
Author: John J. Rushford 
Date:   2016-12-12T19:10:15Z

TS-5089: Add money_trace plugin.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TS-5089) Add money_trace plugin

2016-12-12 Thread John Rushford (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Rushford updated TS-5089:
--
Fix Version/s: sometime

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
> Fix For: sometime
>
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5089) Add money_trace plugin

2016-12-12 Thread John Rushford (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Rushford updated TS-5089:
--
Component/s: Plugins

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: Plugins
>Reporter: John Rushford
>Priority: Minor
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (TS-5089) Add money_trace plugin

2016-12-12 Thread John Rushford (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Rushford updated TS-5089:
--
Priority: Minor  (was: Major)

> Add money_trace plugin
> --
>
> Key: TS-5089
> URL: https://issues.apache.org/jira/browse/TS-5089
> Project: Traffic Server
>  Issue Type: New Feature
>Reporter: John Rushford
>Priority: Minor
>
> This is an experimental remap plugin  that allows ATS to participate in a 
> distrbuted tracing system based upon the Comcast "Money" distributed tracing 
> and monitoring library.  The Comcast "Money" library has its roots in 
> Google's Dapper and Twitters Zipkin systems.  A money trace header or session 
> id, is attached to transaction and allows an operator with the appropriate 
> logging systems in place, to determine where errors and/or latency may exit.
> Use of the library enables the tracing of a transaction through all systems 
> that participate in handling the request. See the documentation on this open 
> source library at https://github.com/Comcast/money/wiki.
> This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
> header is not present no further processing takes place.  However if the 
> header is present,  the plugin will check to to see if the request has been 
> cached.  If so, the plugin will add the "X-Moneytrace" header from the 
> incoming request to the cached response returned to the client as required by 
> the money_trace protocol.  If the request has not been cached, the plugin 
> will extends the trace context by creating a new "X-MoneyTrace" header for 
> inclusion in the outgoing request to a parent cache or origin server. The 
> extended header includes the 'trace-id' from the incoming request, the 
> incoming span-id becomes the outgoing parent-id and the plugin generates a 
> new random long span id for the outgoing request.  See the documentation at 
> the link above for a complete description on the "X-MoneyTrace" header and 
> how to use and extend it in a distributed tracing system.
> To configure and use this plugin, simply add it in the remap.config file 
> where needed.  EXAMPLE:
>   map http://vod.foobar.com http://origin.vod.foobar.com 
> @plugin=money_trace.so



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (TS-5089) Add money_trace plugin

2016-12-12 Thread John Rushford (JIRA) 
John Rushford created TS-5089:
-

 Summary: Add money_trace plugin
 Key: TS-5089
 URL: https://issues.apache.org/jira/browse/TS-5089
 Project: Traffic Server
  Issue Type: New Feature
Reporter: John Rushford


This is an experimental remap plugin  that allows ATS to participate in a 
distrbuted tracing system based upon the Comcast "Money" distributed tracing 
and monitoring library.  The Comcast "Money" library has its roots in Google's 
Dapper and Twitters Zipkin systems.  A money trace header or session id, is 
attached to transaction and allows an operator with the appropriate logging 
systems in place, to determine where errors and/or latency may exit.

Use of the library enables the tracing of a transaction through all systems 
that participate in handling the request. See the documentation on this open 
source library at https://github.com/Comcast/money/wiki.

This plugin checks incoming requests for the "X-MoneyTrace" header.  If the 
header is not present no further processing takes place.  However if the header 
is present,  the plugin will check to to see if the request has been cached.  
If so, the plugin will add the "X-Moneytrace" header from the incoming request 
to the cached response returned to the client as required by the money_trace 
protocol.  If the request has not been cached, the plugin will extends the 
trace context by creating a new "X-MoneyTrace" header for inclusion in the 
outgoing request to a parent cache or origin server. The extended header 
includes the 'trace-id' from the incoming request, the incoming span-id becomes 
the outgoing parent-id and the plugin generates a new random long span id for 
the outgoing request.  See the documentation at the link above for a complete 
description on the "X-MoneyTrace" header and how to use and extend it in a 
distributed tracing system.

To configure and use this plugin, simply add it in the remap.config file where 
needed.  EXAMPLE:

  map http://vod.foobar.com http://origin.vod.foobar.com @plugin=money_trace.so




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-5060) Add support for DNAME record type

2016-12-12 Thread John Rushford (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Rushford resolved TS-5060.
---
Resolution: Fixed

patch has been merged.

> Add support for DNAME record type
> -
>
> Key: TS-5060
> URL: https://issues.apache.org/jira/browse/TS-5060
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: DNS
>Reporter: Mark Torluemke
>Assignee: John Rushford
> Fix For: 7.1.0
>
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Described here: https://en.wikipedia.org/wiki/CNAME_record#DNAME_record
> And in more detail here: https://tools.ietf.org/html/rfc6672



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Closed] (TS-5060) Add support for DNAME record type

2016-12-12 Thread John Rushford (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Rushford closed TS-5060.
-

> Add support for DNAME record type
> -
>
> Key: TS-5060
> URL: https://issues.apache.org/jira/browse/TS-5060
> Project: Traffic Server
>  Issue Type: New Feature
>  Components: DNS
>Reporter: Mark Torluemke
>Assignee: John Rushford
> Fix For: 7.1.0
>
>  Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Described here: https://en.wikipedia.org/wiki/CNAME_record#DNAME_record
> And in more detail here: https://tools.ietf.org/html/rfc6672



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5053) const char **argv passed to TSPluginInit is not null terminated

2016-12-12 Thread ASF GitHub Bot (JIRA) 

 [ 
https://issues.apache.org/jira/browse/TS-5053?focusedWorklogId=33415=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-33415
 ]

ASF GitHub Bot logged work on TS-5053:
--

Author: ASF GitHub Bot
Created on: 12/Dec/16 18:39
Start Date: 12/Dec/16 18:39
Worklog Time Spent: 10m 
  Work Description: GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1257

TS-5053 const char **argv passed to TSPluginInit is not null terminated

Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver TS-5053

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1257


commit a338905c3c6dfce511c162e9a352330181fcbdc8
Author: Daniel Xu 
Date:   2016-12-12T18:38:05Z

TS-5053 const char **argv passed to TSPluginInit is not null terminated

Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.




Issue Time Tracking
---

Worklog Id: (was: 33415)
Time Spent: 10m
Remaining Estimate: 0h

> const char **argv passed to TSPluginInit is not null terminated
> ---
>
> Key: TS-5053
> URL: https://issues.apache.org/jira/browse/TS-5053
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: Daniel Xu
>Assignee: Daniel Xu
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> See title. Typically **argv is null terminated in other systems. And who are 
> we to question 1000 years of tradition?
> One example of an issue is that {{lib/ts/ink_args.cc}} actually relies on 
> **argv being null terminated. Interesting segfaults occur in plugins usings 
> the ATS argument parser.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1257: TS-5053 const char **argv passed to TSPlug...

2016-12-12 Thread danobi 
GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1257

TS-5053 const char **argv passed to TSPluginInit is not null terminated

Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver TS-5053

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1257


commit a338905c3c6dfce511c162e9a352330181fcbdc8
Author: Daniel Xu 
Date:   2016-12-12T18:38:05Z

TS-5053 const char **argv passed to TSPluginInit is not null terminated

Typically **argv is null terminated in other systems. There's no
good reason for ATS to be any different.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TS-3950) PluginVC receives events after it's already closed.

2016-12-12 Thread Leif Hedstrom (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-3950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15742025#comment-15742025
 ] 

Leif Hedstrom commented on TS-3950:
---

Hard to tell if this is an ATS issue, or a plugin issue, it could be either.

This can happen with many plugins, during a configuration reload (of 
remap.config). Some plugins addresses this by proper ref-counting, but many do 
not. The real solution to all such plugins is to make the ref-counting part of 
ATS core itself IMO (we've talked about some ideas of making plugin.config / 
remap.config plugins all be part of reloadable threads, which would also solve 
this).

> PluginVC receives events after it's already closed.
> ---
>
> Key: TS-3950
> URL: https://issues.apache.org/jira/browse/TS-3950
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Core, Plugins
>Reporter: Sudheer Vinukonda
>Assignee: Sudheer Vinukonda
> Fix For: sometime
>
>
> This is a follow up to TS-3949. It looks like PluginVC receives events (read, 
> write, timeout etc) even after it's already closed. It currently ignores 
> those events by checking the *closed* state. However, this looks to be 
> inherently incorrect, since, accessing the data inside an already closed 
> pluginVC is fraught with bugs (e.g. it could have been reallocated etc).
> Opening this jira to track the problem and see if it can be fixed better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)