[jira] [Resolved] (TS-5106) Assert on ParentSelection.h line 337, there is no selection_strategy for default parent proxy.

[Oknet Xu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oknet Xu resolved TS-5106.
--
   Resolution: Fixed
 Assignee: Oknet Xu
Fix Version/s: 7.0.0

> Assert on ParentSelection.h line 337, there is no selection_strategy for 
> default parent proxy.
> --
>
> Key: TS-5106
> URL: https://issues.apache.org/jira/browse/TS-5106
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Parent Proxy
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> {code}
> FATAL: ParentSelection.h:337: failed assertion 
> `result->rec->selection_strategy != NULL`
> traffic_server: Aborted (Signal sent by tkill() 21363 65534)
> traffic_server - STACK TRACE: 
> ../../bin/traffic_server(crash_logger_invoke(int, siginfo_t*, 
> void*)+0x99)[0x4c1be9]
> /lib/x86_64-linux-gnu/libpthread.so.0(+0xf8d0)[0x7f8b2a8ba8d0]
> /lib/x86_64-linux-gnu/libc.so.6(gsignal+0x37)[0x7f8b29b15107]
> /lib/x86_64-linux-gnu/libc.so.6(abort+0x148)[0x7f8b29b164e8]
> /usr/local/ats/lib/libtsutil.so.7(+0x2ac31)[0x7f8b2c1adc31]
> /usr/local/ats/lib/libtsutil.so.7(+0x28c95)[0x7f8b2c1abc95]
> ../../bin/traffic_server(ParentConfigParams::findParent(HttpRequestData*, 
> ParentResult*)+0x56e)[0x4f677e]
> ../../bin/traffic_server(SocksEntry::init(Ptr&, 
> UnixNetVConnection*, unsigned char, unsigned char)+0x59b)[0x762dfb]
> ../../bin/traffic_server(UnixNetProcessor::connect_re_internal(Continuation*, 
> sockaddr const*, NetVCOptions*)+0x251)[0x74eaf1]
> ../../bin/traffic_server(HttpSM::do_http_server_open(bool)+0x850)[0x5bb5d0]
> ../../bin/traffic_server(HttpSM::set_next_state()+0x4a3)[0x5bc7b3]
> ../../bin/traffic_server(HttpSM::call_transact_and_set_next_state(void 
> (*)(HttpTransact::State*))+0x3a)[0x5ae28a]
> ../../bin/traffic_server(HttpSM::state_cache_open_write(int, 
> void*)+0x1ce)[0x5b083e]
> ../../bin/traffic_server(HttpSM::main_handler(int, void*)+0xc8)[0x5b6eb8]
> ../../bin/traffic_server(HttpCacheSM::state_cache_open_write(int, 
> void*)+0x1d1)[0x599221]
> ../../bin/traffic_server(CacheVC::callcont(int)+0x5b)[0x6a1b2b]
> ../../bin/traffic_server(Cache::open_write(Continuation*, ats::CryptoHash 
> const*, HTTPInfo*, long, ats::CryptoHash const*, CacheFragType, char const*, 
> int)+0x56b)[0x713f0b]
> ../../bin/traffic_server(HttpCacheSM::open_write(HttpCacheKey const*, URL*, 
> HTTPHdr*, HTTPInfo*, long, bool, bool)+0xcd)[0x598fed]
> ../../bin/traffic_server(HttpSM::do_cache_prepare_action(HttpCacheSM*, 
> HTTPInfo*, bool, bool)+0x15d)[0x5a90dd]
> ../../bin/traffic_server(HttpSM::set_next_state()+0x8b6)[0x5bcbc6]
> ../../bin/traffic_server(HttpSM::call_transact_and_set_next_state(void 
> (*)(HttpTransact::State*))+0x3a)[0x5ae28a]
> ../../bin/traffic_server(HttpSM::handle_api_return()+0xe7)[0x5b95f7]
> ../../bin/traffic_server(HttpSM::set_next_state()+0x16b)[0x5bc47b]
> ../../bin/traffic_server(HttpSM::call_transact_and_set_next_state(void 
> (*)(HttpTransact::State*))+0x3a)[0x5ae28a]
> ../../bin/traffic_server(HttpSM::state_hostdb_lookup(int, 
> void*)+0xa0)[0x5ba540]
> ../../bin/traffic_server(HttpSM::main_handler(int, void*)+0xc8)[0x5b6eb8]
> ../../bin/traffic_server[0x690386]
> ../../bin/traffic_server(HostDBContinuation::do_dns()+0x1d7)[0x691fc7]
> ../../bin/traffic_server(HostDBContinuation::probeEvent(int, 
> Event*)+0x228)[0x6946a8]
> ../../bin/traffic_server(EThread::process_event(Event*, int)+0x8d)[0x77980d]
> ../../bin/traffic_server(EThread::execute()+0x73d)[0x77a4cd]
> ../../bin/traffic_server[0x778c4a]
> /lib/x86_64-linux-gnu/libpthread.so.0(+0x80a4)[0x7f8b2a8b30a4]
> /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d)[0x7f8b29bc607d]
> Aborted
> {code}
> The default parent proxy is set by ParentRecord::DefaultInit(char *val), but 
> it is not create selection_strategy for default parent proxy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Resolved] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[Oknet Xu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oknet Xu resolved TS-5105.
--
Resolution: Fixed

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work started] (TS-5105) Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal

[Oknet Xu (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on TS-5105 started by Oknet Xu.

> Assert on Socks.cc line 67, due to remote_addr not set in connect_re_internal
> -
>
> Key: TS-5105
> URL: https://issues.apache.org/jira/browse/TS-5105
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SOCKS
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {code}
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Version 4
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) server connect timeout: 10 socks respnonse 
> timeout 100
> [Dec 21 17:27:34.840] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (SocksProxy) Read SocksProxy info: accept_enabled = 
> 0 accept_port = 1080 http_port = 80
> [Dec 21 17:27:34.841] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Config File: 
> /usr/local/etc/trafficserver/socks.config
> [Dec 21 17:27:34.842] Server {0x804006400} DEBUG:  (loadSocksConfiguration)> (Socks) Socks Turned on
> [Dec 21 17:27:35.052] Server {0x804008000} DEBUG:  (connect_re_internal)> (Socks) Using Socks ip: 216.58.192.142:80
> Assertion failed: (ats_is_ip4(_addr)), function init, file Socks.cc, 
> line 67.
> traffic_server: using root directory '/usr/local'
> traffic_server: Abort trap
> traffic_server - STACK TRACE:
> 0x4b07a9 <_Z19crash_logger_invokeiP9__siginfoPv+0x69> at 
> /usr/local/bin/traffic_server
> 0x80275ab37  at /lib/libthr.so.3
> 0x80275a22c  at /lib/libthr.so.3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34490=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34490
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:49
Start Date: 03/Jan/17 03:49
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1286/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34490)
Time Spent: 1h 40m  (was: 1.5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34489=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34489
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:48
Start Date: 03/Jan/17 03:48
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1180/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34489)
Time Spent: 1.5h  (was: 1h 20m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1295: TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1180/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1295: TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1286/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34488=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34488
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:37
Start Date: 03/Jan/17 03:37
Worklog Time Spent: 10m 
  Work Description: Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1285/ for details.
 



Issue Time Tracking
---

Worklog Id: (was: 34488)
Time Spent: 1h 20m  (was: 1h 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1285/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34487=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34487
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:36
Start Date: 03/Jan/17 03:36
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 34487)
Time Spent: 1h 10m  (was: 1h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1295: TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

[PSUdaemon]

Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1295
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34486=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34486
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:35
Start Date: 03/Jan/17 03:35
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
[approve ci]

@zwoop shouldn't these be auto-running the CI for @jablko?


Issue Time Tracking
---

Worklog Id: (was: 34486)
Time Spent: 1h  (was: 50m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34485=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34485
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:35
Start Date: 03/Jan/17 03:35
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1293
  
[approve ci]


Issue Time Tracking
---

Worklog Id: (was: 34485)
Time Spent: 50m  (was: 40m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

[PSUdaemon]

Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1294
  
[approve ci]

@zwoop shouldn't these be auto-running the CI for @jablko?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1293: TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()

[PSUdaemon]

Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1293
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34484=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34484
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 03:34
Start Date: 03/Jan/17 03:34
Worklog Time Spent: 10m 
  Work Description: Github user PSUdaemon commented on a diff in the pull 
request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94357370
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
 
 #include "BIO_fastopen.h"
 
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
--- End diff --

Don't mean to bike shed, but this seems like we could have a better name 
for this.


Issue Time Tracking
---

Worklog Id: (was: 34484)
Time Spent: 40m  (was: 0.5h)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

[PSUdaemon]

Github user PSUdaemon commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1294#discussion_r94357370
  
--- Diff: iocore/net/BIO_fastopen.cc ---
@@ -27,13 +27,26 @@
 
 #include "BIO_fastopen.h"
 
+#if OPENSSL_VERSION_NUMBER < 0x1010L
+#define BIO_set_data(a, ptr) ((a)->ptr = (ptr))
+#define BIO_get_data(a) ((a)->ptr)
+#define BIO_set_init(a, init) ((a)->init = (init))
+#define BIO_set_shutdown(a, shut) ((a)->shutdown = (shut))
+#define BIO_get_shutdown(a) ((a)->shutdown)
+#endif
+
+struct Data {
--- End diff --

Don't mean to bike shed, but this seems like we could have a better name 
for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34482=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34482
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 03/Jan/17 00:41
Start Date: 03/Jan/17 00:41
Worklog Time Spent: 10m 
  Work Description: GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1295

TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

EVP_MD_CTX and HMAC_CTX were made opaque in OpenSSL 1.1 [1],
so allocating them on the stack is no longer supported.

Also EVP_MD_CTX_cleanup() was removed. EVP_MD_CTX_reset() should be
called instead, to reinitialise an already created structure.

[1] https://www.openssl.org/news/changelog#x4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver digest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1295


commit 26d0329471f26431f1880350591da4ab2a05b3a2
Author: Jack Bates 
Date:   2017-01-03T00:16:33Z

TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

EVP_MD_CTX and HMAC_CTX were made opaque in OpenSSL 1.1 [1],
so allocating them on the stack is no longer supported.

Also EVP_MD_CTX_cleanup() was removed. EVP_MD_CTX_reset() should be
called instead, to reinitialise an already created structure.

[1] https://www.openssl.org/news/changelog#x4




Issue Time Tracking
---

Worklog Id: (was: 34482)
Time Spent: 0.5h  (was: 20m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1295: TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_C...

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1295

TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

EVP_MD_CTX and HMAC_CTX were made opaque in OpenSSL 1.1 [1],
so allocating them on the stack is no longer supported.

Also EVP_MD_CTX_cleanup() was removed. EVP_MD_CTX_reset() should be
called instead, to reinitialise an already created structure.

[1] https://www.openssl.org/news/changelog#x4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver digest

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1295


commit 26d0329471f26431f1880350591da4ab2a05b3a2
Author: Jack Bates 
Date:   2017-01-03T00:16:33Z

TS-5059: OpenSSL 1.1 EVP_MD_CTX and HMAC_CTX

EVP_MD_CTX and HMAC_CTX were made opaque in OpenSSL 1.1 [1],
so allocating them on the stack is no longer supported.

Also EVP_MD_CTX_cleanup() was removed. EVP_MD_CTX_reset() should be
called instead, to reinitialise an already created structure.

[1] https://www.openssl.org/news/changelog#x4




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34481=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34481
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 02/Jan/17 22:16
Start Date: 02/Jan/17 22:16
Worklog Time Spent: 10m 
  Work Description: GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1294

TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

BIO and BIO_METHOD were made opaque in OpenSSL 1.1.0 [1].

[1] https://www.openssl.org/news/changelog#x4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver fastopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1294


commit f28f2b5164a6c018e8025363c9b8734843c94d42
Author: Jack Bates 
Date:   2017-01-02T22:00:13Z

TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

BIO and BIO_METHOD were made opaque in OpenSSL 1.1.0 [1].

[1] https://www.openssl.org/news/changelog#x4




Issue Time Tracking
---

Worklog Id: (was: 34481)
Time Spent: 20m  (was: 10m)

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL...

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1294

TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

BIO and BIO_METHOD were made opaque in OpenSSL 1.1.0 [1].

[1] https://www.openssl.org/news/changelog#x4

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver fastopen

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1294.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1294


commit f28f2b5164a6c018e8025363c9b8734843c94d42
Author: Jack Bates 
Date:   2017-01-02T22:00:13Z

TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

BIO and BIO_METHOD were made opaque in OpenSSL 1.1.0 [1].

[1] https://www.openssl.org/news/changelog#x4




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[Jack Bates (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-5059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793562#comment-15793562
 ] 

Jack Bates commented on TS-5059:


I think the problem is that SSL_set_rbio() was renamed SSL_set0_rbio()?

Apparently it was renamed before OpenSSL 1.1.0 was released [1][2].

[1] 
https://github.com/openssl/openssl/commit/65e2d672548e7c4bcb28f1c5c835362830b1745b
[2] https://rt.openssl.org/Ticket/Display.html?id=4572

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Work logged] (TS-5059) ATS 7.0.0 build fails with OpenSSL 1.1.0c

[ASF GitHub Bot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TS-5059?focusedWorklogId=34480=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-34480
 ]

ASF GitHub Bot logged work on TS-5059:
--

Author: ASF GitHub Bot
Created on: 02/Jan/17 21:44
Start Date: 02/Jan/17 21:44
Worklog Time Spent: 10m 
  Work Description: GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1293

TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()

It was renamed before OpenSSL 1.1.0 was released [1][2].

[1] 
https://github.com/openssl/openssl/commit/65e2d672548e7c4bcb28f1c5c835362830b1745b
[2] https://rt.openssl.org/Ticket/Display.html?id=4572

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver SSL_set0_rbio

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1293


commit e8d2e0c721b0fe5649b21a9292de6332610ad5ac
Author: Jack Bates 
Date:   2017-01-02T21:25:09Z

TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()

It was renamed before OpenSSL 1.1.0 was released [1][2].

[1] 
https://github.com/openssl/openssl/commit/65e2d672548e7c4bcb28f1c5c835362830b1745b
[2] https://rt.openssl.org/Ticket/Display.html?id=4572




Issue Time Tracking
---

Worklog Id: (was: 34480)
Time Spent: 10m
Remaining Estimate: 0h

> ATS 7.0.0 build fails with OpenSSL 1.1.0c
> -
>
> Key: TS-5059
> URL: https://issues.apache.org/jira/browse/TS-5059
> Project: Traffic Server
>  Issue Type: Bug
>  Components: SSL, TLS
>Reporter: Jean Baptiste Favre
> Fix For: 7.1.0
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> ATS 7.0.0 build currently fails with following error:
> {code}SSLInternal.cc: In function ‘void SSL_set_rbio(SSL*, BIO*)’:
> SSLInternal.cc:40:10: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>if (ssl->rbio != NULL) {
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:41:17: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>  BIO_free(ssl->rbio);
>  ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> SSLInternal.cc:43:6: error: invalid use of incomplete type ‘SSL {aka
> struct ssl_st}’
>ssl->rbio = rbio;
>   ^~
> In file included from /usr/include/openssl/crypto.h:31:0,
>  from /usr/include/openssl/comp.h:16,
>  from /usr/include/openssl/ssl.h:47,
>  from SSLInternal.cc:33:
> /usr/include/openssl/ossl_typ.h:144:16: note: forward declaration of
> ‘SSL {aka struct ssl_st}’
>  typedef struct ssl_st SSL;
> ^~
> {code}
> The full configure log can be found here:
> https://gist.github.com/jbfavre/00f63362b435d8ffc682d42d29b671f2
> According to https://wiki.openssl.org/index.php/1.1_API_Changes :
> > setting SSL->rbio without setting SSL->wbio. New function introduction
> in 1.1.0 to handle this: SSL_set_rbio()".
> Problem is, rbio doesn't seems to be nicely detected at configure stage:
> {code}checking for SSL_set_rbio... no
> checking whether to enable set rbio... no{code}
> Binding ATS to OpenSSL 1.0 still works.
> Regards,
> Jean Baptiste Favre



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] trafficserver pull request #1293: TS-5059: SSL_set_rbio() renamed SSL_set0_r...

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1293

TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()

It was renamed before OpenSSL 1.1.0 was released [1][2].

[1] 
https://github.com/openssl/openssl/commit/65e2d672548e7c4bcb28f1c5c835362830b1745b
[2] https://rt.openssl.org/Ticket/Display.html?id=4572

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver SSL_set0_rbio

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1293.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1293


commit e8d2e0c721b0fe5649b21a9292de6332610ad5ac
Author: Jack Bates 
Date:   2017-01-02T21:25:09Z

TS-5059: SSL_set_rbio() renamed SSL_set0_rbio()

It was renamed before OpenSSL 1.1.0 was released [1][2].

[1] 
https://github.com/openssl/openssl/commit/65e2d672548e7c4bcb28f1c5c835362830b1745b
[2] https://rt.openssl.org/Ticket/Display.html?id=4572




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---