[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/20/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1348/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1455/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/19/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1409
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/18/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[maskit]

Github user maskit commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
Re-pushed with Conflicts info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1347/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1409
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1346/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1410: 6.2.x: TS-4729 and TS-4665: H2 not terminating st...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1410
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1454/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1409: Log crc field and psql field correctly with H2

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1409
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1453/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1410: 6.2.x: TS-4729 and TS-4665: H2 not termina...

[maskit]

GitHub user maskit opened a pull request:

https://github.com/apache/trafficserver/pull/1410

6.2.x: TS-4729 and TS-4665: H2 not terminating stream with short chunked 
response

Backporting #888. Just cherry-picked the two commits, and resolved few 
conflicts.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maskit/trafficserver ts-4729-and-4665

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1410.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1410


commit 152205cd17c77fea92b246ddce3d6d2eb25a9875
Author: shinrich 
Date:   2016-08-10T20:00:43Z

TS-4729: Fix dead assignment.

(cherry picked from commit 29bc28a713463eb815524a91e03be95fe3aeedb1)

commit f27dbeb22478f0a189ec2f79042e219479492f52
Author: Susan Hinrichs 
Date:   2016-08-22T14:33:57Z

TS-4665: Http2 not terminating stream with short chunked response.

(cherry picked from commit 5e9b18a1a8ed584e4e7cbbab9121b303b9465915)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1397
  
I'm seeing the same thing on the CI machine [1]. Can you please share the 
output of `make V=1 cmd/traffic_top/traffic_top` with me?

[1] https://ci.trafficserver.apache.org/job/Github-Linux/1344/console


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1409: Log crc field and psql field correctly wit...

[maskit]

GitHub user maskit opened a pull request:

https://github.com/apache/trafficserver/pull/1409

Log crc field and psql field correctly with H2

The two field values were logged incorrectly if a resopnse body is short.

Because a write VIO isn't pass to a consumer if whole response body was 
sent before calling `update_write_request `, the field values aren't collected. 
The flag `retval` is used for switching whether a VIO will be passed.

Also, 6.2.x has the same problem.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maskit/trafficserver h2_logging

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1409.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1409


commit b048dcd81d066f0fcb8b2f8b80fe25aa0ca164db
Author: Masakazu Kitajo 
Date:   2017-02-01T23:54:52Z

Log crc field and psql field correctly with H2

The two field values were logged incorrectly if a resopnse body is short.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1397: TS-1768: AC_SEARCH_LIBS vs. AC_CHECK_LIB

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1397
  
Hmmm, not sure, it is for me:

```
[root@fedora ats]# ldd bin/traffic_top  | grep -i hwloc
libhwloc.so.5 => /lib64/libhwloc.so.5 (0x7f29395a7000)
```

That's from the install dir.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/17/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/16/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1452/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1345/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1344/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1408: Prune some unused library dependencies

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1408
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1451/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1408: Prune some unused library dependencies

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1408

Prune some unused library dependencies

and add a script to check for unused dependencies going forward.

This PR depends on #1392 because otherwise the script fails -- 
traffic_server is linked with zlib and/or liblzma but never uses either. The 
first commit belongs to that PR.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver unused

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1408.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1408


commit c902e82c50eeff10bdeef976e4c48d02d59cda2c
Author: Jack Bates 
Date:   2017-01-27T19:06:17Z

TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always false

Since replacing TS_FLAG_HEADERS, zlibh and lzmah are always false.
Just use HAVE_ZLIB_H and HAVE_LZMA_H directly.

commit ac4d50b873dcb863070c893b7e999b6350fd5c10
Author: Jack Bates 
Date:   2017-02-01T21:29:16Z

Prune some unused library dependencies

and add a script to check for unused dependencies going forward.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1407: Fix potential spin loop in perl management librar...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1407
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/15/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

[vmamidi]

Github user vmamidi commented on the issue:

https://github.com/apache/trafficserver/pull/1404
  
incorporated the review comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1407: Fix for YTSATS-983

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1407
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1343/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1407: Fix for YTSATS-983

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1407
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1450/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1407: Fix for YTSATS-983

[SolidWallOfCode]

GitHub user SolidWallOfCode opened a pull request:

https://github.com/apache/trafficserver/pull/1407

Fix for YTSATS-983

This is a bug where the AdminClient perl interface can get trapped in a 
spin loop. This has been an internal problem with Yahoo! monitoring 
applications.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/SolidWallOfCode/trafficserver yts-983

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1407


commit 77045e9a2fb3b18741b0c5497618244e1f083820
Author: Pushkar Pradhan 
Date:   2016-12-16T01:30:46Z

Fix for YTSATS-983




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
clang-analyzer build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/14/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1342/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1406: Fix Assertion failure in the regex_revalidate plu...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1406
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1449/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1405
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/13/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1406: Fix Assertion failure in the regex_revalid...

[jrushford]

GitHub user jrushford opened a pull request:

https://github.com/apache/trafficserver/pull/1406

Fix Assertion failure in the regex_revalidate plugin.

When using the regex_revalidate plugin, we see an assertion failure in 
TSContSchedule() at InkAPI.cc:4232

Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require
that the continuation associated with the TSCont parameter must have a 
mutex.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver regex_revalidate_issue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1406.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1406


commit 27c4a142a0371f8dff59b8fc03a61b37c5232eb4
Author: John J. Rushford 
Date:   2017-02-01T20:34:44Z

Fix Assertion failure in the regex_revalidate plugin.

Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require
that the continuation associated with the TSCont parameter must have a 
mutex.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1405
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1448/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1405: TS-552: Trivial Autoconf cleanup

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1405
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1341/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1405: TS-552: Trivial Autoconf cleanup

[jablko]

GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1405

TS-552: Trivial Autoconf cleanup

We dropped exc_capture_context() and MLD_demangle_string()
along with support for the Alpha architecture.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver cleanup

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1405.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1405


commit 57ba1a518bfd479425da39ebbb85a3111a63229b
Author: Jack Bates 
Date:   2017-02-01T20:08:03Z

TS-552: Trivial Autoconf cleanup

We dropped exc_capture_context() and MLD_demangle_string()
along with support for the Alpha architecture.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1402: Crash in InactivityCop::check_inactivity with dea...

[jaaju]

Github user jaaju commented on the issue:

https://github.com/apache/trafficserver/issues/1402
  
@zwoop , we are seeing this issue only in our production env and our 
synthetic tests and internal deployments do not have the issue. Also, we are in 
the process of upgrading from ATS 5 to ATS 6, and so can not quickly deploy 7 
to a prod env.

I will continue to get a local repro, and will update the issue if that is 
possible. Meanwhile, wanted to post here to see if others have run into this, 
or if there have been changes to this feature recently.

Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/Github-Clang/12/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-FreeBSD/1447/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1332: Updates to cache documentation and Cache Tool.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1332
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/Github-Linux/1340/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1357: TS-5022: reduce memory allocation in clientcert l...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1357
  
@SolidWallOfCode Is this going to go in for 7.1.x ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1403
  
This is the PR for this issue: #1404


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1404#discussion_r98966326
  
--- Diff: proxy/http/HttpTransact.cc ---
@@ -6487,9 +6487,15 @@ HttpTransact::is_request_valid(State *s, HTTPHdr 
*incoming_request)
 bool
 HttpTransact::is_request_retryable(State *s)
 {
+  // If safe requests are  retryable, it should be safe to retry safe 
requests irrespective of bytes sent or connection state
+  // according to RFC the following methods are safe 
(https://tools.ietf.org/html/rfc7231#section-4.2.1)
   // If there was no error establishing the connection (and we sent 
bytes)-- we cannot retry
-  if (s->current.state != CONNECTION_ERROR && 
s->state_machine->server_request_hdr_bytes > 0 &&
-  s->state_machine->get_server_session()->get_netvc()->outstanding() 
!= s->state_machine->server_request_hdr_bytes) {
+  if (!(s->txn_conf->safe_requests_retryable == 1 &&
--- End diff --

Nit picky, but just treat is as a boolean? I.e. why explicitly compare it 
with "1" ? We generally don't do that for other similar configs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1404: TS-1403 retry safe methods in case of server fail...

[vmamidi]

Github user vmamidi commented on the issue:

https://github.com/apache/trafficserver/pull/1404
  
According to RFC ( https://tools.ietf.org/html/rfc7231#section-4.2.1 ) all 
the idempotent methods should be retryable but we can at least try to retry the 
safe requests. The methods GET, HEAD, OPTIONS, and TRACE are considered safe.

ATS does not retry any requests based on the connection state with Origin 
Server and bytes sent to Origin Server. ATS should retry all the safe requests 
to give a chance to serve the request instead of responding with 502.

Also, we can make this configurable so that ATS can handle special 
scenarios.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/issues/1403
  
Closing, since we have a PR already.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

[zwoop]

Github user zwoop closed the issue at:

https://github.com/apache/trafficserver/issues/1403


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1404: TS-1403 retry safe methods in case of serv...

[vmamidi]

GitHub user vmamidi opened a pull request:

https://github.com/apache/trafficserver/pull/1404

TS-1403 retry safe methods in case of server failures irrespective of 
connection state



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/vmamidi/trafficserver 
idempodent_requests_retry

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1404.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1404


commit 18f633b4402122b08d5a011186ba0162670397c5
Author: vijayabhaskar 
Date:   2017-02-01T17:12:36Z

retry safe requests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1392: TS-2095: TS_HAS_LIBZ and TS_HAS_LZMA are always f...

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1392
  
@zwoop I revised this:

```Diff
   print_feature("BUILD_PERSON", BUILD_PERSON, json);
   print_feature("BUILD_GROUP", BUILD_GROUP, json);
   print_feature("BUILD_NUMBER", BUILD_NUMBER, json);
-  print_feature("TS_HAS_LIBZ", TS_HAS_LIBZ, json);
-  print_feature("TS_HAS_LZMA", TS_HAS_LZMA, json);
+#ifdef HAVE_ZLIB_H
+  print_feature("TS_HAS_LIBZ", 1, json);
+#else
+  print_feature("TS_HAS_LIBZ", 0, json);
+#endif
+#ifdef HAVE_LZMA_H
+  print_feature("TS_HAS_LZMA", 1, json);
+#else
+  print_feature("TS_HAS_LZMA", 0, json);
+#endif
   print_feature("TS_HAS_JEMALLOC", TS_HAS_JEMALLOC, json);
   print_feature("TS_HAS_TCMALLOC", TS_HAS_TCMALLOC, json);
   print_feature("TS_HAS_IN6_IS_ADDR_UNSPECIFIED", 
TS_HAS_IN6_IS_ADDR_UNSPECIFIED, json);
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1403: idempotent requests should be retryable irrespect...

[vmamidi]

GitHub user vmamidi opened an issue:

https://github.com/apache/trafficserver/issues/1403

idempotent requests should be retryable irrespective of the state of the 
connection

According to RFC  ( https://tools.ietf.org/html/rfc7231#section-4.2.1 ) all 
the idempotent methods should be retryable but we can at least try to retry the 
safe requests. The methods GET, HEAD, OPTIONS, and TRACE are considered safe. 

ATS does not retry any requests based on the connection state with Origin 
Server and bytes sent to Origin Server. ATS should retry all the safe requests 
to give a chance to serve the request instead of responding with 502. 

Also, we can make this configurable so that ATS can handle special 
scenarios.







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1388: Fixes for building with OpenSSL 1.1

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1388
  
@zwoop I separated the commits because they each address a different issue 
-- #1384 and #1385. I think that makes the most sense ... but I'm happy to 
squash them if you prefer!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1400: traffic_via depends on the PCRE library

[jablko]

Github user jablko commented on the issue:

https://github.com/apache/trafficserver/pull/1400
  
> I think we should backport this to 7.1.x too

I agree.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1400: traffic_via depends on the PCRE library

[jablko]

Github user jablko closed the pull request at:

https://github.com/apache/trafficserver/pull/1400


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---