[GitHub] trafficserver pull request #1545: Socket fd is not closed while failed to co...

[oknet]

Github user oknet closed the pull request at:

https://github.com/apache/trafficserver/pull/1545


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1545: Socket fd is not closed while failed to connect i...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1545
  
sorry, this is not a bug, it closed in ~Connection()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1531: Assertion in state_read_server_response_header (v...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/issues/1531
  
@zwoop @shinrich It could run into state_read_server_response_header twice 
if the data is point to write.vio and the handler function doest not 
do_io_close on vc while the 1st run into it.

after #947 , iocore set read.error and write.error to 1 if EPOLLERR that 
means for that VC iocore will callback read._cont with EVENT_ERROR first and 
then callback write._cont with EVENT_ERROR if the VC is not disabled or closed 
in the first callback.

I think the SM can not receive EVENT_ERROR twice just like it can not 
receive EVENT_TIMEOUT twice (UnixNetVConnection::mainEvent will ignore the 
write VIO callback if its _cont is the same as read VIO).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1545: Socket fd is not closed while failed to connect i...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1545
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/250/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

[shukitchan]

Github user shukitchan commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1545: Socket fd is not closed while failed to connect i...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1545
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1582/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
@zwoop Could you create a new Label：Transform ？


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/249/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1545: Socket fd is not closed while failed to connect i...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1545
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/118/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1545: Socket fd is not closed while failed to connect i...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1545
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1686/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1581/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1545: Socket fd is not closed while failed to co...

[oknet]

GitHub user oknet opened a pull request:

https://github.com/apache/trafficserver/pull/1545

Socket fd is not closed while failed to connect in 
UnixNetVConnection::connectUp()



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oknet/trafficserver i1544

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1545


commit 29ab80ea5d99e54cf8ce96f285c94ae4ea8ebf02
Author: Oknet Xu 
Date:   2017-03-07T04:16:53Z

Socket fd is not closed while failed to connect in 
UnixNetVConnection::connectUp()




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/117/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1516: Implement Cache-Control: immutable handling

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1516
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1685/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1544: AddressSanitizer failed to deallocate

[scw00]

GitHub user scw00 opened an issue:

https://github.com/apache/trafficserver/issues/1544

AddressSanitizer failed to deallocate

```
==22977== ERROR: AddressSanitizer failed to deallocate 0x23000 (143360) 
bytes at address 0x7fff680d
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
==22977== ERROR: AddressSanitizer failed to deallocate 0x8 (524288) 
bytes at address 0x7fff67fc7000
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
==22977== ERROR: AddressSanitizer failed to deallocate 0x20 (2097152) 
bytes at address 0x7fff67da4000
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
==22977== ERROR: AddressSanitizer failed to deallocate 0x10 (1048576) 
bytes at address 0x7fff67c81000
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
==22977== ERROR: AddressSanitizer failed to deallocate 0x4000 (16384) bytes 
at address 0x77fdd000
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
==22977== ERROR: AddressSanitizer failed to deallocate 0x23000 (143360) 
bytes at address 0x7fff66f0
==22977== AddressSanitizer CHECK failed: 
../../../../src/libsanitizer/sanitizer_common/sanitizer_posix.cc:81 "(("unable 
to unmap" && 0)) != (0)" (0x0, 0x0)
```






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/248/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
@bryancall @scw00 after #947 , We must change the SM to handle EVENT_ERROR 
event just like EVENT_TIMEOUT.

before #947 , an ERROR indicate a VIO error. after #947 , an ERROR indicate 
a VC error.

And we should combine vc->read.error & vc->write.error to one event if the 
vc->read._cont and vc->write._cont point to same SM. It is just like the 
EVENT_TIMEOUT callback that we do it in UnixNetVC::mainEvent().


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

[danobi]

Github user danobi commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1516#discussion_r104584519
  
--- Diff: plugins/esi/combo_handler.cc ---
@@ -187,6 +207,94 @@ InterceptData::~InterceptData()
   }
 }
 
+void
+CacheControlHeader::update(TSMBuffer bufp, TSMLoc hdr_loc)
+{
+  vector values;
+  bool found_immutable = false;
+  bool found_private   = false;
+
+  // Load each value from the Cache-Control header into the vector values
+  TSMLoc field_loc = TSMimeHdrFieldFind(bufp, hdr_loc, 
TS_MIME_FIELD_CACHE_CONTROL, TS_MIME_LEN_CACHE_CONTROL);
+  if (field_loc != TS_NULL_MLOC) {
+int n_values = TSMimeHdrFieldValuesCount(bufp, hdr_loc, field_loc);
+if ((n_values != TS_ERROR) && (n_values > 0)) {
+  for (int i = 0; i < n_values; i++) {
+// Grab this current header value
+int _val_len = 0;
+const char *_val = TSMimeHdrFieldValueStringGet(bufp, hdr_loc, 
field_loc, i, &_val_len);
+string val(_val, _val_len);
+
+// We want the header value to be lowercase since CC headers are 
case insensitive
+transform(val.begin(), val.end(), val.begin(), ::tolower);
+values.push_back(val);
+  }
+} else {
+  TSHandleMLocRelease(bufp, hdr_loc, field_loc);
+  return;
+}
+TSHandleMLocRelease(bufp, hdr_loc, field_loc);
+  } else {
+return;
+  }
+
+  for (auto const  : values) {
+// Update max-age if necessary
+if (val.find(TS_HTTP_VALUE_MAX_AGE) != string::npos) {
+  int max_age = -1;
+  char *ptr   = const_cast(val.c_str());
+  ptr += TS_HTTP_LEN_MAX_AGE;
+  while ((*ptr == ' ') || (*ptr == '\t'))
+ptr++;
+  if (*ptr == '=') {
+ptr++;
+max_age = atoi(ptr);
+  }
+  if (max_age > 0 && max_age < _max_age) {
+_max_age = max_age;
+  }
+  // If we find even a single occurrence of private, the whole 
response must be private
+} else if (val.find(TS_HTTP_VALUE_PRIVATE) != string::npos) {
+  found_private = true;
+  // Every requested document must have immutable for the final 
response to be immutable
+} else if (val.find(HTTP_IMMUTABLE) != string::npos) {
+  found_immutable = true;
+}
+  }
+
+  if (!found_immutable) {
+LOG_DEBUG("Did not see an immutable cache control. The response will 
be not be immutable");
+_immutable = false;
+  }
+
+  if (found_private) {
+LOG_DEBUG("Saw a private cache control. The response will be private");
+_public  = false;
+_private = true;
+  }
+}
+
+string
+CacheControlHeader::generate() const
+{
+  char line_buf[256];
+  const char *publicity;
+  const char *immutable;
+
+  if (_public) {
+publicity = TS_HTTP_VALUE_PUBLIC;
+  } else if (_private) {
+publicity = TS_HTTP_VALUE_PRIVATE;
+  } else {
+// Default is public
+publicity = TS_HTTP_VALUE_PUBLIC;
+  }
+  immutable = (_immutable ? ", " HTTP_IMMUTABLE : "");
+
+  sprintf(line_buf, "Cache-Control: max-age=%d, %s%s\r\n", _max_age, 
publicity, immutable);
--- End diff --

2^64 ~ 1.84x10^{19}, so it won't be over 20 digits long. The buffer is 256 
chars wide so I think we're good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/116/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1580/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[scw00]

Github user scw00 commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
```
(gdb) p *server_entry->read_vio
$3 = {_cont = 0x607000476100, nbytes = 9223372036854775807, ndone = 0, op = 
1, buffer = {name = 0x0, mbuf = 0x6024000cebc0, entry = 0x0}, 
  vc_server = 0x603c00270900, mutex = {m_ptr = 0x601800129ac0}}
(gdb) p (VIO *)data
$4 = (VIO *) 0x603c00270aa0
(gdb) p *(VIO *)data
$5 = {_cont = 0x607000476100, nbytes = 172, ndone = 172, op = 2, buffer = 
{name = 0x0, mbuf = 0x6024000ce6c0, entry = 0x6024000ce6d8}, 
  vc_server = 0x603c00270900, mutex = {m_ptr = 0x601800129ac0}}
(gdb) 
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1534: Use StringView for protocol stack to avoid callin...

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1534
  
H. I think I'd leave that for another day. Those aren't really used 
internally, only to forward the API request. The return value isn't examined 
except to check for `nullptr` which is just as fast without the `StringView`. 
Further the `StringView` can't be returned via the TS API without changes, 
making that not particularly useful. A key goal of that call is to normalize 
the string to allow direct pointer comparison, in which case the length is 
superflous.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1684/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1114: TS-4976: Remove useless casts from plugins.

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1114
  
Closing this out, doing it piece meal which I think will work better.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1114: TS-4976: Remove useless casts from plugins...

[SolidWallOfCode]

Github user SolidWallOfCode closed the pull request at:

https://github.com/apache/trafficserver/pull/1114


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
@scw00 What are `server_entry->read_vio` and `data` set to when it asserts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/247/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/115/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1579/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1543: Remove nullptr instance that was introduce...

[PSUdaemon]

Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1543


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1683/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1543: Remove nullptr instance that was introduced from ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1543
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/246/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[SolidWallOfCode]

Github user SolidWallOfCode commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Yeah, I must have used `mv` instead of `git mv`. Sigh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1543: Remove nullptr instance that was introduced from ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1543
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1578/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory

[scw00]

Github user scw00 commented on the issue:

https://github.com/apache/trafficserver/issues/1532
  
We have meet the same situation in our product env, and we try to modified 
max_map_count, the kernel variable, and it work well.

In Short, it may too much map nnon in process, and linux limited it by 
max_map_count !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1543: Remove nullptr instance that was introduced from ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1543
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/114/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1543: Remove nullptr instance that was introduced from ...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1543
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1682/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1543: Remove nullptr instance that was introduce...

[PSUdaemon]

GitHub user PSUdaemon opened a pull request:

https://github.com/apache/trafficserver/pull/1543

Remove nullptr instance that was introduced from upstream backport an…

…d replace it with NULL.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/PSUdaemon/trafficserver nullptr_part_deux

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1543.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1543






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
I think this would be good for @jablko to review. Also, Jack, I think you 
have to go through the MATT process again to link your account, I'm not able to 
assign this to you for review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[scw00]

Github user scw00 commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Actually, there is still a problem in my test after these patch by jtest.
```
#0  0x72be9c37 in __GI_raise (sig=sig@entry=6) at 
../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x72bed028 in __GI_abort () at abort.c:89
#2  0x74bd8e55 in ink_abort (message_format=0x74c1da40 "%s:%d: 
failed assertion `%s`") at ink_error.cc:99
#3  0x74bd34bb in _ink_assert (expression=0xb13620 
"server_entry->read_vio == (VIO *)data", file=0xb11420 "HttpSM.cc", line=1827)
at ink_assert.cc:37
#4  0x0068e24e in HttpSM::state_read_server_response_header 
(this=0x60700016e100, event=3, data=0x603c0039d3a0) at HttpSM.cc:1827
#5  0x00695861 in HttpSM::main_handler (this=0x60700016e100, 
event=3, data=0x603c0039d3a0) at HttpSM.cc:2679
#6  0x00539f32 in Continuation::handleEvent (this=0x60700016e100, 
event=3, data=0x603c0039d3a0)
at /root/ATS-7.0/trafficserver/iocore/eventsystem/I_Continuation.h:153
#7  0x00a2a2e0 in write_signal_and_update (event=3, 
vc=0x603c0039d200) at UnixNetVConnection.cc:176
#8  0x00a2a6b2 in write_signal_done (event=3, nh=0x7fffef217650, 
vc=0x603c0039d200) at UnixNetVConnection.cc:218
#9  0x00a2a7b8 in write_signal_error (nh=0x7fffef217650, 
vc=0x603c0039d200, lerrno=32) at UnixNetVConnection.cc:237
#10 0x00a2bf13 in write_to_net_io (nh=0x7fffef217650, 
vc=0x603c0039d200, thread=0x7fffef213800) at UnixNetVConnection.cc:453
#11 0x00a2bbe9 in write_to_net (nh=0x7fffef217650, 
vc=0x603c0039d200, thread=0x7fffef213800) at UnixNetVConnection.cc:430
#12 0x00a19be5 in NetHandler::mainNetEvent (this=0x7fffef217650, 
event=5, e=0x60125ab0) at UnixNet.cc:526
#13 0x00539f32 in Continuation::handleEvent (this=0x7fffef217650, 
event=5, data=0x60125ab0)
at /root/ATS-7.0/trafficserver/iocore/eventsystem/I_Continuation.h:153
#14 0x00a764af in EThread::process_event (this=0x7fffef213800, 
e=0x60125ab0, calling_code=5) at UnixEThread.cc:143
#15 0x00a7713f in EThread::execute (this=0x7fffef213800) at 
UnixEThread.cc:270
#16 0x00a74dfc in spawn_thread_internal (a=0x600800015a50) at 
Thread.cc:84
#17 0x74e63b98 in ?? () from /usr/lib/x86_64-linux-gnu/libasan.so.0
#18 0x739a4184 in start_thread (arg=0x7fffe3d5a700) at 
pthread_create.c:312
#19 0x72cad37d in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:111
```
We got the error event and callback to SM, but SM do not want to this write 
event.because write.enabled is 0. So SM assert! The backtrace is the same as 
#1531 .
So I think if enabled is 0 , we should not callback to any SM. 6.0.x logic 
may be better!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1456: Add TCP accept metric which tracks the total numb...

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/pull/1456
  
http2 connections are tracked by 
proxy.process.http2.current_client_sessions and 
proxy.process.http2.total_client_connections.

All successfully negotiated SSL/TCP connections would be the sum of 
proxy.process.http2.total_client_connections and 
proxy.process.http.total_client_connections


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Running the current PR under gdb with this macro to see if the optimization 
in the patch above would work.  I don't think there is a case where error is 
set and triggered is not

gdb macro:
```
handle SIGPIPE nostop
handle SIGPIPE noprint

break UnixNet.cc:508 if (!vc->read.triggered && vc->read.error)
break UnixNet.cc:525 if (!vc->write.triggered && vc->write.error)

cont

p vc->read.triggered
p vc->read.enabled
p vc->read.error

p vc->write.triggered
p vc->write.enabled
p vc->write.error
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/245/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/244/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1681/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1577/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/113/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/112/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Linux build *failed*! See 
https://ci.trafficserver.apache.org/job/linux-github/1576/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[postwait]

Github user postwait commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
Given the mixing of || and &&, I'd highly suggest superfluous parentheses 
for clarity.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
I updated the PR to use oknet's recommendation.  I am going to test a 
another version of this fix to be:

```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527..636b9a2 100644
--- a/iocore/net/UnixNet.cc
+++ b/iocore/net/UnixNet.cc
@@ -505,7 +505,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 set_cont_flags(vc->control_flags);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error && 
vc->read.vio._cont != nullptr)
   vc->net_read_io(this, trigger_event->ethread);
 else if (!vc->read.enabled) {
   read_ready_list.remove(vc);
@@ -522,7 +522,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 set_cont_flags(vc->control_flags);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error 
&& vc->write.vio._cont != nullptr)
   write_to_net(this, vc, trigger_event->ethread);
 else if (!vc->write.enabled) {
   write_ready_list.remove(vc);
@@ -540,7 +540,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 diags->set_override(vc->control.debug_override);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error && 
vc->read.vio._cont != nullptr)
   vc->net_read_io(this, trigger_event->ethread);
 else if (!vc->read.enabled)
   vc->ep.modify(-EVENTIO_READ);
@@ -549,7 +549,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 diags->set_override(vc->control.debug_override);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error 
&& vc->write.vio._cont != nullptr)
   write_to_net(this, vc, trigger_event->ethread);
 else if (!vc->write.enabled)
   vc->ep.modify(-EVENTIO_WRITE);
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1680/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #351: TS-4042: Add feature to buffer request body before...

[zizhong]

Github user zizhong commented on the issue:

https://github.com/apache/trafficserver/pull/351
  
@bryancall @bgaff @zwoop @SolidWallOfCode @jpeach @sudheerv Local patches 
of `request buffer` we have in Linkedin ATS repo really hurt us a lot(merge 
issues, etc). I'll work on updating this PR and push it out.
Before that, just want to make sure that upstream still agree on this 
approach.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1457: fix TS-4195: crash when stop trafficserver

[zizhong]

Github user zizhong commented on the issue:

https://github.com/apache/trafficserver/pull/1457
  
Thanks @jpeach . I do not fully understand what you suggested. Could you 
explain a bit more, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1522: Ignore read and write errors if vio has been clea...

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1522
  
@oknet Thank for the suggestion I am running in 7.1.0 in production with 
the change you mention above instead of this PR

```
diff --git a/iocore/net/UnixNet.cc b/iocore/net/UnixNet.cc
index 85d7527ec..636b9a255 100644
--- a/iocore/net/UnixNet.cc
+++ b/iocore/net/UnixNet.cc
@@ -505,7 +505,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 set_cont_flags(vc->control_flags);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error && 
vc->read.vio._cont != nullptr)
   vc->net_read_io(this, trigger_event->ethread);
 else if (!vc->read.enabled) {
   read_ready_list.remove(vc);
@@ -522,7 +522,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 set_cont_flags(vc->control_flags);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error 
&& vc->write.vio._cont != nullptr)
   write_to_net(this, vc, trigger_event->ethread);
 else if (!vc->write.enabled) {
   write_ready_list.remove(vc);
@@ -540,7 +540,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 diags->set_override(vc->control.debug_override);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->read.enabled || vc->read.error) && vc->read.triggered)
+else if (vc->read.enabled && vc->read.triggered || vc->read.error && 
vc->read.vio._cont != nullptr)
   vc->net_read_io(this, trigger_event->ethread);
 else if (!vc->read.enabled)
   vc->ep.modify(-EVENTIO_READ);
@@ -549,7 +549,7 @@ NetHandler::mainNetEvent(int event, Event *e)
 diags->set_override(vc->control.debug_override);
 if (vc->closed)
   close_UnixNetVConnection(vc, trigger_event->ethread);
-else if ((vc->write.enabled || vc->write.error) && vc->write.triggered)
+else if (vc->write.enabled && vc->write.triggered || vc->write.error 
&& vc->write.vio._cont != nullptr)
   write_to_net(this, vc, trigger_event->ethread);
 else if (!vc->write.enabled)
   vc->ep.modify(-EVENTIO_WRITE);
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1485: back port "fix TS-4195: double free when stop tra...

[zizhong]

Github user zizhong commented on the issue:

https://github.com/apache/trafficserver/pull/1485
  
@PSUdaemon No. It's not related. When it got built, there were some ICC 
build issues, so I backport zwoop's fix too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear

[dragon512]

Github user dragon512 commented on the issue:

https://github.com/apache/trafficserver/issues/1538
  
It looks like the Traffics server died. ( removing color codes)

Test : Checking that ReturnCode == None - Failed
Reason: Returned Value 70 != None
 file 
/home/bcall/dev/apache/trafficserver/tests/_sandbox/cache-generation-clear/ts/log/diags.log
 : diags.log should not contain errors - Failed
Reason: Cannot read 
/home/bcall/dev/apache/trafficserver/tests/_sandbox/cache-generation-clear/ts/log/diags.log:
 [Errno 2] No such file or directory: 
'/home/bcall/dev/apache/trafficserver/tests/_sandbox/cache-generation-clear/ts/log/diags.log'

It also did not get to a place to right out anything to diags.log. You are 
going to been to look at the sandbox directory. I would look at the 
_tmp_..._ts/steam.all.log file. I would guess this might have what was dump on 
the screen by traffic_server. Or you can try to replay the run with the 
replay.sh scripts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[PSUdaemon]

Github user PSUdaemon commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
@vmamidi 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/243/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/242/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1679/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1575/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/111/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
@oknet Can you please add the appropriate Label andMilestone for this PR? 
("Plugins" and "7.2.0" respectively).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1542: Move the Github commands to ci/ source tree

[zwoop]

GitHub user zwoop opened an issue:

https://github.com/apache/trafficserver/issues/1542

Move the Github commands to ci/ source tree

Right now, we simply run the commands in each Github build configuration. 
To be aligned with the rest of the CI, and now that these builds are stable, we 
should incorporate these into scripts in the ci/ tree.






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
He probably didn't reconnect his account after the Infra changes last week.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
I'd like Vijay to review but was unable to assign him for some reason.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[zwoop]

Github user zwoop commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
The FreeBSD builds are in a bit of distress, [approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/110/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1574/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1541: retry safe requests

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1541
  
FreeBSD build *failed*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1678/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1541: retry safe requests

[jrushford]

GitHub user jrushford opened a pull request:

https://github.com/apache/trafficserver/pull/1541

retry safe requests

(cherry picked from commit a57f6609644752b8a2e81bcd4872f64575331c1e)

Conflicts:
doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst
proxy/InkAPI.cc
proxy/http/HttpConfig.cc
proxy/http/HttpConfig.h
proxy/http/HttpSM.cc
proxy/http/HttpTransact.cc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver retry_safe_methods

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1541.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1541


commit 0c63fd307afa4267394f107b49e444b280c878ea
Author: vijayabhaskar 
Date:   2017-02-01T17:12:36Z

retry safe requests

(cherry picked from commit a57f6609644752b8a2e81bcd4872f64575331c1e)

Conflicts:
doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst
proxy/InkAPI.cc
proxy/http/HttpConfig.cc
proxy/http/HttpConfig.h
proxy/http/HttpSM.cc
proxy/http/HttpTransact.cc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1529: cppapi broken building on FreeBSD 11

[mingzym]

Github user mingzym commented on the issue:

https://github.com/apache/trafficserver/issues/1529
  
hmm, it turns out to be conflict with the system trafficserver lib 
installed in /usr/local/, which is v6.2.0. I have to remove it.

why it build with the /usr/local preferred?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1335: Deadlock in HostDB

[jacksontj]

Github user jacksontj commented on the issue:

https://github.com/apache/trafficserver/issues/1335
  
@zwoop Where you able to come up with a reproducible case for this? I'm 
going to try and take a look this week-- it'd be easier if I had a repro method 
:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...

[PSUdaemon]

Github user PSUdaemon closed the pull request at:

https://github.com/apache/trafficserver/pull/1513


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1537: TS-4976: Regularize example plugin basic_auth.

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/pull/1537
  
Looks like you removed a file and didn't add one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1538: Tests are failing on cache-generation-clear

[bryancall]

Github user bryancall commented on the issue:

https://github.com/apache/trafficserver/issues/1538
  
@dragon512  Here is the full output: https://da.gd/zDXXX


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1539: Signals fix

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1539#discussion_r104453441
  
--- Diff: iocore/eventsystem/I_EThread.h ---
@@ -56,7 +56,7 @@ enum ThreadType {
   DEDICATED,
 };
 
-extern volatile bool shutdown_event_system;
+extern bool shutdown_event_system;
--- End diff --

`volatile` shouldn't have any effect.  It is used incorrectly throughout 
ATS as a synchronization mechanism.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/241/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/240/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1677/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1573/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/109/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/108/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1676/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1572/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...

[jrushford]

GitHub user jrushford reopened a pull request:

https://github.com/apache/trafficserver/pull/1513

TS-4747: make marking parent proxies down in hostdb configurable.

Back port of https://github.com/apache/trafficserver/pull/1464 to 6.2.2

(cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b)

Conflicts:
doc/admin-guide/files/records.config.en.rst
doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst
lib/ts/apidefs.h.in
mgmt/RecordsConfig.cc
plugins/experimental/ts_lua/ts_lua_http_config.c
proxy/InkAPI.cc
proxy/InkAPITest.cc
proxy/http/HttpConfig.cc
proxy/http/HttpConfig.h

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jrushford/trafficserver ts-4747bp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1513.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1513


commit 65e41a6a3b6ce1a7ceabd2da70b9a171647f82b0
Author: jrushf1239k 
Date:   2017-02-17T16:34:33Z

TS-4747: make marking parent proxies down in hostdb configurable.

(cherry picked from commit 2752c758fd480c1becd814f40ff53896d44b315b)

Conflicts:
doc/admin-guide/files/records.config.en.rst
doc/developer-guide/api/functions/TSHttpOverridableConfig.en.rst
lib/ts/apidefs.h.in
mgmt/RecordsConfig.cc
plugins/experimental/ts_lua/ts_lua_http_config.c
proxy/InkAPI.cc
proxy/InkAPITest.cc
proxy/http/HttpConfig.cc
proxy/http/HttpConfig.h




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1513: TS-4747: make marking parent proxies down ...

[jrushford]

Github user jrushford closed the pull request at:

https://github.com/apache/trafficserver/pull/1513


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1513: TS-4747: make marking parent proxies down in host...

[jrushford]

Github user jrushford commented on the issue:

https://github.com/apache/trafficserver/pull/1513
  
[approve ci]


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1532: ATS 7.1 release running out of memory

[shinrich]

Github user shinrich commented on the issue:

https://github.com/apache/trafficserver/issues/1532
  
I saw stacks like this when I was running with the free list disabled (-f). 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/238/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
clang-analyzer build *successful*! See 
https://ci.trafficserver.apache.org/job/clang-analyzer-github/239/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1570/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/106/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1675/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
Intel CC build *successful*! See 
https://ci.trafficserver.apache.org/job/icc-github/107/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
Linux build *successful*! See 
https://ci.trafficserver.apache.org/job/linux-github/1571/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[atsci]

Github user atsci commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
FreeBSD build *successful*! See 
https://ci.trafficserver.apache.org/job/freebsd-github/1674/ for details.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

[oknet]

Github user oknet commented on the issue:

https://github.com/apache/trafficserver/pull/1540
  
@jablko 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1540: Must not destroy the Transform Contp, only...

[oknet]

GitHub user oknet opened a pull request:

https://github.com/apache/trafficserver/pull/1540

Must not destroy the Transform Contp, only shutdown write on it while 
received WRITE_COMPLETE



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oknet/trafficserver i1540

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1540.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1540


commit 8d356bb35a4cdd75e3fcdaa8a364c3f4039960b4
Author: Oknet Xu 
Date:   2017-03-06T10:47:11Z

Must not destroy the Transform Contp, only shutdown write on it while 
received WRITE_COMPLETE




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---