[jira] [Commented] (TS-4610) Fix HTTP and HTTP2 stats
[ https://issues.apache.org/jira/browse/TS-4610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369366#comment-15369366 ] ASF subversion and git services commented on TS-4610: - Commit 8c44ecf436137b7d8389fd75544fd410caa1455b in trafficserver's branch refs/heads/master from [~shinrich] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8c44ecf ] TS-4610 Fixes HTTP and HTTP2 stats This closes #763 > Fix HTTP and HTTP2 stats > > > Key: TS-4610 > URL: https://issues.apache.org/jira/browse/TS-4610 > Project: Traffic Server > Issue Type: Bug > Components: HTTP, HTTP/2, Metrics >Reporter: Susan Hinrichs >Assignee: Susan Hinrichs > Fix For: 7.0.0 > > > There are a number of problems with HTTP and HTTP2 stats. Some were > introduced with TS-3612. Other problems appear to predate those changes. > proxy.process.http.current_client_transactions was not being adequately > decremented. With this fix it now corresponds to the number of active HttpSMs. > proxy.process.http2.current_client_sessions wasn't being set accurately. > proxy.process.http2.total_client_streams wasn't being set at all. > Originally had the Http2 logic adjusting > proxy.process.http.current_client_connections and > proxy.process.http.total_client_connections. But decided to pull that out and > just have it adjust the http2 versions of those stats. So proxy.process.http > connection stats just refer to HTTP/1.x protocols (and SPDY) and > proxy.process.http2 connection stats refer to HTTP/2 protocols. This gives > monitoring and analysis tools the option to look at connections per protocol. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4512) Error when building with gcc 6.1.1
[
https://issues.apache.org/jira/browse/TS-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368643#comment-15368643
]
ASF subversion and git services commented on TS-4512:
-
Commit c4a79f799f873c394403ab1fb104740ed90cc742 in trafficserver's branch
refs/heads/6.2.x from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c4a79f7 ]
TS-4512: Error when building with gcc 6.1.1
(cherry picked from commit 78d6bbb8dbdcffce68acada02e71efe50bce37c2)
> Error when building with gcc 6.1.1
> --
>
> Key: TS-4512
> URL: https://issues.apache.org/jira/browse/TS-4512
> Project: Traffic Server
> Issue Type: Improvement
> Components: Build
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.2.0, 7.0.0
>
>
> {code}
> In file included from LogObject.cc:40:0:
> ../../lib/ts/TestBox.h:59:1: error: 'bool {anonymous}::TestBox::check(bool,
> const char*, ...)' defined but not used [-Werror=unused-function]
> TestBox::check(bool result, char const *fmt, ...)
> ^~~
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4472) Number of active connections is incorrect
[
https://issues.apache.org/jira/browse/TS-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368637#comment-15368637
]
ASF subversion and git services commented on TS-4472:
-
Commit 57af7007ed8cd8fdcdb7b6846f085d9a6b84c288 in trafficserver's branch
refs/heads/6.2.x from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=57af700 ]
TS-4472 Fixes http_current_active_client_connections_stat metric
The issue here is that there are two m_active member variables, in
both Http1ClientSession and Http1ClientTransaction. However, the former
contains the latter, so this patch eliminates the m_active from the
session class, and then consistently sets and checks the m_active from
the http1ClientTransaction class.
(cherry picked from commit 1db2d3aee58eda4806d5d7f27e953d69cb882741)
Conflicts:
proxy/http/Http1ClientSession.cc
> Number of active connections is incorrect
> -
>
> Key: TS-4472
> URL: https://issues.apache.org/jira/browse/TS-4472
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 6.2.0, 7.0.0
>
>
> Looks like the number of active connections is not decrementing and is always
> increasing.
> active connections keeps increasing in traffic_top:
> {code}
> Active Con 60.4K
> {code}
> [bcall@l28 trafficserver]$ ss -s
> {code}
> Total: 7036 (kernel 7258)
> TCP: 11404 (estab 6776, closed 4247, orphaned 349, synrecv 0, timewait
> 4247/0), ports 2580
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4472) Number of active connections is incorrect
[
https://issues.apache.org/jira/browse/TS-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15368268#comment-15368268
]
ASF subversion and git services commented on TS-4472:
-
Commit 1db2d3aee58eda4806d5d7f27e953d69cb882741 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1db2d3a ]
TS-4472 Fixes http_current_active_client_connections_stat metric
The issue here is that there are two m_active member variables, in
both Http1ClientSession and Http1ClientTransaction. However, the former
contains the latter, so this patch eliminates the m_active from the
session class, and then consistently sets and checks the m_active from
the http1ClientTransaction class.
> Number of active connections is incorrect
> -
>
> Key: TS-4472
> URL: https://issues.apache.org/jira/browse/TS-4472
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 6.2.0, 7.0.0
>
>
> Looks like the number of active connections is not decrementing and is always
> increasing.
> active connections keeps increasing in traffic_top:
> {code}
> Active Con 60.4K
> {code}
> [bcall@l28 trafficserver]$ ss -s
> {code}
> Total: 7036 (kernel 7258)
> TCP: 11404 (estab 6776, closed 4247, orphaned 349, synrecv 0, timewait
> 4247/0), ports 2580
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3816) Should we replace ptr_len_cmp() with memcmp() consistently?
[ https://issues.apache.org/jira/browse/TS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15366924#comment-15366924 ] ASF subversion and git services commented on TS-3816: - Commit d36cb4791a4e42736e4db97100eb8449ad118231 in trafficserver's branch refs/heads/master from [~tstroh] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d36cb47 ] TS-3816 : Replace ptr_len_cmp with memcmp (#783) > Should we replace ptr_len_cmp() with memcmp() consistently? > --- > > Key: TS-3816 > URL: https://issues.apache.org/jira/browse/TS-3816 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Leif Hedstrom >Assignee: Tyler Stroh > Labels: newbie++ > Fix For: 7.0 > > > In most places, we already use memcmp(), but we have our own implementation / > wrapper named ptr_len_cmp(), which is used in a few places. This seems rather > inconsistent, so either we use ptr_len_cmp() consistently, or just use > memcmp() across the board. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3371) Should create a global session ticket disable
[ https://issues.apache.org/jira/browse/TS-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360544#comment-15360544 ] ASF subversion and git services commented on TS-3371: - Commit 2aa25041c34384b4db1928773c6f334cdb67587a in trafficserver's branch refs/heads/master from [~shinrich] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2aa2504 ] Merge pull request #758 from persiaAziz/TS-3371 TS-3371: Global variable for enabling SSL session ticket > Should create a global session ticket disable > - > > Key: TS-3371 > URL: https://issues.apache.org/jira/browse/TS-3371 > Project: Traffic Server > Issue Type: Bug > Components: SSL >Reporter: Susan Hinrichs >Assignee: Syeda Persia Aziz > Fix For: sometime > > > The current implementation requires the ATS to set the ssl_ticket_enabled=0 > for every entry in ssl_multicert.config to turn off the ssl ticket session > support. > It would be better to have a global switch. It seems highly unlikely that > someone will want to deploy ssl tickets for some destinations but not others. > Would also be good to have a switch to disable ATS from offering session > tickets when communicating with origin servers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3371) Should create a global session ticket disable
[ https://issues.apache.org/jira/browse/TS-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360545#comment-15360545 ] ASF subversion and git services commented on TS-3371: - Commit 2aa25041c34384b4db1928773c6f334cdb67587a in trafficserver's branch refs/heads/master from [~shinrich] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2aa2504 ] Merge pull request #758 from persiaAziz/TS-3371 TS-3371: Global variable for enabling SSL session ticket > Should create a global session ticket disable > - > > Key: TS-3371 > URL: https://issues.apache.org/jira/browse/TS-3371 > Project: Traffic Server > Issue Type: Bug > Components: SSL >Reporter: Susan Hinrichs >Assignee: Syeda Persia Aziz > Fix For: sometime > > > The current implementation requires the ATS to set the ssl_ticket_enabled=0 > for every entry in ssl_multicert.config to turn off the ssl ticket session > support. > It would be better to have a global switch. It seems highly unlikely that > someone will want to deploy ssl tickets for some destinations but not others. > Would also be good to have a switch to disable ATS from offering session > tickets when communicating with origin servers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-3371) Should create a global session ticket disable
[ https://issues.apache.org/jira/browse/TS-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360543#comment-15360543 ] ASF subversion and git services commented on TS-3371: - Commit 986e56bb542e662329d267ff1ee73c28d7ee8510 in trafficserver's branch refs/heads/master from Syeda Aziz [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=986e56b ] TS-3371: Programmatic disabling of SSL ticket use. unwanted changes removed > Should create a global session ticket disable > - > > Key: TS-3371 > URL: https://issues.apache.org/jira/browse/TS-3371 > Project: Traffic Server > Issue Type: Bug > Components: SSL >Reporter: Susan Hinrichs >Assignee: Syeda Persia Aziz > Fix For: sometime > > > The current implementation requires the ATS to set the ssl_ticket_enabled=0 > for every entry in ssl_multicert.config to turn off the ssl ticket session > support. > It would be better to have a global switch. It seems highly unlikely that > someone will want to deploy ssl tickets for some destinations but not others. > Would also be good to have a switch to disable ATS from offering session > tickets when communicating with origin servers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4590) INKVConnInternal didn't set m_free_magic to DEAD as INKContInternal
[ https://issues.apache.org/jira/browse/TS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360533#comment-15360533 ] ASF subversion and git services commented on TS-4590: - Commit 36ee05067bac07f0e9099ae0dd7eb713ed8207d8 in trafficserver's branch refs/heads/master from [~shinrich] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=36ee050 ] Merge pull request #752 from oknet/TS-4590 TS-4590: INKContInternal & INKVConnInternal Optimize > INKVConnInternal didn't set m_free_magic to DEAD as INKContInternal > --- > > Key: TS-4590 > URL: https://issues.apache.org/jira/browse/TS-4590 > Project: Traffic Server > Issue Type: Improvement > Components: TS API >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > > The class INKContInternal is a base class of INKVConnInternal. > INKVConnInternal rewrite destroy() and handle_event(), but forgot to set > m_free_magic to DEAD that is a debug flag. > I will add 2 methods for INKContInternal and INKVConnInternal: > - clear() > - clear variables > - free() > - call clear() first > - call this->mutex.clear(); > - set m_free_magic > - call xxxAllocator.free(this) > and rewrite destroy to call free(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4487) haven't check the change of lock after return from wbe callback
[
https://issues.apache.org/jira/browse/TS-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360531#comment-15360531
]
ASF subversion and git services commented on TS-4487:
-
Commit b9f16f2b4f14cd3aaac13f562dcf413617b20bda in trafficserver's branch
refs/heads/master from [~shinrich]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b9f16f2 ]
Merge pull request #754 from oknet/TS-4487
TS-4487: check the change of lock after return from wbe callback
> haven't check the change of lock after return from wbe callback
> ---
>
> Key: TS-4487
> URL: https://issues.apache.org/jira/browse/TS-4487
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> the code:
> {code}
> int64_t r = vc->load_buffer_and_write(towrite, wattempted, total_written,
> buf, needs);
> {code}
> At the end of write_to_net_io,
> {code}
> if (!buf.reader()->read_avail()) { // should check needs==0
> write_disable(nh, vc);
> return;
> }
> if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> write_reschedule(nh, vc);
> }
> if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> read_reschedule(nh, vc);
> }
> return;
> {code}
> another issue in write_to_net_io(): did not check the change of lock at the
> return callback with wbe.
> {code}
> if (s->vio.ntodo() <= 0) {
> write_signal_done(VC_EVENT_WRITE_COMPLETE, nh, vc);
> return;
> } else if (signalled && (wbe_event != vc->write_buffer_empty_event)) {
> // @a signalled means we won't send an event, and the event values
> differing means we
> // had a write buffer trap and cleared it, so we need to send it now.
> if (write_signal_and_update(wbe_event, vc) != EVENT_CONT)
> return;
> // > did not check the change of lock at the return callback
> with wbe.
> } else if (!signalled) {
> if (write_signal_and_update(VC_EVENT_WRITE_READY, vc) != EVENT_CONT) {
> return;
> }
> // change of lock... don't look at shared variables!
> if (lock.get_mutex() != s->vio.mutex.get()) {
> write_reschedule(nh, vc);
> return;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4487) haven't check the change of lock after return from wbe callback
[
https://issues.apache.org/jira/browse/TS-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360530#comment-15360530
]
ASF subversion and git services commented on TS-4487:
-
Commit b9f16f2b4f14cd3aaac13f562dcf413617b20bda in trafficserver's branch
refs/heads/master from [~shinrich]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b9f16f2 ]
Merge pull request #754 from oknet/TS-4487
TS-4487: check the change of lock after return from wbe callback
> haven't check the change of lock after return from wbe callback
> ---
>
> Key: TS-4487
> URL: https://issues.apache.org/jira/browse/TS-4487
> Project: Traffic Server
> Issue Type: Improvement
> Components: SSL
>Reporter: Oknet Xu
>Assignee: Oknet Xu
> Fix For: 7.0.0
>
>
> the code:
> {code}
> int64_t r = vc->load_buffer_and_write(towrite, wattempted, total_written,
> buf, needs);
> {code}
> At the end of write_to_net_io,
> {code}
> if (!buf.reader()->read_avail()) { // should check needs==0
> write_disable(nh, vc);
> return;
> }
> if ((needs & EVENTIO_WRITE) == EVENTIO_WRITE) {
> write_reschedule(nh, vc);
> }
> if ((needs & EVENTIO_READ) == EVENTIO_READ) {
> read_reschedule(nh, vc);
> }
> return;
> {code}
> another issue in write_to_net_io(): did not check the change of lock at the
> return callback with wbe.
> {code}
> if (s->vio.ntodo() <= 0) {
> write_signal_done(VC_EVENT_WRITE_COMPLETE, nh, vc);
> return;
> } else if (signalled && (wbe_event != vc->write_buffer_empty_event)) {
> // @a signalled means we won't send an event, and the event values
> differing means we
> // had a write buffer trap and cleared it, so we need to send it now.
> if (write_signal_and_update(wbe_event, vc) != EVENT_CONT)
> return;
> // > did not check the change of lock at the return callback
> with wbe.
> } else if (!signalled) {
> if (write_signal_and_update(VC_EVENT_WRITE_READY, vc) != EVENT_CONT) {
> return;
> }
> // change of lock... don't look at shared variables!
> if (lock.get_mutex() != s->vio.mutex.get()) {
> write_reschedule(nh, vc);
> return;
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360351#comment-15360351 ] ASF subversion and git services commented on TS-4519: - Commit 1b689efcf8fb18fede7b43e57d141ac8634461c6 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1b689ef ] TS-4519 Typo on the cruuid > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360347#comment-15360347 ] ASF subversion and git services commented on TS-4519: - Commit c3e999b1a3d3d9132955a3e4e7ed0cbf4993ad6d in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c3e999b ] TS-4519 Added docs for new tags > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360239#comment-15360239 ] ASF subversion and git services commented on TS-4519: - Commit fadb41bc5509de232c91f43444670a38445583a9 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=fadb41b ] TS-4519 Adds a new log tag, % for the sm_id > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360240#comment-15360240 ] ASF subversion and git services commented on TS-4519: - Commit dda9df7ca7b886b5fd54d3ff6e9ed4f741948ba3 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dda9df7 ] TS-4519 Adds a new log tag, % for the process UUID > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360241#comment-15360241 ] ASF subversion and git services commented on TS-4519: - Commit 4cd270dc5be6ae0e7f985daebb4e6f666848e741 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4cd270d ] TS-4519 Adds a new log tag, % client_req unique ID This is in reality just a concatenation of %-%, but is convenient to have, and also assures consistency with other features (e.g. header_rewrite, and Debug() in the HttpSM). > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4623) Add a pre-commit shell script
[ https://issues.apache.org/jira/browse/TS-4623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15360223#comment-15360223 ] ASF subversion and git services commented on TS-4623: - Commit 5e959ecae52d9fb12bb660a52add4c28967f28a0 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5e959ec ] TS-4623 Adds a pre-commit script for git > Add a pre-commit shell script > - > > Key: TS-4623 > URL: https://issues.apache.org/jira/browse/TS-4623 > Project: Traffic Server > Issue Type: Improvement > Components: Build >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > I have a little script that helps enforcing proper clang-format on git commit. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4633) Fix an erroneous warning message when reading the parent.config file.
[ https://issues.apache.org/jira/browse/TS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359879#comment-15359879 ] ASF subversion and git services commented on TS-4633: - Commit e151ff4e9e17ce406a51ff7581f7b34bf312f8cb in trafficserver's branch refs/heads/6.2.x from John J. Rushford [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e151ff4 ] TS-4633: Fix an erroneous warning message when reading the parent.config file. (cherry picked from commit dff3d2bc99f7a4ed9c9581ac1370b10995d44490) > Fix an erroneous warning message when reading the parent.config file. > - > > Key: TS-4633 > URL: https://issues.apache.org/jira/browse/TS-4633 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: John Rushford >Assignee: John Rushford >Priority: Minor > Fix For: 6.2.0, 7.0.0 > > > An erroneous warning message is logged when at startup when reading the > parent.config file: > WARNING: [ParentSelection] disabling > parent_retry on line 24 because parent_is_proxy is true > This warning should only be logged when parent_retry is set in the > parent.config and when parent_is_proxy is true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4633) Fix an erroneous warning message when reading the parent.config file.
[ https://issues.apache.org/jira/browse/TS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359750#comment-15359750 ] ASF subversion and git services commented on TS-4633: - Commit e5d53b15a79e042a3ac792c3339a0249a269e62d in trafficserver's branch refs/heads/master from John J. Rushford [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e5d53b1 ] Merge pull request #782 from jrushford/TS-4633 TS-4633: Fix an erroneous warning message when reading the parent.con… > Fix an erroneous warning message when reading the parent.config file. > - > > Key: TS-4633 > URL: https://issues.apache.org/jira/browse/TS-4633 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: John Rushford >Assignee: John Rushford >Priority: Minor > Fix For: 7.0.0 > > > An erroneous warning message is logged when at startup when reading the > parent.config file: > WARNING: [ParentSelection] disabling > parent_retry on line 24 because parent_is_proxy is true > This warning should only be logged when parent_retry is set in the > parent.config and when parent_is_proxy is true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4633) Fix an erroneous warning message when reading the parent.config file.
[ https://issues.apache.org/jira/browse/TS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359749#comment-15359749 ] ASF subversion and git services commented on TS-4633: - Commit e5d53b15a79e042a3ac792c3339a0249a269e62d in trafficserver's branch refs/heads/master from John J. Rushford [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e5d53b1 ] Merge pull request #782 from jrushford/TS-4633 TS-4633: Fix an erroneous warning message when reading the parent.con… > Fix an erroneous warning message when reading the parent.config file. > - > > Key: TS-4633 > URL: https://issues.apache.org/jira/browse/TS-4633 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: John Rushford >Assignee: John Rushford >Priority: Minor > Fix For: 7.0.0 > > > An erroneous warning message is logged when at startup when reading the > parent.config file: > WARNING: [ParentSelection] disabling > parent_retry on line 24 because parent_is_proxy is true > This warning should only be logged when parent_retry is set in the > parent.config and when parent_is_proxy is true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4633) Fix an erroneous warning message when reading the parent.config file.
[ https://issues.apache.org/jira/browse/TS-4633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359748#comment-15359748 ] ASF subversion and git services commented on TS-4633: - Commit dff3d2bc99f7a4ed9c9581ac1370b10995d44490 in trafficserver's branch refs/heads/master from John J. Rushford [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dff3d2b ] TS-4633: Fix an erroneous warning message when reading the parent.config file. > Fix an erroneous warning message when reading the parent.config file. > - > > Key: TS-4633 > URL: https://issues.apache.org/jira/browse/TS-4633 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: John Rushford >Assignee: John Rushford >Priority: Minor > Fix For: 7.0.0 > > > An erroneous warning message is logged when at startup when reading the > parent.config file: > WARNING: [ParentSelection] disabling > parent_retry on line 24 because parent_is_proxy is true > This warning should only be logged when parent_retry is set in the > parent.config and when parent_is_proxy is true. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4598) Coverity Null-Check after deref in NetworkUtilisRemote.cc
[
https://issues.apache.org/jira/browse/TS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359546#comment-15359546
]
ASF subversion and git services commented on TS-4598:
-
Commit 715edafcbf711896cb983a93d183f62ca1a196b0 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=715edaf ]
Merge pull request #775 from strotyl/TS-4598
TS-4598 Coverity: Null-Check after deref in NetworkUtilsRemote.cc
> Coverity Null-Check after deref in NetworkUtilisRemote.cc
> -
>
> Key: TS-4598
> URL: https://issues.apache.org/jira/browse/TS-4598
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
>Reporter: Tyler Stroh
>Assignee: Tyler Stroh
> Labels: coverity
> Fix For: 7.0.0
>
>
> {code}
> ** 1237320 Dereference before null check **
> ___
> 660 event_notice = (TSMgmtEvent *)arg;
> deref_ptr: Directly dereferencing pointer event_notice.
> 661 index= (int)event_notice->id;
> 662 LLQ *func_q; // list of callback functions need to call
> 663
> 664 func_q = create_queue();
> 665 if (!func_q) {
>
> CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking event_notice suggests that it may be null,
> but it has already been dereferenced on all paths leading to the check.
> 666if (event_notice)
> 667 TSEventDestroy(event_notice);
> 668return NULL;
> 669 }
> ___
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4598) Coverity Null-Check after deref in NetworkUtilisRemote.cc
[
https://issues.apache.org/jira/browse/TS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359545#comment-15359545
]
ASF subversion and git services commented on TS-4598:
-
Commit 6ff69b7703e589cb75ae34cc4eebeac4d1084bf2 in trafficserver's branch
refs/heads/master from [~tstroh]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6ff69b7 ]
TS-4598 : Coverity Null-Check after deref in NetworkUtilisRemote.cc
This is fixing Coverity issue CID 1237320.
> Coverity Null-Check after deref in NetworkUtilisRemote.cc
> -
>
> Key: TS-4598
> URL: https://issues.apache.org/jira/browse/TS-4598
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
>Reporter: Tyler Stroh
>Assignee: Tyler Stroh
> Labels: coverity
> Fix For: 7.0.0
>
>
> {code}
> ** 1237320 Dereference before null check **
> ___
> 660 event_notice = (TSMgmtEvent *)arg;
> deref_ptr: Directly dereferencing pointer event_notice.
> 661 index= (int)event_notice->id;
> 662 LLQ *func_q; // list of callback functions need to call
> 663
> 664 func_q = create_queue();
> 665 if (!func_q) {
>
> CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking event_notice suggests that it may be null,
> but it has already been dereferenced on all paths leading to the check.
> 666if (event_notice)
> 667 TSEventDestroy(event_notice);
> 668return NULL;
> 669 }
> ___
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4598) Coverity Null-Check after deref in NetworkUtilisRemote.cc
[
https://issues.apache.org/jira/browse/TS-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359547#comment-15359547
]
ASF subversion and git services commented on TS-4598:
-
Commit 715edafcbf711896cb983a93d183f62ca1a196b0 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=715edaf ]
Merge pull request #775 from strotyl/TS-4598
TS-4598 Coverity: Null-Check after deref in NetworkUtilsRemote.cc
> Coverity Null-Check after deref in NetworkUtilisRemote.cc
> -
>
> Key: TS-4598
> URL: https://issues.apache.org/jira/browse/TS-4598
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
>Reporter: Tyler Stroh
>Assignee: Tyler Stroh
> Labels: coverity
> Fix For: 7.0.0
>
>
> {code}
> ** 1237320 Dereference before null check **
> ___
> 660 event_notice = (TSMgmtEvent *)arg;
> deref_ptr: Directly dereferencing pointer event_notice.
> 661 index= (int)event_notice->id;
> 662 LLQ *func_q; // list of callback functions need to call
> 663
> 664 func_q = create_queue();
> 665 if (!func_q) {
>
> CID 1237320 (#1 of 1): Dereference before null check (REVERSE_INULL)
> check_after_deref: Null-checking event_notice suggests that it may be null,
> but it has already been dereferenced on all paths leading to the check.
> 666if (event_notice)
> 667 TSEventDestroy(event_notice);
> 668return NULL;
> 669 }
> ___
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4629) ServerSessionPool::purge can use an invalid iterator
[
https://issues.apache.org/jira/browse/TS-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359326#comment-15359326
]
ASF subversion and git services commented on TS-4629:
-
Commit d30791bcbe3fa77b36a214d68e45a666e56eb271 in trafficserver's branch
refs/heads/master from [~amc]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d30791b ]
TS-4629: Add now required braces to for loop.
> ServerSessionPool::purge can use an invalid iterator
>
>
> Key: TS-4629
> URL: https://issues.apache.org/jira/browse/TS-4629
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Alan M. Carroll
>
> {{purge}} calls {{do_io_close}} on the session via an iterator and
> {{do_io_close}} can cause the session to be de-allocated. Because the
> container links are intrusive this causes the iterator to be come invalid
> even though it hasn't been removed from the container.
> Also, in fixing this, I noticed {{IPHashTable::iterator}} didn't have a
> postfix increment operator, which I added because it's perfect for this
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4629) ServerSessionPool::purge can use an invalid iterator
[
https://issues.apache.org/jira/browse/TS-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359299#comment-15359299
]
ASF subversion and git services commented on TS-4629:
-
Commit 44bc6b9e072580558ac391454c80809f8aa8e4d0 in trafficserver's branch
refs/heads/master from [~amc]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=44bc6b9 ]
TS-4629: Fix use of invalid iterator in ServerSessionPool::purge.
Add postfix increment to IPHashTable::iterator.
This closes #780.
> ServerSessionPool::purge can use an invalid iterator
>
>
> Key: TS-4629
> URL: https://issues.apache.org/jira/browse/TS-4629
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Alan M. Carroll
>
> {{purge}} calls {{do_io_close}} on the session via an iterator and
> {{do_io_close}} can cause the session to be de-allocated. Because the
> container links are intrusive this causes the iterator to be come invalid
> even though it hasn't been removed from the container.
> Also, in fixing this, I noticed {{IPHashTable::iterator}} didn't have a
> postfix increment operator, which I added because it's perfect for this
> application.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4395) remap_purge: Simple plugin to purge an entire remap rule
[
https://issues.apache.org/jira/browse/TS-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359207#comment-15359207
]
ASF subversion and git services commented on TS-4395:
-
Commit 21d9f6e9987466939abaef6809a2b2cefcb5c041 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=21d9f6e ]
TS-4395 Replaces memrchr, since it is not on OSX
> remap_purge: Simple plugin to purge an entire remap rule
>
>
> Key: TS-4395
> URL: https://issues.apache.org/jira/browse/TS-4395
> Project: Traffic Server
> Issue Type: New Feature
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> This is similar to the existing plugin to purge based on a genID stored in a
> persistent storage. The difference is that the purging is done exclusively
> via a restful API, and has little (no) overhead on performance (since the
> generation ID is always in memory).
> Example:
> {code}
> map http://example.com/p1 http://p1.example.com
> @plugin=remap_purge.so @pparam=--path=__secret_purge__
> @pparam=--state=example_p1
> {code}
> And to purge:
> {code}
> $ curl -s -D - -X PURGE http://example.com/p1/__secret_purge__
> HTTP/1.1 200 OK
> Date: Sat, 30 Apr 2016 00:09:34 GMT
> Connection: close
> Server: ATS/7.0.0
> Content-Length: 39
> Content-Type: text/html
> PURGED http://example.com/p1
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4395) remap_purge: Simple plugin to purge an entire remap rule
[
https://issues.apache.org/jira/browse/TS-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359033#comment-15359033
]
ASF subversion and git services commented on TS-4395:
-
Commit e28bf65167e7c0e7ce37b978c912c58e78d794e7 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e28bf65 ]
TS-4395 Fix a few coverity warnings
> remap_purge: Simple plugin to purge an entire remap rule
>
>
> Key: TS-4395
> URL: https://issues.apache.org/jira/browse/TS-4395
> Project: Traffic Server
> Issue Type: New Feature
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> This is similar to the existing plugin to purge based on a genID stored in a
> persistent storage. The difference is that the purging is done exclusively
> via a restful API, and has little (no) overhead on performance (since the
> generation ID is always in memory).
> Example:
> {code}
> map http://example.com/p1 http://p1.example.com
> @plugin=remap_purge.so @pparam=--path=__secret_purge__
> @pparam=--state=example_p1
> {code}
> And to purge:
> {code}
> $ curl -s -D - -X PURGE http://example.com/p1/__secret_purge__
> HTTP/1.1 200 OK
> Date: Sat, 30 Apr 2016 00:09:34 GMT
> Connection: close
> Server: ATS/7.0.0
> Content-Length: 39
> Content-Type: text/html
> PURGED http://example.com/p1
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4625) 6.2 RC2 crashes immediately with Epic plugin installed
[ https://issues.apache.org/jira/browse/TS-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358291#comment-15358291 ] ASF subversion and git services commented on TS-4625: - Commit 19de79a26756e77d59a79fec95ea57aae06cc429 in trafficserver's branch refs/heads/6.2.x from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=19de79a ] TS-4625 epic: Adds a mutex to the continutation (cherry picked from commit 5bb407696216d6b678065f17917c15b2a3d9255b) > 6.2 RC2 crashes immediately with Epic plugin installed > -- > > Key: TS-4625 > URL: https://issues.apache.org/jira/browse/TS-4625 > Project: Traffic Server > Issue Type: Bug >Reporter: Miles Libbey >Assignee: Leif Hedstrom > Fix For: 6.2.0, 7.0.0 > > > We think its an incompatibility with > https://github.com/apache/trafficserver/pull/603/files -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4625) 6.2 RC2 crashes immediately with Epic plugin installed
[ https://issues.apache.org/jira/browse/TS-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358232#comment-15358232 ] ASF subversion and git services commented on TS-4625: - Commit 5bb407696216d6b678065f17917c15b2a3d9255b in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5bb4076 ] TS-4625 epic: Adds a mutex to the continutation > 6.2 RC2 crashes immediately with Epic plugin installed > -- > > Key: TS-4625 > URL: https://issues.apache.org/jira/browse/TS-4625 > Project: Traffic Server > Issue Type: Bug >Reporter: Miles Libbey >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > We think its an incompatibility with > https://github.com/apache/trafficserver/pull/603/files -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4625) 6.2 RC2 crashes immediately with Epic plugin installed
[ https://issues.apache.org/jira/browse/TS-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358234#comment-15358234 ] ASF subversion and git services commented on TS-4625: - Commit 541bd55394076eb8948726a9ce297c19a65a6fa9 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=541bd55 ] Merge pull request #778 from zwoop/TS-4625 TS-4625 epic: Adds a mutex to the continutation > 6.2 RC2 crashes immediately with Epic plugin installed > -- > > Key: TS-4625 > URL: https://issues.apache.org/jira/browse/TS-4625 > Project: Traffic Server > Issue Type: Bug >Reporter: Miles Libbey >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > We think its an incompatibility with > https://github.com/apache/trafficserver/pull/603/files -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4625) 6.2 RC2 crashes immediately with Epic plugin installed
[ https://issues.apache.org/jira/browse/TS-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358233#comment-15358233 ] ASF subversion and git services commented on TS-4625: - Commit 541bd55394076eb8948726a9ce297c19a65a6fa9 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=541bd55 ] Merge pull request #778 from zwoop/TS-4625 TS-4625 epic: Adds a mutex to the continutation > 6.2 RC2 crashes immediately with Epic plugin installed > -- > > Key: TS-4625 > URL: https://issues.apache.org/jira/browse/TS-4625 > Project: Traffic Server > Issue Type: Bug >Reporter: Miles Libbey >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > We think its an incompatibility with > https://github.com/apache/trafficserver/pull/603/files -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4395) remap_purge: Simple plugin to purge an entire remap rule
[
https://issues.apache.org/jira/browse/TS-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358227#comment-15358227
]
ASF subversion and git services commented on TS-4395:
-
Commit e63b12d03f4fdef10129bb85152c5da615cb69cd in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e63b12d ]
TS-4395 Add new plugin, remap_purge
This is similar to the existing plugin to purge based on a genID stored in a
persistent storage. The difference is that the purging is done exclusively via
a restful API, and has little (no) overhead on performance (since the
generation ID is always in memory).
Example:
map http://example.com/p1 http://p1.example.com
@plugin=remap_purge.so @pparam=--path=__secret__ @pparam=--state=example_p1
And to purge:
$ curl -s -D - -X PURGE http://example.com/p1/__secret__
HTTP/1.1 200 OK
Date: Sat, 30 Apr 2016 00:09:34 GMT
Connection: close
Server: ATS/7.0.0
Content-Length: 39
Content-Type: text/html
PURGED http://example.com/p1
> remap_purge: Simple plugin to purge an entire remap rule
>
>
> Key: TS-4395
> URL: https://issues.apache.org/jira/browse/TS-4395
> Project: Traffic Server
> Issue Type: New Feature
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> This is similar to the existing plugin to purge based on a genID stored in a
> persistent storage. The difference is that the purging is done exclusively
> via a restful API, and has little (no) overhead on performance (since the
> generation ID is always in memory).
> Example:
> {code}
> map http://example.com/p1 http://p1.example.com
> @plugin=remap_purge.so @pparam=--path=__secret_purge__
> @pparam=--state=example_p1
> {code}
> And to purge:
> {code}
> $ curl -s -D - -X PURGE http://example.com/p1/__secret_purge__
> HTTP/1.1 200 OK
> Date: Sat, 30 Apr 2016 00:09:34 GMT
> Connection: close
> Server: ATS/7.0.0
> Content-Length: 39
> Content-Type: text/html
> PURGED http://example.com/p1
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4570) Return to TS_HTTP_OS_DNS_HOOK after explicit DNS
[
https://issues.apache.org/jira/browse/TS-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357900#comment-15357900
]
ASF subversion and git services commented on TS-4570:
-
Commit 658cbb952e70507dd496b7a5e1172995523d6f38 in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=658cbb9 ]
Merge pull request #740 from jpeach/fix/4570
TS-4570: Return to TS_HTTP_OS_DNS_HOOK if server address is set.
> Return to TS_HTTP_OS_DNS_HOOK after explicit DNS
>
>
> Key: TS-4570
> URL: https://issues.apache.org/jira/browse/TS-4570
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, TS API
>Reporter: James Peach
> Fix For: sometime
>
>
> Consider the case of a plugin that has out -of-band routing knowledge
> equivalent to DNS. So for a domain, it might have a number of possible IP
> addresses. Remap plugins can implement {{TSRemapOSResponse}}, which is called
> in the connection result handling path, but there's no facility for global
> plugins to reroute the request.
> In my case, I'm largely doing forward proxying, so I don't have a remap rule
> for everything I need to route. Hence I'm a global plugin.
> Here is a relatively hacky patch that backs the state machine back up to
> {{TS_HTTP_OS_DNS_HOOK}} if we get a connection failure, have retries left,
> and a plugin has called {{TSHttpTxnServerAddrSet}}.
> {code}
> $ git diff proxy/http/HttpTransact.cc
> diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
> index 5ef0430..3363af1 100644
> --- a/proxy/http/HttpTransact.cc
> +++ b/proxy/http/HttpTransact.cc
> @@ -3762,6 +3762,11 @@ HttpTransact::handle_response_from_server(State *s)
> // families - that is locked in by the client source address.
>
> s->state_machine->ua_session->set_host_res_style(ats_host_res_match(>current.server->dst_addr.sa));
> TRANSACT_RETURN(SM_ACTION_DNS_LOOKUP, OSDNSLookup);
> + } else if (s->api_server_addr_set) {
> +// If the address was set by a plugin, give it another chance.
> +s->dns_info.os_addr_style = DNSLookupInfo::OS_ADDR_TRY_HOSTDB;
> +s->current.attempts++;
> +TRANSACT_RETURN(SM_ACTION_API_OS_DNS, OSDNSLookup);
>} else if ((s->dns_info.srv_lookup_success ||
> s->host_db_info.is_rr_elt()) &&
> (s->txn_conf->connect_attempts_rr_retries > 0) &&
> (s->current.attempts %
> s->txn_conf->connect_attempts_rr_retries == 0)) {
> {code}
> Note that some plugins might be unprepared for {{TS_HTTP_OS_DNS_HOOK}} to be
> called multiple times, so we should document that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4570) Return to TS_HTTP_OS_DNS_HOOK after explicit DNS
[
https://issues.apache.org/jira/browse/TS-4570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357899#comment-15357899
]
ASF subversion and git services commented on TS-4570:
-
Commit ab84e0eb928207ff4d8cb1c11d54203a6bf157d7 in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ab84e0e ]
TS-4570: Return to TS_HTTP_OS_DNS_HOOK if server address is set.
Using HostDB, Traffic Server will try to connect to all the resolved
IP addresses if the connection fail. However if a plugin sets the
address using some out-of-band knowledge and TSHttpTxnServerAddrSet,
it onlt gets to set the address once.
This change returns the state machine to the OS_DNS_HOOK API callout
so that the plugin can have an opportunity to set a different server
address.
> Return to TS_HTTP_OS_DNS_HOOK after explicit DNS
>
>
> Key: TS-4570
> URL: https://issues.apache.org/jira/browse/TS-4570
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core, TS API
>Reporter: James Peach
> Fix For: sometime
>
>
> Consider the case of a plugin that has out -of-band routing knowledge
> equivalent to DNS. So for a domain, it might have a number of possible IP
> addresses. Remap plugins can implement {{TSRemapOSResponse}}, which is called
> in the connection result handling path, but there's no facility for global
> plugins to reroute the request.
> In my case, I'm largely doing forward proxying, so I don't have a remap rule
> for everything I need to route. Hence I'm a global plugin.
> Here is a relatively hacky patch that backs the state machine back up to
> {{TS_HTTP_OS_DNS_HOOK}} if we get a connection failure, have retries left,
> and a plugin has called {{TSHttpTxnServerAddrSet}}.
> {code}
> $ git diff proxy/http/HttpTransact.cc
> diff --git a/proxy/http/HttpTransact.cc b/proxy/http/HttpTransact.cc
> index 5ef0430..3363af1 100644
> --- a/proxy/http/HttpTransact.cc
> +++ b/proxy/http/HttpTransact.cc
> @@ -3762,6 +3762,11 @@ HttpTransact::handle_response_from_server(State *s)
> // families - that is locked in by the client source address.
>
> s->state_machine->ua_session->set_host_res_style(ats_host_res_match(>current.server->dst_addr.sa));
> TRANSACT_RETURN(SM_ACTION_DNS_LOOKUP, OSDNSLookup);
> + } else if (s->api_server_addr_set) {
> +// If the address was set by a plugin, give it another chance.
> +s->dns_info.os_addr_style = DNSLookupInfo::OS_ADDR_TRY_HOSTDB;
> +s->current.attempts++;
> +TRANSACT_RETURN(SM_ACTION_API_OS_DNS, OSDNSLookup);
>} else if ((s->dns_info.srv_lookup_success ||
> s->host_db_info.is_rr_elt()) &&
> (s->txn_conf->connect_attempts_rr_retries > 0) &&
> (s->current.attempts %
> s->txn_conf->connect_attempts_rr_retries == 0)) {
> {code}
> Note that some plugins might be unprepared for {{TS_HTTP_OS_DNS_HOOK}} to be
> called multiple times, so we should document that.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4542) ASAN error with HTTP/2
[
https://issues.apache.org/jira/browse/TS-4542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357818#comment-15357818
]
ASF subversion and git services commented on TS-4542:
-
Commit 52afdf7b0f1bdbaff342fa76ffac6104ecef17a7 in trafficserver's branch
refs/heads/6.2.x from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=52afdf7 ]
TS-4542: ASAN error with HTTP/2
(cherry picked from commit 1bf2f04e3043182b65b30a5f1187d97a50335860)
> ASAN error with HTTP/2
> --
>
> Key: TS-4542
> URL: https://issues.apache.org/jira/browse/TS-4542
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.2.0, 7.0.0
>
>
> {code}
> ==29132==ERROR: AddressSanitizer: SEGV on unknown address 0x0250 (pc
> 0x009a1be5 sp 0x2ae2c2ab0290 bp 0x2ae2c2ab0370 T20)
> #0 0x9a1be4 in Ptr::operator ProxyMutex*() const
> ../../../trafficserver/lib/ts/Ptr.h:317
> #1 0x9a1be4 in Http2ConnectionState::schedule_stream(Http2Stream*)
> ../../../trafficserver/proxy/http2/Http2ConnectionState.cc:974
> #2 0x99eb7f in Http2ConnectionState::restart_streams()
> ../../../trafficserver/proxy/http2/Http2ConnectionState.cc:914
> #3 0x99eb7f in rcv_window_update_frame
> ../../../trafficserver/proxy/http2/Http2ConnectionState.cc:627
> #4 0x9b27c4 in Http2ConnectionState::main_event_handler(int, void*)
> ../../../trafficserver/proxy/http2/Http2ConnectionState.cc:823
> #5 0x9906e3 in Continuation::handleEvent(int, void*)
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:153
> #6 0x9906e3 in send_connection_event
> ../../../trafficserver/proxy/http2/Http2ClientSession.cc:58
> #7 0x991145 in Http2ClientSession::state_complete_frame_read(int, void*)
> ../../../trafficserver/proxy/http2/Http2ClientSession.cc:430
> #8 0x992ba0 in Continuation::handleEvent(int, void*)
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:153
> #9 0x992ba0 in Http2ClientSession::state_start_frame_read(int, void*)
> ../../../trafficserver/proxy/http2/Http2ClientSession.cc:403
> #10 0xe2be16 in Continuation::handleEvent(int, void*)
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:153
> #11 0xe2be16 in read_signal_and_update
> ../../../trafficserver/iocore/net/UnixNetVConnection.cc:153
> #12 0xe2be16 in UnixNetVConnection::readSignalAndUpdate(int)
> ../../../trafficserver/iocore/net/UnixNetVConnection.cc:1036
> #13 0xdc791e in SSLNetVConnection::net_read_io(NetHandler*, EThread*)
> ../../../trafficserver/iocore/net/SSLNetVConnection.cc:595
> #14 0xde7db0 in NetHandler::mainNetEvent(int, Event*)
> ../../../trafficserver/iocore/net/UnixNet.cc:513
> #15 0xea2ce9 in Continuation::handleEvent(int, void*)
> ../../../trafficserver/iocore/eventsystem/I_Continuation.h:153
> #16 0xea2ce9 in EThread::process_event(Event*, int)
> ../../../trafficserver/iocore/eventsystem/UnixEThread.cc:148
> #17 0xea2ce9 in EThread::execute()
> ../../../trafficserver/iocore/eventsystem/UnixEThread.cc:275
> #18 0xe9e128 in spawn_thread_internal
> ../../../trafficserver/iocore/eventsystem/Thread.cc:86
> #19 0x2ae2b8e85aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0)
> #20 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4608) Memory leak in ProxyAllocator.cc
[ https://issues.apache.org/jira/browse/TS-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357819#comment-15357819 ] ASF subversion and git services commented on TS-4608: - Commit ffc97318cffb15d66593bc499a4d1702c2bdd3fb in trafficserver's branch refs/heads/6.2.x from [~jaaju] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ffc9731 ] TS-4608: Fix memory leak in ProxyAllocator.cc. (#774) This removes the pre-processor flag TS_USE_FREELIST which is not defined since commit e56d1f9eb6f55b0257d1fb758b773dea468159ee to make freelists a runtime option. (cherry picked from commit e707c3ec02d71ae079db9282c825d0449f62a88c) > Memory leak in ProxyAllocator.cc > > > Key: TS-4608 > URL: https://issues.apache.org/jira/browse/TS-4608 > Project: Traffic Server > Issue Type: Bug >Reporter: Jay Ramamurthi >Priority: Blocker > Fix For: 6.2.0, 7.0.0 > > > The change to make freelists a runtime option > (https://github.com/apache/trafficserver/commit/e56d1f9eb6f55b0257d1fb758b773dea468159ee) > seems to have missed this file. > With the preprocessor symbol TS_USE_FREELIST now gone (earlier used to be 1), > the overload of thread_alloc defined in this file always uses Proxy Allocator > (the second argument to the method) but free routines are from the freelist. > This overload of thread_alloc is used by HdrHeap, that is widely used in > transaction processing, causing leaks. > Steps to reproduce: > Traffic server with a single remap configuration, and ab workload should show > memory growth. > Version seen in: Traffic Server built from branches master, 6.1.x, 6.2.x. > Platform: Linux 64-bit (RHEL 6.6), g++ 4.4.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4608) Memory leak in ProxyAllocator.cc
[ https://issues.apache.org/jira/browse/TS-4608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15357795#comment-15357795 ] ASF subversion and git services commented on TS-4608: - Commit e707c3ec02d71ae079db9282c825d0449f62a88c in trafficserver's branch refs/heads/master from [~jaaju] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e707c3e ] TS-4608: Fix memory leak in ProxyAllocator.cc. (#774) This removes the pre-processor flag TS_USE_FREELIST which is not defined since commit e56d1f9eb6f55b0257d1fb758b773dea468159ee to make freelists a runtime option. > Memory leak in ProxyAllocator.cc > > > Key: TS-4608 > URL: https://issues.apache.org/jira/browse/TS-4608 > Project: Traffic Server > Issue Type: Bug >Reporter: Jay Ramamurthi >Priority: Blocker > Fix For: 7.0.0 > > > The change to make freelists a runtime option > (https://github.com/apache/trafficserver/commit/e56d1f9eb6f55b0257d1fb758b773dea468159ee) > seems to have missed this file. > With the preprocessor symbol TS_USE_FREELIST now gone (earlier used to be 1), > the overload of thread_alloc defined in this file always uses Proxy Allocator > (the second argument to the method) but free routines are from the freelist. > This overload of thread_alloc is used by HdrHeap, that is widely used in > transaction processing, causing leaks. > Steps to reproduce: > Traffic server with a single remap configuration, and ab workload should show > memory growth. > Version seen in: Traffic Server built from branches master, 6.1.x, 6.2.x. > Platform: Linux 64-bit (RHEL 6.6), g++ 4.4.7 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4324) Inefficient way of transferring data frames
[
https://issues.apache.org/jira/browse/TS-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356347#comment-15356347
]
ASF subversion and git services commented on TS-4324:
-
Commit 54b0d3110abc5eb582081e4da42b3f80b3cab2dd in trafficserver's branch
refs/heads/master from [~masaori]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=54b0d31 ]
TS-4324: Allocate 16KB for DATA frame payload exactly
- Cleanup Http2Frame
- Separate frame header and frame payload
> Inefficient way of transferring data frames
> ---
>
> Key: TS-4324
> URL: https://issues.apache.org/jira/browse/TS-4324
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> ATS transfers data 8K - 9 bytes (http/2 header size) and then sends the 9
> bytes is couldn't write in a new frame that only has 9 bytes. This also
> happens if you bump up the buffer size to 16K.
> {code}
> [ 1.036] recv DATA frame
[jira] [Commented] (TS-4324) Inefficient way of transferring data frames
[
https://issues.apache.org/jira/browse/TS-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356348#comment-15356348
]
ASF subversion and git services commented on TS-4324:
-
Commit 3ad8e94d017bd6c34512216dd489a1217d72e456 in trafficserver's branch
refs/heads/master from [~masaori]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3ad8e94 ]
Merge pull request #733 from masaori335/ts-4324
TS-4324: Allocate 16KB for DATA frame payload exactly
> Inefficient way of transferring data frames
> ---
>
> Key: TS-4324
> URL: https://issues.apache.org/jira/browse/TS-4324
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
>Reporter: Bryan Call
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> ATS transfers data 8K - 9 bytes (http/2 header size) and then sends the 9
> bytes is couldn't write in a new frame that only has 9 bytes. This also
> happens if you bump up the buffer size to 16K.
> {code}
> [ 1.036] recv DATA frame
[jira] [Commented] (TS-4605) Coverity issue 1357058: Uninitialized members in PriorityQueue.h
[
https://issues.apache.org/jira/browse/TS-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356323#comment-15356323
]
ASF subversion and git services commented on TS-4605:
-
Commit e1a37058fc14646f517c304b6d277c788a9c0462 in trafficserver's branch
refs/heads/master from [~masaori]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e1a3705 ]
TS-4605: fix Coverity issue 1357058
> Coverity issue 1357058: Uninitialized members in PriorityQueue.h
>
>
> Key: TS-4605
> URL: https://issues.apache.org/jira/browse/TS-4605
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> {code}
> ** CID 1357058: Uninitialized members (UNINIT_CTOR)
> /lib/ts/PriorityQueue.h: 32 in PriorityQueueEntry *>::PriorityQueueEntry()()
>
> *** CID 1357058: Uninitialized members (UNINIT_CTOR)
> /lib/ts/PriorityQueue.h: 32 in PriorityQueueEntry *>::PriorityQueueEntry()()
> 26
> 27 #include "ts/ink_assert.h"
> 28 #include "ts/Vec.h"
> 29
> 30 template struct PriorityQueueEntry {
> 31 PriorityQueueEntry(T n) : index(0), node(n){};
>CID 1357058: Uninitialized members (UNINIT_CTOR)
>Non-static class member "node" is not initialized in this constructor nor
> in any functions that it calls.
> 32 PriorityQueueEntry() : index(0){};
> 33 uint32_t index;
> 34 T node;
> 35 };
> 36
> 37 template struct PriorityQueueLess {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4605) Coverity issue 1357058: Uninitialized members in PriorityQueue.h
[
https://issues.apache.org/jira/browse/TS-4605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356324#comment-15356324
]
ASF subversion and git services commented on TS-4605:
-
Commit c64ce724b1fe1225d44ede9967d682bc4c54eed5 in trafficserver's branch
refs/heads/master from [~masaori]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c64ce72 ]
Merge pull request #767 from masaori335/ts-4605
TS-4605: fix Coverity issue 1357058
> Coverity issue 1357058: Uninitialized members in PriorityQueue.h
>
>
> Key: TS-4605
> URL: https://issues.apache.org/jira/browse/TS-4605
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Leif Hedstrom
>Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> {code}
> ** CID 1357058: Uninitialized members (UNINIT_CTOR)
> /lib/ts/PriorityQueue.h: 32 in PriorityQueueEntry *>::PriorityQueueEntry()()
>
> *** CID 1357058: Uninitialized members (UNINIT_CTOR)
> /lib/ts/PriorityQueue.h: 32 in PriorityQueueEntry *>::PriorityQueueEntry()()
> 26
> 27 #include "ts/ink_assert.h"
> 28 #include "ts/Vec.h"
> 29
> 30 template struct PriorityQueueEntry {
> 31 PriorityQueueEntry(T n) : index(0), node(n){};
>CID 1357058: Uninitialized members (UNINIT_CTOR)
>Non-static class member "node" is not initialized in this constructor nor
> in any functions that it calls.
> 32 PriorityQueueEntry() : index(0){};
> 33 uint32_t index;
> 34 T node;
> 35 };
> 36
> 37 template struct PriorityQueueLess {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4550) xdebug: Add support for new UUID APIs
[ https://issues.apache.org/jira/browse/TS-4550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356294#comment-15356294 ] ASF subversion and git services commented on TS-4550: - Commit a56c5ac0cf02b26335c533f538459145073743d8 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a56c5ac ] TS-4550 Adds X-Transaction-Id to xdebug This makes a header value that matches the new log tag, %. > xdebug: Add support for new UUID APIs > - > > Key: TS-4550 > URL: https://issues.apache.org/jira/browse/TS-4550 > Project: Traffic Server > Issue Type: New Feature > Components: Plugins >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > E.g. X-Debug: ATS-Txn-UUID -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4519) Add new log tags for the Process UUID + HttpSM ID
[ https://issues.apache.org/jira/browse/TS-4519?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355927#comment-15355927 ] ASF subversion and git services commented on TS-4519: - Commit 779fd2ffa5ff871d06fdf8feca81bd71da46ee7a in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=779fd2f ] TS-4520 header_rewrite: Add a new ID condition, with 3 types This gives header_rewrite the functionality to get / use the same UUID / IDs as the new log-formats in TS-4519. > Add new log tags for the Process UUID + HttpSM ID > - > > Key: TS-4519 > URL: https://issues.apache.org/jira/browse/TS-4519 > Project: Traffic Server > Issue Type: New Feature > Components: Logging >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This depends on the feature in TS-4518. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4520) header_rewrite: Add support for the UUID and HttpSM ID tags
[ https://issues.apache.org/jira/browse/TS-4520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355925#comment-15355925 ] ASF subversion and git services commented on TS-4520: - Commit 779fd2ffa5ff871d06fdf8feca81bd71da46ee7a in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=779fd2f ] TS-4520 header_rewrite: Add a new ID condition, with 3 types This gives header_rewrite the functionality to get / use the same UUID / IDs as the new log-formats in TS-4519. > header_rewrite: Add support for the UUID and HttpSM ID tags > --- > > Key: TS-4520 > URL: https://issues.apache.org/jira/browse/TS-4520 > Project: Traffic Server > Issue Type: New Feature > Components: Plugins >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > This requires TS-4518 . -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4588) Require braces around statements.
[ https://issues.apache.org/jira/browse/TS-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355649#comment-15355649 ] ASF subversion and git services commented on TS-4588: - Commit 2832d63e6fbf973b0dd431406b1cd3293205d179 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2832d63 ] TS-4588: Add initial clang-tidy configuration. > Require braces around statements. > - > > Key: TS-4588 > URL: https://issues.apache.org/jira/browse/TS-4588 > Project: Traffic Server > Issue Type: Improvement > Components: Cleanup, Core >Reporter: James Peach >Assignee: James Peach > Fix For: 7.0.0 > > > Bodies of if statements and loops (for, range-for, do-while, and while) are > inside braces. > Apply this as a clang-tidy change > [readability-braces-around-statements|http://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html]. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4611) C++ API example plugins are missing run-time library linkage
[ https://issues.apache.org/jira/browse/TS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354469#comment-15354469 ] ASF subversion and git services commented on TS-4611: - Commit 49bafe1e8995710713f304fc0105facfe805ceaa in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=49bafe1 ] TS-4611: Fix the CPP API plugins to liba against libatscppapi. (#764) > C++ API example plugins are missing run-time library linkage > > > Key: TS-4611 > URL: https://issues.apache.org/jira/browse/TS-4611 > Project: Traffic Server > Issue Type: Bug > Components: CPP API >Reporter: Oliver Goodman >Assignee: James Peach > Fix For: 7.0.0 > > > The example plugins appear to compile just fine but when you try to load one > you get a link error. The problem seems to come down to a missing -latscppapi > flag in the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4611) C++ API example plugins are missing run-time library linkage
[ https://issues.apache.org/jira/browse/TS-4611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354453#comment-15354453 ] ASF subversion and git services commented on TS-4611: - Commit 248bbf64a488d8bda3507816f788556f210edaf5 in trafficserver's branch refs/heads/fix/cppapi-build from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=248bbf6 ] TS-4611: Fix the CPP API plugins to liba against libatscppapi. > C++ API example plugins are missing run-time library linkage > > > Key: TS-4611 > URL: https://issues.apache.org/jira/browse/TS-4611 > Project: Traffic Server > Issue Type: Bug > Components: CPP API >Reporter: Oliver Goodman >Assignee: Brian Geffon > > The example plugins appear to compile just fine but when you try to load one > you get a link error. The problem seems to come down to a missing -latscppapi > flag in the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4481) CPP API should not initialize all handles on every event.
[ https://issues.apache.org/jira/browse/TS-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353996#comment-15353996 ] ASF subversion and git services commented on TS-4481: - Commit c8328c655641355abe00a95c44eaf87aaf9a6a55 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c8328c6 ] TS-4481 clang-format > CPP API should not initialize all handles on every event. > - > > Key: TS-4481 > URL: https://issues.apache.org/jira/browse/TS-4481 > Project: Traffic Server > Issue Type: Bug > Components: CPP API >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll > Fix For: 7.0.0 > > > To avoid problems with stale handles to transaction headers the CPP API was > changed to initialize all such handles for a set of events. However this > causes the error log to be flooded because not all headers are available for > all of the events and each one that is not generates an error message. This > generates a lot of errors even in normal use without problems. Simply > disabling the messages seems a poor choice as the cases where the particular > header is accessed and not found should be noted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4481) CPP API should not initialize all handles on every event.
[ https://issues.apache.org/jira/browse/TS-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353954#comment-15353954 ] ASF subversion and git services commented on TS-4481: - Commit c05f02d902ccb606f4bf4b500baf28a7e8d7279c in trafficserver's branch refs/heads/master from [~amc] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c05f02d ] TS-4481: CPP API - clear handles and reload on demand. This closes #663. > CPP API should not initialize all handles on every event. > - > > Key: TS-4481 > URL: https://issues.apache.org/jira/browse/TS-4481 > Project: Traffic Server > Issue Type: Bug > Components: CPP API >Reporter: Alan M. Carroll >Assignee: Brian Geffon > Fix For: 7.0.0 > > > To avoid problems with stale handles to transaction headers the CPP API was > changed to initialize all such handles for a set of events. However this > causes the error log to be flooded because not all headers are available for > all of the events and each one that is not generates an error message. This > generates a lot of errors even in normal use without problems. Simply > disabling the messages seems a poor choice as the cases where the particular > header is accessed and not found should be noted. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4331) Hostdb consistency problems due to MultiCache
[
https://issues.apache.org/jira/browse/TS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353504#comment-15353504
]
ASF subversion and git services commented on TS-4331:
-
Commit 67404970b32d2fc19b4dab606efa265aadfd5d9f in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6740497 ]
TS-4606 TS-4331 0 is a valid FD
> Hostdb consistency problems due to MultiCache
> -
>
> Key: TS-4331
> URL: https://issues.apache.org/jira/browse/TS-4331
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> This ticket is for the correct long term fix to TS-4207
> pulled from a comment, which wraps up the issue
> {quote}
> Leif Hedstrom I have spent a decent amount of time on this while I was OOO on
> vacation the last couple of weeks. It seems that the root cause of this issue
> has always existed, and that the addition of always doing hostname storing
> (https://github.com/apache/trafficserver/commit/0e703e1e) we are just causing
> the issue to happen all the time.
> To understand the issue I'll give a little background in how hostdb is
> currently working. Basically hostdb is just a wrapper around this templated
> struct called MultiCache. MultiCache is "multi" not because it is templated,
> but because it has two types of storage (static-- blocks and dynamic--
> alloc). The static side of the cache can hold N HostDBInfo structs (the
> results of DNS queries). The dynamic side is used to store the round robin
> records and various strings associated with the record. The size of this
> dynamic space is defined as (N x [estimated_heap_bytes_per_entry. The basic
> problem we are running into is that we are putting too much preassure on the
> dynamic heap-- such that the heap is getting re-used while people still have
> references to items in that space.
> So, I've actually been working on re-writing MultiCache to allocate the
> entire required block at once (so we don't have this problem where the parent
> exists but not the children), but I'm not certain if we want such a change to
> go into the 6.x branch (I'm willing to discuss if we want). If we aren't
> comfortable with such a large change I suggest just accounting for the
> hostname size in the estimated_heap_bytes_per_entry as a stopgap solution.
> The maximum allowable size is 253 (so 254 with null terminator), but we could
> pick a smaller number (~120 or so seems to be more reasonable). Alternatively
> you can increase the number of records in hostdb (and the size accordingly)
> to increase the dynamic heap size.
> TLDR; almost done with the long term solution, but I'm not sure if we want to
> merge that into 6.x-- alternatively we can do a simple workaround in 6.x
> (https://github.com/apache/trafficserver/pull/553)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4606) CID 1357056: Resource leaks in P_RefCountCache.
[
https://issues.apache.org/jira/browse/TS-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353503#comment-15353503
]
ASF subversion and git services commented on TS-4606:
-
Commit 67404970b32d2fc19b4dab606efa265aadfd5d9f in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6740497 ]
TS-4606 TS-4331 0 is a valid FD
> CID 1357056: Resource leaks in P_RefCountCache.
>
>
> Key: TS-4606
> URL: https://issues.apache.org/jira/browse/TS-4606
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Leif Hedstrom
>Assignee: Thomas Jackson
> Labels: coverity
> Fix For: 7.0.0
>
>
> {code}
> ** CID 1357056: Resource leaks (RESOURCE_LEAK)
> /iocore/hostdb/P_RefCountCache.h: 823 in
> LoadRefCountCacheFromPath(RefCountCache &,
> std::basic_string,
> std::basic_string, T1
> *(*)(char *, unsigned int))()
>
> *** CID 1357056: Resource leaks (RESOURCE_LEAK)
> /iocore/hostdb/P_RefCountCache.h: 823 in
> LoadRefCountCacheFromPath(RefCountCache &,
> std::basic_string,
> std::basic_string, T1
> *(*)(char *, unsigned int))()
> 817 if (load_func == NULL) {
> 818 return -1; // TODO: some specific error code
> 819 }
> 820
> 821 int fd = open(filepath.c_str(), O_RDONLY);
> 822 if (fd <= 0) {
>CID 1357056: Resource leaks (RESOURCE_LEAK)
>Handle variable "fd" going out of scope leaks the handle.
> 823 return -1; // specific code for missing?
> 824 }
> 825
> 826 // read in the header
> 827 RefCountCacheHeader tmpHeader = RefCountCacheHeader();
> 828 int read_ret = read(fd, (char *),
> sizeof(RefCountCacheHeader));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4604) The page on "configuring traffic server" needs correction
[ https://issues.apache.org/jira/browse/TS-4604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353413#comment-15353413 ] ASF subversion and git services commented on TS-4604: - Commit 931b6833583bb57d1d4e533f422cb78f81b30edb in trafficserver's branch refs/heads/master from [~persiaAziz] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=931b683 ] TS-4604 : Command for configuring traffic server corrected (#756) * Update configuring-traffic-server.en.rst * Update configuring-traffic-server.en.rst * Update configuring-traffic-server.en.rst * Update configuring-traffic-server.en.rst > The page on "configuring traffic server" needs correction > - > > Key: TS-4604 > URL: https://issues.apache.org/jira/browse/TS-4604 > Project: Traffic Server > Issue Type: Bug > Components: Documentation >Reporter: Syeda Persia Aziz > Fix For: 7.0.0 > > > https://docs.trafficserver.apache.org/en/latest/admin-guide/configuring-traffic-server.en.html?highlight=traffic_config > "traffic_config" does not exist. Also this page talks about traffic line but > the examples use traffic_ctl, which looks confusing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4518) UUID and HttpSM ID APIs and Machine support for a process UUID
[ https://issues.apache.org/jira/browse/TS-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353363#comment-15353363 ] ASF subversion and git services commented on TS-4518: - Commit 8652504331afd6268552f3197644235cdc51c4f5 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8652504 ] TS-4518 Eliminate memory leaks in UUID regressions > UUID and HttpSM ID APIs and Machine support for a process UUID > -- > > Key: TS-4518 > URL: https://issues.apache.org/jira/browse/TS-4518 > Project: Traffic Server > Issue Type: New Feature > Components: Core, TS API >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > As was discussed on https://github.com/apache/trafficserver/pull/199, I've > started the work to generalize this, and breaking it up in various parts. > This first Jira is about adding four things: > 1) An internal process UUID, which goes into Machine. It's accessible from > the core. > 2) An API to get this Machine UUID. > 3) A set of generic UUID APIs, to do things like stringification, Copy() etc. > 4) A very simple API that exposes the HttpSM's sequences number (sm_id). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4331) Hostdb consistency problems due to MultiCache
[
https://issues.apache.org/jira/browse/TS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353271#comment-15353271
]
ASF subversion and git services commented on TS-4331:
-
Commit c1f7bef5f1579ef64c18166cd9c1ce1a4d163824 in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=c1f7bef ]
TS-4331 Remove printf that slipped past review
> Hostdb consistency problems due to MultiCache
> -
>
> Key: TS-4331
> URL: https://issues.apache.org/jira/browse/TS-4331
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> This ticket is for the correct long term fix to TS-4207
> pulled from a comment, which wraps up the issue
> {quote}
> Leif Hedstrom I have spent a decent amount of time on this while I was OOO on
> vacation the last couple of weeks. It seems that the root cause of this issue
> has always existed, and that the addition of always doing hostname storing
> (https://github.com/apache/trafficserver/commit/0e703e1e) we are just causing
> the issue to happen all the time.
> To understand the issue I'll give a little background in how hostdb is
> currently working. Basically hostdb is just a wrapper around this templated
> struct called MultiCache. MultiCache is "multi" not because it is templated,
> but because it has two types of storage (static-- blocks and dynamic--
> alloc). The static side of the cache can hold N HostDBInfo structs (the
> results of DNS queries). The dynamic side is used to store the round robin
> records and various strings associated with the record. The size of this
> dynamic space is defined as (N x [estimated_heap_bytes_per_entry. The basic
> problem we are running into is that we are putting too much preassure on the
> dynamic heap-- such that the heap is getting re-used while people still have
> references to items in that space.
> So, I've actually been working on re-writing MultiCache to allocate the
> entire required block at once (so we don't have this problem where the parent
> exists but not the children), but I'm not certain if we want such a change to
> go into the 6.x branch (I'm willing to discuss if we want). If we aren't
> comfortable with such a large change I suggest just accounting for the
> hostname size in the estimated_heap_bytes_per_entry as a stopgap solution.
> The maximum allowable size is 253 (so 254 with null terminator), but we could
> pick a smaller number (~120 or so seems to be more reasonable). Alternatively
> you can increase the number of records in hostdb (and the size accordingly)
> to increase the dynamic heap size.
> TLDR; almost done with the long term solution, but I'm not sure if we want to
> merge that into 6.x-- alternatively we can do a simple workaround in 6.x
> (https://github.com/apache/trafficserver/pull/553)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4156) remove the traffic_sac, stand alone log collation server
[ https://issues.apache.org/jira/browse/TS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353081#comment-15353081 ] ASF subversion and git services commented on TS-4156: - Commit d939dd1c18f9824b69febbfa64a216dd39f95b71 in trafficserver's branch refs/heads/master from [~zym] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d939dd1 ] TS-4156: remove the traffic_sac, stand alone log collation server > remove the traffic_sac, stand alone log collation server > > > Key: TS-4156 > URL: https://issues.apache.org/jira/browse/TS-4156 > Project: Traffic Server > Issue Type: Improvement > Components: Logging >Reporter: Zhao Yongming >Assignee: Zhao Yongming > Fix For: 7.0.0 > > > the stand alone collation server act as a dedicated log server from ATS, this > is a dedicated log product back in the Inktomi age, and we don't need it as > this functions are build into the traffic_server binary for free distribution. > it is time to nuke it down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4156) remove the traffic_sac, stand alone log collation server
[ https://issues.apache.org/jira/browse/TS-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353082#comment-15353082 ] ASF subversion and git services commented on TS-4156: - Commit 64d79bf2751b54200e1f76b28544efa4279885c2 in trafficserver's branch refs/heads/master from [~zym] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=64d79bf ] Merge pull request #593 from mingzym/TS-4156 TS-4156: remove the traffic_sac, stand alone log collation server > remove the traffic_sac, stand alone log collation server > > > Key: TS-4156 > URL: https://issues.apache.org/jira/browse/TS-4156 > Project: Traffic Server > Issue Type: Improvement > Components: Logging >Reporter: Zhao Yongming >Assignee: Zhao Yongming > Fix For: 7.0.0 > > > the stand alone collation server act as a dedicated log server from ATS, this > is a dedicated log product back in the Inktomi age, and we don't need it as > this functions are build into the traffic_server binary for free distribution. > it is time to nuke it down. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4331) Hostdb consistency problems due to MultiCache
[
https://issues.apache.org/jira/browse/TS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352111#comment-15352111
]
ASF subversion and git services commented on TS-4331:
-
Commit 53f75794c6911aba93fe39903bb39a346e3ef3d8 in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=53f7579 ]
TS-4331: Major re-write of hostdb (#653)
* Consolidate SRV `alive` checks to use the `alive` method on `HostDBInfo`
* TS-4331 Replace MultiCache with RefCountCache
* Misc cleanup to hostdb before cleanup
Before doing the rewrite of hostdb (TS-4331) this commit cleans up someo f the
method names etc. to make this subsystem less confusing
> Hostdb consistency problems due to MultiCache
> -
>
> Key: TS-4331
> URL: https://issues.apache.org/jira/browse/TS-4331
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> This ticket is for the correct long term fix to TS-4207
> pulled from a comment, which wraps up the issue
> {quote}
> Leif Hedstrom I have spent a decent amount of time on this while I was OOO on
> vacation the last couple of weeks. It seems that the root cause of this issue
> has always existed, and that the addition of always doing hostname storing
> (https://github.com/apache/trafficserver/commit/0e703e1e) we are just causing
> the issue to happen all the time.
> To understand the issue I'll give a little background in how hostdb is
> currently working. Basically hostdb is just a wrapper around this templated
> struct called MultiCache. MultiCache is "multi" not because it is templated,
> but because it has two types of storage (static-- blocks and dynamic--
> alloc). The static side of the cache can hold N HostDBInfo structs (the
> results of DNS queries). The dynamic side is used to store the round robin
> records and various strings associated with the record. The size of this
> dynamic space is defined as (N x [estimated_heap_bytes_per_entry. The basic
> problem we are running into is that we are putting too much preassure on the
> dynamic heap-- such that the heap is getting re-used while people still have
> references to items in that space.
> So, I've actually been working on re-writing MultiCache to allocate the
> entire required block at once (so we don't have this problem where the parent
> exists but not the children), but I'm not certain if we want such a change to
> go into the 6.x branch (I'm willing to discuss if we want). If we aren't
> comfortable with such a large change I suggest just accounting for the
> hostname size in the estimated_heap_bytes_per_entry as a stopgap solution.
> The maximum allowable size is 253 (so 254 with null terminator), but we could
> pick a smaller number (~120 or so seems to be more reasonable). Alternatively
> you can increase the number of records in hostdb (and the size accordingly)
> to increase the dynamic heap size.
> TLDR; almost done with the long term solution, but I'm not sure if we want to
> merge that into 6.x-- alternatively we can do a simple workaround in 6.x
> (https://github.com/apache/trafficserver/pull/553)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4331) Hostdb consistency problems due to MultiCache
[
https://issues.apache.org/jira/browse/TS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352110#comment-15352110
]
ASF subversion and git services commented on TS-4331:
-
Commit 53f75794c6911aba93fe39903bb39a346e3ef3d8 in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=53f7579 ]
TS-4331: Major re-write of hostdb (#653)
* Consolidate SRV `alive` checks to use the `alive` method on `HostDBInfo`
* TS-4331 Replace MultiCache with RefCountCache
* Misc cleanup to hostdb before cleanup
Before doing the rewrite of hostdb (TS-4331) this commit cleans up someo f the
method names etc. to make this subsystem less confusing
> Hostdb consistency problems due to MultiCache
> -
>
> Key: TS-4331
> URL: https://issues.apache.org/jira/browse/TS-4331
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> This ticket is for the correct long term fix to TS-4207
> pulled from a comment, which wraps up the issue
> {quote}
> Leif Hedstrom I have spent a decent amount of time on this while I was OOO on
> vacation the last couple of weeks. It seems that the root cause of this issue
> has always existed, and that the addition of always doing hostname storing
> (https://github.com/apache/trafficserver/commit/0e703e1e) we are just causing
> the issue to happen all the time.
> To understand the issue I'll give a little background in how hostdb is
> currently working. Basically hostdb is just a wrapper around this templated
> struct called MultiCache. MultiCache is "multi" not because it is templated,
> but because it has two types of storage (static-- blocks and dynamic--
> alloc). The static side of the cache can hold N HostDBInfo structs (the
> results of DNS queries). The dynamic side is used to store the round robin
> records and various strings associated with the record. The size of this
> dynamic space is defined as (N x [estimated_heap_bytes_per_entry. The basic
> problem we are running into is that we are putting too much preassure on the
> dynamic heap-- such that the heap is getting re-used while people still have
> references to items in that space.
> So, I've actually been working on re-writing MultiCache to allocate the
> entire required block at once (so we don't have this problem where the parent
> exists but not the children), but I'm not certain if we want such a change to
> go into the 6.x branch (I'm willing to discuss if we want). If we aren't
> comfortable with such a large change I suggest just accounting for the
> hostname size in the estimated_heap_bytes_per_entry as a stopgap solution.
> The maximum allowable size is 253 (so 254 with null terminator), but we could
> pick a smaller number (~120 or so seems to be more reasonable). Alternatively
> you can increase the number of records in hostdb (and the size accordingly)
> to increase the dynamic heap size.
> TLDR; almost done with the long term solution, but I'm not sure if we want to
> merge that into 6.x-- alternatively we can do a simple workaround in 6.x
> (https://github.com/apache/trafficserver/pull/553)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4331) Hostdb consistency problems due to MultiCache
[
https://issues.apache.org/jira/browse/TS-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15352109#comment-15352109
]
ASF subversion and git services commented on TS-4331:
-
Commit 53f75794c6911aba93fe39903bb39a346e3ef3d8 in trafficserver's branch
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=53f7579 ]
TS-4331: Major re-write of hostdb (#653)
* Consolidate SRV `alive` checks to use the `alive` method on `HostDBInfo`
* TS-4331 Replace MultiCache with RefCountCache
* Misc cleanup to hostdb before cleanup
Before doing the rewrite of hostdb (TS-4331) this commit cleans up someo f the
method names etc. to make this subsystem less confusing
> Hostdb consistency problems due to MultiCache
> -
>
> Key: TS-4331
> URL: https://issues.apache.org/jira/browse/TS-4331
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
>Reporter: Thomas Jackson
>Assignee: Thomas Jackson
> Fix For: 7.0.0
>
>
> This ticket is for the correct long term fix to TS-4207
> pulled from a comment, which wraps up the issue
> {quote}
> Leif Hedstrom I have spent a decent amount of time on this while I was OOO on
> vacation the last couple of weeks. It seems that the root cause of this issue
> has always existed, and that the addition of always doing hostname storing
> (https://github.com/apache/trafficserver/commit/0e703e1e) we are just causing
> the issue to happen all the time.
> To understand the issue I'll give a little background in how hostdb is
> currently working. Basically hostdb is just a wrapper around this templated
> struct called MultiCache. MultiCache is "multi" not because it is templated,
> but because it has two types of storage (static-- blocks and dynamic--
> alloc). The static side of the cache can hold N HostDBInfo structs (the
> results of DNS queries). The dynamic side is used to store the round robin
> records and various strings associated with the record. The size of this
> dynamic space is defined as (N x [estimated_heap_bytes_per_entry. The basic
> problem we are running into is that we are putting too much preassure on the
> dynamic heap-- such that the heap is getting re-used while people still have
> references to items in that space.
> So, I've actually been working on re-writing MultiCache to allocate the
> entire required block at once (so we don't have this problem where the parent
> exists but not the children), but I'm not certain if we want such a change to
> go into the 6.x branch (I'm willing to discuss if we want). If we aren't
> comfortable with such a large change I suggest just accounting for the
> hostname size in the estimated_heap_bytes_per_entry as a stopgap solution.
> The maximum allowable size is 253 (so 254 with null terminator), but we could
> pick a smaller number (~120 or so seems to be more reasonable). Alternatively
> you can increase the number of records in hostdb (and the size accordingly)
> to increase the dynamic heap size.
> TLDR; almost done with the long term solution, but I'm not sure if we want to
> merge that into 6.x-- alternatively we can do a simple workaround in 6.x
> (https://github.com/apache/trafficserver/pull/553)
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4449) header_rewrite: Improve TSDebug() statements
[
https://issues.apache.org/jira/browse/TS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351501#comment-15351501
]
ASF subversion and git services commented on TS-4449:
-
Commit 56c0a6755398f283a11f4fc9f8581d3258b09524 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=56c0a67 ]
TS-4449 Cleanup of coding style
> header_rewrite: Improve TSDebug() statements
>
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Right now, it can be difficult at times to understand why header_rewrite
> isn't behaving as you'd expect. There are a number of places where we can
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with
> our current best practices (e.g. use if () { } consistently).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4449) header_rewrite: Improve TSDebug() statements
[
https://issues.apache.org/jira/browse/TS-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351502#comment-15351502
]
ASF subversion and git services commented on TS-4449:
-
Commit b905a52a4a7a0a3d05966bc1a74ee6407cf94c39 in trafficserver's branch
refs/heads/master from [~zwoop]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b905a52 ]
TS-4449 Better errors and debug output
This does a few things:
1. Better error reports when parsing a config file
2. Better diagnostics when debugging expressions
I also added an example to the docs, for a common use case that
turns out to be non-obvious.
> header_rewrite: Improve TSDebug() statements
>
>
> Key: TS-4449
> URL: https://issues.apache.org/jira/browse/TS-4449
> Project: Traffic Server
> Issue Type: Improvement
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Leif Hedstrom
> Fix For: 7.0.0
>
>
> Right now, it can be difficult at times to understand why header_rewrite
> isn't behaving as you'd expect. There are a number of places where we can
> improve TSDebug().
> Also, I'm going to do a code cleanup here, to make the code more inline with
> our current best practices (e.g. use if () { } consistently).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4518) UUID and HttpSM ID APIs and Machine support for a process UUID
[ https://issues.apache.org/jira/browse/TS-4518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351468#comment-15351468 ] ASF subversion and git services commented on TS-4518: - Commit 9f774fb656b44930375746e63df1b2cdb583bd18 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9f774fb ] TS-4518 Add the basic APIs and code for UUIDs > UUID and HttpSM ID APIs and Machine support for a process UUID > -- > > Key: TS-4518 > URL: https://issues.apache.org/jira/browse/TS-4518 > Project: Traffic Server > Issue Type: New Feature > Components: Core, TS API >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > As was discussed on https://github.com/apache/trafficserver/pull/199, I've > started the work to generalize this, and breaking it up in various parts. > This first Jira is about adding four things: > 1) An internal process UUID, which goes into Machine. It's accessible from > the core. > 2) An API to get this Machine UUID. > 3) A set of generic UUID APIs, to do things like stringification, Copy() etc. > 4) A very simple API that exposes the HttpSM's sequences number (sm_id). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4589) Coalesce CPPAPI examples build.
[
https://issues.apache.org/jira/browse/TS-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350246#comment-15350246
]
ASF subversion and git services commented on TS-4589:
-
Commit e9b68c3ac377528eaafb2310b4d97d2e0676c9b0 in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e9b68c3 ]
TS-4589: Coalesce CPP API examples build.
The CPP API examples all have trivial, identical makefiles. Coalesce
these like we did to the TSAPI examples to parallelize the build,
remove duplication and support the --enable-example-plugins build
option.
> Coalesce CPPAPI examples build.
> ---
>
> Key: TS-4589
> URL: https://issues.apache.org/jira/browse/TS-4589
> Project: Traffic Server
> Issue Type: Improvement
> Components: CPP API
>Reporter: James Peach
>Assignee: Brian Geffon
> Fix For: 7.0.0
>
>
> The CPP API examples all have trivial, identical makefiles. We should
> coalesce these like we did to the TSAPI examples to parallelize the build,
> result duplication and support the {{\--enable-example-plugins}} build option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4589) Coalesce CPPAPI examples build.
[
https://issues.apache.org/jira/browse/TS-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15350247#comment-15350247
]
ASF subversion and git services commented on TS-4589:
-
Commit 1136124d03add739cc36498e253bd6f0dfd1b70a in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1136124 ]
Merge pull request #742 from jpeach/fix/4589
TS-4589: Coalesce CPP API examples build.
> Coalesce CPPAPI examples build.
> ---
>
> Key: TS-4589
> URL: https://issues.apache.org/jira/browse/TS-4589
> Project: Traffic Server
> Issue Type: Improvement
> Components: CPP API
>Reporter: James Peach
>Assignee: Brian Geffon
> Fix For: 7.0.0
>
>
> The CPP API examples all have trivial, identical makefiles. We should
> coalesce these like we did to the TSAPI examples to parallelize the build,
> result duplication and support the {{\--enable-example-plugins}} build option.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4483) NetAccept & SSLNetAccept Optimize
[ https://issues.apache.org/jira/browse/TS-4483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15349846#comment-15349846 ] ASF subversion and git services commented on TS-4483: - Commit 80d865300794e70b828ba04330d732503b2ea5f1 in trafficserver's branch refs/heads/master from [~oknet] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=80d8653 ] TS-4483: Simplify NetAccept and SSLNetAccept. Replace getEtype() with member etype. NetAccept has a member named 'etype' and it is set by upgradeEtype before NetAccept running. Thus, we can replace getEtype() with member etype and make the SSLNetAccept codes clearly. This closes #734. > NetAccept & SSLNetAccept Optimize > - > > Key: TS-4483 > URL: https://issues.apache.org/jira/browse/TS-4483 > Project: Traffic Server > Issue Type: Improvement > Components: Core >Reporter: Oknet Xu >Assignee: Oknet Xu > Fix For: 7.0.0 > > > replace getEtype() with member etype. > NetAccept has a member named 'etype' and it is set by upgradeEtype before > NetAccept running. > Thus, we can replace getEtype() with member etype and make the SSLNetAccept > codes clearly. > Should we remote the getEtype() method ? It is called by none after the patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4577) Coverity Resource leaks in remap_stats.cc
[
https://issues.apache.org/jira/browse/TS-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348590#comment-15348590
]
ASF subversion and git services commented on TS-4577:
-
Commit 0ee06bf5394ec98c292eaa6664b384ea238404f0 in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0ee06bf ]
Merge pull request #738 from strotyl/TS-4577
TS-4577 remap_stats: Fix memory leak
> Coverity Resource leaks in remap_stats.cc
> -
>
> Key: TS-4577
> URL: https://issues.apache.org/jira/browse/TS-4577
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Tyler Stroh
> Fix For: 7.0.0
>
>
> {code}
> ** CID 1356996: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
>
> *** CID 1356996: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
> 99 TSMLoc url_loc;
> 100
> 101 effective_url = TSHttpTxnEffectiveUrlStringGet(txn, );
> 102 buf = TSMBufferCreate();
> 103 if (TS_SUCCESS != TSUrlCreate(buf, _loc)) {
> 104 TSDebug(DEBUG_TAG, "unable to create url");
>CID 1356996: Resource leaks (RESOURCE_LEAK)
>Variable "buf" going out of scope leaks the storage it points to.
> 105 return NULL;
> 106 }
> 107 tmp = effective_url;
> 108 TSUrlParse(buf, url_loc, (const char **)(), (const char
> *)(effective_url + len));
> 109 TSfree(effective_url);
> 110 host = TSUrlHostGet(buf, url_loc, );
> ** CID 1356995: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
>
> *** CID 1356995: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
> 99 TSMLoc url_loc;
> 100
> 101 effective_url = TSHttpTxnEffectiveUrlStringGet(txn, );
> 102 buf = TSMBufferCreate();
> 103 if (TS_SUCCESS != TSUrlCreate(buf, _loc)) {
> 104 TSDebug(DEBUG_TAG, "unable to create url");
>CID 1356995: Resource leaks (RESOURCE_LEAK)
>Variable "effective_url" going out of scope leaks the storage it points to.
> 105 return NULL;
> 106 }
> 107 tmp = effective_url;
> 108 TSUrlParse(buf, url_loc, (const char **)(), (const char
> *)(effective_url + len));
> 109 TSfree(effective_url);
> 110 host = TSUrlHostGet(buf, url_loc, );
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4577) Coverity Resource leaks in remap_stats.cc
[
https://issues.apache.org/jira/browse/TS-4577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348588#comment-15348588
]
ASF subversion and git services commented on TS-4577:
-
Commit 0ee06bf5394ec98c292eaa6664b384ea238404f0 in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0ee06bf ]
Merge pull request #738 from strotyl/TS-4577
TS-4577 remap_stats: Fix memory leak
> Coverity Resource leaks in remap_stats.cc
> -
>
> Key: TS-4577
> URL: https://issues.apache.org/jira/browse/TS-4577
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
>Reporter: Leif Hedstrom
>Assignee: Tyler Stroh
> Fix For: 7.0.0
>
>
> {code}
> ** CID 1356996: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
>
> *** CID 1356996: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
> 99 TSMLoc url_loc;
> 100
> 101 effective_url = TSHttpTxnEffectiveUrlStringGet(txn, );
> 102 buf = TSMBufferCreate();
> 103 if (TS_SUCCESS != TSUrlCreate(buf, _loc)) {
> 104 TSDebug(DEBUG_TAG, "unable to create url");
>CID 1356996: Resource leaks (RESOURCE_LEAK)
>Variable "buf" going out of scope leaks the storage it points to.
> 105 return NULL;
> 106 }
> 107 tmp = effective_url;
> 108 TSUrlParse(buf, url_loc, (const char **)(), (const char
> *)(effective_url + len));
> 109 TSfree(effective_url);
> 110 host = TSUrlHostGet(buf, url_loc, );
> ** CID 1356995: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
>
> *** CID 1356995: Resource leaks (RESOURCE_LEAK)
> /plugins/experimental/remap_stats/remap_stats.c: 105 in get_effective_host()
> 99 TSMLoc url_loc;
> 100
> 101 effective_url = TSHttpTxnEffectiveUrlStringGet(txn, );
> 102 buf = TSMBufferCreate();
> 103 if (TS_SUCCESS != TSUrlCreate(buf, _loc)) {
> 104 TSDebug(DEBUG_TAG, "unable to create url");
>CID 1356995: Resource leaks (RESOURCE_LEAK)
>Variable "effective_url" going out of scope leaks the storage it points to.
> 105 return NULL;
> 106 }
> 107 tmp = effective_url;
> 108 TSUrlParse(buf, url_loc, (const char **)(), (const char
> *)(effective_url + len));
> 109 TSfree(effective_url);
> 110 host = TSUrlHostGet(buf, url_loc, );
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4565) clang_format: Align assignment on the =
[ https://issues.apache.org/jira/browse/TS-4565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345231#comment-15345231 ] ASF subversion and git services commented on TS-4565: - Commit e384a7e57a4caa72cddaf8077c61548862f73e40 in trafficserver's branch refs/heads/6.2.x from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e384a7e ] TS-4565 Enables clang_format AlignConsecutiveAssignments (cherry picked from commit 67c23f8e6e7c76dbb81ef7e2f3e0a53baba349e9) > clang_format: Align assignment on the = > --- > > Key: TS-4565 > URL: https://issues.apache.org/jira/browse/TS-4565 > Project: Traffic Server > Issue Type: Improvement > Components: Build >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > -AlignConsecutiveAssignments: false > +AlignConsecutiveAssignments: true -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4470) ASAN stack-buffer-overflow when slow log is enabled
[ https://issues.apache.org/jira/browse/TS-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345228#comment-15345228 ] ASF subversion and git services commented on TS-4470: - Commit 8d9bfb3b5b0c6750716d2e05f6182c87045c3dec in trafficserver's branch refs/heads/6.2.x from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8d9bfb3 ] TS-4470: ASAN stack-buffer-overflow when slow log is enabled Update to use offset (cherry picked from commit 639a081ab4a8ff9306b02834a9dc5b028f23501a) > ASAN stack-buffer-overflow when slow log is enabled > --- > > Key: TS-4470 > URL: https://issues.apache.org/jira/browse/TS-4470 > Project: Traffic Server > Issue Type: Bug >Affects Versions: 6.2.0 >Reporter: Bryan Call >Assignee: Bryan Call >Priority: Blocker > Fix For: 6.2.0, 7.0.0 > > > = > ==13159==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x2b5ec8877660 at pc 0x004fcdf1 bp 0x2b5ec8875c60 sp 0x2b5ec8875410 > READ of size 260 at 0x2b5ec8877660 thread T21 ([ET_NET 20]) > #0 0x4fcdf0 in printf_common(void*, char const*, __va_list_tag*) [clone > .isra.6] (/usr/local/bin/traffic_server+0x4fcdf0) > #1 0x4fd744 in vfprintf (/usr/local/bin/traffic_server+0x4fd744) > #2 0x2b5ec1a668ee in vprintline<1024> > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:61 > #3 0x2b5ec1a668ee in Diags::print_va(char const*, DiagsLevel, SrcLoc > const*, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:340 > #4 0x2b5ec1a6765f in Diags::error_va(DiagsLevel, char const*, char > const*, int, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:572 > #5 0x72a724 in Diags::error(DiagsLevel, char const*, char const*, int, > char const*, ...) const /home/bcall/dev/trafficserver/lib/ts/Diags.h:242 > #6 0x7455d6 in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6972 > #7 0x77b07f in HttpSM::kill_this() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6786 > #8 0x77d6f7 in HttpSM::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:2660 > #9 0x832d3a in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #10 0x832d3a in HttpTunnel::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpTunnel.cc:1637 > #11 0xcfdbb5 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #12 0xcfdbb5 in write_signal_and_update > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:181 > #13 0xcfdbb5 in write_signal_done > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:223 > #14 0xcfdbb5 in write_to_net_io(NetHandler*, UnixNetVConnection*, > EThread*) /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:563 > #15 0xcbc4ca in NetHandler::mainNetEvent(int, Event*) > /home/bcall/dev/trafficserver/iocore/net/UnixNet.cc:529 > #16 0xda8ce3 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #17 0xda8ce3 in EThread::process_event(Event*, int) > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:148 > #18 0xdabc8a in EThread::execute() > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:275 > #19 0xda7a58 in spawn_thread_internal > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:86 > #20 0x2b5ec2264aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0) > #21 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c) > Address 0x2b5ec8877660 is located in stack of thread T21 ([ET_NET 20]) at > offset 736 in frame > #0 0x7443ef in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6827 > This frame has 6 object(s): > [32, 36) 'offset' > [96, 100) 'skip' > [160, 164) 'length' > [224, 270) 'client_ip' > [320, 448) 'unique_id_string' > [480, 736) 'url_string' <== Memory access at offset 736 overflows this > variable > HINT: this may be a false positive if your program uses some custom stack > unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T21 ([ET_NET 20]) created by T0 ([ET_NET 0]) here: > #0 0x4d50b4 in pthread_create (/usr/local/bin/traffic_server+0x4d50b4) > #1 0xda85aa in ink_thread_create > /home/bcall/dev/trafficserver/lib/ts/ink_thread.h:147 > #2 0xda85aa in Thread::start(char const*, unsigned long, void* > (*)(void*), void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:101 > #3 0xdafff2 in
[jira] [Commented] (TS-4568) Milestones where changed from seconds to milliseconds
[
https://issues.apache.org/jira/browse/TS-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345230#comment-15345230
]
ASF subversion and git services commented on TS-4568:
-
Commit fbbe33e03fd43727544330487580c6c3d9a3f786 in trafficserver's branch
refs/heads/6.2.x from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=fbbe33e ]
TS-4568: Milestones where changed from seconds to milliseconds
> Milestones where changed from seconds to milliseconds
> -
>
> Key: TS-4568
> URL: https://issues.apache.org/jira/browse/TS-4568
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 6.2.0, 7.0.0
>
>
> Sleeping for 1 seconds on the origin shows 999 seconds in slow log:
> {code}
> [Jun 21 10:55:02.763] Server {0x7f33a565b8c0} ERROR: (update_stats)> [0] Slow Request: client_ip: 127.0.0.1:48486 url:
> http://127.0.0.1:80/sleep.php?slfkjasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskdjfhalsdkhflsdhjfaslfsdfdasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskd
> status: 200 unique id: redirection_tries: 0 bytes: 2 fd: 0 client state: 0
> server state: 9 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done:
> 0.000 cache_open_read_begin: 0.000 cache_open_read_end: 0.000
> dns_lookup_begin: -1.000 dns_lookup_end: -1.000 server_connect: 0.000
> server_first_read: 999.000 server_read_header_done: 999.000 server_close:
> 999.000 ua_close: 999.000 sm_finish: 999.000 plugin_active: -1.000
> plugin_total: -1.000
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4571) Fix "pointer to local outside scope" (CID 1356978)
[
https://issues.apache.org/jira/browse/TS-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345229#comment-15345229
]
ASF subversion and git services commented on TS-4571:
-
Commit 1034f6cc764104457f31b6c4369c28bce8241fa5 in trafficserver's branch
refs/heads/6.2.x from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1034f6c ]
TS-4571: Fix "pointer to local outside scope" (CID 1356978) (#727)
(cherry picked from commit 0597cfefed63ec29fd210953226da89b25bf9f15)
> Fix "pointer to local outside scope" (CID 1356978)
> --
>
> Key: TS-4571
> URL: https://issues.apache.org/jira/browse/TS-4571
> Project: Traffic Server
> Issue Type: Bug
> Components: Parent Proxy
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 6.2.0, 7.0.0
>
>
> {noformat}
> Dereferencing the returned or out-of-scope stack pointer will access an
> invalid location on the stack after its scope or after the function returns.
> In ParentRecord::Init(matcher_line *): Pointer to a local stack variable
> returned or used outside scope (CWE-562)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4572) Fix "Unchecked return value" (CID 1356972)
[
https://issues.apache.org/jira/browse/TS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345134#comment-15345134
]
ASF subversion and git services commented on TS-4572:
-
Commit 2d6052f0dc2a57ad70c58c2319a0fd7aaea4a07d in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2d6052f ]
Merge pull request #728 from PSUdaemon/TS-4572
TS-4572: Fix "Unchecked return value" (CID 1356972)
> Fix "Unchecked return value" (CID 1356972)
> --
>
> Key: TS-4572
> URL: https://issues.apache.org/jira/browse/TS-4572
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.0.0
>
>
> {noformat}
> If the function returns an error value, the error value may be mistaken for a
> normal value.
> In get_effective_host: Value returned from a function is not checked for
> errors before being used (CWE-252)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4572) Fix "Unchecked return value" (CID 1356972)
[
https://issues.apache.org/jira/browse/TS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345133#comment-15345133
]
ASF subversion and git services commented on TS-4572:
-
Commit 3a3cb0ac6e3e4af2023c78f7cfc942f2318e2719 in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3a3cb0a ]
TS-4572: Fix "Unchecked return value" (CID 1356972)
> Fix "Unchecked return value" (CID 1356972)
> --
>
> Key: TS-4572
> URL: https://issues.apache.org/jira/browse/TS-4572
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.0.0
>
>
> {noformat}
> If the function returns an error value, the error value may be mistaken for a
> normal value.
> In get_effective_host: Value returned from a function is not checked for
> errors before being used (CWE-252)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4572) Fix "Unchecked return value" (CID 1356972)
[
https://issues.apache.org/jira/browse/TS-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345135#comment-15345135
]
ASF subversion and git services commented on TS-4572:
-
Commit 2d6052f0dc2a57ad70c58c2319a0fd7aaea4a07d in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2d6052f ]
Merge pull request #728 from PSUdaemon/TS-4572
TS-4572: Fix "Unchecked return value" (CID 1356972)
> Fix "Unchecked return value" (CID 1356972)
> --
>
> Key: TS-4572
> URL: https://issues.apache.org/jira/browse/TS-4572
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.0.0
>
>
> {noformat}
> If the function returns an error value, the error value may be mistaken for a
> normal value.
> In get_effective_host: Value returned from a function is not checked for
> errors before being used (CWE-252)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4571) Fix "pointer to local outside scope" (CID 1356978)
[
https://issues.apache.org/jira/browse/TS-4571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15345128#comment-15345128
]
ASF subversion and git services commented on TS-4571:
-
Commit 0597cfefed63ec29fd210953226da89b25bf9f15 in trafficserver's branch
refs/heads/master from [~psudaemon]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=0597cfe ]
TS-4571: Fix "pointer to local outside scope" (CID 1356978) (#727)
> Fix "pointer to local outside scope" (CID 1356978)
> --
>
> Key: TS-4571
> URL: https://issues.apache.org/jira/browse/TS-4571
> Project: Traffic Server
> Issue Type: Bug
> Components: Parent Proxy
>Reporter: Phil Sorber
>Assignee: Phil Sorber
> Fix For: 7.0.0
>
>
> {noformat}
> Dereferencing the returned or out-of-scope stack pointer will access an
> invalid location on the stack after its scope or after the function returns.
> In ParentRecord::Init(matcher_line *): Pointer to a local stack variable
> returned or used outside scope (CWE-562)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344610#comment-15344610 ] ASF subversion and git services commented on TS-4569: - Commit 9c672bd5cc730916868e6fec08eef32dfe83c5d7 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=9c672bd ] TS-4569: New Coverity issues found in updated scan Fixed issues: 1356980 and 1356979 > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344612#comment-15344612 ] ASF subversion and git services commented on TS-4569: - Commit 6a5631c34a13abf6cf0d896e4c8c2016106360be in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6a5631c ] Merge pull request #730 from bryancall/TS-4569_2 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344605#comment-15344605 ] ASF subversion and git services commented on TS-4569: - Commit 4e9173338224961045a30bc7ad9ad8043773300b in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4e91733 ] TS-4569: New Coverity issues found in updated scan Fixed issues: 1356977 > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344607#comment-15344607 ] ASF subversion and git services commented on TS-4569: - Commit 40597408a180ba4fa5e08fa56ba34b447ebd91ea in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4059740 ] Merge pull request #731 from bryancall/TS-4569_3 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344606#comment-15344606 ] ASF subversion and git services commented on TS-4569: - Commit 40597408a180ba4fa5e08fa56ba34b447ebd91ea in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=4059740 ] Merge pull request #731 from bryancall/TS-4569_3 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15344611#comment-15344611 ] ASF subversion and git services commented on TS-4569: - Commit 6a5631c34a13abf6cf0d896e4c8c2016106360be in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6a5631c ] Merge pull request #730 from bryancall/TS-4569_2 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4500) add cookie-rewrite functionality into header-rewrite plugin
[ https://issues.apache.org/jira/browse/TS-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343198#comment-15343198 ] ASF subversion and git services commented on TS-4500: - Commit a59dea0491fa21d5255e7ae8098031563896dfa2 in trafficserver's branch refs/heads/master from [~zhangzizhong] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a59dea0 ] TS-4500: add cookie-rewrite functionality into header-rewrite plugin > add cookie-rewrite functionality into header-rewrite plugin > --- > > Key: TS-4500 > URL: https://issues.apache.org/jira/browse/TS-4500 > Project: Traffic Server > Issue Type: New Feature > Components: Plugins >Reporter: Zhang Zizhong >Assignee: Zhang Zizhong > Fix For: 7.0.0 > > > add cookie-rewrite functionality into header-rewrite plugin. > There're three cookie handling operators added, including *add-cookie*, > *rm-cookie* and *update-cookie*. > *add-cookie* adds a key-value pair into Cookie. If the given key is already > in Cookie, do nothing. > *rm-cookie* remove a pair with the given key from Cookie. > *update-cookie* sets the value with the given key to the given value. If the > given key doesn't exist, add a new pair into Cookie. So the only difference > between *add-cookie* and *update-cookie* is overwriting an existing pair or > not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4500) add cookie-rewrite functionality into header-rewrite plugin
[ https://issues.apache.org/jira/browse/TS-4500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15343199#comment-15343199 ] ASF subversion and git services commented on TS-4500: - Commit d2f6c9c556f83e21a69c05e8299d0a038032a8bf in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=d2f6c9c ] Merge pull request #692 from zizhong/headerrewrite [TS-4500] header_rewrite: adds cookie-rewrite functionality > add cookie-rewrite functionality into header-rewrite plugin > --- > > Key: TS-4500 > URL: https://issues.apache.org/jira/browse/TS-4500 > Project: Traffic Server > Issue Type: New Feature > Components: Plugins >Reporter: Zhang Zizhong >Assignee: Zhang Zizhong > Fix For: 7.0.0 > > > add cookie-rewrite functionality into header-rewrite plugin. > There're three cookie handling operators added, including *add-cookie*, > *rm-cookie* and *update-cookie*. > *add-cookie* adds a key-value pair into Cookie. If the given key is already > in Cookie, do nothing. > *rm-cookie* remove a pair with the given key from Cookie. > *update-cookie* sets the value with the given key to the given value. If the > given key doesn't exist, add a new pair into Cookie. So the only difference > between *add-cookie* and *update-cookie* is overwriting an existing pair or > not. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342757#comment-15342757 ] ASF subversion and git services commented on TS-4569: - Commit 97d6e2ba5ec9b9c785e9324d0195efc97f92c1d2 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=97d6e2b ] Merge pull request #726 from bryancall/TS-4569 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342762#comment-15342762 ] ASF subversion and git services commented on TS-4569: - Commit 2b60f93cce5c1ba2d4ed3f35acb795455b6707f0 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2b60f93 ] Merge pull request #729 from bryancall/TS-4569_1 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342760#comment-15342760 ] ASF subversion and git services commented on TS-4569: - Commit 26ec8cb478b1c6aafd6f1f6877dcffac4f5db022 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=26ec8cb ] TS-4569: New Coverity issues found in updated scan Fixed issues: 1356981 and 1356983 > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342758#comment-15342758 ] ASF subversion and git services commented on TS-4569: - Commit 97d6e2ba5ec9b9c785e9324d0195efc97f92c1d2 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=97d6e2b ] Merge pull request #726 from bryancall/TS-4569 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342761#comment-15342761 ] ASF subversion and git services commented on TS-4569: - Commit 2b60f93cce5c1ba2d4ed3f35acb795455b6707f0 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=2b60f93 ] Merge pull request #729 from bryancall/TS-4569_1 TS-4569: New Coverity issues found in updated scan > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4569) New Coverity issues found in updated scan
[ https://issues.apache.org/jira/browse/TS-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342756#comment-15342756 ] ASF subversion and git services commented on TS-4569: - Commit e5255f48326a9cff4b76d05969b520f3e93ec2e2 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=e5255f4 ] TS-4569: New Coverity issues found in updated scan Fixes for issues: 1356985, 1356984, and 1356982 > New Coverity issues found in updated scan > - > > Key: TS-4569 > URL: https://issues.apache.org/jira/browse/TS-4569 > Project: Traffic Server > Issue Type: Bug > Components: Cache, Core, HTTP, HTTP/2 >Reporter: Bryan Call > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4568) Milestones where changed from seconds to milliseconds
[
https://issues.apache.org/jira/browse/TS-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342406#comment-15342406
]
ASF subversion and git services commented on TS-4568:
-
Commit 7b4b5825397ef289dc8b8f9e57983a9c00711cb9 in trafficserver's branch
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7b4b582 ]
Merge pull request #725 from bryancall/TS-4568
TS-4568: Milestones where changed from seconds to milliseconds
> Milestones where changed from seconds to milliseconds
> -
>
> Key: TS-4568
> URL: https://issues.apache.org/jira/browse/TS-4568
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>
> Sleeping for 1 seconds on the origin shows 999 seconds in slow log:
> {code}
> [Jun 21 10:55:02.763] Server {0x7f33a565b8c0} ERROR: (update_stats)> [0] Slow Request: client_ip: 127.0.0.1:48486 url:
> http://127.0.0.1:80/sleep.php?slfkjasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskdjfhalsdkhflsdhjfaslfsdfdasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskd
> status: 200 unique id: redirection_tries: 0 bytes: 2 fd: 0 client state: 0
> server state: 9 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done:
> 0.000 cache_open_read_begin: 0.000 cache_open_read_end: 0.000
> dns_lookup_begin: -1.000 dns_lookup_end: -1.000 server_connect: 0.000
> server_first_read: 999.000 server_read_header_done: 999.000 server_close:
> 999.000 ua_close: 999.000 sm_finish: 999.000 plugin_active: -1.000
> plugin_total: -1.000
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4568) Milestones where changed from seconds to milliseconds
[
https://issues.apache.org/jira/browse/TS-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342405#comment-15342405
]
ASF subversion and git services commented on TS-4568:
-
Commit b91cc9f40e5c9221d02c48c3cb14d00b87b86bb8 in trafficserver's branch
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=b91cc9f ]
TS-4568: Milestones where changed from seconds to milliseconds
> Milestones where changed from seconds to milliseconds
> -
>
> Key: TS-4568
> URL: https://issues.apache.org/jira/browse/TS-4568
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>
> Sleeping for 1 seconds on the origin shows 999 seconds in slow log:
> {code}
> [Jun 21 10:55:02.763] Server {0x7f33a565b8c0} ERROR: (update_stats)> [0] Slow Request: client_ip: 127.0.0.1:48486 url:
> http://127.0.0.1:80/sleep.php?slfkjasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskdjfhalsdkhflsdhjfaslfsdfdasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskd
> status: 200 unique id: redirection_tries: 0 bytes: 2 fd: 0 client state: 0
> server state: 9 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done:
> 0.000 cache_open_read_begin: 0.000 cache_open_read_end: 0.000
> dns_lookup_begin: -1.000 dns_lookup_end: -1.000 server_connect: 0.000
> server_first_read: 999.000 server_read_header_done: 999.000 server_close:
> 999.000 ua_close: 999.000 sm_finish: 999.000 plugin_active: -1.000
> plugin_total: -1.000
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4568) Milestones where changed from seconds to milliseconds
[
https://issues.apache.org/jira/browse/TS-4568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342407#comment-15342407
]
ASF subversion and git services commented on TS-4568:
-
Commit 7b4b5825397ef289dc8b8f9e57983a9c00711cb9 in trafficserver's branch
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7b4b582 ]
Merge pull request #725 from bryancall/TS-4568
TS-4568: Milestones where changed from seconds to milliseconds
> Milestones where changed from seconds to milliseconds
> -
>
> Key: TS-4568
> URL: https://issues.apache.org/jira/browse/TS-4568
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
>Affects Versions: 6.2.0
>Reporter: Bryan Call
>Assignee: Bryan Call
> Fix For: 7.0.0
>
>
> Sleeping for 1 seconds on the origin shows 999 seconds in slow log:
> {code}
> [Jun 21 10:55:02.763] Server {0x7f33a565b8c0} ERROR: (update_stats)> [0] Slow Request: client_ip: 127.0.0.1:48486 url:
> http://127.0.0.1:80/sleep.php?slfkjasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskdjfhalsdkhflsdhjfaslfsdfdasdflkajsdfl;kajsdf;lkajsf;alksjdf;alksjdflaksjfl;askjdflaskdfjaksljdfhalskd
> status: 200 unique id: redirection_tries: 0 bytes: 2 fd: 0 client state: 0
> server state: 9 ua_begin: 0.000 ua_first_read: 0.000 ua_read_header_done:
> 0.000 cache_open_read_begin: 0.000 cache_open_read_end: 0.000
> dns_lookup_begin: -1.000 dns_lookup_end: -1.000 server_connect: 0.000
> server_first_read: 999.000 server_read_header_done: 999.000 server_close:
> 999.000 ua_close: 999.000 sm_finish: 999.000 plugin_active: -1.000
> plugin_total: -1.000
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4470) ASAN stack-buffer-overflow when slow log is enabled
[ https://issues.apache.org/jira/browse/TS-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342200#comment-15342200 ] ASF subversion and git services commented on TS-4470: - Commit ebbd54bd0592686ba0fbc6b53972ddb586a52c71 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ebbd54b ] Merge pull request #724 from bryancall/TS-4470 TS-4470: ASAN stack-buffer-overflow when slow log is enabled > ASAN stack-buffer-overflow when slow log is enabled > --- > > Key: TS-4470 > URL: https://issues.apache.org/jira/browse/TS-4470 > Project: Traffic Server > Issue Type: Bug >Affects Versions: 6.2.0 >Reporter: Bryan Call >Assignee: Bryan Call >Priority: Blocker > Fix For: 6.2.0, 7.0.0 > > > = > ==13159==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x2b5ec8877660 at pc 0x004fcdf1 bp 0x2b5ec8875c60 sp 0x2b5ec8875410 > READ of size 260 at 0x2b5ec8877660 thread T21 ([ET_NET 20]) > #0 0x4fcdf0 in printf_common(void*, char const*, __va_list_tag*) [clone > .isra.6] (/usr/local/bin/traffic_server+0x4fcdf0) > #1 0x4fd744 in vfprintf (/usr/local/bin/traffic_server+0x4fd744) > #2 0x2b5ec1a668ee in vprintline<1024> > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:61 > #3 0x2b5ec1a668ee in Diags::print_va(char const*, DiagsLevel, SrcLoc > const*, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:340 > #4 0x2b5ec1a6765f in Diags::error_va(DiagsLevel, char const*, char > const*, int, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:572 > #5 0x72a724 in Diags::error(DiagsLevel, char const*, char const*, int, > char const*, ...) const /home/bcall/dev/trafficserver/lib/ts/Diags.h:242 > #6 0x7455d6 in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6972 > #7 0x77b07f in HttpSM::kill_this() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6786 > #8 0x77d6f7 in HttpSM::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:2660 > #9 0x832d3a in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #10 0x832d3a in HttpTunnel::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpTunnel.cc:1637 > #11 0xcfdbb5 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #12 0xcfdbb5 in write_signal_and_update > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:181 > #13 0xcfdbb5 in write_signal_done > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:223 > #14 0xcfdbb5 in write_to_net_io(NetHandler*, UnixNetVConnection*, > EThread*) /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:563 > #15 0xcbc4ca in NetHandler::mainNetEvent(int, Event*) > /home/bcall/dev/trafficserver/iocore/net/UnixNet.cc:529 > #16 0xda8ce3 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #17 0xda8ce3 in EThread::process_event(Event*, int) > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:148 > #18 0xdabc8a in EThread::execute() > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:275 > #19 0xda7a58 in spawn_thread_internal > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:86 > #20 0x2b5ec2264aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0) > #21 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c) > Address 0x2b5ec8877660 is located in stack of thread T21 ([ET_NET 20]) at > offset 736 in frame > #0 0x7443ef in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6827 > This frame has 6 object(s): > [32, 36) 'offset' > [96, 100) 'skip' > [160, 164) 'length' > [224, 270) 'client_ip' > [320, 448) 'unique_id_string' > [480, 736) 'url_string' <== Memory access at offset 736 overflows this > variable > HINT: this may be a false positive if your program uses some custom stack > unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T21 ([ET_NET 20]) created by T0 ([ET_NET 0]) here: > #0 0x4d50b4 in pthread_create (/usr/local/bin/traffic_server+0x4d50b4) > #1 0xda85aa in ink_thread_create > /home/bcall/dev/trafficserver/lib/ts/ink_thread.h:147 > #2 0xda85aa in Thread::start(char const*, unsigned long, void* > (*)(void*), void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:101 > #3 0xdafff2 in EventProcessor::start(int, unsigned long) >
[jira] [Commented] (TS-4470) ASAN stack-buffer-overflow when slow log is enabled
[ https://issues.apache.org/jira/browse/TS-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342199#comment-15342199 ] ASF subversion and git services commented on TS-4470: - Commit ebbd54bd0592686ba0fbc6b53972ddb586a52c71 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ebbd54b ] Merge pull request #724 from bryancall/TS-4470 TS-4470: ASAN stack-buffer-overflow when slow log is enabled > ASAN stack-buffer-overflow when slow log is enabled > --- > > Key: TS-4470 > URL: https://issues.apache.org/jira/browse/TS-4470 > Project: Traffic Server > Issue Type: Bug >Affects Versions: 6.2.0 >Reporter: Bryan Call >Assignee: Bryan Call >Priority: Blocker > Fix For: 6.2.0, 7.0.0 > > > = > ==13159==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x2b5ec8877660 at pc 0x004fcdf1 bp 0x2b5ec8875c60 sp 0x2b5ec8875410 > READ of size 260 at 0x2b5ec8877660 thread T21 ([ET_NET 20]) > #0 0x4fcdf0 in printf_common(void*, char const*, __va_list_tag*) [clone > .isra.6] (/usr/local/bin/traffic_server+0x4fcdf0) > #1 0x4fd744 in vfprintf (/usr/local/bin/traffic_server+0x4fd744) > #2 0x2b5ec1a668ee in vprintline<1024> > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:61 > #3 0x2b5ec1a668ee in Diags::print_va(char const*, DiagsLevel, SrcLoc > const*, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:340 > #4 0x2b5ec1a6765f in Diags::error_va(DiagsLevel, char const*, char > const*, int, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:572 > #5 0x72a724 in Diags::error(DiagsLevel, char const*, char const*, int, > char const*, ...) const /home/bcall/dev/trafficserver/lib/ts/Diags.h:242 > #6 0x7455d6 in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6972 > #7 0x77b07f in HttpSM::kill_this() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6786 > #8 0x77d6f7 in HttpSM::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:2660 > #9 0x832d3a in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #10 0x832d3a in HttpTunnel::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpTunnel.cc:1637 > #11 0xcfdbb5 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #12 0xcfdbb5 in write_signal_and_update > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:181 > #13 0xcfdbb5 in write_signal_done > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:223 > #14 0xcfdbb5 in write_to_net_io(NetHandler*, UnixNetVConnection*, > EThread*) /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:563 > #15 0xcbc4ca in NetHandler::mainNetEvent(int, Event*) > /home/bcall/dev/trafficserver/iocore/net/UnixNet.cc:529 > #16 0xda8ce3 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #17 0xda8ce3 in EThread::process_event(Event*, int) > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:148 > #18 0xdabc8a in EThread::execute() > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:275 > #19 0xda7a58 in spawn_thread_internal > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:86 > #20 0x2b5ec2264aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0) > #21 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c) > Address 0x2b5ec8877660 is located in stack of thread T21 ([ET_NET 20]) at > offset 736 in frame > #0 0x7443ef in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6827 > This frame has 6 object(s): > [32, 36) 'offset' > [96, 100) 'skip' > [160, 164) 'length' > [224, 270) 'client_ip' > [320, 448) 'unique_id_string' > [480, 736) 'url_string' <== Memory access at offset 736 overflows this > variable > HINT: this may be a false positive if your program uses some custom stack > unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T21 ([ET_NET 20]) created by T0 ([ET_NET 0]) here: > #0 0x4d50b4 in pthread_create (/usr/local/bin/traffic_server+0x4d50b4) > #1 0xda85aa in ink_thread_create > /home/bcall/dev/trafficserver/lib/ts/ink_thread.h:147 > #2 0xda85aa in Thread::start(char const*, unsigned long, void* > (*)(void*), void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:101 > #3 0xdafff2 in EventProcessor::start(int, unsigned long) >
[jira] [Commented] (TS-4470) ASAN stack-buffer-overflow when slow log is enabled
[ https://issues.apache.org/jira/browse/TS-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342198#comment-15342198 ] ASF subversion and git services commented on TS-4470: - Commit 639a081ab4a8ff9306b02834a9dc5b028f23501a in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=639a081 ] TS-4470: ASAN stack-buffer-overflow when slow log is enabled Update to use offset > ASAN stack-buffer-overflow when slow log is enabled > --- > > Key: TS-4470 > URL: https://issues.apache.org/jira/browse/TS-4470 > Project: Traffic Server > Issue Type: Bug >Affects Versions: 6.2.0 >Reporter: Bryan Call >Assignee: Bryan Call >Priority: Blocker > Fix For: 6.2.0, 7.0.0 > > > = > ==13159==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x2b5ec8877660 at pc 0x004fcdf1 bp 0x2b5ec8875c60 sp 0x2b5ec8875410 > READ of size 260 at 0x2b5ec8877660 thread T21 ([ET_NET 20]) > #0 0x4fcdf0 in printf_common(void*, char const*, __va_list_tag*) [clone > .isra.6] (/usr/local/bin/traffic_server+0x4fcdf0) > #1 0x4fd744 in vfprintf (/usr/local/bin/traffic_server+0x4fd744) > #2 0x2b5ec1a668ee in vprintline<1024> > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:61 > #3 0x2b5ec1a668ee in Diags::print_va(char const*, DiagsLevel, SrcLoc > const*, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:340 > #4 0x2b5ec1a6765f in Diags::error_va(DiagsLevel, char const*, char > const*, int, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:572 > #5 0x72a724 in Diags::error(DiagsLevel, char const*, char const*, int, > char const*, ...) const /home/bcall/dev/trafficserver/lib/ts/Diags.h:242 > #6 0x7455d6 in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6972 > #7 0x77b07f in HttpSM::kill_this() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6786 > #8 0x77d6f7 in HttpSM::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:2660 > #9 0x832d3a in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #10 0x832d3a in HttpTunnel::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpTunnel.cc:1637 > #11 0xcfdbb5 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #12 0xcfdbb5 in write_signal_and_update > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:181 > #13 0xcfdbb5 in write_signal_done > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:223 > #14 0xcfdbb5 in write_to_net_io(NetHandler*, UnixNetVConnection*, > EThread*) /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:563 > #15 0xcbc4ca in NetHandler::mainNetEvent(int, Event*) > /home/bcall/dev/trafficserver/iocore/net/UnixNet.cc:529 > #16 0xda8ce3 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #17 0xda8ce3 in EThread::process_event(Event*, int) > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:148 > #18 0xdabc8a in EThread::execute() > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:275 > #19 0xda7a58 in spawn_thread_internal > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:86 > #20 0x2b5ec2264aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0) > #21 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c) > Address 0x2b5ec8877660 is located in stack of thread T21 ([ET_NET 20]) at > offset 736 in frame > #0 0x7443ef in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6827 > This frame has 6 object(s): > [32, 36) 'offset' > [96, 100) 'skip' > [160, 164) 'length' > [224, 270) 'client_ip' > [320, 448) 'unique_id_string' > [480, 736) 'url_string' <== Memory access at offset 736 overflows this > variable > HINT: this may be a false positive if your program uses some custom stack > unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T21 ([ET_NET 20]) created by T0 ([ET_NET 0]) here: > #0 0x4d50b4 in pthread_create (/usr/local/bin/traffic_server+0x4d50b4) > #1 0xda85aa in ink_thread_create > /home/bcall/dev/trafficserver/lib/ts/ink_thread.h:147 > #2 0xda85aa in Thread::start(char const*, unsigned long, void* > (*)(void*), void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:101 > #3 0xdafff2 in EventProcessor::start(int, unsigned long) >
[jira] [Commented] (TS-4560) C++ API should not depend on ink_autoconf.h
[
https://issues.apache.org/jira/browse/TS-4560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342064#comment-15342064
]
ASF subversion and git services commented on TS-4560:
-
Commit 647469508a73713cda83e02142df005fb5f68810 in trafficserver's branch
refs/heads/master from [~jpe...@apache.org]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=6474695 ]
TS-4560: Add generated shared_ptr.h to gitignore.
> C++ API should not depend on ink_autoconf.h
> ---
>
> Key: TS-4560
> URL: https://issues.apache.org/jira/browse/TS-4560
> Project: Traffic Server
> Issue Type: Bug
> Components: CPP API
>Reporter: James Peach
>Assignee: James Peach
> Fix For: 6.2.0, 7.0.0
>
>
> {{atscppapi/shared_ptr.h}} includes {{ink_autoconf.h}}. {{ink_autoconf.h}} is
> not installed (and must not be installed). This makes it impossible for
> people to consume the C++ API.
> It is totally reasonable IMHO to expect to be able to build plugins with a
> different toolchain than Traffic Server was built with. Consider installing
> {{devtoolset-3}} and building plugins against a distribution package, or
> building plugins with clang.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-4566) Disable all clang-analyzer checks for LuaJIT
[ https://issues.apache.org/jira/browse/TS-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340673#comment-15340673 ] ASF subversion and git services commented on TS-4566: - Commit 71b13803b50cf0545f47af0118a9668b1e3a4c2a in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=71b1380 ] TS-4566: Try harder to exclude LuaJIT from static analysis. > Disable all clang-analyzer checks for LuaJIT > > > Key: TS-4566 > URL: https://issues.apache.org/jira/browse/TS-4566 > Project: Traffic Server > Issue Type: Bug > Components: Build, Lua >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > For now, we need to turn off the clang-analyzer checks in the LuaJIT tree. > This is "new" since we now (as of 7.0.0) require Lua. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4566) Disable all clang-analyzer checks for LuaJIT
[ https://issues.apache.org/jira/browse/TS-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340661#comment-15340661 ] ASF subversion and git services commented on TS-4566: - Commit 3276feb6c9fdaab1dc5bc13628198f00223dcf53 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=3276feb ] TS-4566: Fix LUA_CFLAGS whitespacing. If LUA_CFLAGS get set, the AC_SUBST ends up being sensitive to whitespace. Use TS_ADDTO() which deals with this. > Disable all clang-analyzer checks for LuaJIT > > > Key: TS-4566 > URL: https://issues.apache.org/jira/browse/TS-4566 > Project: Traffic Server > Issue Type: Bug > Components: Build, Lua >Reporter: Leif Hedstrom >Assignee: Leif Hedstrom > Fix For: 7.0.0 > > > For now, we need to turn off the clang-analyzer checks in the LuaJIT tree. > This is "new" since we now (as of 7.0.0) require Lua. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4470) ASAN stack-buffer-overflow when slow log is enabled
[ https://issues.apache.org/jira/browse/TS-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15339766#comment-15339766 ] ASF subversion and git services commented on TS-4470: - Commit ceec590f76bca2b38f3e3f0cad47a6ee077223e0 in trafficserver's branch refs/heads/master from [~bcall] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=ceec590 ] Merge pull request #721 from bryancall/TS-4470 TS-4470: ASAN stack-buffer-overflow when slow log is enabled > ASAN stack-buffer-overflow when slow log is enabled > --- > > Key: TS-4470 > URL: https://issues.apache.org/jira/browse/TS-4470 > Project: Traffic Server > Issue Type: Bug >Affects Versions: 6.2.0 >Reporter: Bryan Call >Assignee: Bryan Call >Priority: Blocker > Fix For: 7.0.0 > > > = > ==13159==ERROR: AddressSanitizer: stack-buffer-overflow on address > 0x2b5ec8877660 at pc 0x004fcdf1 bp 0x2b5ec8875c60 sp 0x2b5ec8875410 > READ of size 260 at 0x2b5ec8877660 thread T21 ([ET_NET 20]) > #0 0x4fcdf0 in printf_common(void*, char const*, __va_list_tag*) [clone > .isra.6] (/usr/local/bin/traffic_server+0x4fcdf0) > #1 0x4fd744 in vfprintf (/usr/local/bin/traffic_server+0x4fd744) > #2 0x2b5ec1a668ee in vprintline<1024> > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:61 > #3 0x2b5ec1a668ee in Diags::print_va(char const*, DiagsLevel, SrcLoc > const*, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:340 > #4 0x2b5ec1a6765f in Diags::error_va(DiagsLevel, char const*, char > const*, int, char const*, __va_list_tag*) const > /home/bcall/dev/trafficserver/lib/ts/Diags.cc:572 > #5 0x72a724 in Diags::error(DiagsLevel, char const*, char const*, int, > char const*, ...) const /home/bcall/dev/trafficserver/lib/ts/Diags.h:242 > #6 0x7455d6 in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6972 > #7 0x77b07f in HttpSM::kill_this() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6786 > #8 0x77d6f7 in HttpSM::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:2660 > #9 0x832d3a in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #10 0x832d3a in HttpTunnel::main_handler(int, void*) > /home/bcall/dev/trafficserver/proxy/http/HttpTunnel.cc:1637 > #11 0xcfdbb5 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #12 0xcfdbb5 in write_signal_and_update > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:181 > #13 0xcfdbb5 in write_signal_done > /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:223 > #14 0xcfdbb5 in write_to_net_io(NetHandler*, UnixNetVConnection*, > EThread*) /home/bcall/dev/trafficserver/iocore/net/UnixNetVConnection.cc:563 > #15 0xcbc4ca in NetHandler::mainNetEvent(int, Event*) > /home/bcall/dev/trafficserver/iocore/net/UnixNet.cc:529 > #16 0xda8ce3 in Continuation::handleEvent(int, void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/I_Continuation.h:153 > #17 0xda8ce3 in EThread::process_event(Event*, int) > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:148 > #18 0xdabc8a in EThread::execute() > /home/bcall/dev/trafficserver/iocore/eventsystem/UnixEThread.cc:275 > #19 0xda7a58 in spawn_thread_internal > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:86 > #20 0x2b5ec2264aa0 in start_thread (/lib64/libpthread.so.0+0x3818807aa0) > #21 0x38180e893c in clone (/lib64/libc.so.6+0x38180e893c) > Address 0x2b5ec8877660 is located in stack of thread T21 ([ET_NET 20]) at > offset 736 in frame > #0 0x7443ef in HttpSM::update_stats() > /home/bcall/dev/trafficserver/proxy/http/HttpSM.cc:6827 > This frame has 6 object(s): > [32, 36) 'offset' > [96, 100) 'skip' > [160, 164) 'length' > [224, 270) 'client_ip' > [320, 448) 'unique_id_string' > [480, 736) 'url_string' <== Memory access at offset 736 overflows this > variable > HINT: this may be a false positive if your program uses some custom stack > unwind mechanism or swapcontext > (longjmp and C++ exceptions *are* supported) > Thread T21 ([ET_NET 20]) created by T0 ([ET_NET 0]) here: > #0 0x4d50b4 in pthread_create (/usr/local/bin/traffic_server+0x4d50b4) > #1 0xda85aa in ink_thread_create > /home/bcall/dev/trafficserver/lib/ts/ink_thread.h:147 > #2 0xda85aa in Thread::start(char const*, unsigned long, void* > (*)(void*), void*) > /home/bcall/dev/trafficserver/iocore/eventsystem/Thread.cc:101 > #3 0xdafff2 in EventProcessor::start(int, unsigned long) >
