[jira] [Updated] (TS-5012) CID 1267812 Logically Dead Code
[
https://issues.apache.org/jira/browse/TS-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian updated TS-5012:
--
Labels: coverity (was: )
Fix Version/s: 7.1.0
Component/s: Manager
> CID 1267812 Logically Dead Code
> ---
>
> Key: TS-5012
> URL: https://issues.apache.org/jira/browse/TS-5012
> Project: Traffic Server
> Issue Type: Bug
> Components: Manager
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Labels: coverity
> Fix For: 7.1.0
>
>
> 8void
> 189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
> 190{
> 191 int idx;
> 192
> cond_at_least: Condition id != 0U, taking true branch. Now the value of
> id is at least 1.
> cond_cannot_single: Condition id != 0U, taking true branch. Now the
> value of id cannot be equal to 0.
> 193 ink_assert(id != 0);
> cond_between: Condition id <= 100U, taking true branch. Now the value
> of id is between 1 and 100.
> 194 ink_assert(id <= MAX_CONFIGS);
> 195
> between: At condition id == 0U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id == 0U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id == 0U cannot be true.
> cond_between: Condition id == 0U, taking false branch. Now the value of
> id is between 1 and 100.
> between: At condition id > 100U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id > 100U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id > 100U cannot be true.
> 196 if (id == 0 || id > MAX_CONFIGS) {
> 197// nothing to delete since we have an invalid index
>
> CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return;.
> 198return;
> 199 }
> 200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-5012) CID 1267812 Logically Dead Code
Nathan Garabedian created TS-5012:
-
Summary: CID 1267812 Logically Dead Code
Key: TS-5012
URL: https://issues.apache.org/jira/browse/TS-5012
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: Nathan Garabedian
8void
189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
190{
191 int idx;
192
cond_at_least: Condition id != 0U, taking true branch. Now the value of
id is at least 1.
cond_cannot_single: Condition id != 0U, taking true branch. Now the
value of id cannot be equal to 0.
193 ink_assert(id != 0);
cond_between: Condition id <= 100U, taking true branch. Now the value
of id is between 1 and 100.
194 ink_assert(id <= MAX_CONFIGS);
195
between: At condition id == 0U, the value of id must be between 1 and
100.
cannot_single: At condition id == 0U, the value of id cannot be equal
to 0.
dead_error_condition: The condition id == 0U cannot be true.
cond_between: Condition id == 0U, taking false branch. Now the value of
id is between 1 and 100.
between: At condition id > 100U, the value of id must be between 1 and
100.
cannot_single: At condition id > 100U, the value of id cannot be equal
to 0.
dead_error_condition: The condition id > 100U cannot be true.
196 if (id == 0 || id > MAX_CONFIGS) {
197// nothing to delete since we have an invalid index
CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return;.
198return;
199 }
200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (TS-5012) CID 1267812 Logically Dead Code
[
https://issues.apache.org/jira/browse/TS-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian reassigned TS-5012:
-
Assignee: Nathan Garabedian
> CID 1267812 Logically Dead Code
> ---
>
> Key: TS-5012
> URL: https://issues.apache.org/jira/browse/TS-5012
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>
> 8void
> 189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
> 190{
> 191 int idx;
> 192
> cond_at_least: Condition id != 0U, taking true branch. Now the value of
> id is at least 1.
> cond_cannot_single: Condition id != 0U, taking true branch. Now the
> value of id cannot be equal to 0.
> 193 ink_assert(id != 0);
> cond_between: Condition id <= 100U, taking true branch. Now the value
> of id is between 1 and 100.
> 194 ink_assert(id <= MAX_CONFIGS);
> 195
> between: At condition id == 0U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id == 0U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id == 0U cannot be true.
> cond_between: Condition id == 0U, taking false branch. Now the value of
> id is between 1 and 100.
> between: At condition id > 100U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id > 100U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id > 100U cannot be true.
> 196 if (id == 0 || id > MAX_CONFIGS) {
> 197// nothing to delete since we have an invalid index
>
> CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return;.
> 198return;
> 199 }
> 200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-5012) CID 1267812 Logically Dead Code
[
https://issues.apache.org/jira/browse/TS-5012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian updated TS-5012:
--
Component/s: (was: Core)
> CID 1267812 Logically Dead Code
> ---
>
> Key: TS-5012
> URL: https://issues.apache.org/jira/browse/TS-5012
> Project: Traffic Server
> Issue Type: Bug
> Components: Manager
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Labels: coverity
> Fix For: 7.1.0
>
>
> 8void
> 189ConfigProcessor::release(unsigned int id, ConfigInfo *info)
> 190{
> 191 int idx;
> 192
> cond_at_least: Condition id != 0U, taking true branch. Now the value of
> id is at least 1.
> cond_cannot_single: Condition id != 0U, taking true branch. Now the
> value of id cannot be equal to 0.
> 193 ink_assert(id != 0);
> cond_between: Condition id <= 100U, taking true branch. Now the value
> of id is between 1 and 100.
> 194 ink_assert(id <= MAX_CONFIGS);
> 195
> between: At condition id == 0U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id == 0U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id == 0U cannot be true.
> cond_between: Condition id == 0U, taking false branch. Now the value of
> id is between 1 and 100.
> between: At condition id > 100U, the value of id must be between 1 and
> 100.
> cannot_single: At condition id > 100U, the value of id cannot be equal
> to 0.
> dead_error_condition: The condition id > 100U cannot be true.
> 196 if (id == 0 || id > MAX_CONFIGS) {
> 197// nothing to delete since we have an invalid index
>
> CID 1267812 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return;.
> 198return;
> 199 }
> 200
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-5009) CID 1022011 Logically dead code
[
https://issues.apache.org/jira/browse/TS-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian updated TS-5009:
--
Fix Version/s: 7.1.0
> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Labels: coverity
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687 static char _error = '\0';
> 688 IOBufferBlock *b = block.get();
> 689
> 690 i += start_offset;
> cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691 while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694 return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697 }
> 698
> 699 ink_assert(!"out of range");
> const: At condition !!b, the value of b must be equal to 0.
> null: At condition !!b, the value of b must be NULL.
> dead_error_condition: The condition !!b cannot be true.
> 700 if (unlikely(b)) {
>
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-5009) CID 1022011 Logically dead code
[
https://issues.apache.org/jira/browse/TS-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian updated TS-5009:
--
Labels: coverity (was: )
> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Labels: coverity
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687 static char _error = '\0';
> 688 IOBufferBlock *b = block.get();
> 689
> 690 i += start_offset;
> cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691 while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694 return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697 }
> 698
> 699 ink_assert(!"out of range");
> const: At condition !!b, the value of b must be equal to 0.
> null: At condition !!b, the value of b must be NULL.
> dead_error_condition: The condition !!b cannot be true.
> 700 if (unlikely(b)) {
>
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (TS-5008) CID 1022007 Logically dead code
[
https://issues.apache.org/jira/browse/TS-5008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian reassigned TS-5008:
-
Assignee: Nathan Garabedian
> CID 1022007 Logically dead code
> ---
>
> Key: TS-5008
> URL: https://issues.apache.org/jira/browse/TS-5008
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
> Time Spent: 40m
> Remaining Estimate: 0h
>
> if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
> const: At condition in_ext_map, the value of in_ext_map must be equal
> to 0.
> dead_error_condition: The condition in_ext_map cannot be true.
> 620if (in_ext_map) {
>
> CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: ret = true;.
> 621 ret = true;
> 622} else {
> 623 ret = false;
> 624}
> 625 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (TS-5004) CID 1021675 Structurally dead code
[ https://issues.apache.org/jira/browse/TS-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Garabedian reassigned TS-5004: - Assignee: Nathan Garabedian > CID 1021675 Structurally dead code > -- > > Key: TS-5004 > URL: https://issues.apache.org/jira/browse/TS-5004 > Project: Traffic Server > Issue Type: Bug > Components: Plugins >Reporter: Nathan Garabedian >Assignee: Nathan Garabedian > Time Spent: 20m > Remaining Estimate: 0h > > Some lines of code exist after a return 1; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-5009) CID 1022011 Logically dead code
[
https://issues.apache.org/jira/browse/TS-5009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian reassigned TS-5009:
-
Assignee: Nathan Garabedian
> CID 1022011 Logically dead code
> ---
>
> Key: TS-5009
> URL: https://issues.apache.org/jira/browse/TS-5009
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>
> TS_INLINE char ::operator[](int64_t i)
> 686{
> 687 static char _error = '\0';
> 688 IOBufferBlock *b = block.get();
> 689
> 690 i += start_offset;
> cond_null: Condition b, taking false branch. Now the value of b is NULL.
> 691 while (b) {
> 692int64_t bytes = b->read_avail();
> 693if (bytes > i)
> 694 return b->start()[i];
> 695i -= bytes;
> 696b = b->next.get();
> 697 }
> 698
> 699 ink_assert(!"out of range");
> const: At condition !!b, the value of b must be equal to 0.
> null: At condition !!b, the value of b must be NULL.
> dead_error_condition: The condition !!b cannot be true.
> 700 if (unlikely(b)) {
>
> CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return b->start();.
> 701return *b->start();
> 702 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-5009) CID 1022011 Logically dead code
Nathan Garabedian created TS-5009:
-
Summary: CID 1022011 Logically dead code
Key: TS-5009
URL: https://issues.apache.org/jira/browse/TS-5009
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: Nathan Garabedian
TS_INLINE char ::operator[](int64_t i)
686{
687 static char _error = '\0';
688 IOBufferBlock *b = block.get();
689
690 i += start_offset;
cond_null: Condition b, taking false branch. Now the value of b is NULL.
691 while (b) {
692int64_t bytes = b->read_avail();
693if (bytes > i)
694 return b->start()[i];
695i -= bytes;
696b = b->next.get();
697 }
698
699 ink_assert(!"out of range");
const: At condition !!b, the value of b must be equal to 0.
null: At condition !!b, the value of b must be NULL.
dead_error_condition: The condition !!b cannot be true.
700 if (unlikely(b)) {
CID 1022011 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return b->start();.
701return *b->start();
702 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-5008) CID 1022007 Logically dead code
Nathan Garabedian created TS-5008:
-
Summary: CID 1022007 Logically dead code
Key: TS-5008
URL: https://issues.apache.org/jira/browse/TS-5008
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: Nathan Garabedian
if (ink_hash_table_lookup(our_map, virt_ip, _value) != 0) {
const: At condition in_ext_map, the value of in_ext_map must be equal
to 0.
dead_error_condition: The condition in_ext_map cannot be true.
620if (in_ext_map) {
CID 1022007 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: ret = true;.
621 ret = true;
622} else {
623 ret = false;
624}
625 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-5004) CID 1021675 Structurally dead code
[ https://issues.apache.org/jira/browse/TS-5004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Garabedian updated TS-5004: -- Summary: CID 1021675 Structurally dead code (was: CID 121675 Structurally dead code) > CID 1021675 Structurally dead code > -- > > Key: TS-5004 > URL: https://issues.apache.org/jira/browse/TS-5004 > Project: Traffic Server > Issue Type: Bug > Components: Plugins >Reporter: Nathan Garabedian > > Some lines of code exist after a return 1; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-5004) CID 121675 Structurally dead code
Nathan Garabedian created TS-5004: - Summary: CID 121675 Structurally dead code Key: TS-5004 URL: https://issues.apache.org/jira/browse/TS-5004 Project: Traffic Server Issue Type: Bug Components: Plugins Reporter: Nathan Garabedian Some lines of code exist after a return 1; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-4860) Logically Dead Code - Multiple Coverity Issues
[ https://issues.apache.org/jira/browse/TS-4860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Garabedian reassigned TS-4860: - Assignee: Nathan Garabedian > Logically Dead Code - Multiple Coverity Issues > -- > > Key: TS-4860 > URL: https://issues.apache.org/jira/browse/TS-4860 > Project: Traffic Server > Issue Type: Bug > Components: Build >Reporter: Nathan Garabedian >Assignee: Nathan Garabedian > > CID 1267834 - Logically Dead Code in INKMgmtAPI.cc line 251 > CID 1267849 - Logically Dead Code in INKMgmtAPI.cc line 320 > CID 1267846 - Logically Dead Code in INKMgmtAPI.cc line 347 > CID 1267813 - Logically Dead Code in INKMgmtAPI.cc line 358 > etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (TS-4860) Logically Dead Code - Multiple Coverity Issues
Nathan Garabedian created TS-4860: - Summary: Logically Dead Code - Multiple Coverity Issues Key: TS-4860 URL: https://issues.apache.org/jira/browse/TS-4860 Project: Traffic Server Issue Type: Bug Components: Build Reporter: Nathan Garabedian CID 1267834 - Logically Dead Code in INKMgmtAPI.cc line 251 CID 1267849 - Logically Dead Code in INKMgmtAPI.cc line 320 CID 1267846 - Logically Dead Code in INKMgmtAPI.cc line 347 CID 1267813 - Logically Dead Code in INKMgmtAPI.cc line 358 etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
[
https://issues.apache.org/jira/browse/TS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nathan Garabedian reassigned TS-4815:
-
Assignee: Nathan Garabedian
> CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
> --
>
> Key: TS-4815
> URL: https://issues.apache.org/jira/browse/TS-4815
> Project: Traffic Server
> Issue Type: Bug
> Components: Management API
>Reporter: Nathan Garabedian
>Assignee: Nathan Garabedian
>
> cond_notnull: Condition ctx, taking true branch. Now the value of ctx
> is not NULL.
> 165 ink_assert(ctx);
> notnull: At condition ctx, the value of ctx cannot be NULL.
> dead_error_condition: The condition !ctx cannot be true.
> 166 if (!ctx) {
>
> CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
> dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
> 167return TS_ERR_PARAMS;
> 168 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-4815) CID 1267839 dead code in /mgmt/api/CfgContextManager.cc: return TS_ERR_PARAMS;
Nathan Garabedian created TS-4815:
-
Summary: CID 1267839 dead code in /mgmt/api/CfgContextManager.cc:
return TS_ERR_PARAMS;
Key: TS-4815
URL: https://issues.apache.org/jira/browse/TS-4815
Project: Traffic Server
Issue Type: Bug
Components: Management API
Reporter: Nathan Garabedian
cond_notnull: Condition ctx, taking true branch. Now the value of ctx
is not NULL.
165 ink_assert(ctx);
notnull: At condition ctx, the value of ctx cannot be NULL.
dead_error_condition: The condition !ctx cannot be true.
166 if (!ctx) {
CID 1267839 (#1 of 1): Logically dead code (DEADCODE)
dead_error_line: Execution cannot reach this statement: return TS_ERR_PARAMS;.
167return TS_ERR_PARAMS;
168 }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TS-4581) CID 1356973 dead code in proxy/hdrs/HTTP.cc
Nathan Garabedian created TS-4581: - Summary: CID 1356973 dead code in proxy/hdrs/HTTP.cc Key: TS-4581 URL: https://issues.apache.org/jira/browse/TS-4581 Project: Traffic Server Issue Type: Bug Components: HTTP Reporter: Nathan Garabedian 1069 notnull: At condition url_start, the value of url_start cannot be NULL. dead_error_condition: The condition !url_start cannot be true. notnull: At condition url_end, the value of url_end cannot be NULL. dead_error_condition: The condition !url_end cannot be true. 1070if (!url_start || !url_end) CID 1356973 (#1 of 1): Logically dead code (DEADCODE) dead_error_line: Execution cannot reach this statement: return PARSE_ERROR;. 1071 return PARSE_ERROR; -- This message was sent by Atlassian JIRA (v6.3.4#6332)
