[jira] [Commented] (TS-2981) Add HTTP session id to all HTTP debug log messages
[ https://issues.apache.org/jira/browse/TS-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15465206#comment-15465206 ] bwahn commented on TS-2981: --- [~bcall] Thanks for your feedback, I will patch with . > Add HTTP session id to all HTTP debug log messages > -- > > Key: TS-2981 > URL: https://issues.apache.org/jira/browse/TS-2981 > Project: Traffic Server > Issue Type: Improvement > Components: Logging >Reporter: Bryan Call > Labels: newbie > Fix For: sometime > > > Trying to debug an event system with interleaved debugging messages can make > you crazy... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1775) Cleanup of ink_hrtime.{cc,h}
[
https://issues.apache.org/jira/browse/TS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579818#comment-14579818
]
bwahn commented on TS-1775:
---
[~ngjunjie], I agree with it.
Cleanup of ink_hrtime.{cc,h}
Key: TS-1775
URL: https://issues.apache.org/jira/browse/TS-1775
Project: Traffic Server
Issue Type: Improvement
Reporter: Leif Hedstrom
Labels: newbie
Fix For: 6.0.0
A few things comes to mind:
1) Why do we have a NEED_HRTIME define? It's always on as far as I can tell,
and I can't imagine there's a reason to not have it on (it'd completely break
like everything, in fact it would fail to compile since gethrtime() doesn't
exist?).
2) We should eliminate the USE_TIME_STAMP_COUNTER_HRTIME define, and the code
that implements our own TSC code. Modern Unix flavors implements this already
in various way (e.g. glibc's gettimeofday() wrapper has a TSC user space
implementation).
3) On FreeBSD, jpeach points out that CLOCK_REALTIME is probably not the
optimal way to use clock_gettime(). He suggest using CLOCK_REALTIME_FAST or
CLOCK_MONOTONIC_FAST which is similar to the optimizations done with TSC for
gettimeofday() on linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Resolved] (TS-1256) Streamline usage of PATH_NAME_MAX
[
https://issues.apache.org/jira/browse/TS-1256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn resolved TS-1256.
---
Resolution: Fixed
Streamline usage of PATH_NAME_MAX
-
Key: TS-1256
URL: https://issues.apache.org/jira/browse/TS-1256
Project: Traffic Server
Issue Type: Task
Components: Cleanup
Reporter: Igor Galić
Assignee: James Peach
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1256.diff
There are right now two different usages of the constant {{PATH_NAME_MAX}} in
variable declarations:
{code}
char foo[PATH_NAME_MAX];
{code}
and
{code}
char bar[PATH_NAME_MAX + 1];
{code}
Since we define what {{PATH_NAME_MAX}} is ourselves, we should streamline our
code to only use the first kind of declaration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2981) Add HTTP session id to all HTTP debug log messages
[ https://issues.apache.org/jira/browse/TS-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385819#comment-14385819 ] bwahn commented on TS-2981: --- [~bcall], Please review my comment. Add HTTP session id to all HTTP debug log messages -- Key: TS-2981 URL: https://issues.apache.org/jira/browse/TS-2981 Project: Traffic Server Issue Type: Improvement Components: Logging Reporter: Bryan Call Labels: newbie Fix For: 6.0.0 Trying to debug an event system with interleaved debugging messages can make you crazy... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-2981) Add HTTP session id to all HTTP debug log messages
[
https://issues.apache.org/jira/browse/TS-2981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14385769#comment-14385769
]
bwahn commented on TS-2981:
---
I'm thinking that (http) debug message as below :
{code}
[Mar 29 13:32:03.007] Server {0x2aea723a5ac0} DEBUG: (http) [5]
perform_cache_write_action CACHE_DO_NO_ACTION
{code}
If HTTP Session id will show in traffic.out using of debug.enabled(1) and
debug.tags(http.*),
{code}
[Mar 29 13:32:03.007] Server {0x2aea723a5ac0} DEBUG: (http) [con_id] [5]
perform_cache_write_action CACHE_DO_NO_ACTION
{code}
[con_id] is int64_t con_id of HttpServerSession.
Add HTTP session id to all HTTP debug log messages
--
Key: TS-2981
URL: https://issues.apache.org/jira/browse/TS-2981
Project: Traffic Server
Issue Type: Improvement
Components: Logging
Reporter: Bryan Call
Labels: newbie
Fix For: 6.0.0
Trying to debug an event system with interleaved debugging messages can make
you crazy...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378019#comment-14378019
]
bwahn commented on TS-1878:
---
I add configure.ac and build.
But, I can't find difference between using of -Wl,-as-needed and not using.
Use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Not use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Could you describe more details?
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.patch
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378019#comment-14378019
]
bwahn edited comment on TS-1878 at 3/24/15 3:23 PM:
I add configure.ac and build.
But, I can't find difference between using of -Wl,-as-needed and not using.
Please reivew TS-1878.diff .
Use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Not use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Could you describe more details?
was (Author: bwahn):
I add configure.ac and build.
But, I can't find difference between using of -Wl,-as-needed and not using.
Use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Not use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Could you describe more details?
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.diff
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn updated TS-1878:
--
Attachment: (was: TS-1878.patch)
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.diff
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn updated TS-1878:
--
Attachment: TS-1878.patch
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.patch
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn updated TS-1878:
--
Attachment: TS-1878.diff
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.diff
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-1878) link libraries as needed on linux
[
https://issues.apache.org/jira/browse/TS-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14378019#comment-14378019
]
bwahn edited comment on TS-1878 at 3/24/15 3:36 PM:
I add -Wl,-as-needed in configure.ac and build.
But, I can't find difference between using of -Wl,-as-needed and not using.
Please reivew TS-1878.diff .
Use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Not use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Could you describe more details?
was (Author: bwahn):
I add configure.ac and build.
But, I can't find difference between using of -Wl,-as-needed and not using.
Please reivew TS-1878.diff .
Use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Not use -Wl,-as-needed :
/opt/ats/bin$ ldd -u -r traffic_server
Unused direct dependencies:
linux-vdso.so.1
Could you describe more details?
link libraries as needed on linux
-
Key: TS-1878
URL: https://issues.apache.org/jira/browse/TS-1878
Project: Traffic Server
Issue Type: Improvement
Components: Build
Reporter: James Peach
Priority: Minor
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1878.diff
We should pass {{-Wl,-as-needed}} to the linker on Linux to get it to strip
unused libraries. The equivalent Darwin option is {{-Wl,-dead_strip_dylibs}}.
See also:
http://www.gentoo.org/proj/en/qa/asneeded.xml
http://sigquit.wordpress.com/2011/02/16/why-asneeded-doesnt-work-as-expected-for-your-libraries-on-your-autotools-project/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376013#comment-14376013 ] bwahn commented on TS-1015: --- TSEvent defined lib/ts/apidefs.h TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1849) traffic_logstats does not accept relative log file paths
[
https://issues.apache.org/jira/browse/TS-1849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14375935#comment-14375935
]
bwahn commented on TS-1849:
---
[~jpe...@apache.org], I tested like this :
squid.log located in /opt/ats/var/log/trafficserver/. The path defined
CONFIG proxy.config.log.logfile_dir STRING var/log/trafficserver as
records.config.
{code}
/opt/ats/bin$ ./traffic_logstats squid.log
Traffic summary
Origin Server Hits Misses Errors
--
192.168.100.10 0 3 0
==
...
...
{code}
I'm thinking traffic_logstats has already feature for supported relative path.
Could you explain more detail?
traffic_logstats does not accept relative log file paths
Key: TS-1849
URL: https://issues.apache.org/jira/browse/TS-1849
Project: Traffic Server
Issue Type: Bug
Components: Logging
Reporter: James Peach
Labels: newbie
Fix For: 6.0.0
From TS-1834, traffic_logstats pukes if you give it a relative path to a log
file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376146#comment-14376146 ] bwahn edited comment on TS-1015 at 3/23/15 4:37 PM: [~niq] Add TS-1015-2.diff. Please review diff file. was (Author: bwahn): Add TS-1015-2.diff. Please review diff file. TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015-2.diff, TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376146#comment-14376146 ] bwahn commented on TS-1015: --- Add TS-1015-2.diff. Please review diff file. TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015-2.diff, TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bwahn updated TS-1015: -- Attachment: TS-1015.diff TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] bwahn updated TS-1015: -- Attachment: TS-1015-2.diff TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015-2.diff, TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376146#comment-14376146 ] bwahn edited comment on TS-1015 at 3/23/15 4:39 PM: [~n...@webthing.com] and [~zwoop], Add TS-1015-2.diff. Please review diff file. was (Author: bwahn): [~n...@webthing.com] Add TS-1015-2.diff. Please review diff file. TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015-2.diff, TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (TS-1015) TSEvent is widely declared as int
[ https://issues.apache.org/jira/browse/TS-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14376146#comment-14376146 ] bwahn edited comment on TS-1015 at 3/23/15 4:38 PM: [~n...@webthing.com] Add TS-1015-2.diff. Please review diff file. was (Author: bwahn): [~niq] Add TS-1015-2.diff. Please review diff file. TSEvent is widely declared as int - Key: TS-1015 URL: https://issues.apache.org/jira/browse/TS-1015 Project: Traffic Server Issue Type: Bug Components: Cleanup Reporter: Nick Kew Assignee: Meera Mosale Nataraja Priority: Minor Labels: api-change, newbie Fix For: 6.0.0 Attachments: TS-1015-2.diff, TS-1015.diff TSEvent is an enum, defined in ts.h. But in much of the code, TSEvent is declared as type int. This makes it harder to follow/debug using tools like *trace or gdb. This may usefully be fixed as and when people encounter instances of it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377215#comment-14377215 ] bwahn commented on TS-1774: --- It should make ink_hrtime_get() function in Thread.cc. and I will review the class. thanks [~amc] Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1775) Cleanup of ink_hrtime.{cc,h}
[
https://issues.apache.org/jira/browse/TS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377145#comment-14377145
]
bwahn commented on TS-1775:
---
It should have to do globally code refactoring, I think.
Cleanup of ink_hrtime.{cc,h}
Key: TS-1775
URL: https://issues.apache.org/jira/browse/TS-1775
Project: Traffic Server
Issue Type: Improvement
Reporter: Leif Hedstrom
Labels: newbie
Fix For: 6.0.0
A few things comes to mind:
1) Why do we have a NEED_HRTIME define? It's always on as far as I can tell,
and I can't imagine there's a reason to not have it on (it'd completely break
like everything, in fact it would fail to compile since gethrtime() doesn't
exist?).
2) We should eliminate the USE_TIME_STAMP_COUNTER_HRTIME define, and the code
that implements our own TSC code. Modern Unix flavors implements this already
in various way (e.g. glibc's gettimeofday() wrapper has a TSC user space
implementation).
3) On FreeBSD, jpeach points out that CLOCK_REALTIME is probably not the
optimal way to use clock_gettime(). He suggest using CLOCK_REALTIME_FAST or
CLOCK_MONOTONIC_FAST which is similar to the optimizations done with TSC for
gettimeofday() on linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (TS-1775) Cleanup of ink_hrtime.{cc,h}
[
https://issues.apache.org/jira/browse/TS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn updated TS-1775:
--
Attachment: (was: TS-1775.patch)
Cleanup of ink_hrtime.{cc,h}
Key: TS-1775
URL: https://issues.apache.org/jira/browse/TS-1775
Project: Traffic Server
Issue Type: Improvement
Reporter: Leif Hedstrom
Labels: newbie
Fix For: 6.0.0
A few things comes to mind:
1) Why do we have a NEED_HRTIME define? It's always on as far as I can tell,
and I can't imagine there's a reason to not have it on (it'd completely break
like everything, in fact it would fail to compile since gethrtime() doesn't
exist?).
2) We should eliminate the USE_TIME_STAMP_COUNTER_HRTIME define, and the code
that implements our own TSC code. Modern Unix flavors implements this already
in various way (e.g. glibc's gettimeofday() wrapper has a TSC user space
implementation).
3) On FreeBSD, jpeach points out that CLOCK_REALTIME is probably not the
optimal way to use clock_gettime(). He suggest using CLOCK_REALTIME_FAST or
CLOCK_MONOTONIC_FAST which is similar to the optimizations done with TSC for
gettimeofday() on linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377111#comment-14377111 ] bwahn edited comment on TS-1774 at 3/24/15 2:09 AM: -I'm thinking ink_hrtime_get() function removed that because TS-1775. This issue would resolve won't fix and so on.- was (Author: bwahn): I'm thinking ink_hrtime_get() function removed that because TS-1775. This issue would resolve won't fix and so on. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377116#comment-14377116 ] bwahn commented on TS-1774: --- I can't find ink_hrtime_get() funciton on master branch. It will be resolved 'won't fixed'. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (TS-1775) Cleanup of ink_hrtime.{cc,h}
[
https://issues.apache.org/jira/browse/TS-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
bwahn updated TS-1775:
--
Attachment: TS-1775.patch
It was attached to this for patch.
Cleanup of ink_hrtime.{cc,h}
Key: TS-1775
URL: https://issues.apache.org/jira/browse/TS-1775
Project: Traffic Server
Issue Type: Improvement
Reporter: Leif Hedstrom
Labels: newbie
Fix For: 6.0.0
Attachments: TS-1775.patch
A few things comes to mind:
1) Why do we have a NEED_HRTIME define? It's always on as far as I can tell,
and I can't imagine there's a reason to not have it on (it'd completely break
like everything, in fact it would fail to compile since gethrtime() doesn't
exist?).
2) We should eliminate the USE_TIME_STAMP_COUNTER_HRTIME define, and the code
that implements our own TSC code. Modern Unix flavors implements this already
in various way (e.g. glibc's gettimeofday() wrapper has a TSC user space
implementation).
3) On FreeBSD, jpeach points out that CLOCK_REALTIME is probably not the
optimal way to use clock_gettime(). He suggest using CLOCK_REALTIME_FAST or
CLOCK_MONOTONIC_FAST which is similar to the optimizations done with TSC for
gettimeofday() on linux.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-1174) Should we eliminate all ERR_* status message in squid logging?
[
https://issues.apache.org/jira/browse/TS-1174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14370528#comment-14370528
]
bwahn commented on TS-1174:
---
[~zwoop] I will follow this issue.
Should we eliminate all ERR_* status message in squid logging?
Key: TS-1174
URL: https://issues.apache.org/jira/browse/TS-1174
Project: Traffic Server
Issue Type: Improvement
Components: Logging
Reporter: Leif Hedstrom
Labels: compatibility, newbie
Fix For: 6.0.0
In more recent versions of Squid, ERR_* status messages have been merged into
the status code. E.g.
{code}
ERR_*
Errors are now contained in the status code.
{code}
Should we do likewise?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-2685) TSHttpEventNameLookup can't lookup TSEvent values
[
https://issues.apache.org/jira/browse/TS-2685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14367525#comment-14367525
]
bwahn commented on TS-2685:
---
Ah~ It's already have a ticket. It would be add a typedef.
TSHttpEventNameLookup can't lookup TSEvent values
-
Key: TS-2685
URL: https://issues.apache.org/jira/browse/TS-2685
Project: Traffic Server
Issue Type: Bug
Components: TS API
Reporter: James Peach
Assignee: Meera Mosale Nataraja
Labels: newbie
Fix For: 6.0.0
{{TSHttpEventNameLookup}} can't look up {{TSEvent}} values, see the
implementation of {{HttpDebugNames::get_event_name}}.
It would also be pretty neat if it formatted the event class if it didn't
know about the specific event, e.g. {{ICP_EVENT_EVENTS_START+22}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
