[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

[igalic]

Github user igalic commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1133#discussion_r84887560
  
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = 
"TEST_dbg_header_rewrite";
 extern "C" void
 TSError(const char *fmt, ...)
 {
-  char buf[2048];
-  int bytes = 0;
-  va_list args;
-  va_start(args, fmt);
-  if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
-  }
-  va_end(args);
--- End diff --

you may want to replace the functions content then with this ^ `/* comment 
*/`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1133: TS-4993: Disables escaping and quotes insi...

[igalic]

Github user igalic commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1133#discussion_r84601766
  
--- Diff: plugins/header_rewrite/header_rewrite_test.cc ---
@@ -31,274 +33,395 @@ const char PLUGIN_NAME_DBG[] = 
"TEST_dbg_header_rewrite";
 extern "C" void
 TSError(const char *fmt, ...)
 {
-  char buf[2048];
-  int bytes = 0;
-  va_list args;
-  va_start(args, fmt);
-  if ((bytes = vsnprintf(buf, sizeof(buf), fmt, args)) > 0) {
-fprintf(stderr, "TSError: %s: %.*s\n", PLUGIN_NAME, bytes, buf);
-  }
-  va_end(args);
--- End diff --

how does this function work now?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1108: TS-4970: Crash in INKVConnInternal when ha...

[igalic]

Github user igalic commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1108#discussion_r83423846
  
--- Diff: proxy/InkAPI.cc ---
@@ -1053,15 +1053,14 @@ int
 INKVConnInternal::handle_event(int event, void *edata)
 {
   handle_event_count(event);
-  if (m_deleted) {
-if (m_deletable) {
-  this->mutex = NULL;
-  m_read_vio.set_continuation(NULL);
-  m_write_vio.set_continuation(NULL);
-  INKVConnAllocator.free(this);
-}
-  } else {
+  // If the VConn isn't deleted, call the handler
+  if (!m_deleted) {
 return m_event_func((TSCont) this, (TSEvent) event, edata);
+  } else {
--- End diff --

why is this an `else` if we previously `return`ed?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---