[GitHub] trafficserver pull request #1473: Avoid forcing "proxied URL" in case of tra...
Github user ushachar commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1473#discussion_r104184151
--- Diff: proxy/http/HttpTransact.cc ---
@@ -7845,10 +7845,12 @@ HttpTransact::build_request(State *s, HTTPHdr
*base_request, HTTPHdr *outgoing_r
DebugTxn("http_trans", "[build_request] adding target to URL for
parent proxy");
outgoing_request->set_url_target_from_host_field();
}
- } else if (s->next_hop_scheme == URL_WKSIDX_HTTP || s->next_hop_scheme
== URL_WKSIDX_HTTPS ||
- s->next_hop_scheme == URL_WKSIDX_WS || s->next_hop_scheme ==
URL_WKSIDX_WSS) {
+ } else if (!(s->client_info.is_transparent &&
base_request->is_target_in_url()) &&
--- End diff --
It's not equivalent -- the additional () forces both terms to be evaluated
(even if the first one is false)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Github user ushachar commented on the issue: https://github.com/apache/trafficserver/pull/712 @jpeach / @SolidWallOfCode - Since there were a couple of concerns about this API in the beginning could one of you ack this as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Github user ushachar commented on the issue: https://github.com/apache/trafficserver/pull/712 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #712: TS-4523 - Add pause functionality to the Transform...
Github user ushachar commented on the issue: https://github.com/apache/trafficserver/pull/712 The reason for wanting this feature is to support prolonged content related actions -- in @davidbz case out-of-process content malware analysis. When acting as a forward proxy and handling a request for a very large file, he needs to support an initial analysis on the first N MBs of the file in order to decide if he must analyze the full file or can release it to the client. This analysis can take a significant amount of time and continuing to buffer the contents can lead to resource exhaustion. (When combined with turning on flow control to make sure that we throttle the proxy<->upstream tcp connection) @bgaff - I know you had some concerns regarding this - does this use case seem reasonable to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #712: TS-4523
Github user ushachar commented on the issue: https://github.com/apache/trafficserver/pull/712 Yep. Getting back to this asap --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
