[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/1066 The clean up changes were done and look good. Deeper review and approve done by @zwoop --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/806/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/911/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user ericcarlschwartz commented on the issue: https://github.com/apache/trafficserver/pull/1066 ok fixed those up will let the ci stuff build. would we also want to make this change on the origin side? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user ericcarlschwartz commented on the issue: https://github.com/apache/trafficserver/pull/1066 i'll drop the assert and switch to the countof! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1066 I'm generally ok with this, up to you if you wish to clean anything up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/801/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/906/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/905/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user ericcarlschwartz commented on the issue: https://github.com/apache/trafficserver/pull/1066 Oh god sorry. I'll get the clang formatting right on the first time someday. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user ericcarlschwartz commented on the issue: https://github.com/apache/trafficserver/pull/1066 The same request over http/2 has the additional h2 marker as follows: `via: https/1.1 yahoo.com (ApacheTrafficServer), http/1.1 h2 tls/1.2 tcp ipv4 ubuntu (ApacheTrafficServer/7.1.0)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user ericcarlschwartz commented on the issue: https://github.com/apache/trafficserver/pull/1066 As a heads up, this simplifies things a bit, always relying on the HttpSM `populate_client_protocol` call on the client side. This changes our via header even for http/1.1. An old via header that read: `Via: https/1.1 ats2.fp.gq1.yahoo.com (ApacheTrafficServer), http/1.1 ubuntu (ApacheTrafficServer/7.1.0)` Would now read: `Via: https/1.1 ats2.fp.gq1.yahoo.com (ApacheTrafficServer), http/1.1 tls/1.2 tcp ipv4 ubuntu (ApacheTrafficServer/7.1.0)` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/800/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/904/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1066: [TS-4457] Via header always reports http1
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1066 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/799/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
