[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *successful*! See https://ci.trafficserver.apache.org/job/RAT-github/7/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/185/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/53/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1515/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1620/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1479 Gah, what a tarpit. The conflict resolution collided with another override update and that caused the regression test failure. Should be fixed now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/180/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *failed*! See https://ci.trafficserver.apache.org/job/linux-github/1510/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/freebsd-github/1615/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Intel CC build *failed*! See https://ci.trafficserver.apache.org/job/icc-github/48/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1479 I guess. I don't really think this is all that much better than the template logic, except that it's easier to understand for non template people. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1479 @SolidWallOfCode If you fix the merge conflicts now, I'll +1 this against my better judgement :-). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1479 I like the elimination of that additional enum type, but I don't know enough about the details in C++11 here to know what the impact are on performance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user SolidWallOfCode commented on the issue: https://github.com/apache/trafficserver/pull/1479 I think the implementation is significantly simpler, avoids more advanced template techniques, and eliminates a type. It is also more easily expandable in that the converters can check for any type easily, rather than depending on the set of values in the enum. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/1479 I don't get how this is better than the previous version. That was purely compile time and this compares the global `typeid` constants at runtime. It doesn't seem better. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 clang-analyzer build *successful*! See https://ci.trafficserver.apache.org/job/clang-analyzer-github/161/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/freebsd-github/1596/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Linux build *successful*! See https://ci.trafficserver.apache.org/job/linux-github/1490/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1479: Add static type checking to configuration overrid...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1479 Intel CC build *successful*! See https://ci.trafficserver.apache.org/job/icc-github/29/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
