[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1624 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user chenglongwei commented on the issue: https://github.com/apache/trafficserver/pull/1624 This debugging feature is mainly used to debug plugins. I also modified the title to avoid confusedness. This debugging requires to know 'before or after' 'what hook id', 'what plugin' modifies 'what contents' of request/response headers. The plugin-like debugging method you mentioned might not work for this requirements. 1. Use this plugin-like method, we could not get the idea about which debugged plugin is executing. Because using this method, we could only get current TSCont, event and edata. ```plugin_handler(TSCont contp, TSEvent event, void *edata)``` We would lose clues about the debugged plugin. 2. Generally plugin interested events are one-to-one relationship to http hooks. And in plugins, event is used to decide which hook id current transaction is executing. Using this plugin-like method, we only get event "TS_EVENT_HTTP_PLUGIN_CALL_BEFORE" or "TS_EVENT_HTTP_PLUGIN_CALL_AFTER". Our debugger would not know current debugged hook id. 3. Original TS_EVENT_XXX would happen sequently just as TS_HTTP_XXX hooks. This idea would be very complex because "TS_EVENT_HTTP_PLUGIN_CALL_BEFORE" and "TS_EVENT_HTTP_PLUGIN_CALL_AFTER" would happen every now and then with normal TS_HTTP_XXX hooks as well as "TS_HTTP_PLUGIN_CALL". Fire events "TS_EVENT_HTTP_PLUGIN_CALL_BEFORE", "TS_EVENT_HTTP_PLUGIN_CALL_AFTER" to triger hook "TS_HTTP_PLUGIN_CALL" is not easy to implement. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1624 Yes, I'm very much -1 on adding new plugin APIs and specially the loading of a .so via records.config. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/1624 It would be better to make these normal transaction hooks and use the TSHttpHookAdd() function to add the hook. Then you can use the normal plugin.config to load the plugin. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #1624: Http transaction debugging feature
Github user chenglongwei commented on the issue: https://github.com/apache/trafficserver/pull/1624 #1624 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
