[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/846 Yes, we should land it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/846 Should we land this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/846 Yes, it is moved to `ProxyClientTransaction::destroy()` by TS-4507 https://github.com/apache/trafficserver/blob/master/proxy/ProxyClientTransaction.cc#L85 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/846 I think I see this, we only set current_reader=NULL after that assert, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/846 Agreed that the assert doesn't mean much at this point. current_reader (the HttpSM) may be NULL here or not. If the StateMachine calls ua_session->release then it will not be null. But Http2Stream::release() calls do_io_close which calls super::release() again for good measure. The second time through current_reader will be NULL. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user JamesPeach commented on the issue: https://github.com/apache/trafficserver/pull/846 Is the reader actually *guaranteed* to be NULL here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/846 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/409/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #846: TS-4726: Remove unnecessary assert in ProxyClientT...
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/846 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/512/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
