[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/877 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/690/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/877 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/586/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/877 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/877 Have to run clang format, (I highly recommend installing the git hook that we have, see https://github.com/apache/trafficserver/blob/master/tools/pre-commit Also, I think we suggested/agreed on moving this to a new directory, like plugins/test ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/877 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/566/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/877 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/462/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/877 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/877 I have mixed feelings on the custom log for this. This is really for intermittent testing of behavior, similar to e.g. the memory usage dump feature. I.e. I can't imagine someone would use this in a way where it dumps the metrics more than a handful of times. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/877 Should this use a TextLog rather than standard output? Then you would get log rotation, etc, which is probably desirable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user petarpenkov commented on the issue: https://github.com/apache/trafficserver/pull/877 Aw yeah, totally meant to do that and forgot. Will update ASAP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #877: TS-4755: Header Frequency plugin. Initial version
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/877 Looks good, but I didn't see any locking when updating client_freq and origin_freq. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
