[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/977 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/977 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/646/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/977 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/750/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/977 It looks like I had an error in the "compile against openssl 1.0.2" case. FreeBSD must use openssl 1.0.2 and linux must use openssl 1.0.1. Fixing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/977
Looks good, but fails on FreeBSD for some reason:
{code}
../../../iocore/net/SSLUtils.cc:384:27: error: use of undeclared identifier
'TS_SSL_CERT_EVENT'; did you mean 'TS_SSL_CERT_HOOK'?
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
TS_SSL_CERT_HOOK
../../lib/ts/apidefs.h:290:3: note: 'TS_SSL_CERT_HOOK' declared here
TS_SSL_CERT_HOOK = TS_SSL_SNI_HOOK,
^
../../../iocore/net/SSLUtils.cc:384:27: error: cannot initialize a
parameter of type 'TSEvent' with an rvalue of type 'TSHttpHookID'
if (!netvc->calledHooks(TS_SSL_CERT_EVENT)) {
^
../../../iocore/net/P_SSLNetVConnection.h:221:41: note: passing argument to
parameter here
bool calledHooks(TSEvent /* eventId */) const { return
(this->sslHandshakeHookState != HANDSHAKE_HOOKS_PRE); }
^
{code}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/977 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/615/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] trafficserver issue #977: TS-4657: SNI hook sends hook ID for events
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/977 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/719/ for details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
