Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1045#discussion_r80590510
--- Diff: proxy/Main.cc ---
@@ -1507,9 +1507,8 @@ main(int /* argc ATS_UNUSED */, const char **argv)
// re-start it again, TS will crash.
// This is also needed for log rotation - setting up the file can cause
privilege
// related errors and if diagsConfig isn't get up yet that will crash on
a NULL pointer.
- diagsConfig = new DiagsConfig(DIAGS_LOG_FILENAME, error_tags,
action_tags, false);
- diags = diagsConfig->diags;
- diags->prefix_str = "Server ";
+ diagsConfig = new DiagsConfig("Server ", DIAGS_LOG_FILENAME, error_tags,
action_tags, false);
--- End diff --
Why do we sometimes have a trailing space on the prefix?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
