[GitHub] trafficserver pull request #1248: TS-5070 Add configuration variables to set...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1248


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1248: TS-5070 Add configuration variables to set...

[danobi]

GitHub user danobi opened a pull request:

https://github.com/apache/trafficserver/pull/1248

TS-5070 Add configuration variables to set file permissions for diags.log & 
traffic.out

We add 2 more config variables to control file permissions for
diagnostics logs. These are not reloadable.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/danobi/trafficserver TS-5070

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1248.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1248


commit f29e8fa65de66d634f922ac8a448f817fe025d54
Author: Daniel Xu 
Date:   2016-11-30T23:34:31Z

TS-5070 Add configuration variables to set file permissions for diags.log & 
traffic.out

We add 2 more config variables to control file permissions for
diagnostics logs. These are not reloadable.

commit bd9535c5ba2d15f108455f6f4acfe37beb78ee5d
Author: Daniel Xu 
Date:   2016-12-05T23:00:59Z

Fix chmod permission errors & code refactor

This was needed because traffic.out, unlike squid.blog, is created
before ATS drops superuser status. Thus, we cannot use a traditional
chmod(2) on traffic.out since traffic.out is owned by root when
we want to change it as nobody.

The trick here is to use the CAP_FOWNER capability to bypass permission
checks.

commit 4e2dcb81115c3d3decfa59a5cf79196caa9e5e59
Author: Daniel Xu 
Date:   2016-12-05T23:04:23Z

clang-format

commit 04f7561dd963187b9c7ecda3fa6f29c01b64bb45
Author: Daniel Xu 
Date:   2016-12-05T23:07:04Z

Remove reloadable attribute in docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---