[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-24 Thread jablko 
Github user jablko closed the pull request at:

https://github.com/apache/trafficserver/pull/1309


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-17 Thread bryancall 
Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1309#discussion_r96547120
  
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , 
int )
 std::string
 WSBuffer::ws_digest(std::string const )
 {
-#if OPENSSL_VERSION_NUMBER < 0x1010L
+#if OPENSSL_VERSION_NUMBER < 0x1010L || 
defined(LIBRESSL_VERSION_NUMBER)
--- End diff --

True :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-09 Thread jablko 
Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1309#discussion_r95238878
  
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , 
int )
 std::string
 WSBuffer::ws_digest(std::string const )
 {
-#if OPENSSL_VERSION_NUMBER < 0x1010L
+#if OPENSSL_VERSION_NUMBER < 0x1010L || 
defined(LIBRESSL_VERSION_NUMBER)
--- End diff --

I don't know which future version of LibreSSL will change this behavior ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-09 Thread jablko 
Github user jablko commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1309#discussion_r95238279
  
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , 
int )
 std::string
 WSBuffer::ws_digest(std::string const )
 {
-#if OPENSSL_VERSION_NUMBER < 0x1010L
+#if OPENSSL_VERSION_NUMBER < 0x1010L || 
defined(LIBRESSL_VERSION_NUMBER)
--- End diff --

Good idea. Is it okay if I make that change in #1313?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-09 Thread jpeach 
Github user jpeach commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1309#discussion_r95204594
  
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , 
int )
 std::string
 WSBuffer::ws_digest(std::string const )
 {
-#if OPENSSL_VERSION_NUMBER < 0x1010L
+#if OPENSSL_VERSION_NUMBER < 0x1010L || 
defined(LIBRESSL_VERSION_NUMBER)
--- End diff --

Do we really need all this ifdeffery? Can we just unconditionally use the 
modern API?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-09 Thread bryancall 
Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1309#discussion_r95200335
  
--- Diff: example/cppapi/websocket/WSBuffer.cc ---
@@ -157,7 +157,7 @@ WSBuffer::read_buffered_message(std::string , 
int )
 std::string
 WSBuffer::ws_digest(std::string const )
 {
-#if OPENSSL_VERSION_NUMBER < 0x1010L
+#if OPENSSL_VERSION_NUMBER < 0x1010L || 
defined(LIBRESSL_VERSION_NUMBER)
--- End diff --


Shouldn't you check against a version number for LIBRESSL_VERSION_NUMBER?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1309: Fixes for building with LibreSSL

2017-01-08 Thread jablko 
GitHub user jablko opened a pull request:

https://github.com/apache/trafficserver/pull/1309

Fixes for building with LibreSSL

Fixes #1307

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jablko/trafficserver libressl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1309.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1309


commit 7bc7158616aaac49daa037ab02f7fa7c0ce78345
Author: Jack Bates 
Date:   2017-01-08T20:34:39Z

Fixes for building with LibreSSL

Fixes #1307




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---