[GitHub] trafficserver pull request #1315: TS-5022: fix silent exit problem

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1315


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1315: TS-5022: fix silent exit problem

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1315#discussion_r95249133
  
--- Diff: iocore/net/SSLConfig.cc ---
@@ -421,7 +421,6 @@ SSLConfigParams::getNewCTX(char *client_cert) const
   return nclient_ctx;
 fail:
   SSLReleaseContext(nclient_ctx);
--- End diff --

How does this compile, without a return value in this case?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1315: TS-5022: fix silent exit problem

[persiaAziz]

GitHub user persiaAziz opened a pull request:

https://github.com/apache/trafficserver/pull/1315

TS-5022: fix silent exit problem



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/persiaAziz/trafficserver TS-5022

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1315.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1315


commit 5ffbcb63ec80ef9461dd2512683cfc4991cfb404
Author: Persia Aziz 
Date:   2017-01-09T21:14:20Z

TS-5022: fix silent exit problem




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---