[GitHub] trafficserver pull request #1365: TS-4896: TSHttp***ClientAddrGet/TSHttp***I...

2017-01-30 Thread shinrich 
Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1365


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1365: TS-4896: TSHttp***ClientAddrGet/TSHttp***I...

2017-01-26 Thread maskit 
Github user maskit commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1365#discussion_r97994347
  
--- Diff: proxy/ProxyClientSession.h ---
@@ -214,6 +214,19 @@ class ProxyClientSession : public VConnection
   ink_hrtime ssn_start_time;
   ink_hrtime ssn_last_txn_time;
 
+  virtual sockaddr const *
+  get_client_addr()
+  {
+NetVConnection *netvc = get_netvc();
+return netvc ? netvc->get_remote_addr() : NULL;
--- End diff --

nullptr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1365: TS-4896: TSHttp***ClientAddrGet/TSHttp***I...

2017-01-23 Thread shinrich 
GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1365

TS-4896: TSHttp***ClientAddrGet/TSHttp***IncomingAddrGet may return NULL

Several of our plugins would experience crashes once we tightened up clean 
up on session shutdown.  They assumed that the TSHttp{Txn|Ssn}ClientAddrGet and 
TSHttp{Txn|Ssn}IncomingAddrGet calls would never return NULL.   If the client 
initiates the shutdown, the underlying netvc may get cleaned up before the 
sessions, transactions, and state machines were completely shutdown.  The 
original code would return NULL in that case.  

In our version, we added this logic to cache the address information and 
use that data if the vc has been cleaned up.  This avoided spinning changes in 
the plugins.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver ts-4896

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1365.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1365


commit 1c8703c9d678f74daaf0e1184affb7eb428076e3
Author: Susan Hinrichs 
Date:   2017-01-24T01:46:15Z

TS-4896: TSHttpTxnClientAddrGet and TSHttpTxnIncomingAddrGet may return NULL




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---