[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[shinrich]

Github user shinrich closed the pull request at:

https://github.com/apache/trafficserver/pull/1370


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[shinrich]

Github user shinrich commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1370#discussion_r97871781
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4933,8 +4933,10 @@ HttpSM::do_http_server_open(bool raw)
 // between the statement above and the check below.
 // If this happens, we might go over the max by 1 but this is ok.
 if (sum >= t_state.http_config_param->server_max_connections) {
-  ink_assert(pending_action == nullptr);
-  pending_action = eventProcessor.schedule_in(this, 
HRTIME_MSECONDS(100));
+  // Eventually may want to have a queue as the origin_max_connection 
does to allow for a combination
+  // of retries and errors.  But at this point, we are just going to 
allow the error case.
+  t_state.current.state = HttpTransact::CONNECTION_ERROR;
+  call_transact_and_set_next_state(HttpTransact::HandleResponse);
   httpSessionManager.purge_keepalives();
--- End diff --

This is the order we are currently running in Yahoo production.  The 
purge_keepalives is just clearing out the global pool, so it should not 
interfere is the set next state.  This was pre-existing code.  I'm guessing the 
rationale is that is the system is loaded, we should be shutting down idle 
connections.  Could do the purge first I suppose.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[SolidWallOfCode]

Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1370#discussion_r97822530
  
--- Diff: proxy/http/HttpSM.cc ---
@@ -4933,8 +4933,10 @@ HttpSM::do_http_server_open(bool raw)
 // between the statement above and the check below.
 // If this happens, we might go over the max by 1 but this is ok.
 if (sum >= t_state.http_config_param->server_max_connections) {
-  ink_assert(pending_action == nullptr);
-  pending_action = eventProcessor.schedule_in(this, 
HRTIME_MSECONDS(100));
+  // Eventually may want to have a queue as the origin_max_connection 
does to allow for a combination
+  // of retries and errors.  But at this point, we are just going to 
allow the error case.
+  t_state.current.state = HttpTransact::CONNECTION_ERROR;
+  call_transact_and_set_next_state(HttpTransact::HandleResponse);
   httpSessionManager.purge_keepalives();
--- End diff --

Are you sure you want to do this after `call_transact_and_set_next_state`? 
Normal is to return the return value of that call.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1370: Issue #1369: proxy.config.http.server_max_...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1370

Issue #1369: proxy.config.http.server_max_connections over limit fail



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver issue-1369

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1370.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1370


commit e3b586998a9906de3540ce575a550eb72b3ce206
Author: Susan Hinrichs 
Date:   2017-01-24T03:43:59Z

Issue #1369: proxy.config.http.server_max_connections over limit should 
fail immediately




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---