[GitHub] trafficserver pull request #1565: Fix Assertion failure in the regex_revalid...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1565


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1565: Fix Assertion failure in the regex_revalid...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1565#discussion_r106033633
  
--- Diff: plugins/regex_revalidate/regex_revalidate.c ---
@@ -362,7 +362,7 @@ config_handler(TSCont cont, TSEvent event ATS_UNUSED, 
void *edata ATS_UNUSED)
 iptr = __sync_val_compare_and_swap(&(pstate->invalidate_list), 
pstate->invalidate_list, i);
 
 if (iptr) {
-  free_cont = TSContCreate(free_handler, NULL);
+  free_cont = TSContCreate(free_handler, TSMutexCreate());
--- End diff --

I'm ok with this (assuming this solves the problem, it's not immediately 
clear as to why it needs the mutex). However, this approach of a schedule 
"delete" seems bad, we should change this (later) to use ref-counted data 
instead. That would eliminate the entire free_cont, and is a better / more 
reliable pattern.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1565: Fix Assertion failure in the regex_revalid...

[shinrich]

GitHub user shinrich opened a pull request:

https://github.com/apache/trafficserver/pull/1565

Fix Assertion failure in the regex_revalidate plugin.

Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require
that the continuation associated with the TSCont parameter must have a 
mutex.

(cherry picked from commit 0b1f28b53174baf5cfff54a2d224ffbe09a64374)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shinrich/trafficserver issue-1561

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1565


commit a1755d6cc2bb43547962b0e4e4f61d62a2243150
Author: John J. Rushford 
Date:   2017-02-01T20:34:44Z

Fix Assertion failure in the regex_revalidate plugin.

Since TS-4387, Calls to TSContSchedule/TSContScheduleEvery(), require
that the continuation associated with the TSCont parameter must have a 
mutex.

(cherry picked from commit 0b1f28b53174baf5cfff54a2d224ffbe09a64374)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---