[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[zwoop]

Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1573


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1573#discussion_r105754317
  
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_proxy_resp_content_type_str(nullptr),
 m_proxy_resp_content_type_len(0),
 m_cache_lookup_url_canon_str(nullptr),
-m_cache_lookup_url_canon_len(0)
+m_cache_lookup_url_canon_len(-1)
--- End diff --

Yeah, it would be better to do it in another PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1573#discussion_r105749469
  
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_proxy_resp_content_type_str(nullptr),
 m_proxy_resp_content_type_len(0),
 m_cache_lookup_url_canon_str(nullptr),
-m_cache_lookup_url_canon_len(0)
+m_cache_lookup_url_canon_len(-1)
--- End diff --

```
diff --git a/proxy/logging/LogAccessHttp.cc b/proxy/logging/LogAccessHttp.cc
index 95a620e..b3b7490 100644
--- a/proxy/logging/LogAccessHttp.cc
+++ b/proxy/logging/LogAccessHttp.cc
@@ -57,9 +57,9 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_server_response(nullptr),
 m_cache_response(nullptr),
 m_client_req_url_str(nullptr),
-m_client_req_url_len(0),
+m_client_req_url_len(-1),
 m_client_req_url_canon_str(nullptr),
-m_client_req_url_canon_len(0),
+m_client_req_url_canon_len(-1),
 m_client_req_unmapped_url_canon_str(nullptr),
 m_client_req_unmapped_url_canon_len(-1),
 m_client_req_unmapped_url_path_str(nullptr),
@@ -67,9 +67,9 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_client_req_unmapped_url_host_str(nullptr),
 m_client_req_unmapped_url_host_len(-1),
 m_client_req_url_path_str(nullptr),
-m_client_req_url_path_len(0),
+m_client_req_url_path_len(-1),
 m_proxy_resp_content_type_str(nullptr),
-m_proxy_resp_content_type_len(0),
+m_proxy_resp_content_type_len(-1),
 m_cache_lookup_url_canon_str(nullptr),
 m_cache_lookup_url_canon_len(-1)
 {
```

But, I think I'd prefer to defer this until after we land this, to minimize 
last minute breakage of 7.1.0.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[zwoop]

Github user zwoop commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1573#discussion_r105746991
  
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_proxy_resp_content_type_str(nullptr),
 m_proxy_resp_content_type_len(0),
 m_cache_lookup_url_canon_str(nullptr),
-m_cache_lookup_url_canon_len(0)
+m_cache_lookup_url_canon_len(-1)
--- End diff --

Maybe, not sure which (if any) should stay zero though. But it seems the 
URL ones ought to be consistently -1. Let me check that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[bryancall]

Github user bryancall commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1573#discussion_r105724614
  
--- Diff: proxy/logging/LogAccessHttp.cc ---
@@ -71,7 +71,7 @@ LogAccessHttp::LogAccessHttp(HttpSM *sm)
 m_proxy_resp_content_type_str(nullptr),
 m_proxy_resp_content_type_len(0),
 m_cache_lookup_url_canon_str(nullptr),
-m_cache_lookup_url_canon_len(0)
+m_cache_lookup_url_canon_len(-1)
--- End diff --

Should have consistency on the len initialization values.  Set them all to 
-1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] trafficserver pull request #1573: #1481 Makes % work consistently, and...

[zwoop]

GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1573

#1481 Makes % work consistently, and at all



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver CLUC

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1573


commit 76fe1c6a4158e6ffaedd3c8d78c94a4edb81fce7
Author: Leif Hedstrom 
Date:   2017-03-13T17:14:24Z

#1481 Makes % work consistently, and at all




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---