[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}

2017-04-03 Thread zwoop
Github user zwoop closed the pull request at:

https://github.com/apache/trafficserver/pull/1620


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}

2017-03-31 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request:

https://github.com/apache/trafficserver/pull/1620#discussion_r109226751
  
--- Diff: doc/admin-guide/plugins/header_rewrite.en.rst ---
@@ -291,6 +293,35 @@ INCOMING-PORT
 TCP port, as a decimal integer, on which the incoming client connection was
 made.
 
+IP
+~~
+::
+
+cond %{IP:} 
+
+This is one of four possible IPs associated with the transaction, with the
--- End diff --

"IP" is "intellectual propety". I think you mean "IP addresses".


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}

2017-03-29 Thread zwoop
GitHub user zwoop opened a pull request:

https://github.com/apache/trafficserver/pull/1620

Adds a new condition, %{IP:}

This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.

cond %{SEND_RESPONSE_HDR_HOOK}
 set-header X-Client-IP %{IP:CLIENT}
 set-header X-Inbound-IP %{IP:INBOUND}
 set-header X-Server-IP %{IP:SERVER}
 set-header X-Outbound-IP %{IP:OUTBOUND}

In the case of a sockaddr not being populated, e.g. IP:SERVER on
a cache hit, the string is "" (empty).

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zwoop/trafficserver ConditionIp

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/trafficserver/pull/1620.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1620


commit 2e8f6eb86a4554e0eea64d8ff64f9725907d8e1f
Author: Leif Hedstrom 
Date:   2017-03-29T22:23:15Z

Adds a new condition, %{IP:}

This replaces the old %{CLIENT-IP}, and generalizes the access to
all four IP addresses. E.g.

cond %{SEND_RESPONSE_HDR_HOOK}
 set-header X-Client-IP %{IP:CLIENT}
 set-header X-Inbound-IP %{IP:INBOUND}
 set-header X-Server-IP %{IP:SERVER}
 set-header X-Outbound-IP %{IP:OUTBOUND}

In the case of a sockaddr not being populated, e.g. IP:SERVER on
a cache hit, the string is "" (empty).




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---