[jira] [Commented] (TS-1031) reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions

2011-12-09 Thread John Plevyak (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166654#comment-13166654
 ] 

John Plevyak commented on TS-1031:
--

I don't understand why this is necessary.  Nobody should call do_io_close() 
until they have cleared ALL pointers to the NetVC.  This seems like a hack to 
prevent buggy code from crashing in this particular way rather than just doing 
other bad things (including crashing in some other way).

 reduce lock in netHandler and reduce the possiblity of acquiring expire 
 server sessions
 ---

 Key: TS-1031
 URL: https://issues.apache.org/jira/browse/TS-1031
 Project: Traffic Server
  Issue Type: Improvement
  Components: Core
Affects Versions: 3.1.1
Reporter: Zhao Yongming
Assignee: weijin
Priority: Minor
 Attachments: ts-1031.diff


 reduce lock in netHandler and reduce the possiblity of acquiring expire 
 server sessions. put your patch here for review :D

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] [Commented] (TS-1031) reduce lock in netHandler and reduce the possiblity of acquiring expire server sessions

2011-11-29 Thread Alan M. Carroll (Commented) (JIRA)

[ 
https://issues.apache.org/jira/browse/TS-1031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13159343#comment-13159343
 ] 

Alan M. Carroll commented on TS-1031:
-

This is something of a hack.

Longer term what would be better is to separate IO closure with re-allocation. 
If we used something like Ptr (from lib/ts/Ptr.h) to reference count and not 
put the VC back on the free list until the last reference clears, then this 
would be far less of a problem. It is plausible that everything crash has 
happened after a VC was free'd rather than just closed.

The one issue would be cross thread freeing, although that should not be a 
problem unless there is a consistent drift of VCs to a single thread, although 
it might be that VCs are really freed when the thread local free list grows too 
large in which case this is just not maximally efficient.

 reduce lock in netHandler and reduce the possiblity of acquiring expire 
 server sessions
 ---

 Key: TS-1031
 URL: https://issues.apache.org/jira/browse/TS-1031
 Project: Traffic Server
  Issue Type: Improvement
  Components: Core
Affects Versions: 3.1.1
Reporter: Zhao Yongming
Assignee: weijin
Priority: Minor
 Attachments: ts-1031.diff


 reduce lock in netHandler and reduce the possiblity of acquiring expire 
 server sessions. put your patch here for review :D

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira