[jira] [Commented] (TS-1734) VMap functionality is missing a the vmap_config tool for bringing ip addresses up and down; but appears to be largely dead code
[ https://issues.apache.org/jira/browse/TS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609339#comment-13609339 ] ASF subversion and git services commented on TS-1734: - Commit 1a2ebccb112987acf450a5d678b6185c5d98257f in branch refs/heads/master from James Peach jpe...@apache.org [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=1a2ebcc ] TS-1734: fix wrong jira number VMap functionality is missing a the vmap_config tool for bringing ip addresses up and down; but appears to be largely dead code --- Key: TS-1734 URL: https://issues.apache.org/jira/browse/TS-1734 Project: Traffic Server Issue Type: Bug Components: Management Affects Versions: 3.3.4, 3.3.0, 3.2.4 Reporter: John Kew Assignee: Igor Galić Fix For: 3.3.2 Attachments: remove_vip_rebalance.patch Virtual IPs were once managed such that within a cluster they would automatically rebalance themselves between nodes by bringing subinterfaces up and down. After ATS was open sourced the original setuid tool, vip_config (or traffic_vip_config) was inadvertently removed; but the code which depended on this tool was not cleaned up. Since modern deployments either do not use this tool at all (because it was broken for a few years) and modern deployments also have some central system for managing cluster state reliably, we do not need VMap to implement some scheme for automatically rebalancing the ips. This patch keeps much of the code for detecting ip address conflicts and for receiving the multicast messages from the cluster; but we remove all instances where we either bring up/down an interface. Deployments should manage this through external state systems. Note: VIPs do not actually bind to the specific addresses in vaddrs; this is just an operations convience to ensure that a cluster has no ip conflicts or unmanaged vips. This feature becomes even less useful. LocalManager.cc would have to be modified in some way to set this up properly. Note: The *right* thing to do here may be to recall that old tool and let VMap do it's thing. Note: Another *right* thing to do may be to remove VMap entirely, along with the associated cluster messages. At least with this exiting changeset we can detect ip address conflicts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1734) VMap functionality is missing a the vmap_config tool for bringing ip addresses up and down; but appears to be largely dead code
[ https://issues.apache.org/jira/browse/TS-1734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13609341#comment-13609341 ] James Peach commented on TS-1734: - Commit dbf7124a945f38204b0548b1d2fdc54f51ed84ce in branch refs/heads/master from John Kew [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=dbf7124 ] (commit was mis-labeled for TS-1735 ... sign) VMap functionality is missing a the vmap_config tool for bringing ip addresses up and down; but appears to be largely dead code --- Key: TS-1734 URL: https://issues.apache.org/jira/browse/TS-1734 Project: Traffic Server Issue Type: Bug Components: Management Affects Versions: 3.3.4, 3.3.0, 3.2.4 Reporter: John Kew Assignee: Igor Galić Fix For: 3.3.2 Attachments: remove_vip_rebalance.patch Virtual IPs were once managed such that within a cluster they would automatically rebalance themselves between nodes by bringing subinterfaces up and down. After ATS was open sourced the original setuid tool, vip_config (or traffic_vip_config) was inadvertently removed; but the code which depended on this tool was not cleaned up. Since modern deployments either do not use this tool at all (because it was broken for a few years) and modern deployments also have some central system for managing cluster state reliably, we do not need VMap to implement some scheme for automatically rebalancing the ips. This patch keeps much of the code for detecting ip address conflicts and for receiving the multicast messages from the cluster; but we remove all instances where we either bring up/down an interface. Deployments should manage this through external state systems. Note: VIPs do not actually bind to the specific addresses in vaddrs; this is just an operations convience to ensure that a cluster has no ip conflicts or unmanaged vips. This feature becomes even less useful. LocalManager.cc would have to be modified in some way to set this up properly. Note: The *right* thing to do here may be to recall that old tool and let VMap do it's thing. Note: Another *right* thing to do may be to remove VMap entirely, along with the associated cluster messages. At least with this exiting changeset we can detect ip address conflicts. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
