[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598585#comment-14598585 ] ASF subversion and git services commented on TS-1774: - Commit 738d9ed3ca1882bfc1855f87d3ccb5bf8a59c2f9 in trafficserver's branch refs/heads/master from [~danobi] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=738d9ed ] TS-1774: Move hrtime functions to Thread class. This closes #185. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Alan M. Carroll Labels: newbie Fix For: 6.1.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14598586#comment-14598586 ] ASF GitHub Bot commented on TS-1774: Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/185 Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Alan M. Carroll Labels: newbie Fix For: 6.1.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14590067#comment-14590067 ] ASF GitHub Bot commented on TS-1774: Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-112872433 https://issues.apache.org/jira/browse/TS-1774 Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Assignee: Alan M. Carroll Labels: newbie Fix For: 6.1.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582344#comment-14582344 ] ASF GitHub Bot commented on TS-1774: Github user danobi commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-11123 Fixed the merge conflicts. Also updated any other uses of ink_get_hrtime() / ink_get_based_hrtime() that occurred during the life of this PR. There's quite a few commits now, let me know if this should all be squashed. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579563#comment-14579563 ] ASF GitHub Bot commented on TS-1774: Github user danobi commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-110504046 Fixed. However, I am unsure how to handle all the merge conflicts. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14579834#comment-14579834 ] ASF GitHub Bot commented on TS-1774: Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-110553260 I think the most likely cause is the code base was reformatted and you're being hit by that. You need to reformat you code base to match before trying to rebase. You can find them here - https://bintray.com/apache/trafficserver/clang-format-tools/view Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14518128#comment-14518128 ] ASF GitHub Bot commented on TS-1774: Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-97224460 Sorry for the delay, I got distracted. I think it's OK except the method name should be just get_hrtime(), there's no need for the ink_ prefix if it's a method. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492512#comment-14492512 ] ASF GitHub Bot commented on TS-1774: Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-92401379 Doe we even need the new Thread APIs? Can we just use Thread::cur_time directly? Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14492522#comment-14492522 ] ASF GitHub Bot commented on TS-1774: Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/185#issuecomment-92403352 Isolation and modularity? It seems better to discuss this on the original bug - it's not really a problem with the pull request. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377215#comment-14377215 ] bwahn commented on TS-1774: --- It should make ink_hrtime_get() function in Thread.cc. and I will review the class. thanks [~amc] Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377116#comment-14377116 ] bwahn commented on TS-1774: --- I can't find ink_hrtime_get() funciton on master branch. It will be resolved 'won't fixed'. Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14377213#comment-14377213 ] Alan M. Carroll commented on TS-1774: - https://github.com/apache/trafficserver/blob/master/iocore/eventsystem/P_Thread.h#L57 Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-1774) Make ink_hrtime_get() in Thread.cc member of the Thread class
[ https://issues.apache.org/jira/browse/TS-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198608#comment-14198608 ] Alan M. Carroll commented on TS-1774: - The problem here is a global function (ink_get_hrtime()) depends on data in a class instance. For that reason it should be a method on the class, not a global function. Probably Thread::get_hrtime(). Make ink_hrtime_get() in Thread.cc member of the Thread class - Key: TS-1774 URL: https://issues.apache.org/jira/browse/TS-1774 Project: Traffic Server Issue Type: Improvement Components: Core Reporter: Leif Hedstrom Labels: newbie Fix For: 6.0.0 It's somewhat confusing that e..g ink_get_hrtime() is not a member of the Thread class, yet, relies on Thread::cur_time. Why is that ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
