[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-15 Thread John Rushford (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959113#comment-14959113
 ] 

John Rushford commented on TS-2118:
---

James, I see the changes, thanks for that.  I just tested in our build 
environment and the plugin builds fine with the 4.4.7 compiler we use.

> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
> Attachments: TS-2118.diff
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-15 Thread James Peach (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959061#comment-14959061
 ] 

James Peach commented on TS-2118:
-

[~jrushford] I dropped the {{-std=c++0x}} changes when I merged this because I 
didn't want to have two separate checks for C++11. I think that the right 
approach might be to change the existing macro we use to separately check for 
{{}}.

> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
> Attachments: TS-2118.diff
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-15 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14959055#comment-14959055
 ] 

ASF subversion and git services commented on TS-2118:
-

Commit 08e27ba984b11610e4544da6be8e1270d66e1f5f in trafficserver's branch 
refs/heads/master from [~jrushford]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=08e27ba ]

TS-2118: add the memcached_remap plugin to the build


> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
> Attachments: TS-2118.diff
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-14 Thread John Rushford (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958063#comment-14958063
 ] 

John Rushford commented on TS-2118:
---

Hi James,

I added the m4 file and the AX_CXX_COMPILE_STDCXX_0X macro and 
AM_CONDITIONAL so that it would build with older compilers like mine, 
gcc 4.4.7 that use the -std=c++0x flag.

John




> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
> Attachments: TS-2118.diff
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-14 Thread James Peach (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14958006#comment-14958006
 ] 

James Peach commented on TS-2118:
-

Looks reasonable, though I'm not sure about the C++11 detection. We already use 
{{AX_CXX_COMPILE_STDCXX_11}}. Looking at the memcached plugin, I didn't really 
see anything that looked like it needed C++11.

> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
> Attachments: TS-2118.diff
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-14 Thread James Peach (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957891#comment-14957891
 ] 

James Peach commented on TS-2118:
-

Looks like the patch didn't attach?

> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-2118) memcached plugin is in the source tree but does not build

2015-10-14 Thread John Rushford (JIRA) 

[ 
https://issues.apache.org/jira/browse/TS-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957883#comment-14957883
 ] 

John Rushford commented on TS-2118:
---

See the attached patch.  I've made modifications so that this plugin may be 
built if the package libmemcached 1.0 or greater has been installed on the 
build host and if --enable-experimental-plugins is used with the configure 
script.  If libmemcached 1.0 or greater is not installed, the plugin will not 
be built but the build will proceed and build all other experimental plugins.  
See the attached TS-2118.diff

> memcached plugin is in the source tree but does not build
> -
>
> Key: TS-2118
> URL: https://issues.apache.org/jira/browse/TS-2118
> Project: Traffic Server
>  Issue Type: Bug
>Reporter: Igor Galić
>Assignee: John Rushford
>  Labels: newbie
> Fix For: 6.1.0
>
>
> The memcached_remap plugin is currently in our experimental plugin tree, but 
> doesn't build even with {{--enable-experimental}}.
> This should be fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)