[jira] [Commented] (TS-2762) Core dump when benchmarking SPDY

[Yunkai Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13985236#comment-13985236
 ] 

Yunkai Zhang commented on TS-2762:
--

Nice catch!

When working with SPDY, Multiple FetchSM of one SPDY session may be executed 
concurrently, as a result, THREAD_ALLOC_INIT() called by FetchSM could be in 
race condition in the old code.

 Core dump when benchmarking SPDY
 

 Key: TS-2762
 URL: https://issues.apache.org/jira/browse/TS-2762
 Project: Traffic Server
  Issue Type: Bug
  Components: SPDY
Reporter: Bryan Call
Assignee: Bryan Call
  Labels: spdy, yahoo
 Fix For: 5.0.0


 The problems exist when trying to use the proxy allocator from a different 
 thread to allocate a HttpClientSession.
 {code}
 /usr/local/bin/traffic_server - STACK TRACE:
 /lib64/libpthread.so.0(+0xf750)[0x2b6270ec2750]
 /usr/local/bin/traffic_server(_ZN14HttpAcceptCont9mainEventEiPv+0x179)[0x50ee99]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore17state_send_acceptEiPv+0x9f)[0x4d89af]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore7connectEv+0x21)[0x4d8c81]
 /usr/local/bin/traffic_server(TSHttpConnectWithProtoStack+0xb0)[0x4b8380]
 /usr/local/bin/traffic_server(_ZN7FetchSM11httpConnectEv+0x28)[0x4c3be8]
 /usr/local/bin/traffic_server[0x57a25a]
 /usr/local/bin/traffic_server(_Z26spdy_on_ctrl_recv_callbackP15spdylay_session18spdylay_frame_typeP13spdylay_framePv+0x8
 1c)[0x57b56c]
 /usr/local/lib/libspdylay.so.7(spdylay_session_on_syn_stream_received+0x100)[0x2b62701cc010]
 /usr/local/lib/libspdylay.so.7(spdylay_session_mem_recv+0xcb7)[0x2b62701ce4c7]
 /usr/local/lib/libspdylay.so.7(spdylay_session_recv+0x51)[0x2b62701ce791]
 /usr/local/bin/traffic_server[0x578aff]
 /usr/local/bin/traffic_server(_ZN18UnixNetVConnection19readSignalAndUpdateEi+0x34)[0x695564]
 /usr/local/bin/traffic_server(_ZN17SSLNetVConnection11net_read_ioEP10NetHandlerP7EThread+0xca1)[0x684cc1]
 /usr/local/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x68c0e2]
 /usr/local/bin/traffic_server(_ZN7EThread7executeEv+0xad3)[0x6bbc63]
 /usr/local/bin/traffic_server[0x6ba69a]
 /lib64/libpthread.so.0(+0x7f33)[0x2b6270ebaf33]
 /lib64/libc.so.6(clone+0x6d)[0x2b6271f56ded]
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (TS-2762) Core dump when benchmarking SPDY

[Bryan Call (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984528#comment-13984528
 ] 

Bryan Call commented on TS-2762:


Simple fix:

{code}
diff --git a/proxy/http/HttpAcceptCont.cc b/proxy/http/HttpAcceptCont.cc
index d3744e7..b6cfff6 100644
--- a/proxy/http/HttpAcceptCont.cc
+++ b/proxy/http/HttpAcceptCont.cc
@@ -59,7 +59,7 @@ HttpAcceptCont::mainEvent(int event, void *data)
 if (is_debug_tag_set(http_seq))
   Debug(http_seq, [HttpAcceptCont:mainEvent %p] accepted connection 
from %s transport type = %d, netvc, ats_ip_nptop(client_ip, ipb, sizeof(ipb)), 
netvc-attributes);

-HttpClientSession *new_session = 
THREAD_ALLOC_INIT(httpClientSessionAllocator, netvc-thread);
+HttpClientSession *new_session = 
THREAD_ALLOC_INIT(httpClientSessionAllocator, this_ethread());

// copy over session related data.
 new_session-f_outbound_transparent = f_outbound_transparent;
{code}

 Core dump when benchmarking SPDY
 

 Key: TS-2762
 URL: https://issues.apache.org/jira/browse/TS-2762
 Project: Traffic Server
  Issue Type: Bug
  Components: SPDY
Reporter: Bryan Call
Assignee: Bryan Call
  Labels: spdy, yahoo
 Fix For: 5.0.0


 The problems exist when trying to use the proxy allocator from a different 
 thread to allocate a HttpClientSession.
 {code}
 /usr/local/bin/traffic_server - STACK TRACE:
 /lib64/libpthread.so.0(+0xf750)[0x2b6270ec2750]
 /usr/local/bin/traffic_server(_ZN14HttpAcceptCont9mainEventEiPv+0x179)[0x50ee99]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore17state_send_acceptEiPv+0x9f)[0x4d89af]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore7connectEv+0x21)[0x4d8c81]
 /usr/local/bin/traffic_server(TSHttpConnectWithProtoStack+0xb0)[0x4b8380]
 /usr/local/bin/traffic_server(_ZN7FetchSM11httpConnectEv+0x28)[0x4c3be8]
 /usr/local/bin/traffic_server[0x57a25a]
 /usr/local/bin/traffic_server(_Z26spdy_on_ctrl_recv_callbackP15spdylay_session18spdylay_frame_typeP13spdylay_framePv+0x8
 1c)[0x57b56c]
 /usr/local/lib/libspdylay.so.7(spdylay_session_on_syn_stream_received+0x100)[0x2b62701cc010]
 /usr/local/lib/libspdylay.so.7(spdylay_session_mem_recv+0xcb7)[0x2b62701ce4c7]
 /usr/local/lib/libspdylay.so.7(spdylay_session_recv+0x51)[0x2b62701ce791]
 /usr/local/bin/traffic_server[0x578aff]
 /usr/local/bin/traffic_server(_ZN18UnixNetVConnection19readSignalAndUpdateEi+0x34)[0x695564]
 /usr/local/bin/traffic_server(_ZN17SSLNetVConnection11net_read_ioEP10NetHandlerP7EThread+0xca1)[0x684cc1]
 /usr/local/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x68c0e2]
 /usr/local/bin/traffic_server(_ZN7EThread7executeEv+0xad3)[0x6bbc63]
 /usr/local/bin/traffic_server[0x6ba69a]
 /lib64/libpthread.so.0(+0x7f33)[0x2b6270ebaf33]
 /lib64/libc.so.6(clone+0x6d)[0x2b6271f56ded]
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (TS-2762) Core dump when benchmarking SPDY

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984556#comment-13984556
 ] 

ASF subversion and git services commented on TS-2762:
-

Commit 5bfe7168306f1004a9114f2cc157036ca53e8663 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=5bfe716 ]

TS-2762: Core dump when benchmarking SPDY


 Core dump when benchmarking SPDY
 

 Key: TS-2762
 URL: https://issues.apache.org/jira/browse/TS-2762
 Project: Traffic Server
  Issue Type: Bug
  Components: SPDY
Reporter: Bryan Call
Assignee: Bryan Call
  Labels: spdy, yahoo
 Fix For: 5.0.0


 The problems exist when trying to use the proxy allocator from a different 
 thread to allocate a HttpClientSession.
 {code}
 /usr/local/bin/traffic_server - STACK TRACE:
 /lib64/libpthread.so.0(+0xf750)[0x2b6270ec2750]
 /usr/local/bin/traffic_server(_ZN14HttpAcceptCont9mainEventEiPv+0x179)[0x50ee99]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore17state_send_acceptEiPv+0x9f)[0x4d89af]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore7connectEv+0x21)[0x4d8c81]
 /usr/local/bin/traffic_server(TSHttpConnectWithProtoStack+0xb0)[0x4b8380]
 /usr/local/bin/traffic_server(_ZN7FetchSM11httpConnectEv+0x28)[0x4c3be8]
 /usr/local/bin/traffic_server[0x57a25a]
 /usr/local/bin/traffic_server(_Z26spdy_on_ctrl_recv_callbackP15spdylay_session18spdylay_frame_typeP13spdylay_framePv+0x8
 1c)[0x57b56c]
 /usr/local/lib/libspdylay.so.7(spdylay_session_on_syn_stream_received+0x100)[0x2b62701cc010]
 /usr/local/lib/libspdylay.so.7(spdylay_session_mem_recv+0xcb7)[0x2b62701ce4c7]
 /usr/local/lib/libspdylay.so.7(spdylay_session_recv+0x51)[0x2b62701ce791]
 /usr/local/bin/traffic_server[0x578aff]
 /usr/local/bin/traffic_server(_ZN18UnixNetVConnection19readSignalAndUpdateEi+0x34)[0x695564]
 /usr/local/bin/traffic_server(_ZN17SSLNetVConnection11net_read_ioEP10NetHandlerP7EThread+0xca1)[0x684cc1]
 /usr/local/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x68c0e2]
 /usr/local/bin/traffic_server(_ZN7EThread7executeEv+0xad3)[0x6bbc63]
 /usr/local/bin/traffic_server[0x6ba69a]
 /lib64/libpthread.so.0(+0x7f33)[0x2b6270ebaf33]
 /lib64/libc.so.6(clone+0x6d)[0x2b6271f56ded]
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (TS-2762) Core dump when benchmarking SPDY

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-2762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13984557#comment-13984557
 ] 

ASF subversion and git services commented on TS-2762:
-

Commit df0e9bb0537b460b418544cb67d57b20e63d1cd7 in trafficserver's branch 
refs/heads/master from [~bcall]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=df0e9bb ]

updated changes to add TS-2762 and remove TS-1125


 Core dump when benchmarking SPDY
 

 Key: TS-2762
 URL: https://issues.apache.org/jira/browse/TS-2762
 Project: Traffic Server
  Issue Type: Bug
  Components: SPDY
Reporter: Bryan Call
Assignee: Bryan Call
  Labels: spdy, yahoo
 Fix For: 5.0.0


 The problems exist when trying to use the proxy allocator from a different 
 thread to allocate a HttpClientSession.
 {code}
 /usr/local/bin/traffic_server - STACK TRACE:
 /lib64/libpthread.so.0(+0xf750)[0x2b6270ec2750]
 /usr/local/bin/traffic_server(_ZN14HttpAcceptCont9mainEventEiPv+0x179)[0x50ee99]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore17state_send_acceptEiPv+0x9f)[0x4d89af]
 /usr/local/bin/traffic_server(_ZN12PluginVCCore7connectEv+0x21)[0x4d8c81]
 /usr/local/bin/traffic_server(TSHttpConnectWithProtoStack+0xb0)[0x4b8380]
 /usr/local/bin/traffic_server(_ZN7FetchSM11httpConnectEv+0x28)[0x4c3be8]
 /usr/local/bin/traffic_server[0x57a25a]
 /usr/local/bin/traffic_server(_Z26spdy_on_ctrl_recv_callbackP15spdylay_session18spdylay_frame_typeP13spdylay_framePv+0x8
 1c)[0x57b56c]
 /usr/local/lib/libspdylay.so.7(spdylay_session_on_syn_stream_received+0x100)[0x2b62701cc010]
 /usr/local/lib/libspdylay.so.7(spdylay_session_mem_recv+0xcb7)[0x2b62701ce4c7]
 /usr/local/lib/libspdylay.so.7(spdylay_session_recv+0x51)[0x2b62701ce791]
 /usr/local/bin/traffic_server[0x578aff]
 /usr/local/bin/traffic_server(_ZN18UnixNetVConnection19readSignalAndUpdateEi+0x34)[0x695564]
 /usr/local/bin/traffic_server(_ZN17SSLNetVConnection11net_read_ioEP10NetHandlerP7EThread+0xca1)[0x684cc1]
 /usr/local/bin/traffic_server(_ZN10NetHandler12mainNetEventEiP5Event+0x1f2)[0x68c0e2]
 /usr/local/bin/traffic_server(_ZN7EThread7executeEv+0xad3)[0x6bbc63]
 /usr/local/bin/traffic_server[0x6ba69a]
 /lib64/libpthread.so.0(+0x7f33)[0x2b6270ebaf33]
 /lib64/libc.so.6(clone+0x6d)[0x2b6271f56ded]
 {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)