[jira] [Commented] (TS-3342) Non-standard method in bad request can cause crash
[
https://issues.apache.org/jira/browse/TS-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14356166#comment-14356166
]
William Bardwell commented on TS-3342:
--
Commit 66bdd406f92e61bd0fdc86afe308a7563093896f in trafficserver's branch
refs/heads/master
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=66bdd40 ]
Non-standard method in bad request can cause crash
--
Key: TS-3342
URL: https://issues.apache.org/jira/browse/TS-3342
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: William Bardwell
Assignee: William Bardwell
Labels: review
Fix For: 5.3.0
Attachments: TS-3342.diff
Fix is to check for a normal sort of method (that would actually need a cache
lookup) in HttpTransact::HandleCacheOpenReadMiss() to do
{code}
s-cache_info.action = CACHE_DO_NO_ACTION;
{code}
instead of
{code}
s-cache_info.action = CACHE_PREPARE_TO_WRITE;
{code}
for anything weird. But I am concerned that this might cause problems if
someone wants to add support for a weird method...but maybe that never works
right with the cache anyway...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3342) Non-standard method in bad request can cause crash
[
https://issues.apache.org/jira/browse/TS-3342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14353883#comment-14353883
]
Leif Hedstrom commented on TS-3342:
---
William, you going to land this?
Non-standard method in bad request can cause crash
--
Key: TS-3342
URL: https://issues.apache.org/jira/browse/TS-3342
Project: Traffic Server
Issue Type: Bug
Components: Core
Reporter: William Bardwell
Assignee: William Bardwell
Labels: review
Fix For: 5.3.0
Attachments: TS-3342.diff
Fix is to check for a normal sort of method (that would actually need a cache
lookup) in HttpTransact::HandleCacheOpenReadMiss() to do
{code}
s-cache_info.action = CACHE_DO_NO_ACTION;
{code}
instead of
{code}
s-cache_info.action = CACHE_PREPARE_TO_WRITE;
{code}
for anything weird. But I am concerned that this might cause problems if
someone wants to add support for a weird method...but maybe that never works
right with the cache anyway...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
