[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15425182#comment-15425182 ] Eric Schwartz commented on TS-4012: --- TS-3612 seems to have fixed this because HttpSM simply has access to the underlying netvc from the parent session. > tcp_reused log field doesn't work for http2 > --- > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2, Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 7.0.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424915#comment-15424915 ] Eric Schwartz commented on TS-4012: --- [~bcall] running a test today on our internal traffic with TS-3612 to see if that fixed this. (It may have) Will update this with results too. > tcp_reused log field doesn't work for http2 > --- > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2, Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 7.0.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424769#comment-15424769 ] Bryan Call commented on TS-4012: [~es] Do you think you will be able to do it in the next 2 weeks for the 7.0.0 release? If not move it out please. > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2, Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 7.0.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385052#comment-15385052 ] Eric Schwartz commented on TS-4012: --- Yes! I should be able to fix this now that TS-3612 is finalized. On Tuesday, July 19, 2016 4:12 PM, Leif Hedstrom (JIRA) wrote: [ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385044#comment-15385044 ] Leif Hedstrom commented on TS-4012: --- [~erics273]Are we getting a new PR for this? Or should we close this? -- This message was sent by Atlassian JIRA (v6.3.4#6332) > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2, Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 7.0.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385044#comment-15385044 ] Leif Hedstrom commented on TS-4012: --- [~erics273]Are we getting a new PR for this? Or should we close this? > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: HTTP/2, Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 7.0.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032104#comment-15032104 ] ASF GitHub Bot commented on TS-4012: Github user ericcarlschwartz closed the pull request at: https://github.com/apache/trafficserver/pull/336 > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 6.1.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032103#comment-15032103 ] ASF GitHub Bot commented on TS-4012: Github user ericcarlschwartz commented on the pull request: https://github.com/apache/trafficserver/pull/336#issuecomment-160693148 Am going to close this PR then. When TS-3612 is done I'll make the change for this JIRA so that we've got this working in open source. > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 6.1.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031975#comment-15031975 ] ASF GitHub Bot commented on TS-4012: Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/336#issuecomment-160666396 I think we have decided to put this off until we have a patch for TS-3612 which will make a much cleaner implementation possible. > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 6.1.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004862#comment-15004862 ] ASF GitHub Bot commented on TS-4012: GitHub user ericcarlschwartz opened a pull request: https://github.com/apache/trafficserver/pull/336 [TS-4012] tcp_reused log field doesn't work for http2/spdy JIRA: https://issues.apache.org/jira/browse/TS-4012 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ericcarlschwartz/trafficserver ts-4012 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/336.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #336 commit b2304952f701379e37efd6135c904e34876be95e Author: ericcarlschwartz Date: 2015-11-13T22:59:11Z [TS-4012] tcp_reused log field doesn't work for http2/spdy > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > Fix For: 6.1.0 > > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999706#comment-14999706 ] Bryan Call commented on TS-4012: done > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz >Assignee: Eric Schwartz > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4012) tcp_reused log field doesn't work for http2/spdy
[ https://issues.apache.org/jira/browse/TS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999396#comment-14999396 ] Eric Schwartz commented on TS-4012: --- Also, could someone assign this to me? > tcp_reused log field doesn't work for http2/spdy > > > Key: TS-4012 > URL: https://issues.apache.org/jira/browse/TS-4012 > Project: Traffic Server > Issue Type: Bug > Components: Logging >Reporter: Eric Schwartz > > This is something we noticed at Yahoo! > Because it uses the HttpClientSession transact_count, the tcp_reused log > field will not properly work for http2 and spdy, where the HttpClientSession > isn't reused. > We need to essentially count the number of initiated streams instead. > We've got a fix that does this for HTTP2. With SPDY eventually dying off, > does it make sense to also submit a change to fix this for SPDY? We have code > to do this as well, but it currently involves an H2 dependency that might be > undesirable. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
