[jira] [Commented] (TS-4845) NULL dereference in url_sig

[Phil Sorber (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629569#comment-15629569
 ] 

Phil Sorber commented on TS-4845:
-

[~jrushford], can you create a back port PR for this if it affects 6.2.x?

> NULL dereference in url_sig
> ---
>
> Key: TS-4845
> URL: https://issues.apache.org/jira/browse/TS-4845
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: James Peach
>Assignee: John Rushford
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Seen in the static analyzer:
> {noformat}
> Making all in url_sig
>   CC   url_sig.lo
> url_sig.c:564:38: warning: Null pointer argument in call to string length 
> function
>   app_qry = getAppQueryString(query, strlen(query));
>  ^
> 1 warning generated.
> {noformat}
> If there is no query string you can still do {{goto allow}}, but it looks 
> like the code assumes missing query string will always {{goto deny}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (TS-4845) NULL dereference in url_sig

[Bryan Call (JIRA)]

[ 
https://issues.apache.org/jira/browse/TS-4845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15570053#comment-15570053
 ] 

Bryan Call commented on TS-4845:


This was in master at the time the 7.0.x branch was created.

> NULL dereference in url_sig
> ---
>
> Key: TS-4845
> URL: https://issues.apache.org/jira/browse/TS-4845
> Project: Traffic Server
>  Issue Type: Bug
>  Components: Plugins
>Reporter: James Peach
>Assignee: John Rushford
> Fix For: 7.0.0
>
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Seen in the static analyzer:
> {noformat}
> Making all in url_sig
>   CC   url_sig.lo
> url_sig.c:564:38: warning: Null pointer argument in call to string length 
> function
>   app_qry = getAppQueryString(query, strlen(query));
>  ^
> 1 warning generated.
> {noformat}
> If there is no query string you can still do {{goto allow}}, but it looks 
> like the code assumes missing query string will always {{goto deny}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)