[jira] [Commented] (TS-917) url_mapping objects don't seem to be deleted
[
https://issues.apache.org/jira/browse/TS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125315#comment-13125315
]
Leif Hedstrom commented on TS-917:
--
Manjesh: I took a look at this, and I don't quite see it. First, I tried it by
reloading the remap.config lots of times, and I see no indications of memory
being leaked. ps and valgrind both says there's no leak.
Secondly, looking at the code, it looks like it should free it, e.g.
{code}
forl_LL(T, iter, m_value_list)
delete iter;
m_value_list.clear();
{code}
If I'm not mistaken, this invokes the destructor for the url_mapping. Or are
there other places where this is missing? Perhaps something with URL regexes
(which I didn't test)?
url_mapping objects don't seem to be deleted
Key: TS-917
URL: https://issues.apache.org/jira/browse/TS-917
Project: Traffic Server
Issue Type: Bug
Components: Remap API
Affects Versions: 3.0.0
Reporter: Manjesh Nilange
Assignee: Leif Hedstrom
Fix For: 3.1.1
In the recent changes to data structures in
UrlRewrite/UrlMappingPathIndex/UrlMappingContainer classes, the url_mapping
itself is not deleted, I think. The PathIndex, Trie objects are cleaned up,
but not the url_mapping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-917) url_mapping objects don't seem to be deleted
[
https://issues.apache.org/jira/browse/TS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125319#comment-13125319
]
Leif Hedstrom commented on TS-917:
--
Hmmm, no, it looks like the regex maps should also free the url_mapping:
{code}
forl_LL(RegexMapping, list_iter, mappings) {
delete list_iter-url_map;
{code}
Any thoughts? I'd like to clarify this, so we can either close it, or get some
ideas of where exactly we're leaking.
Thanks!
url_mapping objects don't seem to be deleted
Key: TS-917
URL: https://issues.apache.org/jira/browse/TS-917
Project: Traffic Server
Issue Type: Bug
Components: Remap API
Affects Versions: 3.0.0
Reporter: Manjesh Nilange
Assignee: Leif Hedstrom
Fix For: 3.1.1
In the recent changes to data structures in
UrlRewrite/UrlMappingPathIndex/UrlMappingContainer classes, the url_mapping
itself is not deleted, I think. The PathIndex, Trie objects are cleaned up,
but not the url_mapping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-917) url_mapping objects don't seem to be deleted
[ https://issues.apache.org/jira/browse/TS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13125346#comment-13125346 ] Manjesh Nilange commented on TS-917: Leif, I think you are right. I don't think there is a leak. I was not sure if url_mapping objects were deleted, but I did not see this change - http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http/remap/Trie.h?diff_format=lr1=1085816r2=1085815pathrev=1085816. It's not intuitive or clean as it is UrlRewrite.cc/url_rewrite class that does the new() and the Trie class does the delete. I don't think the Trie is being used anywhere else, but the user would have to know that the Trie will automatically delete the objects it holds even though it does not create them. As for the RegexMapping, I didn't get what you are saying. The delete line does delete the url_mapping object and then the RegexMapping object itself is deleted later in the code. So both objects are cleaned up. url_mapping objects don't seem to be deleted Key: TS-917 URL: https://issues.apache.org/jira/browse/TS-917 Project: Traffic Server Issue Type: Bug Components: Remap API Affects Versions: 3.0.0 Reporter: Manjesh Nilange Assignee: Leif Hedstrom Fix For: 3.1.1 In the recent changes to data structures in UrlRewrite/UrlMappingPathIndex/UrlMappingContainer classes, the url_mapping itself is not deleted, I think. The PathIndex, Trie objects are cleaned up, but not the url_mapping. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
