[jira] [Work logged] (TS-3204) Crash when body_factory file is empty
[ https://issues.apache.org/jira/browse/TS-3204?focusedWorklogId=30496&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30496 ] ASF GitHub Bot logged work on TS-3204: -- Author: ASF GitHub Bot Created on: 12/Oct/16 14:10 Start Date: 12/Oct/16 14:10 Worklog Time Spent: 10m Work Description: Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1081 Issue Time Tracking --- Worklog Id: (was: 30496) Time Spent: 50m (was: 40m) > Crash when body_factory file is empty > - > > Key: TS-3204 > URL: https://issues.apache.org/jira/browse/TS-3204 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: Thomas Jackson >Assignee: Jari Alhonen > Fix For: 7.1.0 > > Time Spent: 50m > Remaining Estimate: 0h > > Reproducible on 5.0.x > If you have a body factory page that is completely empty, after some time I > start getting very obscure crashes all over the place (ssl, remap, etc.). If > I add a single whitespace it works fine, seems that something in there > doesn't like empty files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3204) Crash when body_factory file is empty
[ https://issues.apache.org/jira/browse/TS-3204?focusedWorklogId=30221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30221 ] ASF GitHub Bot logged work on TS-3204: -- Author: ASF GitHub Bot Created on: 06/Oct/16 03:41 Start Date: 06/Oct/16 03:41 Worklog Time Spent: 10m Work Description: Github user alhonen commented on the issue: https://github.com/apache/trafficserver/pull/1081 In load_from_file(). If the file length is 0, it allocates a buffer with size 1 for the terminating NULL, and returns that with length 0. Issue Time Tracking --- Worklog Id: (was: 30221) Time Spent: 40m (was: 0.5h) > Crash when body_factory file is empty > - > > Key: TS-3204 > URL: https://issues.apache.org/jira/browse/TS-3204 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: Thomas Jackson >Assignee: Jari Alhonen > Fix For: sometime > > Time Spent: 40m > Remaining Estimate: 0h > > Reproducible on 5.0.x > If you have a body factory page that is completely empty, after some time I > start getting very obscure crashes all over the place (ssl, remap, etc.). If > I add a single whitespace it works fine, seems that something in there > doesn't like empty files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3204) Crash when body_factory file is empty
[ https://issues.apache.org/jira/browse/TS-3204?focusedWorklogId=30215&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30215 ] ASF GitHub Bot logged work on TS-3204: -- Author: ASF GitHub Bot Created on: 06/Oct/16 01:29 Start Date: 06/Oct/16 01:29 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1081 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/832/ for details. Issue Time Tracking --- Worklog Id: (was: 30215) Time Spent: 0.5h (was: 20m) > Crash when body_factory file is empty > - > > Key: TS-3204 > URL: https://issues.apache.org/jira/browse/TS-3204 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: Thomas Jackson >Assignee: Jari Alhonen > Fix For: sometime > > Time Spent: 0.5h > Remaining Estimate: 0h > > Reproducible on 5.0.x > If you have a body factory page that is completely empty, after some time I > start getting very obscure crashes all over the place (ssl, remap, etc.). If > I add a single whitespace it works fine, seems that something in there > doesn't like empty files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3204) Crash when body_factory file is empty
[ https://issues.apache.org/jira/browse/TS-3204?focusedWorklogId=30213&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30213 ] ASF GitHub Bot logged work on TS-3204: -- Author: ASF GitHub Bot Created on: 06/Oct/16 01:26 Start Date: 06/Oct/16 01:26 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1081 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/940/ for details. Issue Time Tracking --- Worklog Id: (was: 30213) Time Spent: 20m (was: 10m) > Crash when body_factory file is empty > - > > Key: TS-3204 > URL: https://issues.apache.org/jira/browse/TS-3204 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: Thomas Jackson >Assignee: Jari Alhonen > Fix For: sometime > > Time Spent: 20m > Remaining Estimate: 0h > > Reproducible on 5.0.x > If you have a body factory page that is completely empty, after some time I > start getting very obscure crashes all over the place (ssl, remap, etc.). If > I add a single whitespace it works fine, seems that something in there > doesn't like empty files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-3204) Crash when body_factory file is empty
[ https://issues.apache.org/jira/browse/TS-3204?focusedWorklogId=30212&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30212 ] ASF GitHub Bot logged work on TS-3204: -- Author: ASF GitHub Bot Created on: 06/Oct/16 01:14 Start Date: 06/Oct/16 01:14 Worklog Time Spent: 10m Work Description: GitHub user alhonen opened a pull request: https://github.com/apache/trafficserver/pull/1081 TS-3204: Crash when body_factory file is empty Set internal buffer to null for empty files to not follow the crash-prone execution path. You can merge this pull request into a Git repository by running: $ git pull https://github.com/alhonen/trafficserver TS-3204 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1081.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1081 commit 49f1d8f011eeb69dcb8ecf45232c68d13ae32aef Author: Jari Alhonen Date: 2016-10-04T01:18:05Z TS-3204: Crash when body_factory file is empty Set internal buffer to null for empty files to not follow the crash-prone execution path. Issue Time Tracking --- Worklog Id: (was: 30212) Time Spent: 10m Remaining Estimate: 0h > Crash when body_factory file is empty > - > > Key: TS-3204 > URL: https://issues.apache.org/jira/browse/TS-3204 > Project: Traffic Server > Issue Type: Bug > Components: Configuration >Reporter: Thomas Jackson >Assignee: Jari Alhonen > Fix For: sometime > > Time Spent: 10m > Remaining Estimate: 0h > > Reproducible on 5.0.x > If you have a body factory page that is completely empty, after some time I > start getting very obscure crashes all over the place (ssl, remap, etc.). If > I add a single whitespace it works fine, seems that something in there > doesn't like empty files. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
